From blowekamp at mail.nih.gov  Fri Sep  9 13:18:50 2016
From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C])
Date: Fri, 9 Sep 2016 17:18:50 +0000
Subject: [ITK-dev] Clang scripting to make code changes
Message-ID: <589682C1-BE39-40E6-A7F6-E02F4964634A@mail.nih.gov>

Hans,

If I recall correctly you have used a clang based tool to make context based changes on ITK code before.

To addresses some dynamic_cast failures which can occur with Xcode based tools, we are considering the patch to change dynamic_cast to Object::SafeDownCast[1]. One issue is finding a good way to to update dynamic_casts.

With the clang based tool can we change ?dynamic_cast<TObject>(arg)? to ?TObject::SafeDownCast(arg)? only if TObject has itk::LightObject as some ancestor class?

Thanks,
Brad

[1] http://review.source.kitware.com/#/c/21499/

From francois.budin at kitware.com  Fri Sep  9 15:28:48 2016
From: francois.budin at kitware.com (Francois Budin)
Date: Fri, 9 Sep 2016 15:28:48 -0400
Subject: [ITK-dev] ITKv5
Message-ID: <CAHwLD2VMqX0vjSRTJ8z1WOxT+zLZhcp6-p1p7-oXzEUS=z202g@mail.gmail.com>

Hello everyone,

I just started a wishlist page for ITKv5. As far as I know, there is no
current ITKv5 officially planned but it may be a good location to keep
track of the current limitations of ITK and what could be improved in the
next major revision that may break some of the API. Please feel free to add
any of your wishes on that page here:
https://itk.org/Wiki/ITK_Release_5/Wish_List
Thanks!

Francois
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160909/6b76f712/attachment.html>

From dzenanz at gmail.com  Fri Sep  9 17:40:34 2016
From: dzenanz at gmail.com (=?UTF-8?B?RMW+ZW5hbiBadWtpxIc=?=)
Date: Fri, 9 Sep 2016 17:40:34 -0400
Subject: [ITK-dev] ITKv5
In-Reply-To: <CAHwLD2VMqX0vjSRTJ8z1WOxT+zLZhcp6-p1p7-oXzEUS=z202g@mail.gmail.com>
References: <CAHwLD2VMqX0vjSRTJ8z1WOxT+zLZhcp6-p1p7-oXzEUS=z202g@mail.gmail.com>
Message-ID: <CAPf2UMSRrtwkURm9=2va9d_irjXFjn0L27NtewRFiZCJF73ZHg@mail.gmail.com>

I added a couple items to the wishlist.

On Fri, Sep 9, 2016 at 3:28 PM, Francois Budin <francois.budin at kitware.com>
wrote:

> Hello everyone,
>
> I just started a wishlist page for ITKv5. As far as I know, there is no
> current ITKv5 officially planned but it may be a good location to keep
> track of the current limitations of ITK and what could be improved in the
> next major revision that may break some of the API. Please feel free to add
> any of your wishes on that page here: https://itk.org/Wiki/ITK_
> Release_5/Wish_List
> Thanks!
>
> Francois
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160909/88de1bfd/attachment.html>

From hans-johnson at uiowa.edu  Sat Sep 10 07:26:49 2016
From: hans-johnson at uiowa.edu (Johnson, Hans J)
Date: Sat, 10 Sep 2016 11:26:49 +0000
Subject: [ITK-dev] Clang scripting to make code changes
In-Reply-To: <589682C1-BE39-40E6-A7F6-E02F4964634A@mail.nih.gov>
References: <589682C1-BE39-40E6-A7F6-E02F4964634A@mail.nih.gov>
Message-ID: <0A6CB987-722D-40A5-9204-E8F9F5F30EFA@uiowa.edu>

I use clang tidy.  

I have not written any custom filters.

Sent from my iPhone

> On Sep 9, 2016, at 12:18 PM, Lowekamp, Bradley (NIH/NLM/LHC) [C] <blowekamp at mail.nih.gov> wrote:
> 
> Hans,
> 
> If I recall correctly you have used a clang based tool to make context based changes on ITK code before.
> 
> To addresses some dynamic_cast failures which can occur with Xcode based tools, we are considering the patch to change dynamic_cast to Object::SafeDownCast[1]. One issue is finding a good way to to update dynamic_casts.
> 
> With the clang based tool can we change ?dynamic_cast<TObject>(arg)? to ?TObject::SafeDownCast(arg)? only if TObject has itk::LightObject as some ancestor class?
> 
> Thanks,
> Brad
> 
> [1] http://review.source.kitware.com/#/c/21499/

From someshsandbox at gmail.com  Mon Sep 12 14:49:56 2016
From: someshsandbox at gmail.com (Somesh)
Date: Mon, 12 Sep 2016 14:49:56 -0400
Subject: [ITK-dev] Pre-commit Failure uncrustify
Message-ID: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>

Hi,
I recently set up a ITK dev on my mac. While commiting a patch locally, I
am getting failure in precommit hooks. Specifically uncrustify is giving
the following errors. Do I have to install a specific version of
uncrustify/python ? I installed uncrustify using brew.

./Utilities/Maintenance/uncrustify_itk.cfg:99 Unknown symbol
'indent_cs_delegate_brace'

./Utilities/Maintenance/uncrustify_itk.cfg:287 Unknown symbol
'indent_token_after_brace'

./Utilities/Maintenance/uncrustify_itk.cfg:290 Unknown symbol
'indent_cpp_lambda_body'

./Utilities/Maintenance/uncrustify_itk.cfg:424 Unknown symbol
'sp_angle_paren_empty'

./Utilities/Maintenance/uncrustify_itk.cfg:533 Unknown symbol
'sp_after_operator_sym_empty'

./Utilities/Maintenance/uncrustify_itk.cfg:570 Unknown symbol
'sp_func_proto_paren_empty'

./Utilities/Maintenance/uncrustify_itk.cfg:576 Unknown symbol
'sp_func_def_paren_empty'

./Utilities/Maintenance/uncrustify_itk.cfg:614 Unknown symbol
'sp_func_class_paren_empty'

./Utilities/Maintenance/uncrustify_itk.cfg:644 Unknown symbol
'sp_super_paren'

./Utilities/Maintenance/uncrustify_itk.cfg:647 Unknown symbol
'sp_this_paren'

./Utilities/Maintenance/uncrustify_itk.cfg:851 Unknown symbol
'sp_skip_vbrace_tokens'

./Utilities/Maintenance/uncrustify_itk.cfg:922 Unknown symbol
'align_var_class_span'

./Utilities/Maintenance/uncrustify_itk.cfg:925 Unknown symbol
'align_var_class_thresh'

./Utilities/Maintenance/uncrustify_itk.cfg:928 Unknown symbol
'align_var_class_gap'

./Utilities/Maintenance/uncrustify_itk.cfg:1068 Unknown symbol
'nl_oc_block_brace'

./Utilities/Maintenance/uncrustify_itk.cfg:1245 Unknown symbol
'nl_enum_own_lines'

./Utilities/Maintenance/uncrustify_itk.cfg:1256 Unknown symbol
'nl_func_class_scope'

./Utilities/Maintenance/uncrustify_itk.cfg:1284 Unknown symbol
'nl_func_decl_start_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1287 Unknown symbol
'nl_func_def_start_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1296 Unknown symbol
'nl_func_decl_args_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1299 Unknown symbol
'nl_func_def_args_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1314 Unknown symbol
'nl_func_decl_end_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1317 Unknown symbol
'nl_func_def_end_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1326 Unknown symbol
'nl_func_call_start_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1329 Unknown symbol
'nl_func_call_args_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1332 Unknown symbol
'nl_func_call_end_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1388 Unknown symbol
'nl_squeeze_ifdef_top_level'

./Utilities/Maintenance/uncrustify_itk.cfg:1461 Unknown symbol
'nl_split_if_one_liner'

./Utilities/Maintenance/uncrustify_itk.cfg:1465 Unknown symbol
'nl_split_for_one_liner'

./Utilities/Maintenance/uncrustify_itk.cfg:1469 Unknown symbol
'nl_split_while_one_liner'

./Utilities/Maintenance/uncrustify_itk.cfg:1541 Unknown symbol
'nl_after_func_class_proto'

./Utilities/Maintenance/uncrustify_itk.cfg:1544 Unknown symbol
'nl_after_func_class_proto_group'

./Utilities/Maintenance/uncrustify_itk.cfg:1662 Unknown symbol
'mod_full_brace_if_chain_only'

./Utilities/Maintenance/uncrustify_itk.cfg:1781 Unknown symbol
'cmt_multi_first_len_minimum'

./Utilities/Maintenance/uncrustify_itk.cfg:1812 Unknown symbol
'cmt_insert_before_inlines'

./Utilities/Maintenance/uncrustify_itk.cfg:1817 Unknown symbol
'cmt_insert_before_ctor_dtor'

./Utilities/Maintenance/uncrustify_itk.cfg:1878 Unknown symbol
'use_options_overriding_for_qt_macros'

./Utilities/Maintenance/uncrustify_itk.cfg:1885 Unknown symbol
'warn_level_tabs_found_in_verbatim_string_literals'


Thanks,
Somesh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160912/c7b87b15/attachment.html>

From matt.mccormick at kitware.com  Mon Sep 12 17:12:50 2016
From: matt.mccormick at kitware.com (Matt McCormick)
Date: Mon, 12 Sep 2016 17:12:50 -0400
Subject: [ITK-dev] Pre-commit Failure uncrustify
In-Reply-To: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
References: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
Message-ID: <CALzTN-TCmCv0kWWy7go1qp+R3zUEdW-ZyhGF_x9p1-7=Up4_Zw@mail.gmail.com>

Hi Somesh,

Yes, Dzenan recently improved upstream uncrustify and its
configuration in ITK so it works much better. A newer version of
uncrustify is required as described here:

  https://github.com/InsightSoftwareConsortium/ITK/blob/6ee10575445aa1c878797db4febf7d775a38f1f3/Utilities/DevelopmentSetupScripts/GitTips.sh#L66-L74

Thanks,
Matt

On Mon, Sep 12, 2016 at 2:49 PM, Somesh <someshsandbox at gmail.com> wrote:
> Hi,
> I recently set up a ITK dev on my mac. While commiting a patch locally, I am
> getting failure in precommit hooks. Specifically uncrustify is giving the
> following errors. Do I have to install a specific version of
> uncrustify/python ? I installed uncrustify using brew.
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:99 Unknown symbol
> 'indent_cs_delegate_brace'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:287 Unknown symbol
> 'indent_token_after_brace'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:290 Unknown symbol
> 'indent_cpp_lambda_body'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:424 Unknown symbol
> 'sp_angle_paren_empty'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:533 Unknown symbol
> 'sp_after_operator_sym_empty'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:570 Unknown symbol
> 'sp_func_proto_paren_empty'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:576 Unknown symbol
> 'sp_func_def_paren_empty'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:614 Unknown symbol
> 'sp_func_class_paren_empty'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:644 Unknown symbol
> 'sp_super_paren'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:647 Unknown symbol
> 'sp_this_paren'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:851 Unknown symbol
> 'sp_skip_vbrace_tokens'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:922 Unknown symbol
> 'align_var_class_span'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:925 Unknown symbol
> 'align_var_class_thresh'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:928 Unknown symbol
> 'align_var_class_gap'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1068 Unknown symbol
> 'nl_oc_block_brace'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1245 Unknown symbol
> 'nl_enum_own_lines'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1256 Unknown symbol
> 'nl_func_class_scope'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1284 Unknown symbol
> 'nl_func_decl_start_multi_line'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1287 Unknown symbol
> 'nl_func_def_start_multi_line'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1296 Unknown symbol
> 'nl_func_decl_args_multi_line'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1299 Unknown symbol
> 'nl_func_def_args_multi_line'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1314 Unknown symbol
> 'nl_func_decl_end_multi_line'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1317 Unknown symbol
> 'nl_func_def_end_multi_line'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1326 Unknown symbol
> 'nl_func_call_start_multi_line'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1329 Unknown symbol
> 'nl_func_call_args_multi_line'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1332 Unknown symbol
> 'nl_func_call_end_multi_line'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1388 Unknown symbol
> 'nl_squeeze_ifdef_top_level'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1461 Unknown symbol
> 'nl_split_if_one_liner'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1465 Unknown symbol
> 'nl_split_for_one_liner'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1469 Unknown symbol
> 'nl_split_while_one_liner'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1541 Unknown symbol
> 'nl_after_func_class_proto'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1544 Unknown symbol
> 'nl_after_func_class_proto_group'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1662 Unknown symbol
> 'mod_full_brace_if_chain_only'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1781 Unknown symbol
> 'cmt_multi_first_len_minimum'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1812 Unknown symbol
> 'cmt_insert_before_inlines'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1817 Unknown symbol
> 'cmt_insert_before_ctor_dtor'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1878 Unknown symbol
> 'use_options_overriding_for_qt_macros'
>
> ./Utilities/Maintenance/uncrustify_itk.cfg:1885 Unknown symbol
> 'warn_level_tabs_found_in_verbatim_string_literals'
>
>
> Thanks,
> Somesh
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers
>

From hans-johnson at uiowa.edu  Mon Sep 12 14:58:37 2016
From: hans-johnson at uiowa.edu (Johnson, Hans J)
Date: Mon, 12 Sep 2016 18:58:37 +0000
Subject: [ITK-dev] Pre-commit Failure uncrustify
In-Reply-To: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
References: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
Message-ID: <6E786F2A-50F0-4B98-8199-10F73A887138@uiowa.edu>

Somesh,

I don?t think that uncrustify and KWStyle are consistent.   I think you need to turn off uncrustify.

Hans


--


From: Insight-developers <insight-developers-bounces at itk.org> on behalf of Somesh <someshsandbox at gmail.com>
Date: Monday, September 12, 2016 at 1:49 PM
To: "insight-developers at itk.org" <insight-developers at itk.org>
Subject: [ITK-dev] Pre-commit Failure uncrustify

Hi,
I recently set up a ITK dev on my mac. While commiting a patch locally, I am getting failure in precommit hooks. Specifically uncrustify is giving the following errors. Do I have to install a specific version of uncrustify/python ? I installed uncrustify using brew.


./Utilities/Maintenance/uncrustify_itk.cfg:99 Unknown symbol 'indent_cs_delegate_brace'

./Utilities/Maintenance/uncrustify_itk.cfg:287 Unknown symbol 'indent_token_after_brace'

./Utilities/Maintenance/uncrustify_itk.cfg:290 Unknown symbol 'indent_cpp_lambda_body'

./Utilities/Maintenance/uncrustify_itk.cfg:424 Unknown symbol 'sp_angle_paren_empty'

./Utilities/Maintenance/uncrustify_itk.cfg:533 Unknown symbol 'sp_after_operator_sym_empty'

./Utilities/Maintenance/uncrustify_itk.cfg:570 Unknown symbol 'sp_func_proto_paren_empty'

./Utilities/Maintenance/uncrustify_itk.cfg:576 Unknown symbol 'sp_func_def_paren_empty'

./Utilities/Maintenance/uncrustify_itk.cfg:614 Unknown symbol 'sp_func_class_paren_empty'

./Utilities/Maintenance/uncrustify_itk.cfg:644 Unknown symbol 'sp_super_paren'

./Utilities/Maintenance/uncrustify_itk.cfg:647 Unknown symbol 'sp_this_paren'

./Utilities/Maintenance/uncrustify_itk.cfg:851 Unknown symbol 'sp_skip_vbrace_tokens'

./Utilities/Maintenance/uncrustify_itk.cfg:922 Unknown symbol 'align_var_class_span'

./Utilities/Maintenance/uncrustify_itk.cfg:925 Unknown symbol 'align_var_class_thresh'

./Utilities/Maintenance/uncrustify_itk.cfg:928 Unknown symbol 'align_var_class_gap'

./Utilities/Maintenance/uncrustify_itk.cfg:1068 Unknown symbol 'nl_oc_block_brace'

./Utilities/Maintenance/uncrustify_itk.cfg:1245 Unknown symbol 'nl_enum_own_lines'

./Utilities/Maintenance/uncrustify_itk.cfg:1256 Unknown symbol 'nl_func_class_scope'

./Utilities/Maintenance/uncrustify_itk.cfg:1284 Unknown symbol 'nl_func_decl_start_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1287 Unknown symbol 'nl_func_def_start_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1296 Unknown symbol 'nl_func_decl_args_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1299 Unknown symbol 'nl_func_def_args_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1314 Unknown symbol 'nl_func_decl_end_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1317 Unknown symbol 'nl_func_def_end_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1326 Unknown symbol 'nl_func_call_start_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1329 Unknown symbol 'nl_func_call_args_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1332 Unknown symbol 'nl_func_call_end_multi_line'

./Utilities/Maintenance/uncrustify_itk.cfg:1388 Unknown symbol 'nl_squeeze_ifdef_top_level'

./Utilities/Maintenance/uncrustify_itk.cfg:1461 Unknown symbol 'nl_split_if_one_liner'

./Utilities/Maintenance/uncrustify_itk.cfg:1465 Unknown symbol 'nl_split_for_one_liner'

./Utilities/Maintenance/uncrustify_itk.cfg:1469 Unknown symbol 'nl_split_while_one_liner'

./Utilities/Maintenance/uncrustify_itk.cfg:1541 Unknown symbol 'nl_after_func_class_proto'

./Utilities/Maintenance/uncrustify_itk.cfg:1544 Unknown symbol 'nl_after_func_class_proto_group'

./Utilities/Maintenance/uncrustify_itk.cfg:1662 Unknown symbol 'mod_full_brace_if_chain_only'

./Utilities/Maintenance/uncrustify_itk.cfg:1781 Unknown symbol 'cmt_multi_first_len_minimum'

./Utilities/Maintenance/uncrustify_itk.cfg:1812 Unknown symbol 'cmt_insert_before_inlines'

./Utilities/Maintenance/uncrustify_itk.cfg:1817 Unknown symbol 'cmt_insert_before_ctor_dtor'

./Utilities/Maintenance/uncrustify_itk.cfg:1878 Unknown symbol 'use_options_overriding_for_qt_macros'

./Utilities/Maintenance/uncrustify_itk.cfg:1885 Unknown symbol 'warn_level_tabs_found_in_verbatim_string_literals'


Thanks,
Somesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160912/c9b337a2/attachment.html>

From someshsandbox at gmail.com  Mon Sep 12 21:03:49 2016
From: someshsandbox at gmail.com (Somesh)
Date: Mon, 12 Sep 2016 21:03:49 -0400
Subject: [ITK-dev] Pre-commit Failure uncrustify
In-Reply-To: <CALzTN-TCmCv0kWWy7go1qp+R3zUEdW-ZyhGF_x9p1-7=Up4_Zw@mail.gmail.com>
References: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
 <CALzTN-TCmCv0kWWy7go1qp+R3zUEdW-ZyhGF_x9p1-7=Up4_Zw@mail.gmail.com>
Message-ID: <CADafqVqqDKDFpE8cMqtv4AtoN8d_0AUJT75udH9wUx3zxKC8jQ@mail.gmail.com>

Hi Matt,
Do KWStyle and uncrustify play well with both enabled ?
I have  uncrustify  version 0.63 and the prehooks still fail. I believe
0.63 is the latest uncrustify version:
https://github.com/uncrustify/uncrustify/blob/master/CMakeLists.txt#L124

Thanks,
Somesh

On Mon, Sep 12, 2016 at 5:12 PM, Matt McCormick <matt.mccormick at kitware.com>
wrote:

> Hi Somesh,
>
> Yes, Dzenan recently improved upstream uncrustify and its
> configuration in ITK so it works much better. A newer version of
> uncrustify is required as described here:
>
>   https://github.com/InsightSoftwareConsortium/ITK/blob/
> 6ee10575445aa1c878797db4febf7d775a38f1f3/Utilities/
> DevelopmentSetupScripts/GitTips.sh#L66-L74
>
> Thanks,
> Matt
>
> On Mon, Sep 12, 2016 at 2:49 PM, Somesh <someshsandbox at gmail.com> wrote:
> > Hi,
> > I recently set up a ITK dev on my mac. While commiting a patch locally,
> I am
> > getting failure in precommit hooks. Specifically uncrustify is giving the
> > following errors. Do I have to install a specific version of
> > uncrustify/python ? I installed uncrustify using brew.
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:99 Unknown symbol
> > 'indent_cs_delegate_brace'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:287 Unknown symbol
> > 'indent_token_after_brace'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:290 Unknown symbol
> > 'indent_cpp_lambda_body'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:424 Unknown symbol
> > 'sp_angle_paren_empty'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:533 Unknown symbol
> > 'sp_after_operator_sym_empty'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:570 Unknown symbol
> > 'sp_func_proto_paren_empty'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:576 Unknown symbol
> > 'sp_func_def_paren_empty'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:614 Unknown symbol
> > 'sp_func_class_paren_empty'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:644 Unknown symbol
> > 'sp_super_paren'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:647 Unknown symbol
> > 'sp_this_paren'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:851 Unknown symbol
> > 'sp_skip_vbrace_tokens'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:922 Unknown symbol
> > 'align_var_class_span'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:925 Unknown symbol
> > 'align_var_class_thresh'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:928 Unknown symbol
> > 'align_var_class_gap'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1068 Unknown symbol
> > 'nl_oc_block_brace'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1245 Unknown symbol
> > 'nl_enum_own_lines'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1256 Unknown symbol
> > 'nl_func_class_scope'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1284 Unknown symbol
> > 'nl_func_decl_start_multi_line'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1287 Unknown symbol
> > 'nl_func_def_start_multi_line'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1296 Unknown symbol
> > 'nl_func_decl_args_multi_line'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1299 Unknown symbol
> > 'nl_func_def_args_multi_line'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1314 Unknown symbol
> > 'nl_func_decl_end_multi_line'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1317 Unknown symbol
> > 'nl_func_def_end_multi_line'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1326 Unknown symbol
> > 'nl_func_call_start_multi_line'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1329 Unknown symbol
> > 'nl_func_call_args_multi_line'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1332 Unknown symbol
> > 'nl_func_call_end_multi_line'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1388 Unknown symbol
> > 'nl_squeeze_ifdef_top_level'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1461 Unknown symbol
> > 'nl_split_if_one_liner'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1465 Unknown symbol
> > 'nl_split_for_one_liner'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1469 Unknown symbol
> > 'nl_split_while_one_liner'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1541 Unknown symbol
> > 'nl_after_func_class_proto'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1544 Unknown symbol
> > 'nl_after_func_class_proto_group'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1662 Unknown symbol
> > 'mod_full_brace_if_chain_only'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1781 Unknown symbol
> > 'cmt_multi_first_len_minimum'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1812 Unknown symbol
> > 'cmt_insert_before_inlines'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1817 Unknown symbol
> > 'cmt_insert_before_ctor_dtor'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1878 Unknown symbol
> > 'use_options_overriding_for_qt_macros'
> >
> > ./Utilities/Maintenance/uncrustify_itk.cfg:1885 Unknown symbol
> > 'warn_level_tabs_found_in_verbatim_string_literals'
> >
> >
> > Thanks,
> > Somesh
> >
> >
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> > http://www.kitware.com/opensource/opensource.html
> >
> > Kitware offers ITK Training Courses, for more information visit:
> > http://kitware.com/products/protraining.php
> >
> > Please keep messages on-topic and check the ITK FAQ at:
> > http://www.itk.org/Wiki/ITK_FAQ
> >
> > Follow this link to subscribe/unsubscribe:
> > http://public.kitware.com/mailman/listinfo/insight-developers
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160912/206daf17/attachment.html>

From someshsandbox at gmail.com  Mon Sep 12 21:30:36 2016
From: someshsandbox at gmail.com (Somesh)
Date: Mon, 12 Sep 2016 21:30:36 -0400
Subject: [ITK-dev] Pre-commit Failure uncrustify
In-Reply-To: <CAPmoeGbA6uxA9a0NF9b-x4JVqPkxvOsbDsWFQYw=yzAjnocOHg@mail.gmail.com>
References: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
 <CALzTN-TCmCv0kWWy7go1qp+R3zUEdW-ZyhGF_x9p1-7=Up4_Zw@mail.gmail.com>
 <CADafqVqqDKDFpE8cMqtv4AtoN8d_0AUJT75udH9wUx3zxKC8jQ@mail.gmail.com>
 <CAPmoeGbA6uxA9a0NF9b-x4JVqPkxvOsbDsWFQYw=yzAjnocOHg@mail.gmail.com>
Message-ID: <CADafqVpzwHs71ft9L=YESmu5-ChnyUvkwX3p+mssQRSP_2KGPw@mail.gmail.com>

Hi D?enan,
I am using the HEAD of master uncrustify. The last commit to this repo was
made today.

commit 5a264cf59733fa8e0f69f8e6567e069a8cfd8bde
Merge: 553ef05 8ce4ca1
Author: Zhiming Wang <zmwangx at gmail.com>
Date:   Mon Sep 12 10:22:27 2016 -0400

I have build from source using brew for mac.

Also my mergetool/difftool are all set. I am using OS X El Captain 10.11.6
and kaleidoscope tool for mac http://www.kaleidoscopeapp.com/.

Thanks,
Somesh

On Mon, Sep 12, 2016 at 9:11 PM, Dzenan Zukic <dzenan.zukic at kitware.com>
wrote:

> Hi Somesh,
>
> You need a recent master version (2016-08-26 or newer) which you can build
> yourself from source available on GitHub
> <https://github.com/uncrustify/uncrustify>.
>
> Also, you need to have merge tool set. On Windows kdiff3 works well but
> TortoiseMerge doesn't.
>
> Regards,
> D?enan Zuki?, PhD, Senior R&D Engineer, Kitware (Carrboro, N.C.)
>
> On Mon, Sep 12, 2016 at 9:03 PM, Somesh <someshsandbox at gmail.com> wrote:
>
>> Hi Matt,
>> Do KWStyle and uncrustify play well with both enabled ?
>> I have  uncrustify  version 0.63 and the prehooks still fail. I believe
>> 0.63 is the latest uncrustify version: https://github.com/un
>> crustify/uncrustify/blob/master/CMakeLists.txt#L124
>>
>> Thanks,
>> Somesh
>>
>> On Mon, Sep 12, 2016 at 5:12 PM, Matt McCormick <
>> matt.mccormick at kitware.com> wrote:
>>
>>> Hi Somesh,
>>>
>>> Yes, Dzenan recently improved upstream uncrustify and its
>>> configuration in ITK so it works much better. A newer version of
>>> uncrustify is required as described here:
>>>
>>>   https://github.com/InsightSoftwareConsortium/ITK/blob/6ee105
>>> 75445aa1c878797db4febf7d775a38f1f3/Utilities/DevelopmentSetu
>>> pScripts/GitTips.sh#L66-L74
>>>
>>> Thanks,
>>> Matt
>>>
>>> On Mon, Sep 12, 2016 at 2:49 PM, Somesh <someshsandbox at gmail.com> wrote:
>>> > Hi,
>>> > I recently set up a ITK dev on my mac. While commiting a patch
>>> locally, I am
>>> > getting failure in precommit hooks. Specifically uncrustify is giving
>>> the
>>> > following errors. Do I have to install a specific version of
>>> > uncrustify/python ? I installed uncrustify using brew.
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:99 Unknown symbol
>>> > 'indent_cs_delegate_brace'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:287 Unknown symbol
>>> > 'indent_token_after_brace'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:290 Unknown symbol
>>> > 'indent_cpp_lambda_body'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:424 Unknown symbol
>>> > 'sp_angle_paren_empty'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:533 Unknown symbol
>>> > 'sp_after_operator_sym_empty'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:570 Unknown symbol
>>> > 'sp_func_proto_paren_empty'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:576 Unknown symbol
>>> > 'sp_func_def_paren_empty'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:614 Unknown symbol
>>> > 'sp_func_class_paren_empty'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:644 Unknown symbol
>>> > 'sp_super_paren'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:647 Unknown symbol
>>> > 'sp_this_paren'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:851 Unknown symbol
>>> > 'sp_skip_vbrace_tokens'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:922 Unknown symbol
>>> > 'align_var_class_span'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:925 Unknown symbol
>>> > 'align_var_class_thresh'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:928 Unknown symbol
>>> > 'align_var_class_gap'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1068 Unknown symbol
>>> > 'nl_oc_block_brace'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1245 Unknown symbol
>>> > 'nl_enum_own_lines'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1256 Unknown symbol
>>> > 'nl_func_class_scope'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1284 Unknown symbol
>>> > 'nl_func_decl_start_multi_line'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1287 Unknown symbol
>>> > 'nl_func_def_start_multi_line'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1296 Unknown symbol
>>> > 'nl_func_decl_args_multi_line'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1299 Unknown symbol
>>> > 'nl_func_def_args_multi_line'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1314 Unknown symbol
>>> > 'nl_func_decl_end_multi_line'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1317 Unknown symbol
>>> > 'nl_func_def_end_multi_line'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1326 Unknown symbol
>>> > 'nl_func_call_start_multi_line'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1329 Unknown symbol
>>> > 'nl_func_call_args_multi_line'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1332 Unknown symbol
>>> > 'nl_func_call_end_multi_line'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1388 Unknown symbol
>>> > 'nl_squeeze_ifdef_top_level'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1461 Unknown symbol
>>> > 'nl_split_if_one_liner'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1465 Unknown symbol
>>> > 'nl_split_for_one_liner'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1469 Unknown symbol
>>> > 'nl_split_while_one_liner'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1541 Unknown symbol
>>> > 'nl_after_func_class_proto'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1544 Unknown symbol
>>> > 'nl_after_func_class_proto_group'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1662 Unknown symbol
>>> > 'mod_full_brace_if_chain_only'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1781 Unknown symbol
>>> > 'cmt_multi_first_len_minimum'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1812 Unknown symbol
>>> > 'cmt_insert_before_inlines'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1817 Unknown symbol
>>> > 'cmt_insert_before_ctor_dtor'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1878 Unknown symbol
>>> > 'use_options_overriding_for_qt_macros'
>>> >
>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1885 Unknown symbol
>>> > 'warn_level_tabs_found_in_verbatim_string_literals'
>>> >
>>> >
>>> > Thanks,
>>> > Somesh
>>> >
>>> >
>>> > _______________________________________________
>>> > Powered by www.kitware.com
>>> >
>>> > Visit other Kitware open-source projects at
>>> > http://www.kitware.com/opensource/opensource.html
>>> >
>>> > Kitware offers ITK Training Courses, for more information visit:
>>> > http://kitware.com/products/protraining.php
>>> >
>>> > Please keep messages on-topic and check the ITK FAQ at:
>>> > http://www.itk.org/Wiki/ITK_FAQ
>>> >
>>> > Follow this link to subscribe/unsubscribe:
>>> > http://public.kitware.com/mailman/listinfo/insight-developers
>>> >
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160912/3dc0f44d/attachment.html>

From someshsandbox at gmail.com  Mon Sep 12 22:14:57 2016
From: someshsandbox at gmail.com (Somesh)
Date: Mon, 12 Sep 2016 22:14:57 -0400
Subject: [ITK-dev] Pre-commit Failure uncrustify
In-Reply-To: <CADafqVpzwHs71ft9L=YESmu5-ChnyUvkwX3p+mssQRSP_2KGPw@mail.gmail.com>
References: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
 <CALzTN-TCmCv0kWWy7go1qp+R3zUEdW-ZyhGF_x9p1-7=Up4_Zw@mail.gmail.com>
 <CADafqVqqDKDFpE8cMqtv4AtoN8d_0AUJT75udH9wUx3zxKC8jQ@mail.gmail.com>
 <CAPmoeGbA6uxA9a0NF9b-x4JVqPkxvOsbDsWFQYw=yzAjnocOHg@mail.gmail.com>
 <CADafqVpzwHs71ft9L=YESmu5-ChnyUvkwX3p+mssQRSP_2KGPw@mail.gmail.com>
Message-ID: <CADafqVrQ6SZ2P6KeNPtSZ_mqD+oXJEUfb3oKQA036ez7zg04gQ@mail.gmail.com>

Is running uncrustify hooks a required process in the ITK development
workflow or can I disable it if I have to submit a patch ?

Thanks,
Somesh

On Mon, Sep 12, 2016 at 9:30 PM, Somesh <someshsandbox at gmail.com> wrote:

> Hi D?enan,
> I am using the HEAD of master uncrustify. The last commit to this repo was
> made today.
>
> commit 5a264cf59733fa8e0f69f8e6567e069a8cfd8bde
> Merge: 553ef05 8ce4ca1
> Author: Zhiming Wang <zmwangx at gmail.com>
> Date:   Mon Sep 12 10:22:27 2016 -0400
>
> I have build from source using brew for mac.
>
> Also my mergetool/difftool are all set. I am using OS X El Captain 10.11.6
> and kaleidoscope tool for mac http://www.kaleidoscopeapp.com/.
>
> Thanks,
> Somesh
>
> On Mon, Sep 12, 2016 at 9:11 PM, Dzenan Zukic <dzenan.zukic at kitware.com>
> wrote:
>
>> Hi Somesh,
>>
>> You need a recent master version (2016-08-26 or newer) which you can
>> build yourself from source available on GitHub
>> <https://github.com/uncrustify/uncrustify>.
>>
>> Also, you need to have merge tool set. On Windows kdiff3 works well but
>> TortoiseMerge doesn't.
>>
>> Regards,
>> D?enan Zuki?, PhD, Senior R&D Engineer, Kitware (Carrboro, N.C.)
>>
>> On Mon, Sep 12, 2016 at 9:03 PM, Somesh <someshsandbox at gmail.com> wrote:
>>
>>> Hi Matt,
>>> Do KWStyle and uncrustify play well with both enabled ?
>>> I have  uncrustify  version 0.63 and the prehooks still fail. I believe
>>> 0.63 is the latest uncrustify version: https://github.com/un
>>> crustify/uncrustify/blob/master/CMakeLists.txt#L124
>>>
>>> Thanks,
>>> Somesh
>>>
>>> On Mon, Sep 12, 2016 at 5:12 PM, Matt McCormick <
>>> matt.mccormick at kitware.com> wrote:
>>>
>>>> Hi Somesh,
>>>>
>>>> Yes, Dzenan recently improved upstream uncrustify and its
>>>> configuration in ITK so it works much better. A newer version of
>>>> uncrustify is required as described here:
>>>>
>>>>   https://github.com/InsightSoftwareConsortium/ITK/blob/6ee105
>>>> 75445aa1c878797db4febf7d775a38f1f3/Utilities/DevelopmentSetu
>>>> pScripts/GitTips.sh#L66-L74
>>>>
>>>> Thanks,
>>>> Matt
>>>>
>>>> On Mon, Sep 12, 2016 at 2:49 PM, Somesh <someshsandbox at gmail.com>
>>>> wrote:
>>>> > Hi,
>>>> > I recently set up a ITK dev on my mac. While commiting a patch
>>>> locally, I am
>>>> > getting failure in precommit hooks. Specifically uncrustify is giving
>>>> the
>>>> > following errors. Do I have to install a specific version of
>>>> > uncrustify/python ? I installed uncrustify using brew.
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:99 Unknown symbol
>>>> > 'indent_cs_delegate_brace'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:287 Unknown symbol
>>>> > 'indent_token_after_brace'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:290 Unknown symbol
>>>> > 'indent_cpp_lambda_body'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:424 Unknown symbol
>>>> > 'sp_angle_paren_empty'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:533 Unknown symbol
>>>> > 'sp_after_operator_sym_empty'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:570 Unknown symbol
>>>> > 'sp_func_proto_paren_empty'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:576 Unknown symbol
>>>> > 'sp_func_def_paren_empty'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:614 Unknown symbol
>>>> > 'sp_func_class_paren_empty'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:644 Unknown symbol
>>>> > 'sp_super_paren'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:647 Unknown symbol
>>>> > 'sp_this_paren'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:851 Unknown symbol
>>>> > 'sp_skip_vbrace_tokens'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:922 Unknown symbol
>>>> > 'align_var_class_span'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:925 Unknown symbol
>>>> > 'align_var_class_thresh'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:928 Unknown symbol
>>>> > 'align_var_class_gap'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1068 Unknown symbol
>>>> > 'nl_oc_block_brace'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1245 Unknown symbol
>>>> > 'nl_enum_own_lines'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1256 Unknown symbol
>>>> > 'nl_func_class_scope'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1284 Unknown symbol
>>>> > 'nl_func_decl_start_multi_line'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1287 Unknown symbol
>>>> > 'nl_func_def_start_multi_line'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1296 Unknown symbol
>>>> > 'nl_func_decl_args_multi_line'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1299 Unknown symbol
>>>> > 'nl_func_def_args_multi_line'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1314 Unknown symbol
>>>> > 'nl_func_decl_end_multi_line'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1317 Unknown symbol
>>>> > 'nl_func_def_end_multi_line'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1326 Unknown symbol
>>>> > 'nl_func_call_start_multi_line'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1329 Unknown symbol
>>>> > 'nl_func_call_args_multi_line'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1332 Unknown symbol
>>>> > 'nl_func_call_end_multi_line'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1388 Unknown symbol
>>>> > 'nl_squeeze_ifdef_top_level'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1461 Unknown symbol
>>>> > 'nl_split_if_one_liner'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1465 Unknown symbol
>>>> > 'nl_split_for_one_liner'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1469 Unknown symbol
>>>> > 'nl_split_while_one_liner'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1541 Unknown symbol
>>>> > 'nl_after_func_class_proto'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1544 Unknown symbol
>>>> > 'nl_after_func_class_proto_group'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1662 Unknown symbol
>>>> > 'mod_full_brace_if_chain_only'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1781 Unknown symbol
>>>> > 'cmt_multi_first_len_minimum'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1812 Unknown symbol
>>>> > 'cmt_insert_before_inlines'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1817 Unknown symbol
>>>> > 'cmt_insert_before_ctor_dtor'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1878 Unknown symbol
>>>> > 'use_options_overriding_for_qt_macros'
>>>> >
>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1885 Unknown symbol
>>>> > 'warn_level_tabs_found_in_verbatim_string_literals'
>>>> >
>>>> >
>>>> > Thanks,
>>>> > Somesh
>>>> >
>>>> >
>>>> > _______________________________________________
>>>> > Powered by www.kitware.com
>>>> >
>>>> > Visit other Kitware open-source projects at
>>>> > http://www.kitware.com/opensource/opensource.html
>>>> >
>>>> > Kitware offers ITK Training Courses, for more information visit:
>>>> > http://kitware.com/products/protraining.php
>>>> >
>>>> > Please keep messages on-topic and check the ITK FAQ at:
>>>> > http://www.itk.org/Wiki/ITK_FAQ
>>>> >
>>>> > Follow this link to subscribe/unsubscribe:
>>>> > http://public.kitware.com/mailman/listinfo/insight-developers
>>>> >
>>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160912/3e486734/attachment-0001.html>

From dzenanz at gmail.com  Mon Sep 12 22:17:52 2016
From: dzenanz at gmail.com (=?UTF-8?B?RMW+ZW5hbiBadWtpxIc=?=)
Date: Mon, 12 Sep 2016 22:17:52 -0400
Subject: [ITK-dev] Pre-commit Failure uncrustify
In-Reply-To: <CADafqVrQ6SZ2P6KeNPtSZ_mqD+oXJEUfb3oKQA036ez7zg04gQ@mail.gmail.com>
References: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
 <CALzTN-TCmCv0kWWy7go1qp+R3zUEdW-ZyhGF_x9p1-7=Up4_Zw@mail.gmail.com>
 <CADafqVqqDKDFpE8cMqtv4AtoN8d_0AUJT75udH9wUx3zxKC8jQ@mail.gmail.com>
 <CAPmoeGbA6uxA9a0NF9b-x4JVqPkxvOsbDsWFQYw=yzAjnocOHg@mail.gmail.com>
 <CADafqVpzwHs71ft9L=YESmu5-ChnyUvkwX3p+mssQRSP_2KGPw@mail.gmail.com>
 <CADafqVrQ6SZ2P6KeNPtSZ_mqD+oXJEUfb3oKQA036ez7zg04gQ@mail.gmail.com>
Message-ID: <CAPf2UMTzDG9xdqhTYkTq+p=7_Py21HuL5fz5qrE3Lhr4xqSBfA@mail.gmail.com>

It is not required.

D?enan at phone

On Sep 12, 2016 22:15, "Somesh" <someshsandbox at gmail.com> wrote:

> Is running uncrustify hooks a required process in the ITK development
> workflow or can I disable it if I have to submit a patch ?
>
> Thanks,
> Somesh
>
> On Mon, Sep 12, 2016 at 9:30 PM, Somesh <someshsandbox at gmail.com> wrote:
>
>> Hi D?enan,
>> I am using the HEAD of master uncrustify. The last commit to this repo
>> was made today.
>>
>> commit 5a264cf59733fa8e0f69f8e6567e069a8cfd8bde
>> Merge: 553ef05 8ce4ca1
>> Author: Zhiming Wang <zmwangx at gmail.com>
>> Date:   Mon Sep 12 10:22:27 2016 -0400
>>
>> I have build from source using brew for mac.
>>
>> Also my mergetool/difftool are all set. I am using OS X El
>> Captain 10.11.6 and kaleidoscope tool for mac http://www.kaleidoscopeapp
>> .com/.
>>
>> Thanks,
>> Somesh
>>
>> On Mon, Sep 12, 2016 at 9:11 PM, Dzenan Zukic <dzenan.zukic at kitware.com>
>> wrote:
>>
>>> Hi Somesh,
>>>
>>> You need a recent master version (2016-08-26 or newer) which you can
>>> build yourself from source available on GitHub
>>> <https://github.com/uncrustify/uncrustify>.
>>>
>>> Also, you need to have merge tool set. On Windows kdiff3 works well but
>>> TortoiseMerge doesn't.
>>>
>>> Regards,
>>> D?enan Zuki?, PhD, Senior R&D Engineer, Kitware (Carrboro, N.C.)
>>>
>>> On Mon, Sep 12, 2016 at 9:03 PM, Somesh <someshsandbox at gmail.com> wrote:
>>>
>>>> Hi Matt,
>>>> Do KWStyle and uncrustify play well with both enabled ?
>>>> I have  uncrustify  version 0.63 and the prehooks still fail. I
>>>> believe 0.63 is the latest uncrustify version: https://github.com/un
>>>> crustify/uncrustify/blob/master/CMakeLists.txt#L124
>>>>
>>>> Thanks,
>>>> Somesh
>>>>
>>>> On Mon, Sep 12, 2016 at 5:12 PM, Matt McCormick <
>>>> matt.mccormick at kitware.com> wrote:
>>>>
>>>>> Hi Somesh,
>>>>>
>>>>> Yes, Dzenan recently improved upstream uncrustify and its
>>>>> configuration in ITK so it works much better. A newer version of
>>>>> uncrustify is required as described here:
>>>>>
>>>>>   https://github.com/InsightSoftwareConsortium/ITK/blob/6ee105
>>>>> 75445aa1c878797db4febf7d775a38f1f3/Utilities/DevelopmentSetu
>>>>> pScripts/GitTips.sh#L66-L74
>>>>>
>>>>> Thanks,
>>>>> Matt
>>>>>
>>>>> On Mon, Sep 12, 2016 at 2:49 PM, Somesh <someshsandbox at gmail.com>
>>>>> wrote:
>>>>> > Hi,
>>>>> > I recently set up a ITK dev on my mac. While commiting a patch
>>>>> locally, I am
>>>>> > getting failure in precommit hooks. Specifically uncrustify is
>>>>> giving the
>>>>> > following errors. Do I have to install a specific version of
>>>>> > uncrustify/python ? I installed uncrustify using brew.
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:99 Unknown symbol
>>>>> > 'indent_cs_delegate_brace'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:287 Unknown symbol
>>>>> > 'indent_token_after_brace'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:290 Unknown symbol
>>>>> > 'indent_cpp_lambda_body'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:424 Unknown symbol
>>>>> > 'sp_angle_paren_empty'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:533 Unknown symbol
>>>>> > 'sp_after_operator_sym_empty'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:570 Unknown symbol
>>>>> > 'sp_func_proto_paren_empty'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:576 Unknown symbol
>>>>> > 'sp_func_def_paren_empty'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:614 Unknown symbol
>>>>> > 'sp_func_class_paren_empty'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:644 Unknown symbol
>>>>> > 'sp_super_paren'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:647 Unknown symbol
>>>>> > 'sp_this_paren'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:851 Unknown symbol
>>>>> > 'sp_skip_vbrace_tokens'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:922 Unknown symbol
>>>>> > 'align_var_class_span'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:925 Unknown symbol
>>>>> > 'align_var_class_thresh'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:928 Unknown symbol
>>>>> > 'align_var_class_gap'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1068 Unknown symbol
>>>>> > 'nl_oc_block_brace'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1245 Unknown symbol
>>>>> > 'nl_enum_own_lines'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1256 Unknown symbol
>>>>> > 'nl_func_class_scope'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1284 Unknown symbol
>>>>> > 'nl_func_decl_start_multi_line'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1287 Unknown symbol
>>>>> > 'nl_func_def_start_multi_line'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1296 Unknown symbol
>>>>> > 'nl_func_decl_args_multi_line'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1299 Unknown symbol
>>>>> > 'nl_func_def_args_multi_line'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1314 Unknown symbol
>>>>> > 'nl_func_decl_end_multi_line'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1317 Unknown symbol
>>>>> > 'nl_func_def_end_multi_line'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1326 Unknown symbol
>>>>> > 'nl_func_call_start_multi_line'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1329 Unknown symbol
>>>>> > 'nl_func_call_args_multi_line'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1332 Unknown symbol
>>>>> > 'nl_func_call_end_multi_line'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1388 Unknown symbol
>>>>> > 'nl_squeeze_ifdef_top_level'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1461 Unknown symbol
>>>>> > 'nl_split_if_one_liner'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1465 Unknown symbol
>>>>> > 'nl_split_for_one_liner'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1469 Unknown symbol
>>>>> > 'nl_split_while_one_liner'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1541 Unknown symbol
>>>>> > 'nl_after_func_class_proto'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1544 Unknown symbol
>>>>> > 'nl_after_func_class_proto_group'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1662 Unknown symbol
>>>>> > 'mod_full_brace_if_chain_only'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1781 Unknown symbol
>>>>> > 'cmt_multi_first_len_minimum'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1812 Unknown symbol
>>>>> > 'cmt_insert_before_inlines'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1817 Unknown symbol
>>>>> > 'cmt_insert_before_ctor_dtor'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1878 Unknown symbol
>>>>> > 'use_options_overriding_for_qt_macros'
>>>>> >
>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1885 Unknown symbol
>>>>> > 'warn_level_tabs_found_in_verbatim_string_literals'
>>>>> >
>>>>> >
>>>>> > Thanks,
>>>>> > Somesh
>>>>> >
>>>>> >
>>>>> > _______________________________________________
>>>>> > Powered by www.kitware.com
>>>>> >
>>>>> > Visit other Kitware open-source projects at
>>>>> > http://www.kitware.com/opensource/opensource.html
>>>>> >
>>>>> > Kitware offers ITK Training Courses, for more information visit:
>>>>> > http://kitware.com/products/protraining.php
>>>>> >
>>>>> > Please keep messages on-topic and check the ITK FAQ at:
>>>>> > http://www.itk.org/Wiki/ITK_FAQ
>>>>> >
>>>>> > Follow this link to subscribe/unsubscribe:
>>>>> > http://public.kitware.com/mailman/listinfo/insight-developers
>>>>> >
>>>>>
>>>>
>>>>
>>>
>>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160912/5c4025f2/attachment.html>

From dzenanz at gmail.com  Wed Sep 14 16:04:14 2016
From: dzenanz at gmail.com (=?UTF-8?B?RMW+ZW5hbiBadWtpxIc=?=)
Date: Wed, 14 Sep 2016 16:04:14 -0400
Subject: [ITK-dev] Pre-commit Failure uncrustify
In-Reply-To: <CAPf2UMTzDG9xdqhTYkTq+p=7_Py21HuL5fz5qrE3Lhr4xqSBfA@mail.gmail.com>
References: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
 <CALzTN-TCmCv0kWWy7go1qp+R3zUEdW-ZyhGF_x9p1-7=Up4_Zw@mail.gmail.com>
 <CADafqVqqDKDFpE8cMqtv4AtoN8d_0AUJT75udH9wUx3zxKC8jQ@mail.gmail.com>
 <CAPmoeGbA6uxA9a0NF9b-x4JVqPkxvOsbDsWFQYw=yzAjnocOHg@mail.gmail.com>
 <CADafqVpzwHs71ft9L=YESmu5-ChnyUvkwX3p+mssQRSP_2KGPw@mail.gmail.com>
 <CADafqVrQ6SZ2P6KeNPtSZ_mqD+oXJEUfb3oKQA036ez7zg04gQ@mail.gmail.com>
 <CAPf2UMTzDG9xdqhTYkTq+p=7_Py21HuL5fz5qrE3Lhr4xqSBfA@mail.gmail.com>
Message-ID: <CAPf2UMTBt81+33QLvQut1N+Hix2CdJK2O0zW-=MqaDVOO5aD8A@mail.gmail.com>

Hi Somesh,

I just pulled master version of uncrustify, the last commit is on 10th (you
have a commit on 12th!):
Revision: 5d703fa01ff67afc029f31a5ac36bd2fbafb6aea
Author: gmaurel <guy.j at maurel.de>
Date: 2016-09-10 15:06:05
Message: Merge pull request #756 from Unity-Technologies/fixes/make_
version_with_cmake

I must conclude that you are using somebody's fork of uncrustify, not HEAD
from the official repository. Can you verify this?

Regards,
D?enan

On Mon, Sep 12, 2016 at 10:17 PM, D?enan Zuki? <dzenanz at gmail.com> wrote:

> It is not required.
>
> D?enan at phone
>
> On Sep 12, 2016 22:15, "Somesh" <someshsandbox at gmail.com> wrote:
>
>> Is running uncrustify hooks a required process in the ITK development
>> workflow or can I disable it if I have to submit a patch ?
>>
>> Thanks,
>> Somesh
>>
>> On Mon, Sep 12, 2016 at 9:30 PM, Somesh <someshsandbox at gmail.com> wrote:
>>
>>> Hi D?enan,
>>> I am using the HEAD of master uncrustify. The last commit to this repo
>>> was made today.
>>>
>>> commit 5a264cf59733fa8e0f69f8e6567e069a8cfd8bde
>>> Merge: 553ef05 8ce4ca1
>>> Author: Zhiming Wang <zmwangx at gmail.com>
>>> Date:   Mon Sep 12 10:22:27 2016 -0400
>>>
>>> I have build from source using brew for mac.
>>>
>>> Also my mergetool/difftool are all set. I am using OS X El
>>> Captain 10.11.6 and kaleidoscope tool for mac http://www.kaleidoscopeapp
>>> .com/.
>>>
>>> Thanks,
>>> Somesh
>>>
>>> On Mon, Sep 12, 2016 at 9:11 PM, Dzenan Zukic <dzenan.zukic at kitware.com>
>>> wrote:
>>>
>>>> Hi Somesh,
>>>>
>>>> You need a recent master version (2016-08-26 or newer) which you can
>>>> build yourself from source available on GitHub
>>>> <https://github.com/uncrustify/uncrustify>.
>>>>
>>>> Also, you need to have merge tool set. On Windows kdiff3 works well but
>>>> TortoiseMerge doesn't.
>>>>
>>>> Regards,
>>>> D?enan Zuki?, PhD, Senior R&D Engineer, Kitware (Carrboro, N.C.)
>>>>
>>>> On Mon, Sep 12, 2016 at 9:03 PM, Somesh <someshsandbox at gmail.com>
>>>> wrote:
>>>>
>>>>> Hi Matt,
>>>>> Do KWStyle and uncrustify play well with both enabled ?
>>>>> I have  uncrustify  version 0.63 and the prehooks still fail. I
>>>>> believe 0.63 is the latest uncrustify version: https://github.com/un
>>>>> crustify/uncrustify/blob/master/CMakeLists.txt#L124
>>>>>
>>>>> Thanks,
>>>>> Somesh
>>>>>
>>>>> On Mon, Sep 12, 2016 at 5:12 PM, Matt McCormick <
>>>>> matt.mccormick at kitware.com> wrote:
>>>>>
>>>>>> Hi Somesh,
>>>>>>
>>>>>> Yes, Dzenan recently improved upstream uncrustify and its
>>>>>> configuration in ITK so it works much better. A newer version of
>>>>>> uncrustify is required as described here:
>>>>>>
>>>>>>   https://github.com/InsightSoftwareConsortium/ITK/blob/6ee105
>>>>>> 75445aa1c878797db4febf7d775a38f1f3/Utilities/DevelopmentSetu
>>>>>> pScripts/GitTips.sh#L66-L74
>>>>>>
>>>>>> Thanks,
>>>>>> Matt
>>>>>>
>>>>>> On Mon, Sep 12, 2016 at 2:49 PM, Somesh <someshsandbox at gmail.com>
>>>>>> wrote:
>>>>>> > Hi,
>>>>>> > I recently set up a ITK dev on my mac. While commiting a patch
>>>>>> locally, I am
>>>>>> > getting failure in precommit hooks. Specifically uncrustify is
>>>>>> giving the
>>>>>> > following errors. Do I have to install a specific version of
>>>>>> > uncrustify/python ? I installed uncrustify using brew.
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:99 Unknown symbol
>>>>>> > 'indent_cs_delegate_brace'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:287 Unknown symbol
>>>>>> > 'indent_token_after_brace'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:290 Unknown symbol
>>>>>> > 'indent_cpp_lambda_body'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:424 Unknown symbol
>>>>>> > 'sp_angle_paren_empty'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:533 Unknown symbol
>>>>>> > 'sp_after_operator_sym_empty'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:570 Unknown symbol
>>>>>> > 'sp_func_proto_paren_empty'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:576 Unknown symbol
>>>>>> > 'sp_func_def_paren_empty'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:614 Unknown symbol
>>>>>> > 'sp_func_class_paren_empty'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:644 Unknown symbol
>>>>>> > 'sp_super_paren'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:647 Unknown symbol
>>>>>> > 'sp_this_paren'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:851 Unknown symbol
>>>>>> > 'sp_skip_vbrace_tokens'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:922 Unknown symbol
>>>>>> > 'align_var_class_span'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:925 Unknown symbol
>>>>>> > 'align_var_class_thresh'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:928 Unknown symbol
>>>>>> > 'align_var_class_gap'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1068 Unknown symbol
>>>>>> > 'nl_oc_block_brace'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1245 Unknown symbol
>>>>>> > 'nl_enum_own_lines'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1256 Unknown symbol
>>>>>> > 'nl_func_class_scope'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1284 Unknown symbol
>>>>>> > 'nl_func_decl_start_multi_line'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1287 Unknown symbol
>>>>>> > 'nl_func_def_start_multi_line'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1296 Unknown symbol
>>>>>> > 'nl_func_decl_args_multi_line'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1299 Unknown symbol
>>>>>> > 'nl_func_def_args_multi_line'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1314 Unknown symbol
>>>>>> > 'nl_func_decl_end_multi_line'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1317 Unknown symbol
>>>>>> > 'nl_func_def_end_multi_line'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1326 Unknown symbol
>>>>>> > 'nl_func_call_start_multi_line'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1329 Unknown symbol
>>>>>> > 'nl_func_call_args_multi_line'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1332 Unknown symbol
>>>>>> > 'nl_func_call_end_multi_line'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1388 Unknown symbol
>>>>>> > 'nl_squeeze_ifdef_top_level'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1461 Unknown symbol
>>>>>> > 'nl_split_if_one_liner'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1465 Unknown symbol
>>>>>> > 'nl_split_for_one_liner'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1469 Unknown symbol
>>>>>> > 'nl_split_while_one_liner'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1541 Unknown symbol
>>>>>> > 'nl_after_func_class_proto'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1544 Unknown symbol
>>>>>> > 'nl_after_func_class_proto_group'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1662 Unknown symbol
>>>>>> > 'mod_full_brace_if_chain_only'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1781 Unknown symbol
>>>>>> > 'cmt_multi_first_len_minimum'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1812 Unknown symbol
>>>>>> > 'cmt_insert_before_inlines'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1817 Unknown symbol
>>>>>> > 'cmt_insert_before_ctor_dtor'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1878 Unknown symbol
>>>>>> > 'use_options_overriding_for_qt_macros'
>>>>>> >
>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1885 Unknown symbol
>>>>>> > 'warn_level_tabs_found_in_verbatim_string_literals'
>>>>>> >
>>>>>> >
>>>>>> > Thanks,
>>>>>> > Somesh
>>>>>> >
>>>>>> >
>>>>>> > _______________________________________________
>>>>>> > Powered by www.kitware.com
>>>>>> >
>>>>>> > Visit other Kitware open-source projects at
>>>>>> > http://www.kitware.com/opensource/opensource.html
>>>>>> >
>>>>>> > Kitware offers ITK Training Courses, for more information visit:
>>>>>> > http://kitware.com/products/protraining.php
>>>>>> >
>>>>>> > Please keep messages on-topic and check the ITK FAQ at:
>>>>>> > http://www.itk.org/Wiki/ITK_FAQ
>>>>>> >
>>>>>> > Follow this link to subscribe/unsubscribe:
>>>>>> > http://public.kitware.com/mailman/listinfo/insight-developers
>>>>>> >
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.php
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/insight-developers
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160914/fce6ff85/attachment.html>

From someshsandbox at gmail.com  Wed Sep 14 19:05:57 2016
From: someshsandbox at gmail.com (Somesh)
Date: Wed, 14 Sep 2016 19:05:57 -0400
Subject: [ITK-dev] Pre-commit Failure uncrustify
In-Reply-To: <CAPf2UMTBt81+33QLvQut1N+Hix2CdJK2O0zW-=MqaDVOO5aD8A@mail.gmail.com>
References: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
 <CALzTN-TCmCv0kWWy7go1qp+R3zUEdW-ZyhGF_x9p1-7=Up4_Zw@mail.gmail.com>
 <CADafqVqqDKDFpE8cMqtv4AtoN8d_0AUJT75udH9wUx3zxKC8jQ@mail.gmail.com>
 <CAPmoeGbA6uxA9a0NF9b-x4JVqPkxvOsbDsWFQYw=yzAjnocOHg@mail.gmail.com>
 <CADafqVpzwHs71ft9L=YESmu5-ChnyUvkwX3p+mssQRSP_2KGPw@mail.gmail.com>
 <CADafqVrQ6SZ2P6KeNPtSZ_mqD+oXJEUfb3oKQA036ez7zg04gQ@mail.gmail.com>
 <CAPf2UMTzDG9xdqhTYkTq+p=7_Py21HuL5fz5qrE3Lhr4xqSBfA@mail.gmail.com>
 <CAPf2UMTBt81+33QLvQut1N+Hix2CdJK2O0zW-=MqaDVOO5aD8A@mail.gmail.com>
Message-ID: <CADafqVoYSBceDbJb7XP6FH-ciULSiSAT8YrH7_hBRxEHz6U_wg@mail.gmail.com>

Hi D?enan,
You are right.  I accidentally sent you the wrong commit info. I use
homebrew package manager for mac and I accidentally sent you the commit ID
of homebrew commit instead of uncrustify. See
https://github.com/Homebrew/brew/commit/5a264cf59733fa8e0f69f8e6567e069a8cfd8bde
. My apologies :)
However it seems I have correct version of uncrustify. Looking into the
uncrustify remotes that I have installed, this is what I am using:

origin https://github.com/uncrustify/uncrustify.git (fetch)
origin https://github.com/uncrustify/uncrustify.git (push)

With the last 5 commits as:


   - 5d703fa01ff67afc029f31a5ac36bd2fbafb6aea Merge pull request #756 from
   Unity-Technologies/fixes/make_version_with_cmake
   - bc2b0c3e0c5b485cabbbcefcfb1eee76dbd62356 removed cmake dependency on
   autotools and directly use make_version.py
   - ac79e4081241359bdf3eec42baca690776ab565f make_version.py will be used
   only to retrieve the version from the VCS.
   - 3ef03cd6ac3fe218e77f14336e7c17daf75ba551 fixed instability retrieving
   the version when under hg-git
   - d9b0253f2d89c3556704bd45145d5bd4108f1043 Merge pull request #661 from
   uncrustify/NewLineProt


I can take a look into why its not working for me in the weekend.

Thanks,
Somesh



On Wed, Sep 14, 2016 at 4:04 PM, D?enan Zuki? <dzenanz at gmail.com> wrote:

> Hi Somesh,
>
> I just pulled master version of uncrustify, the last commit is on 10th
> (you have a commit on 12th!):
> Revision: 5d703fa01ff67afc029f31a5ac36bd2fbafb6aea
> Author: gmaurel <guy.j at maurel.de>
> Date: 2016-09-10 15:06:05
> Message: Merge pull request #756 from Unity-Technologies/fixes/make_
> version_with_cmake
>
> I must conclude that you are using somebody's fork of uncrustify, not HEAD
> from the official repository. Can you verify this?
>
> Regards,
> D?enan
>
> On Mon, Sep 12, 2016 at 10:17 PM, D?enan Zuki? <dzenanz at gmail.com> wrote:
>
>> It is not required.
>>
>> D?enan at phone
>>
>> On Sep 12, 2016 22:15, "Somesh" <someshsandbox at gmail.com> wrote:
>>
>>> Is running uncrustify hooks a required process in the ITK development
>>> workflow or can I disable it if I have to submit a patch ?
>>>
>>> Thanks,
>>> Somesh
>>>
>>> On Mon, Sep 12, 2016 at 9:30 PM, Somesh <someshsandbox at gmail.com> wrote:
>>>
>>>> Hi D?enan,
>>>> I am using the HEAD of master uncrustify. The last commit to this repo
>>>> was made today.
>>>>
>>>> commit 5a264cf59733fa8e0f69f8e6567e069a8cfd8bde
>>>> Merge: 553ef05 8ce4ca1
>>>> Author: Zhiming Wang <zmwangx at gmail.com>
>>>> Date:   Mon Sep 12 10:22:27 2016 -0400
>>>>
>>>> I have build from source using brew for mac.
>>>>
>>>> Also my mergetool/difftool are all set. I am using OS X El
>>>> Captain 10.11.6 and kaleidoscope tool for mac
>>>> http://www.kaleidoscopeapp.com/.
>>>>
>>>> Thanks,
>>>> Somesh
>>>>
>>>> On Mon, Sep 12, 2016 at 9:11 PM, Dzenan Zukic <dzenan.zukic at kitware.com
>>>> > wrote:
>>>>
>>>>> Hi Somesh,
>>>>>
>>>>> You need a recent master version (2016-08-26 or newer) which you can
>>>>> build yourself from source available on GitHub
>>>>> <https://github.com/uncrustify/uncrustify>.
>>>>>
>>>>> Also, you need to have merge tool set. On Windows kdiff3 works well
>>>>> but TortoiseMerge doesn't.
>>>>>
>>>>> Regards,
>>>>> D?enan Zuki?, PhD, Senior R&D Engineer, Kitware (Carrboro, N.C.)
>>>>>
>>>>> On Mon, Sep 12, 2016 at 9:03 PM, Somesh <someshsandbox at gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Hi Matt,
>>>>>> Do KWStyle and uncrustify play well with both enabled ?
>>>>>> I have  uncrustify  version 0.63 and the prehooks still fail. I
>>>>>> believe 0.63 is the latest uncrustify version: https://github.com/un
>>>>>> crustify/uncrustify/blob/master/CMakeLists.txt#L124
>>>>>>
>>>>>> Thanks,
>>>>>> Somesh
>>>>>>
>>>>>> On Mon, Sep 12, 2016 at 5:12 PM, Matt McCormick <
>>>>>> matt.mccormick at kitware.com> wrote:
>>>>>>
>>>>>>> Hi Somesh,
>>>>>>>
>>>>>>> Yes, Dzenan recently improved upstream uncrustify and its
>>>>>>> configuration in ITK so it works much better. A newer version of
>>>>>>> uncrustify is required as described here:
>>>>>>>
>>>>>>>   https://github.com/InsightSoftwareConsortium/ITK/blob/6ee105
>>>>>>> 75445aa1c878797db4febf7d775a38f1f3/Utilities/DevelopmentSetu
>>>>>>> pScripts/GitTips.sh#L66-L74
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Matt
>>>>>>>
>>>>>>> On Mon, Sep 12, 2016 at 2:49 PM, Somesh <someshsandbox at gmail.com>
>>>>>>> wrote:
>>>>>>> > Hi,
>>>>>>> > I recently set up a ITK dev on my mac. While commiting a patch
>>>>>>> locally, I am
>>>>>>> > getting failure in precommit hooks. Specifically uncrustify is
>>>>>>> giving the
>>>>>>> > following errors. Do I have to install a specific version of
>>>>>>> > uncrustify/python ? I installed uncrustify using brew.
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:99 Unknown symbol
>>>>>>> > 'indent_cs_delegate_brace'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:287 Unknown symbol
>>>>>>> > 'indent_token_after_brace'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:290 Unknown symbol
>>>>>>> > 'indent_cpp_lambda_body'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:424 Unknown symbol
>>>>>>> > 'sp_angle_paren_empty'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:533 Unknown symbol
>>>>>>> > 'sp_after_operator_sym_empty'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:570 Unknown symbol
>>>>>>> > 'sp_func_proto_paren_empty'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:576 Unknown symbol
>>>>>>> > 'sp_func_def_paren_empty'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:614 Unknown symbol
>>>>>>> > 'sp_func_class_paren_empty'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:644 Unknown symbol
>>>>>>> > 'sp_super_paren'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:647 Unknown symbol
>>>>>>> > 'sp_this_paren'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:851 Unknown symbol
>>>>>>> > 'sp_skip_vbrace_tokens'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:922 Unknown symbol
>>>>>>> > 'align_var_class_span'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:925 Unknown symbol
>>>>>>> > 'align_var_class_thresh'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:928 Unknown symbol
>>>>>>> > 'align_var_class_gap'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1068 Unknown symbol
>>>>>>> > 'nl_oc_block_brace'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1245 Unknown symbol
>>>>>>> > 'nl_enum_own_lines'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1256 Unknown symbol
>>>>>>> > 'nl_func_class_scope'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1284 Unknown symbol
>>>>>>> > 'nl_func_decl_start_multi_line'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1287 Unknown symbol
>>>>>>> > 'nl_func_def_start_multi_line'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1296 Unknown symbol
>>>>>>> > 'nl_func_decl_args_multi_line'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1299 Unknown symbol
>>>>>>> > 'nl_func_def_args_multi_line'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1314 Unknown symbol
>>>>>>> > 'nl_func_decl_end_multi_line'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1317 Unknown symbol
>>>>>>> > 'nl_func_def_end_multi_line'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1326 Unknown symbol
>>>>>>> > 'nl_func_call_start_multi_line'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1329 Unknown symbol
>>>>>>> > 'nl_func_call_args_multi_line'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1332 Unknown symbol
>>>>>>> > 'nl_func_call_end_multi_line'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1388 Unknown symbol
>>>>>>> > 'nl_squeeze_ifdef_top_level'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1461 Unknown symbol
>>>>>>> > 'nl_split_if_one_liner'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1465 Unknown symbol
>>>>>>> > 'nl_split_for_one_liner'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1469 Unknown symbol
>>>>>>> > 'nl_split_while_one_liner'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1541 Unknown symbol
>>>>>>> > 'nl_after_func_class_proto'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1544 Unknown symbol
>>>>>>> > 'nl_after_func_class_proto_group'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1662 Unknown symbol
>>>>>>> > 'mod_full_brace_if_chain_only'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1781 Unknown symbol
>>>>>>> > 'cmt_multi_first_len_minimum'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1812 Unknown symbol
>>>>>>> > 'cmt_insert_before_inlines'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1817 Unknown symbol
>>>>>>> > 'cmt_insert_before_ctor_dtor'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1878 Unknown symbol
>>>>>>> > 'use_options_overriding_for_qt_macros'
>>>>>>> >
>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1885 Unknown symbol
>>>>>>> > 'warn_level_tabs_found_in_verbatim_string_literals'
>>>>>>> >
>>>>>>> >
>>>>>>> > Thanks,
>>>>>>> > Somesh
>>>>>>> >
>>>>>>> >
>>>>>>> > _______________________________________________
>>>>>>> > Powered by www.kitware.com
>>>>>>> >
>>>>>>> > Visit other Kitware open-source projects at
>>>>>>> > http://www.kitware.com/opensource/opensource.html
>>>>>>> >
>>>>>>> > Kitware offers ITK Training Courses, for more information visit:
>>>>>>> > http://kitware.com/products/protraining.php
>>>>>>> >
>>>>>>> > Please keep messages on-topic and check the ITK FAQ at:
>>>>>>> > http://www.itk.org/Wiki/ITK_FAQ
>>>>>>> >
>>>>>>> > Follow this link to subscribe/unsubscribe:
>>>>>>> > http://public.kitware.com/mailman/listinfo/insight-developers
>>>>>>> >
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.php
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://public.kitware.com/mailman/listinfo/insight-developers
>>>
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160914/bca1aa9f/attachment.html>

From dzenanz at gmail.com  Wed Sep 14 20:10:05 2016
From: dzenanz at gmail.com (=?UTF-8?B?RMW+ZW5hbiBadWtpxIc=?=)
Date: Wed, 14 Sep 2016 20:10:05 -0400
Subject: [ITK-dev] Pre-commit Failure uncrustify
In-Reply-To: <CADafqVoYSBceDbJb7XP6FH-ciULSiSAT8YrH7_hBRxEHz6U_wg@mail.gmail.com>
References: <CADafqVpNZaq4JxNiTLLLv+4QomXW1P0mJJVcjoBGaZ6b5OmQgw@mail.gmail.com>
 <CALzTN-TCmCv0kWWy7go1qp+R3zUEdW-ZyhGF_x9p1-7=Up4_Zw@mail.gmail.com>
 <CADafqVqqDKDFpE8cMqtv4AtoN8d_0AUJT75udH9wUx3zxKC8jQ@mail.gmail.com>
 <CAPmoeGbA6uxA9a0NF9b-x4JVqPkxvOsbDsWFQYw=yzAjnocOHg@mail.gmail.com>
 <CADafqVpzwHs71ft9L=YESmu5-ChnyUvkwX3p+mssQRSP_2KGPw@mail.gmail.com>
 <CADafqVrQ6SZ2P6KeNPtSZ_mqD+oXJEUfb3oKQA036ez7zg04gQ@mail.gmail.com>
 <CAPf2UMTzDG9xdqhTYkTq+p=7_Py21HuL5fz5qrE3Lhr4xqSBfA@mail.gmail.com>
 <CAPf2UMTBt81+33QLvQut1N+Hix2CdJK2O0zW-=MqaDVOO5aD8A@mail.gmail.com>
 <CADafqVoYSBceDbJb7XP6FH-ciULSiSAT8YrH7_hBRxEHz6U_wg@mail.gmail.com>
Message-ID: <CAPf2UMSoL_Hd1aYwWP0738MrDDzymA1B-3hxUp1KXsG=VmGgmA@mail.gmail.com>

Hi Somesh,

maybe ITK's hook is picking up a different version of uncrustify from what
you think it is using. Check how many uncrustify executables there are on
your machine, especially in ITK's source tree.

Regards,
D?enan

On Wed, Sep 14, 2016 at 7:05 PM, Somesh <someshsandbox at gmail.com> wrote:

> Hi D?enan,
> You are right.  I accidentally sent you the wrong commit info. I use
> homebrew package manager for mac and I accidentally sent you the commit ID
> of homebrew commit instead of uncrustify. See https://github.com/
> Homebrew/brew/commit/5a264cf59733fa8e0f69f8e6567e069a8cfd8bde . My
> apologies :)
> However it seems I have correct version of uncrustify. Looking into the
> uncrustify remotes that I have installed, this is what I am using:
>
> origin https://github.com/uncrustify/uncrustify.git (fetch)
> origin https://github.com/uncrustify/uncrustify.git (push)
>
> With the last 5 commits as:
>
>
>    - 5d703fa01ff67afc029f31a5ac36bd2fbafb6aea Merge pull request #756
>    from Unity-Technologies/fixes/make_version_with_cmake
>    - bc2b0c3e0c5b485cabbbcefcfb1eee76dbd62356 removed cmake dependency on
>    autotools and directly use make_version.py
>    - ac79e4081241359bdf3eec42baca690776ab565f make_version.py will be
>    used only to retrieve the version from the VCS.
>    - 3ef03cd6ac3fe218e77f14336e7c17daf75ba551 fixed instability
>    retrieving the version when under hg-git
>    - d9b0253f2d89c3556704bd45145d5bd4108f1043 Merge pull request #661
>    from uncrustify/NewLineProt
>
>
> I can take a look into why its not working for me in the weekend.
>
> Thanks,
> Somesh
>
>
>
> On Wed, Sep 14, 2016 at 4:04 PM, D?enan Zuki? <dzenanz at gmail.com> wrote:
>
>> Hi Somesh,
>>
>> I just pulled master version of uncrustify, the last commit is on 10th
>> (you have a commit on 12th!):
>> Revision: 5d703fa01ff67afc029f31a5ac36bd2fbafb6aea
>> Author: gmaurel <guy.j at maurel.de>
>> Date: 2016-09-10 15:06:05
>> Message: Merge pull request #756 from Unity-Technologies/fixes/make_
>> version_with_cmake
>>
>> I must conclude that you are using somebody's fork of uncrustify, not
>> HEAD from the official repository. Can you verify this?
>>
>> Regards,
>> D?enan
>>
>> On Mon, Sep 12, 2016 at 10:17 PM, D?enan Zuki? <dzenanz at gmail.com> wrote:
>>
>>> It is not required.
>>>
>>> D?enan at phone
>>>
>>> On Sep 12, 2016 22:15, "Somesh" <someshsandbox at gmail.com> wrote:
>>>
>>>> Is running uncrustify hooks a required process in the ITK development
>>>> workflow or can I disable it if I have to submit a patch ?
>>>>
>>>> Thanks,
>>>> Somesh
>>>>
>>>> On Mon, Sep 12, 2016 at 9:30 PM, Somesh <someshsandbox at gmail.com>
>>>> wrote:
>>>>
>>>>> Hi D?enan,
>>>>> I am using the HEAD of master uncrustify. The last commit to this repo
>>>>> was made today.
>>>>>
>>>>> commit 5a264cf59733fa8e0f69f8e6567e069a8cfd8bde
>>>>> Merge: 553ef05 8ce4ca1
>>>>> Author: Zhiming Wang <zmwangx at gmail.com>
>>>>> Date:   Mon Sep 12 10:22:27 2016 -0400
>>>>>
>>>>> I have build from source using brew for mac.
>>>>>
>>>>> Also my mergetool/difftool are all set. I am using OS X El
>>>>> Captain 10.11.6 and kaleidoscope tool for mac
>>>>> http://www.kaleidoscopeapp.com/.
>>>>>
>>>>> Thanks,
>>>>> Somesh
>>>>>
>>>>> On Mon, Sep 12, 2016 at 9:11 PM, Dzenan Zukic <
>>>>> dzenan.zukic at kitware.com> wrote:
>>>>>
>>>>>> Hi Somesh,
>>>>>>
>>>>>> You need a recent master version (2016-08-26 or newer) which you can
>>>>>> build yourself from source available on GitHub
>>>>>> <https://github.com/uncrustify/uncrustify>.
>>>>>>
>>>>>> Also, you need to have merge tool set. On Windows kdiff3 works well
>>>>>> but TortoiseMerge doesn't.
>>>>>>
>>>>>> Regards,
>>>>>> D?enan Zuki?, PhD, Senior R&D Engineer, Kitware (Carrboro, N.C.)
>>>>>>
>>>>>> On Mon, Sep 12, 2016 at 9:03 PM, Somesh <someshsandbox at gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Matt,
>>>>>>> Do KWStyle and uncrustify play well with both enabled ?
>>>>>>> I have  uncrustify  version 0.63 and the prehooks still fail. I
>>>>>>> believe 0.63 is the latest uncrustify version: https://github.com/un
>>>>>>> crustify/uncrustify/blob/master/CMakeLists.txt#L124
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Somesh
>>>>>>>
>>>>>>> On Mon, Sep 12, 2016 at 5:12 PM, Matt McCormick <
>>>>>>> matt.mccormick at kitware.com> wrote:
>>>>>>>
>>>>>>>> Hi Somesh,
>>>>>>>>
>>>>>>>> Yes, Dzenan recently improved upstream uncrustify and its
>>>>>>>> configuration in ITK so it works much better. A newer version of
>>>>>>>> uncrustify is required as described here:
>>>>>>>>
>>>>>>>>   https://github.com/InsightSoftwareConsortium/ITK/blob/6ee105
>>>>>>>> 75445aa1c878797db4febf7d775a38f1f3/Utilities/DevelopmentSetu
>>>>>>>> pScripts/GitTips.sh#L66-L74
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Matt
>>>>>>>>
>>>>>>>> On Mon, Sep 12, 2016 at 2:49 PM, Somesh <someshsandbox at gmail.com>
>>>>>>>> wrote:
>>>>>>>> > Hi,
>>>>>>>> > I recently set up a ITK dev on my mac. While commiting a patch
>>>>>>>> locally, I am
>>>>>>>> > getting failure in precommit hooks. Specifically uncrustify is
>>>>>>>> giving the
>>>>>>>> > following errors. Do I have to install a specific version of
>>>>>>>> > uncrustify/python ? I installed uncrustify using brew.
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:99 Unknown symbol
>>>>>>>> > 'indent_cs_delegate_brace'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:287 Unknown symbol
>>>>>>>> > 'indent_token_after_brace'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:290 Unknown symbol
>>>>>>>> > 'indent_cpp_lambda_body'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:424 Unknown symbol
>>>>>>>> > 'sp_angle_paren_empty'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:533 Unknown symbol
>>>>>>>> > 'sp_after_operator_sym_empty'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:570 Unknown symbol
>>>>>>>> > 'sp_func_proto_paren_empty'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:576 Unknown symbol
>>>>>>>> > 'sp_func_def_paren_empty'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:614 Unknown symbol
>>>>>>>> > 'sp_func_class_paren_empty'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:644 Unknown symbol
>>>>>>>> > 'sp_super_paren'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:647 Unknown symbol
>>>>>>>> > 'sp_this_paren'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:851 Unknown symbol
>>>>>>>> > 'sp_skip_vbrace_tokens'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:922 Unknown symbol
>>>>>>>> > 'align_var_class_span'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:925 Unknown symbol
>>>>>>>> > 'align_var_class_thresh'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:928 Unknown symbol
>>>>>>>> > 'align_var_class_gap'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1068 Unknown symbol
>>>>>>>> > 'nl_oc_block_brace'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1245 Unknown symbol
>>>>>>>> > 'nl_enum_own_lines'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1256 Unknown symbol
>>>>>>>> > 'nl_func_class_scope'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1284 Unknown symbol
>>>>>>>> > 'nl_func_decl_start_multi_line'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1287 Unknown symbol
>>>>>>>> > 'nl_func_def_start_multi_line'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1296 Unknown symbol
>>>>>>>> > 'nl_func_decl_args_multi_line'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1299 Unknown symbol
>>>>>>>> > 'nl_func_def_args_multi_line'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1314 Unknown symbol
>>>>>>>> > 'nl_func_decl_end_multi_line'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1317 Unknown symbol
>>>>>>>> > 'nl_func_def_end_multi_line'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1326 Unknown symbol
>>>>>>>> > 'nl_func_call_start_multi_line'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1329 Unknown symbol
>>>>>>>> > 'nl_func_call_args_multi_line'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1332 Unknown symbol
>>>>>>>> > 'nl_func_call_end_multi_line'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1388 Unknown symbol
>>>>>>>> > 'nl_squeeze_ifdef_top_level'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1461 Unknown symbol
>>>>>>>> > 'nl_split_if_one_liner'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1465 Unknown symbol
>>>>>>>> > 'nl_split_for_one_liner'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1469 Unknown symbol
>>>>>>>> > 'nl_split_while_one_liner'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1541 Unknown symbol
>>>>>>>> > 'nl_after_func_class_proto'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1544 Unknown symbol
>>>>>>>> > 'nl_after_func_class_proto_group'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1662 Unknown symbol
>>>>>>>> > 'mod_full_brace_if_chain_only'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1781 Unknown symbol
>>>>>>>> > 'cmt_multi_first_len_minimum'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1812 Unknown symbol
>>>>>>>> > 'cmt_insert_before_inlines'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1817 Unknown symbol
>>>>>>>> > 'cmt_insert_before_ctor_dtor'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1878 Unknown symbol
>>>>>>>> > 'use_options_overriding_for_qt_macros'
>>>>>>>> >
>>>>>>>> > ./Utilities/Maintenance/uncrustify_itk.cfg:1885 Unknown symbol
>>>>>>>> > 'warn_level_tabs_found_in_verbatim_string_literals'
>>>>>>>> >
>>>>>>>> >
>>>>>>>> > Thanks,
>>>>>>>> > Somesh
>>>>>>>> >
>>>>>>>> >
>>>>>>>> > _______________________________________________
>>>>>>>> > Powered by www.kitware.com
>>>>>>>> >
>>>>>>>> > Visit other Kitware open-source projects at
>>>>>>>> > http://www.kitware.com/opensource/opensource.html
>>>>>>>> >
>>>>>>>> > Kitware offers ITK Training Courses, for more information visit:
>>>>>>>> > http://kitware.com/products/protraining.php
>>>>>>>> >
>>>>>>>> > Please keep messages on-topic and check the ITK FAQ at:
>>>>>>>> > http://www.itk.org/Wiki/ITK_FAQ
>>>>>>>> >
>>>>>>>> > Follow this link to subscribe/unsubscribe:
>>>>>>>> > http://public.kitware.com/mailman/listinfo/insight-developers
>>>>>>>> >
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://kitware.com/products/protraining.php
>>>>
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://public.kitware.com/mailman/listinfo/insight-developers
>>>>
>>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160914/22337241/attachment.html>

From will.schroeder at kitware.com  Thu Sep 15 13:54:58 2016
From: will.schroeder at kitware.com (Will Schroeder)
Date: Thu, 15 Sep 2016 13:54:58 -0400
Subject: [ITK-dev] VTK Textbook and User's Guide now available for download
Message-ID: <CAEiDrtVi8dBP_5jNd6fs1kmyiS0VtzxJk0ZVSyzk89fpuvHouQ@mail.gmail.com>

Kitware is releasing the VTK Textbook and VTK User's Guide for PDF
download. Follow the links below to a landing page where you can buy a
printed version, or download a PDF.

Longer term, the plan is to convert these books to LaTeX (from Framemaker)
and place the content into an open repository. The first step is to mostly
duplicate what exists now; eventually we have the ambitious goal to
completely rewrite / recombine / rethink the books. For example, using
VTK.js (under development now) to offer web interaction with examples etc.
We can certainly use the talents of the community to take this challenge
on, so if you are interested please let me know.

The Visualization Toolkit An Object-Oriented Approach to 3D Graphics (4th
ed.)
http://www.vtk.org/vtk-textbook/
pdf: http://www.kitware.com/products/books/VTKTextbook.pdf

*The VTK User?s Guide*
http://www.vtk.org/vtk-users-guide/
pdf: http://www.kitware.com/products/books/VTKUsersGuide.pdf

Best, please let me know if there are issues or concerns.
W

-- 
William J. Schroeder, PhD
Kitware, Inc. - Building the World's Technical Computing Software
28 Corporate Drive
Clifton Park, NY 12065
will.schroeder at kitware.com
http://www.kitware.com
(518) 881-4902
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160915/32962145/attachment.html>

From francois.budin at kitware.com  Thu Sep 15 15:07:30 2016
From: francois.budin at kitware.com (Francois Budin)
Date: Thu, 15 Sep 2016 15:07:30 -0400
Subject: [ITK-dev] VTK Textbook and User's Guide now available for
	download
In-Reply-To: <CAEiDrtVi8dBP_5jNd6fs1kmyiS0VtzxJk0ZVSyzk89fpuvHouQ@mail.gmail.com>
References: <CAEiDrtVi8dBP_5jNd6fs1kmyiS0VtzxJk0ZVSyzk89fpuvHouQ@mail.gmail.com>
Message-ID: <CAHwLD2XspFeiW4BmkEf7LWs_P=iSoQQVjxWM3x5V9eKnp4DATA@mail.gmail.com>

How about writing the book in a Jupyter notebook using a Python or a
Javascript kernel to run the examples? I know it is possible to export the
content of notebooks as PDFs through LaTeX, although I am not sure how the
formatting is handled and if that would work for a book.

Francois

On Thu, Sep 15, 2016 at 1:54 PM, Will Schroeder <will.schroeder at kitware.com>
wrote:

> Kitware is releasing the VTK Textbook and VTK User's Guide for PDF
> download. Follow the links below to a landing page where you can buy a
> printed version, or download a PDF.
>
> Longer term, the plan is to convert these books to LaTeX (from Framemaker)
> and place the content into an open repository. The first step is to mostly
> duplicate what exists now; eventually we have the ambitious goal to
> completely rewrite / recombine / rethink the books. For example, using
> VTK.js (under development now) to offer web interaction with examples etc.
> We can certainly use the talents of the community to take this challenge
> on, so if you are interested please let me know.
>
> The Visualization Toolkit An Object-Oriented Approach to 3D Graphics (4th
> ed.)
> http://www.vtk.org/vtk-textbook/
> pdf: http://www.kitware.com/products/books/VTKTextbook.pdf
>
> *The VTK User?s Guide*
> http://www.vtk.org/vtk-users-guide/
> pdf: http://www.kitware.com/products/books/VTKUsersGuide.pdf
>
> Best, please let me know if there are issues or concerns.
> W
>
> --
> William J. Schroeder, PhD
> Kitware, Inc. - Building the World's Technical Computing Software
> 28 Corporate Drive
> Clifton Park, NY 12065
> will.schroeder at kitware.com
> http://www.kitware.com
> (518) 881-4902
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160915/c460972d/attachment.html>

From dzenanz at gmail.com  Mon Sep 19 09:54:37 2016
From: dzenanz at gmail.com (=?UTF-8?B?RMW+ZW5hbiBadWtpxIc=?=)
Date: Mon, 19 Sep 2016 09:54:37 -0400
Subject: [ITK-dev] lhcp-vm-rh502.nlm
Message-ID: <CAPf2UMRSABa1DhdAHs7wt=o_0UM_ozZGPrc6wDcbZ8Cod22jPQ@mail.gmail.com>

Hi guys,

who owns build machine lhcp-vm-rh502.nlm? It looks like this machine needs
to have it build directory cleaned up, it produces some spurious warnings
such as these
<https://open.cdash.org/viewBuildError.php?type=1&buildid=4553608>.

Regards,
D?enan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160919/9739b9cc/attachment.html>

From blowekamp at mail.nih.gov  Mon Sep 19 10:01:59 2016
From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C])
Date: Mon, 19 Sep 2016 14:01:59 +0000
Subject: [ITK-dev] [ITK]  lhcp-vm-rh502.nlm
In-Reply-To: <CAPf2UMRSABa1DhdAHs7wt=o_0UM_ozZGPrc6wDcbZ8Cod22jPQ@mail.gmail.com>
References: <CAPf2UMRSABa1DhdAHs7wt=o_0UM_ozZGPrc6wDcbZ8Cod22jPQ@mail.gmail.com>
Message-ID: <C1E15FB2-F616-42CA-BBC0-448D33C684D6@mail.nih.gov>

That is my machine.

The ITK repo is clean and up-to-date.

The warnings looks legitimate about implicit conversion from float to integer types. It should be addressed:

itkAbsImageFilterAndAdaptorTest.cxx:120: warning: passing 'float' for argument 1 to 'std::streamsize std::ios_base::precision(std::streamsize)'

HTH,
Brad

On Sep 19, 2016, at 9:54 AM, D?enan Zuki? <dzenanz at gmail.com<mailto:dzenanz at gmail.com>> wrote:

Hi guys,

who owns build machine lhcp-vm-rh502.nlm? It looks like this machine needs to have it build directory cleaned up, it produces some spurious warnings such as these<https://open.cdash.org/viewBuildError.php?type=1&buildid=4553608>.

Regards,
D?enan
_______________________________________________
Powered by www.kitware.com<http://www.kitware.com>

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/insight-developers
_______________________________________________
Community mailing list
Community at itk.org
http://public.kitware.com/mailman/listinfo/community

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160919/dd4d6454/attachment.html>

From jhlegarreta at vicomtech.org  Mon Sep 19 10:11:46 2016
From: jhlegarreta at vicomtech.org (Jon Haitz Legarreta)
Date: Mon, 19 Sep 2016 16:11:46 +0200
Subject: [ITK-dev] [ITK] lhcp-vm-rh502.nlm
In-Reply-To: <C1E15FB2-F616-42CA-BBC0-448D33C684D6@mail.nih.gov>
References: <CAPf2UMRSABa1DhdAHs7wt=o_0UM_ozZGPrc6wDcbZ8Cod22jPQ@mail.gmail.com>
 <C1E15FB2-F616-42CA-BBC0-448D33C684D6@mail.nih.gov>
Message-ID: <CAAKhGh_A4R-WksFXXYQDscfpQDv0KmSPY_+9JDf_D6DiZgpKXw@mail.gmail.com>

Uops, that warning "belongs to me".
Will submit a patch.

Thanks for the heads-up.

JON HAITZ


--


On 19 September 2016 at 16:01, Lowekamp, Bradley (NIH/NLM/LHC) [C] <
blowekamp at mail.nih.gov> wrote:

> That is my machine.
>
> The ITK repo is clean and up-to-date.
>
> The warnings looks legitimate about implicit conversion from float to
> integer types. It should be addressed:
>
> itkAbsImageFilterAndAdaptorTest.cxx:120: warning: passing 'float' for argument 1 to 'std::streamsize std::ios_base::precision(std::streamsize)'
>
>
> HTH,
> Brad
>
> On Sep 19, 2016, at 9:54 AM, D?enan Zuki? <dzenanz at gmail.com> wrote:
>
> Hi guys,
>
> who owns build machine lhcp-vm-rh502.nlm? It looks like this machine needs
> to have it build directory cleaned up, it produces some spurious warnings
> such as these
> <https://open.cdash.org/viewBuildError.php?type=1&buildid=4553608>.
>
> Regards,
> D?enan
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers
> _______________________________________________
> Community mailing list
> Community at itk.org
> http://public.kitware.com/mailman/listinfo/community
>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160919/a08f0f11/attachment.html>

From steve at sumost.ca  Mon Sep 19 17:38:58 2016
From: steve at sumost.ca (Steve M. Robbins)
Date: Mon, 19 Sep 2016 16:38:58 -0500
Subject: [ITK-dev]
 itk::LinearInterpolateImageFunction::EvaluateAtContinuousIndex() -- what is
 intended behaviour outside of image?
Message-ID: <20160919213858.yx4rb56iie4k7mvm@sumost.ca>

Hi,

The doc for this function doesn't make it clear whether the user may
call it with an index point that lies outside the image or not.  I can
tell you that the code doesn't check the bounds, resulting in
uninitialized memory reads [1].

My question is: is that a user error or bug in the evaluation
function?

If I read the ITK 4.8.2 code correctly, it looks like it takes care of
the lower index bound, but not the upper index bound -- so ITK bug?


Thanks,
-Steve


[1] http://my.cdash.org/viewDynamicAnalysisFile.php?id=3780109

Elastix test suite creates a 2D image of size 10x10, then calls
the interpolator with coordinates { 12.7, 15.3 }.  I believe
that is the cause of this diagnostic:

UMR ==26834== Invalid read of size 2
==26834==    at 0x62AE77: itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double>::EvaluateOptimized(itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double>::Dispatch<2u> const&, itk::ContinuousIndex<double, 2u> const&) const (itkLinearInterpolateImageFunction.h:172)
==26834==    by 0x62228A: itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double>::EvaluateAtContinuousIndex(itk::ContinuousIndex<double, 2u> const&) const (itkLinearInterpolateImageFunction.h:99)
==26834==    by 0x61C431: bool TestInterpolators<2u>() (itkAdvancedLinearInterpolatorTest.cxx:171)
==26834==    by 0x616CD2: main (itkAdvancedLinearInterpolatorTest.cxx:279)

(Later, the code does an out-of-image call in 3D as well)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160919/ed2a4b74/attachment.sig>

From dzenanz at gmail.com  Tue Sep 20 09:00:24 2016
From: dzenanz at gmail.com (=?UTF-8?B?RMW+ZW5hbiBadWtpxIc=?=)
Date: Tue, 20 Sep 2016 09:00:24 -0400
Subject: [ITK-dev]
 itk::LinearInterpolateImageFunction::EvaluateAtContinuousIndex() -- what is
 intended behaviour outside of image?
In-Reply-To: <20160919213858.yx4rb56iie4k7mvm@sumost.ca>
References: <20160919213858.yx4rb56iie4k7mvm@sumost.ca>
Message-ID: <CAPf2UMS9VXW9UAQ0PwkFNiRHJZNqOwm1C7deyYYF+uZ=g2Gv9g@mail.gmail.com>

Hi Steve,

this function is not supposed to do bounds checking. Bounds checking can be
done with IsInsideBuffer(). The commit which introduced the code:

Revision: 6abbc7969a90786c4c73f5d191f634db536c2d1d
Author: Hans Johnson <hans-johnson at uiowa.edu>
Date: 2010-08-05 22:35:42
Message:
Made USE_OPTIMIZED_REGISTRATION the default


The ITK_USE_OPTIMIZED_REGISTRATION is now the default
behavior.  There is no longer another option.

Maybe Hans can explain why the lower bounds are checked but not the upper.
Otherwise you can try removing them and submitting
<http://itk.org/Wiki/ITK/Git/Develop> a patch Steve.

Regards,
D?enan

On Mon, Sep 19, 2016 at 5:38 PM, Steve M. Robbins <steve at sumost.ca> wrote:

> Hi,
>
> The doc for this function doesn't make it clear whether the user may
> call it with an index point that lies outside the image or not.  I can
> tell you that the code doesn't check the bounds, resulting in
> uninitialized memory reads [1].
>
> My question is: is that a user error or bug in the evaluation
> function?
>
> If I read the ITK 4.8.2 code correctly, it looks like it takes care of
> the lower index bound, but not the upper index bound -- so ITK bug?
>
>
> Thanks,
> -Steve
>
>
> [1] http://my.cdash.org/viewDynamicAnalysisFile.php?id=3780109
>
> Elastix test suite creates a 2D image of size 10x10, then calls
> the interpolator with coordinates { 12.7, 15.3 }.  I believe
> that is the cause of this diagnostic:
>
> UMR ==26834== Invalid read of size 2
> ==26834==    at 0x62AE77: itk::LinearInterpolateImageFunction<itk::Image<short,
> 2u>, double>::EvaluateOptimized(itk::LinearInterpolateImageFunction<itk::Image<short,
> 2u>, double>::Dispatch<2u> const&, itk::ContinuousIndex<double, 2u> const&)
> const (itkLinearInterpolateImageFunction.h:172)
> ==26834==    by 0x62228A: itk::LinearInterpolateImageFunction<itk::Image<short,
> 2u>, double>::EvaluateAtContinuousIndex(itk::ContinuousIndex<double, 2u>
> const&) const (itkLinearInterpolateImageFunction.h:99)
> ==26834==    by 0x61C431: bool TestInterpolators<2u>() (
> itkAdvancedLinearInterpolatorTest.cxx:171)
> ==26834==    by 0x616CD2: main (itkAdvancedLinearInterpolatorTest.cxx:279)
>
> (Later, the code does an out-of-image call in 3D as well)
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160920/87669e73/attachment.html>

From simon.warfield at childrens.harvard.edu  Tue Sep 20 15:46:02 2016
From: simon.warfield at childrens.harvard.edu (Simon Warfield)
Date: Tue, 20 Sep 2016 15:46:02 -0400
Subject: [ITK-dev] Insight-developers Digest, Vol 149, Issue 8
In-Reply-To: <mailman.15.1474387209.18857.insight-developers@itk.org>
References: <mailman.15.1474387209.18857.insight-developers@itk.org>
Message-ID: <b63564f8-e3cc-f8e6-d8e0-82bfb6cbb50c@childrens.harvard.edu>


It is a bug in the interpolation API.

It doesn't account for the size of the region in which the function 
evaluation is done.

Only the point at which an evaluation is done is ever checked in the 
hierarchy of code that is called.  The points which are evaluated to get 
the interpolated value are not checked, and if they are not valid, then 
an invalid memory read or segmentation fault occurs.

--Simon


On 9/20/2016 12:00 PM, insight-developers-request at itk.org wrote:
> Send Insight-developers mailing list submissions to
> 	insight-developers at itk.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> 	https://urldefense.proofpoint.com/v2/url?u=http-3A__public.kitware.com_mailman_listinfo_insight-2Ddevelopers&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=WbKAgN9KwXSjz8u0FDu7jhXRlLIeA5UUkqkvHeli9ek&e=
> or, via email, send a message with subject or body 'help' to
> 	insight-developers-request at itk.org
>
> You can reach the person managing the list at
> 	insight-developers-owner at itk.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Insight-developers digest..."
>
>
> Today's Topics:
>
>     1.
>        itk::LinearInterpolateImageFunction::EvaluateAtContinuousIndex()
>        -- what is intended behaviour outside of image? (Steve M. Robbins)
>     2. Re:
>        itk::LinearInterpolateImageFunction::EvaluateAtContinuousIndex()
>        -- what is intended behaviour outside of image? (D?enan Zuki?)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Mon, 19 Sep 2016 16:38:58 -0500
> From: "Steve M. Robbins" <steve at sumost.ca>
> To: ITK developer mailing list <insight-developers at itk.org>
> Cc: elastix at bigr.nl
> Subject: [ITK-dev]
> 	itk::LinearInterpolateImageFunction::EvaluateAtContinuousIndex() --
> 	what is intended behaviour outside of image?
> Message-ID: <20160919213858.yx4rb56iie4k7mvm at sumost.ca>
> Content-Type: text/plain; charset="us-ascii"
>
> Hi,
>
> The doc for this function doesn't make it clear whether the user may
> call it with an index point that lies outside the image or not.  I can
> tell you that the code doesn't check the bounds, resulting in
> uninitialized memory reads [1].
>
> My question is: is that a user error or bug in the evaluation
> function?
>
> If I read the ITK 4.8.2 code correctly, it looks like it takes care of
> the lower index bound, but not the upper index bound -- so ITK bug?
>
>
> Thanks,
> -Steve
>
>
> [1] https://urldefense.proofpoint.com/v2/url?u=http-3A__my.cdash.org_viewDynamicAnalysisFile.php-3Fid-3D3780109&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=dAaswv1c2FewCPDUiwr98T1ca9lOmmzukQgitIsrXok&e=
>
> Elastix test suite creates a 2D image of size 10x10, then calls
> the interpolator with coordinates { 12.7, 15.3 }.  I believe
> that is the cause of this diagnostic:
>
> UMR ==26834== Invalid read of size 2
> ==26834==    at 0x62AE77: itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double>::EvaluateOptimized(itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double>::Dispatch<2u> const&, itk::ContinuousIndex<double, 2u> const&) const (itkLinearInterpolateImageFunction.h:172)
> ==26834==    by 0x62228A: itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double>::EvaluateAtContinuousIndex(itk::ContinuousIndex<double, 2u> const&) const (itkLinearInterpolateImageFunction.h:99)
> ==26834==    by 0x61C431: bool TestInterpolators<2u>() (itkAdvancedLinearInterpolatorTest.cxx:171)
> ==26834==    by 0x616CD2: main (itkAdvancedLinearInterpolatorTest.cxx:279)
>
> (Later, the code does an out-of-image call in 3D as well)
>
> -------------- next part --------------
> A non-text attachment was scrubbed...
> Name: signature.asc
> Type: application/pgp-signature
> Size: 801 bytes
> Desc: not available
> URL: <https://urldefense.proofpoint.com/v2/url?u=http-3A__public.kitware.com_pipermail_insight-2Ddevelopers_attachments_20160919_ed2a4b74_attachment-2D0001.sig&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=7_cM6yi5GMBfxeVRyX9FDCNaXTT_nwTsg01NLa-30j0&e= >
>
> ------------------------------
>
> Message: 2
> Date: Tue, 20 Sep 2016 09:00:24 -0400
> From: D?enan Zuki? <dzenanz at gmail.com>
> To: "Steve M. Robbins" <steve at sumost.ca>
> Cc: "Hans J. Johnson" <hans-johnson at uiowa.edu>, ITK developer mailing
> 	list <insight-developers at itk.org>, elastix at bigr.nl
> Subject: Re: [ITK-dev]
> 	itk::LinearInterpolateImageFunction::EvaluateAtContinuousIndex() --
> 	what is intended behaviour outside of image?
> Message-ID:
> 	<CAPf2UMS9VXW9UAQ0PwkFNiRHJZNqOwm1C7deyYYF+uZ=g2Gv9g at mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
>
> Hi Steve,
>
> this function is not supposed to do bounds checking. Bounds checking can be
> done with IsInsideBuffer(). The commit which introduced the code:
>
> Revision: 6abbc7969a90786c4c73f5d191f634db536c2d1d
> Author: Hans Johnson <hans-johnson at uiowa.edu>
> Date: 2010-08-05 22:35:42
> Message:
> Made USE_OPTIMIZED_REGISTRATION the default
>
>
> The ITK_USE_OPTIMIZED_REGISTRATION is now the default
> behavior.  There is no longer another option.
>
> Maybe Hans can explain why the lower bounds are checked but not the upper.
> Otherwise you can try removing them and submitting
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__itk.org_Wiki_ITK_Git_Develop&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=ZfDuSqeuqNURhOT8lNMXJXYMBhp73A4icvZnVrpogxA&e= > a patch Steve.
>
> Regards,
> D?enan
>
> On Mon, Sep 19, 2016 at 5:38 PM, Steve M. Robbins <steve at sumost.ca> wrote:
>
>> Hi,
>>
>> The doc for this function doesn't make it clear whether the user may
>> call it with an index point that lies outside the image or not.  I can
>> tell you that the code doesn't check the bounds, resulting in
>> uninitialized memory reads [1].
>>
>> My question is: is that a user error or bug in the evaluation
>> function?
>>
>> If I read the ITK 4.8.2 code correctly, it looks like it takes care of
>> the lower index bound, but not the upper index bound -- so ITK bug?
>>
>>
>> Thanks,
>> -Steve
>>
>>
>> [1] https://urldefense.proofpoint.com/v2/url?u=http-3A__my.cdash.org_viewDynamicAnalysisFile.php-3Fid-3D3780109&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=dAaswv1c2FewCPDUiwr98T1ca9lOmmzukQgitIsrXok&e=
>>
>> Elastix test suite creates a 2D image of size 10x10, then calls
>> the interpolator with coordinates { 12.7, 15.3 }.  I believe
>> that is the cause of this diagnostic:
>>
>> UMR ==26834== Invalid read of size 2
>> ==26834==    at 0x62AE77: itk::LinearInterpolateImageFunction<itk::Image<short,
>> 2u>, double>::EvaluateOptimized(itk::LinearInterpolateImageFunction<itk::Image<short,
>> 2u>, double>::Dispatch<2u> const&, itk::ContinuousIndex<double, 2u> const&)
>> const (itkLinearInterpolateImageFunction.h:172)
>> ==26834==    by 0x62228A: itk::LinearInterpolateImageFunction<itk::Image<short,
>> 2u>, double>::EvaluateAtContinuousIndex(itk::ContinuousIndex<double, 2u>
>> const&) const (itkLinearInterpolateImageFunction.h:99)
>> ==26834==    by 0x61C431: bool TestInterpolators<2u>() (
>> itkAdvancedLinearInterpolatorTest.cxx:171)
>> ==26834==    by 0x616CD2: main (itkAdvancedLinearInterpolatorTest.cxx:279)
>>
>> (Later, the code does an out-of-image call in 3D as well)
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.kitware.com_opensource_opensource.html&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=Rc4Rwkix_LmsETzhqKvf7Q-kEcFPtKkVb1xzRn5k1B8&e=
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__kitware.com_products_protraining.php&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=Z9xgtbLlbYxa0EsHHoBoxlm_7hRlGiNDxmAo36JDWSg&e=
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.itk.org_Wiki_ITK-5FFAQ&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=r4DOIPoHB1kBr-eH7IGUEB4Bz0c_tjw6UM2TcWf3UE0&e=
>>
>> Follow this link to subscribe/unsubscribe:
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__public.kitware.com_mailman_listinfo_insight-2Ddevelopers&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=WbKAgN9KwXSjz8u0FDu7jhXRlLIeA5UUkqkvHeli9ek&e=
>>
>>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <https://urldefense.proofpoint.com/v2/url?u=http-3A__public.kitware.com_pipermail_insight-2Ddevelopers_attachments_20160920_87669e73_attachment-2D0001.html&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=IqLCJKLvdLlRAask4nBb1yqbajH_LGSvGX-5JE1Fdgw&e= >
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk.org
> https://urldefense.proofpoint.com/v2/url?u=http-3A__public.kitware.com_mailman_listinfo_insight-2Ddevelopers&d=CwICAg&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=spboX-Qn5Dn-uyspT__O0BtpSEF5erHIiRAwdzSaa_QAQ58afxHcHSMuB76pSgfl&m=HFczLLy-F4uhK-1hDmjBJAGPlMm2sUfpyYm6eA1dNzw&s=WbKAgN9KwXSjz8u0FDu7jhXRlLIeA5UUkqkvHeli9ek&e=
>
>
> ------------------------------
>
> End of Insight-developers Digest, Vol 149, Issue 8
> **************************************************

-- 
Simon K. Warfield, Ph.D.
Thorne Griscom Chair and Professor of Radiology
Harvard Medical School
Director of Radiology Research
Director Computational Radiology Laboratory
Department of Radiology
Boston Children's Hospital


From sepideh.movaghati at gmail.com  Fri Sep 30 15:24:04 2016
From: sepideh.movaghati at gmail.com (sepideh movaghati)
Date: Fri, 30 Sep 2016 15:24:04 -0400
Subject: [ITK-dev] V4 Registration having trouble converging while V3 works
	fine
Message-ID: <CAM7sfn22Yvi8Eo==QnwE4KsYoYs3y+urOw3MdCmr_s9W39Ha8w@mail.gmail.com>

Hi,



I was comparing v3 and v4 registration performance on a set of 3D images.
In few cases, I noticed that v4 registration is diverging while v3
converges to a reasonable result without any problem.
I wonder if you have ever noticed a problem with v4 optimizer that could
cause similar issues.


I copied my code for v3 and v4 registration below. I tried to keep the
registration configuration very similar in both versions. In v3 I set the
NumberOfSpatialSamples to 380000 which is about 10% of voxels. I also tried
with full sampling but the behavior stays the same.


In the attached csv file you can see the metric value at each iteration of
the optimizer for both v3 and v4 version. It is clear that v3 converges
smoothly, but v4 makes the initial metric value worse after too many
iterations.



Thanks a lot in advance.
Regards,
Sepide


auto interpolator = itk::LinearInterpolateImageFunction<ImageType,
double>::New();

auto transform = itk::AffineTransform<double>::New();

transform->SetIdentity();

itk::Array<double> scales;

scales.SetSize(12);

scales.Fill(1.0);

scales[9] =  0.001; //translation parameters scales

scales[10] =  0.001;

scales[11] =  0.001;



// Registration V3 ----------------------- :

    auto metric = itk::MattesMutualInformationImageToImageMetric<ImageType,
ImageType>::New();

    auto optimizer = itk::RegularStepGradientDescentOptimizer::New();

    auto registration = itk::ImageRegistrationMethod<ImageType,
ImageType>::New();



    int NumberOfSpatialSamples = 380000;



    metric->SetNumberOfSpatialSamples(NumberOfSpatialSamples);

    optimizer->SetScales(scales);

    registration->SetMetric(metric);

    registration->SetOptimizer(optimizer);

    registration->SetInterpolator(interpolator);

    registration->SetTransform(transform);

    registration->SetFixedImage(fixedImage);

    registration->SetMovingImage(movingImage);

    registration->SetFixedImageRegion(fixedImage->GetBufferedRegion());

    registration->SetInitialTransformParameters(transform->GetParameters());

    registration->Update();





// Registration V4 ----------------------- :

    auto metric = itk::MattesMutualInformationImageToImageMetricv4<ImageType,
ImageType>::New();

    auto optimizer = itk::RegularStepGradientDescentOptimizerv4::New();

    auto registration = itk::ImageRegistrationMethodv4<ImageType,
ImageType>::New();



    optimizer->SetScales(scales);

    optimizer->SetDoEstimateScales(false);

    optimizer->SetDoEstimateLearningRateAtEachIteration(false);

    optimizer->SetDoEstimateLearningRateOnce(false);

    optimizer->SetMetric(metric);



    registration->SetNumberOfLevels(1);

    registration->SetSmoothingSigmasPerLevel(0);

    registration->SetShrinkFactorsPerLevel(1);

    registration->SetMetricSamplingPercentagePerLevel(0.1);



    registration->SetMetric(metric);

    registration->SetOptimizer(optimizer);

    registration->SetFixedImage(fixedImage);

    registration->SetMovingImage(movingImage);

    registration->SetMetricSamplingStrategy(RegistrationType::REGULAR);

    registration->SetInitialTransform(transform);



    registration->Update();
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160930/6252c380/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: V3andV4Convergence.csv
Type: text/csv
Size: 6180 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160930/6252c380/attachment.csv>

From matt.mccormick at kitware.com  Fri Sep 30 18:07:44 2016
From: matt.mccormick at kitware.com (Matt McCormick)
Date: Fri, 30 Sep 2016 18:07:44 -0400
Subject: [ITK-dev] Patches for 4.10.1
Message-ID: <CALzTN-Rt5MsVr=oF3ZtxDbzbSffpdQ_TWTv6CtmcX=nyVzErXw@mail.gmail.com>

Hi,

It is time to release 4.10.1.  The following are currently in queue on
the release branch:

Bradley Lowekamp (10):
      COMP: Address VS9 ambiguous std::abs call in Haung calculator
      COMP: Fix undefined NumericTraits::Zero and One errors with mingw64
      BUG: Address itkHDF5ImageIO test failures for mingw64
      ENH: Enable CMP0063 New behavior
      COMP: Enable hidden visibility property with vxl static libraries
      COMP: Enable hidden visibility property with HDF5 static libraries
      COMP: Enable hidden visibility property with HDF5 static libraries
      BUG: Match Add2 function to AddImageFilter documentation
      COMP: Bypass XCode 7.3,8 internal compilation error
      ENH: Separate TransformFactory class into separate module

D?enan Zuki? (2):
      COMP: enables TBB 4.4 back-end for VTK7's SMP
      BUG: fixing buffer growing endlessly, as reported by Timothee Evain

Francois Budin (2):
      BUG: lazyAttributes dictionary keys could be over-ridden
      BUG: Missing associated test data

Gert Wollny (1):
      BUG: Relax vnl_complex floating point comparisons for i386

Hans Johnson (1):
      COMP: Add long long usage for HDF5

Hastings Greer (4):
      BUG: ITK-3448 Wrap itkQuadEdgeCellTraitsInfo more specifically
      BUG: remove lsqr because of license issues ITK 1160
      BUG: make itkTriangleHelper instantiable to ease wrapping
      BUG: initialize X to zero in lsmr Solve

Matthew McCormick (10):
      BUG: Fix H5File memory leak in HDF5ImageIO.
      BUG: Limit WRAP_ITK_MODULES when building externally
      COMP: Fix wrapping with a space in the Python include path
      BUG: ResampleImageFilter honor isInside output of the transform method
      COMP: Avoid recursive include of itkMath.h
      COMP: Use add_python_test PythonLazyLoadingImage
      BUG: Index,Size,Offset constructors present in Python with C++11
      COMP: Address missing override it itkFactoryTestLib.cxx
      BUG: Address memory leak, remove NumPy build dep in BridgeNumPy
      COMP: Do not set ITK_LIBRARY_BUILD_TYPE in ITKTransformFactory

Pierre Barbier de Reuille (1):
      COMP: Fix function naming error when using FFTWD

Simon Rit (1):
      COMP: remove C++11 compiler warning for CUDA compilations

Vladimir S. FONOV (1):
      COMP: Build against GCC 5.3.1

Ziv Yaniv (1):
      BUG: Metric sampling percentage accepted values outside (0.0, 1.0].


Other patches to add:

  http://review.source.kitware.com/#/c/21599/
  http://review.source.kitware.com/#/c/21592/
  http://review.source.kitware.com/#/c/21598/

Is there any others that are missing?

Thanks,
Matt