[ITK-dev] ITKv4.10rc2 - Why are there so many new CMake variable?

[Lowekamp, Bradley (NIH/NLM/LHC) [C]]

Matt,

Great thanks for digging into this!

Based on some other CMake variables popping up, are we enabling VNL testing and examples [1]?

Perhaps examples for VNL should be turned off [2]? I think we have always run VNL testings though.

Brad

[1] https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeLists.txt#L441-L447
[2] https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/CMakeLists.txt#L19

> On May 23, 2016, at 1:43 PM, Matt McCormick <matt.mccormick at kitware.com> wrote:
> 
> Hi,
> 
> I looked into this and I found two places that find_package(X11) are called.
> 
> The first one is in a netlib example, which could easily be disabled:
> 
>  https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/examples/CMakeLists.txt#L7
> 
> The second, though, is in GDCM's OpenJPEG:
> 
>  https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/GDCM/src/gdcm/Utilities/gdcmopenjpeg-v2/CMakeLists.txt#L76
>  https://github.com/Kitware/CMake/blob/c75d91a05c9f442582726e3e80fec41d016da76f/Modules/CMakeBackwardCompatibilityC.cmake#L52
> 
> This would have to be changed to only perform the checks it needs.
> The reduced try_compile checks could also reduce initial configuration
> time.
> 
> Thanks,
> Matt
> 
> On Fri, May 20, 2016 at 2:13 PM, Lowekamp, Bradley (NIH/NLM/LHC) [C]
> <blowekamp at mail.nih.gov> wrote:
>> I am now getting a whole bunch of X11 related CMake variables in the advanced configuration of CMake. These are very annoying and not useful. There also seems to be a bunch of other VXL related variables, that didn’t use to be there.
>> 
>> Brad
>> 
>> 
>> _______________________________________________
>> Powered by www.kitware.com
>> 
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>> 
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.php
>> 
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>> 
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/insight-developers