[ITK-dev] ITK4.10rc1 SimpleITK VNL error

[Johnson, Hans J]

Brad,

Thank you for your assistance.    I am hopeful that your solution can maintain a relatively simple set of rules implementing cross platform support.

I’ll review ASAP when you have a patch set to look at.

Your assistance is GREATLY appreciated.

Hans


--


From: Bradley Lowekamp <blowekamp at mail.nih.gov>
Date: Tuesday, May 17, 2016 at 2:44 PM
To: Hans Johnson <hans-johnson at uiowa.edu>
Cc: "insight-developers at itk.org" <insight-developers at itk.org>
Subject: Re: ITK4.10rc1 SimpleITK VNL error

Hans,

This looks like an issue with tr1 includes [1]. This is very tricky business with VS, gcc, clang and libstdc++ and libc++. And it looks like VCL is now requiring shared_ptr support? It that intentional?

In my tests for SimpleITK, I have it noted [2], that Visual Studio 2008, 2010, 2012 don’t need the tr1 in the include path for tr1 headers. The checks in VXL seem to require this sub-folder arrangement. So check like the following should be done:

CHECK_TYPE_EXISTS_ZERO(std::tr1::shared_ptr<void> memory VCL_MEMORY_HAS_TR1_SHARED_PTR)


Note the tr1 namespace but not the tr1 include path.


I’m working on testing this now.

[1] https://github.com/vxl/vxl/blob/abb93b9cea365318028cf18c9b84020c3c6a1d67/vcl/vcl_compiler.h#L942-L955
[2] https://github.com/SimpleITK/SimpleITK/blob/fc6bbeaf91dd74ebb294db57ccef8f9bb9e5e6b0/CMake/sitkCheckCXX11.cmake#L59-L61

On May 17, 2016, at 11:07 AM, Johnson, Hans J <hans-johnson at uiowa.edu<mailto:hans-johnson at uiowa.edu>> wrote:

Thanks Brad.  Do you know if this version can be installed along side of VS 2015 without conflicts?

Hans
--


From: Bradley Lowekamp <blowekamp at mail.nih.gov<mailto:blowekamp at mail.nih.gov>>
Date: Tuesday, May 17, 2016 at 9:34 AM
To: Hans Johnson <hans-johnson at uiowa.edu<mailto:hans-johnson at uiowa.edu>>
Cc: "insight-developers at itk.org<mailto:insight-developers at itk.org>" <insight-developers at itk.org<mailto:insight-developers at itk.org>>
Subject: Re: ITK4.10rc1 SimpleITK VNL error

Hans,

I’ll take a look into it. Thanks for the offer for a hang out, well go there if needed.

I haven’t tries this my self, but there is the Free, VS for Python 2.7, that is suppose to be based on VS9 2008[1]. I don’t know how this works with general CMake project, but maybe it will help improve your access.

Brad


[1] https://www.visualstudio.com/en-us/features/python-vs.aspx

On May 17, 2016, at 10:29 AM, Johnson, Hans J <hans-johnson at uiowa.edu<mailto:hans-johnson at uiowa.edu>> wrote:

This is not fixed in VXL upstream.

There are currently no windows builds on VXL dashboard: https://open.cdash.org/index.php?project=vxl

I don’t see any VS9 builds for ITK either.

I’d be happy to help identify a solution, but I don’t have the VS resources.  If you would like to have a hang out, I’d be interested in assisting with the fix.

Hans

--


From: Bradley Lowekamp <blowekamp at mail.nih.gov<mailto:blowekamp at mail.nih.gov>>
Date: Tuesday, May 17, 2016 at 9:14 AM
To: "insight-developers at itk.org<mailto:insight-developers at itk.org>" <insight-developers at itk.org<mailto:insight-developers at itk.org>>
Cc: Hans Johnson <hans-johnson at uiowa.edu<mailto:hans-johnson at uiowa.edu>>
Subject: ITK4.10rc1 SimpleITK VNL error

Hello,

On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am getting the following compilation error with VS9 2008[1]:


3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------

3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------

3>2>Compiling...

3>4>Compiling...

3>1>Compiling...

3>2>triangle.c

3>1>vcl_deprecated.cxx

3>4>FStream.cxx

3>3>Compiling...

3>3>v3p_netlib_init.c

3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error :  "Missing definition for SHARED_PTR"

Is this addressed in VNL upstream yet? or should I begin looking into it?

Thanks,
Brad


[1] https://open.cdash.org/viewBuildError.php?buildid=4368953


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160517/8b04e6f7/attachment.html>