From matt.mccormick at kitware.com Mon May 2 10:38:53 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Mon, 2 May 2016 10:38:53 -0400 Subject: [ITK-dev] Upcoming ITK 4.10rc1 Message-ID: Hi folks, Please have reviewed, build robot verified feature enhancements merged by the end of this week in preparation for the upcoming 4.10 release candidate 1 next week. Thanks, Matt From tj.jackson1226 at gmail.com Mon May 2 13:46:56 2016 From: tj.jackson1226 at gmail.com (Tim Jackson) Date: Mon, 2 May 2016 13:46:56 -0400 Subject: [ITK-dev] problems with programs crashing -- potentially due to multiple versions of ITK? In-Reply-To: References: Message-ID: Thank you D?enan and Matt for your replies. I've always built ITK as static libraries, so I don't think that's what the problem is. After using Dependency Walker as Matt suggested, it looks like the crashing is the result of a Java error. It's looking for procedures in java.dll, zip.dll, and hpi.dll and not finding them, and then the program exits JAVAW.EXE with code 255. I originally thought this was a problem of conflicting ITK versions, but I realize too that I recently downloaded new versions of Java and changed the Java Path environmental variables in order to do plugin development for ImageJ. Is it possible that something I changed is resulting in the ITK programs to find conflicting versions of java? If so, how do I fix that? Best, Tim -------------- next part -------------- An HTML attachment was scrubbed... URL: From matt.mccormick at kitware.com Mon May 2 13:58:40 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Mon, 2 May 2016 13:58:40 -0400 Subject: [ITK-dev] problems with programs crashing -- potentially due to multiple versions of ITK? In-Reply-To: References: Message-ID: Hi Tim, The behavior is likely unrelated to ITK unless you are using the SCIFIO ITK plugin. This plugin will pick up Java environmental variables if set: https://github.com/scifio/scifio-imageio/blob/5baa6b28a5b56a9862fbb6aaac75ffd533852677/src/itkSCIFIOImageIO.cxx.in#L281-L286 HTH, Matt On Mon, May 2, 2016 at 1:46 PM, Tim Jackson wrote: > Thank you D?enan and Matt for your replies. > > I've always built ITK as static libraries, so I don't think that's what the > problem is. After using Dependency Walker as Matt suggested, it looks like > the crashing is the result of a Java error. It's looking for procedures in > java.dll, zip.dll, and hpi.dll and not finding them, and then the program > exits JAVAW.EXE with code 255. > > I originally thought this was a problem of conflicting ITK versions, but I > realize too that I recently downloaded new versions of Java and changed the > Java Path environmental variables in order to do plugin development for > ImageJ. Is it possible that something I changed is resulting in the ITK > programs to find conflicting versions of java? If so, how do I fix that? > > Best, > Tim From matt.mccormick at kitware.com Thu May 5 11:11:40 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Thu, 5 May 2016 11:11:40 -0400 Subject: [ITK-dev] [vtk-developers] Wiki scrapping regression after web page update In-Reply-To: References: Message-ID: Hi Bill, itk.org/ was recently changed to use HTTPS -- does making that change to your configuration help? Thanks, Matt On Thu, May 5, 2016 at 11:00 AM, Bill Lorensen wrote: > Looks like itk has been changed. Now I can no longer scrape the wiki. HELP! > > > On Tue, May 5, 2015 at 11:07 AM, David E DeMarle > wrote: >> So Bill trying to close the loop on this. >> >> We should now use. >> site = mwclient.Site('www.(project).org', '/Wiki/') >> page = site.Pages['PROJECT/Examples] >> >> That will work now and if/when www.itk.org gets it's own facelift. >> >> hth >> >> >> David E DeMarle >> Kitware, Inc. >> R&D Engineer >> 21 Corporate Drive >> Clifton Park, NY 12065-8662 >> Phone: 518-881-4909 >> >> On Thu, Apr 16, 2015 at 6:31 PM, Jean-Christophe Fillion-Robin >> wrote: >>> >>> Hi Bill, >>> >>> I wrote too fast. Ignore my previous email. >>> >>> Jc >>> >>> On Thu, Apr 16, 2015 at 6:30 PM, Jean-Christophe Fillion-Robin >>> wrote: >>>> >>>> Hi Bill, >>>> >>>> Seems the wiki is available here: http://www.vtk.org/Wiki/VTK >>>> >>>> Instead of >>>> >>>> site = mwclient.Site('vtk.org', '/Wiki/') >>>> >>>> try this >>>> >>>> site = mwclient.Site('vtk.org', '/Wiki/VTK/') >>>> >>>> Hth >>>> Jc >>>> >>>> On Mon, Apr 13, 2015 at 11:45 AM, David E DeMarle >>>> wrote: >>>>> >>>>> I'll take a look. >>>>> thanks >>>>> >>>>> David E DeMarle >>>>> Kitware, Inc. >>>>> R&D Engineer >>>>> 21 Corporate Drive >>>>> Clifton Park, NY 12065-8662 >>>>> Phone: 518-881-4909 >>>>> >>>>> On Tue, Mar 31, 2015 at 3:30 PM, Bill Lorensen >>>>> wrote: >>>>>> >>>>>> Folks, >>>>>> >>>>>> I scrape the vtk.org wiki site each evening to maintain the vtk wiki >>>>>> examples. I have a python program that uses mwclient >>>>>> (https://github.com/mwclient/mwclient) that uses the MediaWiki API. >>>>>> >>>>>> Ever since the vtk.org page was updated, my nightly scripts have been >>>>>> failing. >>>>>> The error are occur on this line: >>>>>> >>>>>> site = mwclient.Site('vtk.org', '/Wiki/') >>>>>> >>>>>> If I change vtk.org to itk.org, my scripts work. >>>>>> >>>>>> I suspect some sort of web magic going on. I can workaround the >>>>>> problem but specifying itk.org, but I'd like to understand what >>>>>> happened just in case the itk.org site changes in the future. >>>>>> >>>>>> Thanks, >>>>>> >>>>>> Bill >>>>>> _______________________________________________ >>>>>> Powered by www.kitware.com >>>>>> >>>>>> Visit other Kitware open-source projects at >>>>>> http://www.kitware.com/opensource/opensource.html >>>>>> >>>>>> Search the list archives at: >>>>>> http://markmail.org/search/?q=vtk-developers >>>>>> >>>>>> Follow this link to subscribe/unsubscribe: >>>>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Powered by www.kitware.com >>>>> >>>>> Visit other Kitware open-source projects at >>>>> http://www.kitware.com/opensource/opensource.html >>>>> >>>>> Search the list archives at: >>>>> http://markmail.org/search/?q=vtk-developers >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> +1 919 869 8849 >>> >>> >>> >>> >>> -- >>> +1 919 869 8849 >> >> > > > > -- > Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Thu May 5 11:30:52 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 5 May 2016 11:30:52 -0400 Subject: [ITK-dev] [vtk-developers] Wiki scrapping regression after web page update In-Reply-To: References: Message-ID: Matt, The change to https is what is causing the problem. I can modify my call from site = mwclient.Site(('itk.org', '/Wiki/') to site = mwclient.Site(('https','itk.org'), '/Wiki/') Thanks, Bill On Thu, May 5, 2016 at 11:11 AM, Matt McCormick wrote: > Hi Bill, > > itk.org/ was recently changed to use HTTPS -- does making that change > to your configuration help? > > Thanks, > Matt > > On Thu, May 5, 2016 at 11:00 AM, Bill Lorensen wrote: >> Looks like itk has been changed. Now I can no longer scrape the wiki. HELP! >> >> >> On Tue, May 5, 2015 at 11:07 AM, David E DeMarle >> wrote: >>> So Bill trying to close the loop on this. >>> >>> We should now use. >>> site = mwclient.Site('www.(project).org', '/Wiki/') >>> page = site.Pages['PROJECT/Examples] >>> >>> That will work now and if/when www.itk.org gets it's own facelift. >>> >>> hth >>> >>> >>> David E DeMarle >>> Kitware, Inc. >>> R&D Engineer >>> 21 Corporate Drive >>> Clifton Park, NY 12065-8662 >>> Phone: 518-881-4909 >>> >>> On Thu, Apr 16, 2015 at 6:31 PM, Jean-Christophe Fillion-Robin >>> wrote: >>>> >>>> Hi Bill, >>>> >>>> I wrote too fast. Ignore my previous email. >>>> >>>> Jc >>>> >>>> On Thu, Apr 16, 2015 at 6:30 PM, Jean-Christophe Fillion-Robin >>>> wrote: >>>>> >>>>> Hi Bill, >>>>> >>>>> Seems the wiki is available here: http://www.vtk.org/Wiki/VTK >>>>> >>>>> Instead of >>>>> >>>>> site = mwclient.Site('vtk.org', '/Wiki/') >>>>> >>>>> try this >>>>> >>>>> site = mwclient.Site('vtk.org', '/Wiki/VTK/') >>>>> >>>>> Hth >>>>> Jc >>>>> >>>>> On Mon, Apr 13, 2015 at 11:45 AM, David E DeMarle >>>>> wrote: >>>>>> >>>>>> I'll take a look. >>>>>> thanks >>>>>> >>>>>> David E DeMarle >>>>>> Kitware, Inc. >>>>>> R&D Engineer >>>>>> 21 Corporate Drive >>>>>> Clifton Park, NY 12065-8662 >>>>>> Phone: 518-881-4909 >>>>>> >>>>>> On Tue, Mar 31, 2015 at 3:30 PM, Bill Lorensen >>>>>> wrote: >>>>>>> >>>>>>> Folks, >>>>>>> >>>>>>> I scrape the vtk.org wiki site each evening to maintain the vtk wiki >>>>>>> examples. I have a python program that uses mwclient >>>>>>> (https://github.com/mwclient/mwclient) that uses the MediaWiki API. >>>>>>> >>>>>>> Ever since the vtk.org page was updated, my nightly scripts have been >>>>>>> failing. >>>>>>> The error are occur on this line: >>>>>>> >>>>>>> site = mwclient.Site('vtk.org', '/Wiki/') >>>>>>> >>>>>>> If I change vtk.org to itk.org, my scripts work. >>>>>>> >>>>>>> I suspect some sort of web magic going on. I can workaround the >>>>>>> problem but specifying itk.org, but I'd like to understand what >>>>>>> happened just in case the itk.org site changes in the future. >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Bill >>>>>>> _______________________________________________ >>>>>>> Powered by www.kitware.com >>>>>>> >>>>>>> Visit other Kitware open-source projects at >>>>>>> http://www.kitware.com/opensource/opensource.html >>>>>>> >>>>>>> Search the list archives at: >>>>>>> http://markmail.org/search/?q=vtk-developers >>>>>>> >>>>>>> Follow this link to subscribe/unsubscribe: >>>>>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Powered by www.kitware.com >>>>>> >>>>>> Visit other Kitware open-source projects at >>>>>> http://www.kitware.com/opensource/opensource.html >>>>>> >>>>>> Search the list archives at: >>>>>> http://markmail.org/search/?q=vtk-developers >>>>>> >>>>>> Follow this link to subscribe/unsubscribe: >>>>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> +1 919 869 8849 >>>> >>>> >>>> >>>> >>>> -- >>>> +1 919 869 8849 >>> >>> >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com -- Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Thu May 5 11:00:31 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Thu, 5 May 2016 11:00:31 -0400 Subject: [ITK-dev] [vtk-developers] Wiki scrapping regression after web page update Message-ID: Looks like itk has been changed. Now I can no longer scrape the wiki. HELP! On Tue, May 5, 2015 at 11:07 AM, David E DeMarle wrote: > So Bill trying to close the loop on this. > > We should now use. > site = mwclient.Site('www.(project).org', '/Wiki/') > page = site.Pages['PROJECT/Examples] > > That will work now and if/when www.itk.org gets it's own facelift. > > hth > > > David E DeMarle > Kitware, Inc. > R&D Engineer > 21 Corporate Drive > Clifton Park, NY 12065-8662 > Phone: 518-881-4909 > > On Thu, Apr 16, 2015 at 6:31 PM, Jean-Christophe Fillion-Robin > wrote: >> >> Hi Bill, >> >> I wrote too fast. Ignore my previous email. >> >> Jc >> >> On Thu, Apr 16, 2015 at 6:30 PM, Jean-Christophe Fillion-Robin >> wrote: >>> >>> Hi Bill, >>> >>> Seems the wiki is available here: http://www.vtk.org/Wiki/VTK >>> >>> Instead of >>> >>> site = mwclient.Site('vtk.org', '/Wiki/') >>> >>> try this >>> >>> site = mwclient.Site('vtk.org', '/Wiki/VTK/') >>> >>> Hth >>> Jc >>> >>> On Mon, Apr 13, 2015 at 11:45 AM, David E DeMarle >>> wrote: >>>> >>>> I'll take a look. >>>> thanks >>>> >>>> David E DeMarle >>>> Kitware, Inc. >>>> R&D Engineer >>>> 21 Corporate Drive >>>> Clifton Park, NY 12065-8662 >>>> Phone: 518-881-4909 >>>> >>>> On Tue, Mar 31, 2015 at 3:30 PM, Bill Lorensen >>>> wrote: >>>>> >>>>> Folks, >>>>> >>>>> I scrape the vtk.org wiki site each evening to maintain the vtk wiki >>>>> examples. I have a python program that uses mwclient >>>>> (https://github.com/mwclient/mwclient) that uses the MediaWiki API. >>>>> >>>>> Ever since the vtk.org page was updated, my nightly scripts have been >>>>> failing. >>>>> The error are occur on this line: >>>>> >>>>> site = mwclient.Site('vtk.org', '/Wiki/') >>>>> >>>>> If I change vtk.org to itk.org, my scripts work. >>>>> >>>>> I suspect some sort of web magic going on. I can workaround the >>>>> problem but specifying itk.org, but I'd like to understand what >>>>> happened just in case the itk.org site changes in the future. >>>>> >>>>> Thanks, >>>>> >>>>> Bill >>>>> _______________________________________________ >>>>> Powered by www.kitware.com >>>>> >>>>> Visit other Kitware open-source projects at >>>>> http://www.kitware.com/opensource/opensource.html >>>>> >>>>> Search the list archives at: >>>>> http://markmail.org/search/?q=vtk-developers >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Search the list archives at: >>>> http://markmail.org/search/?q=vtk-developers >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://public.kitware.com/mailman/listinfo/vtk-developers >>>> >>>> >>> >>> >>> >>> -- >>> +1 919 869 8849 >> >> >> >> >> -- >> +1 919 869 8849 > > -- Unpaid intern in BillsBasement at noware dot com From mohammedrashadkm at gmail.com Mon May 9 16:27:37 2016 From: mohammedrashadkm at gmail.com (Rashad Kanavath) Date: Mon, 9 May 2016 22:27:37 +0200 Subject: [ITK-dev] installed ITK cannot be moved due to absolute path Message-ID: Hello all, I have some issue when copying ITK install directory to a different system. I agree this is not usual and may not appear on a linux distro or windows. My requirement is bit different. I cross-compile ITK and then use the binaries on Windows. Using dll and headers are fine. But the installed cmake files are a problem. They have absolute path in ITK-4.8/Modules/*.cmake files. It is not in all .cmake files even though I put a wildcard there.. For a easy and quick workaround. I rely on mighty sed command to insert something into installed cmake file. For example see this; lib/cmake/ITK-4.8/ITKTargets-release.cmake set(CMAKE_IMPORT_FILE_VERSION 1) set(LIB_INSTALL_PREFIX) get_filename_component(CURRENT_FILE_DIR "${CMAKE_CURRENT_LIST_FILE}" PATH) get_filename_component(LIB_INSTALL_PREFIX "${CURRENT_FILE_DIR}" PATH) get_filename_component(LIB_INSTALL_PREFIX "${LIB_INSTALL_PREFIX}" PATH) get_filename_component(LIB_INSTALL_PREFIX "${LIB_INSTALL_PREFIX}" PATH) and at last: $(SED) -i 's,$(PREFIX)/$(TARGET),\${LIB_INSTALL_PREFIX},g' 'lib/cmake/ITK-$(ITK_VER)/ITKTargets-release.cmake' I would like to have this patch inside the other .cmake files in the installation and avoid the sed commands during post-installation Here is the list of cmake files that needs this change. lib/cmake/ITK-4.8/ITKTargets-release.cmake lib/cmake/ITK-4.8/Modules/ITKZLIB.cmake lib/cmake/ITK-4.8/Modules/ITKExpat.cmake lib/cmake/ITK-4.8/Modules/ITKHDF5.cmake lib/cmake/ITK-4.8/Modules/ITKJPEG.cmake lib/cmake/ITK-4.8/Modules/ITKTIFF.cmake lib/cmake/ITK-4.8/Modules/ITKPNG.cmake So is it possible to make the change into future version of ITK? The major issue here is those cmake files are generated by cmake. Is there a way cmake could use relative path ? -- Regards, Rashad -------------- next part -------------- An HTML attachment was scrubbed... URL: From dzenanz at gmail.com Tue May 10 16:50:03 2016 From: dzenanz at gmail.com (=?UTF-8?B?RMW+ZW5hbiBadWtpxIc=?=) Date: Tue, 10 May 2016 16:50:03 -0400 Subject: [ITK-dev] installed ITK cannot be moved due to absolute path In-Reply-To: References: Message-ID: Hi Rashad, a few months ago relative paths were completely removed from CMake, because they were never fully implemented. Have you followed recommendations from here for cross-compiling? As for integrating your changes into ITK, you should submit a patch following the instructions here . If your changes don't break anything, they are likely to be integrated. Regards, D?enan On Mon, May 9, 2016 at 4:27 PM, Rashad Kanavath wrote: > Hello all, > > I have some issue when copying ITK install directory to a different > system. I agree this is not usual and may not appear on a linux distro or > windows. > > My requirement is bit different. I cross-compile ITK and then use the > binaries on Windows. Using dll and headers are fine. But the installed > cmake files are a problem. They have absolute path in > ITK-4.8/Modules/*.cmake files. It is not in all .cmake files even though I > put a wildcard there.. > > For a easy and quick workaround. I rely on mighty sed command to insert > something into installed cmake file. > > For example see this; > lib/cmake/ITK-4.8/ITKTargets-release.cmake > > set(CMAKE_IMPORT_FILE_VERSION 1) > set(LIB_INSTALL_PREFIX) > get_filename_component(CURRENT_FILE_DIR "${CMAKE_CURRENT_LIST_FILE}" PATH) > get_filename_component(LIB_INSTALL_PREFIX "${CURRENT_FILE_DIR}" PATH) > get_filename_component(LIB_INSTALL_PREFIX "${LIB_INSTALL_PREFIX}" PATH) > get_filename_component(LIB_INSTALL_PREFIX "${LIB_INSTALL_PREFIX}" PATH) > > and at last: > > $(SED) -i 's,$(PREFIX)/$(TARGET),\${LIB_INSTALL_PREFIX},g' > 'lib/cmake/ITK-$(ITK_VER)/ITKTargets-release.cmake' > > I would like to have this patch inside the other .cmake files in the > installation and avoid the sed commands during post-installation > > Here is the list of cmake files that needs this change. > lib/cmake/ITK-4.8/ITKTargets-release.cmake > lib/cmake/ITK-4.8/Modules/ITKZLIB.cmake > lib/cmake/ITK-4.8/Modules/ITKExpat.cmake > lib/cmake/ITK-4.8/Modules/ITKHDF5.cmake > lib/cmake/ITK-4.8/Modules/ITKJPEG.cmake > lib/cmake/ITK-4.8/Modules/ITKTIFF.cmake > lib/cmake/ITK-4.8/Modules/ITKPNG.cmake > > So is it possible to make the change into future version of ITK? > > The major issue here is those cmake files are generated by cmake. Is there > a way cmake could use relative path ? > > > -- > Regards, > Rashad > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mohammedrashadkm at gmail.com Tue May 10 17:25:11 2016 From: mohammedrashadkm at gmail.com (Rashad Kanavath) Date: Tue, 10 May 2016 23:25:11 +0200 Subject: [ITK-dev] installed ITK cannot be moved due to absolute path In-Reply-To: References: Message-ID: On Tue, May 10, 2016 at 10:50 PM, D?enan Zuki? wrote: > Hi Rashad, > > a few months ago relative paths were completely removed from CMake, > because they were never fully implemented. Have you followed > recommendations from here for > cross-compiling? > Yes. indeed. I had updated the mxe/src/itk.mk for several versions of ITK! Regarding relative path in cmake, I don't understand. I didn't use cmake specific REL_PATH. > > As for integrating your changes into ITK, you should submit a patch > following the instructions here . > If your changes don't break anything, they are likely to be integrated. > issue here is a bit different. For all libitk* stuff the story ends well. For thirdparties, zlib, expat etc.. it is good idea to put the full path because we don't know if they are in same install directory as ITK or not. But this make the installed cmake modules non-portable even to a different location on the same disk. Now if anyone want to provide a distributable setup of ITK. patch the generated cmake files with sed and then copy it. This is what I am doing right now! A simple not perfect solution is to have all thirdparties make _PREFIX variable inside the ITKConfig.cmake and for each library we use _PREFIX/include and _PREFIX/lib Another option is to avoid full path directly inside cmake module files and put find_package() calls in the install tree. As these files are autogenerated by cmake, don't know what is possible. > Regards, > D?enan > > On Mon, May 9, 2016 at 4:27 PM, Rashad Kanavath < > mohammedrashadkm at gmail.com> wrote: > >> Hello all, >> >> I have some issue when copying ITK install directory to a different >> system. I agree this is not usual and may not appear on a linux distro or >> windows. >> >> My requirement is bit different. I cross-compile ITK and then use the >> binaries on Windows. Using dll and headers are fine. But the installed >> cmake files are a problem. They have absolute path in >> ITK-4.8/Modules/*.cmake files. It is not in all .cmake files even though I >> put a wildcard there.. >> >> For a easy and quick workaround. I rely on mighty sed command to insert >> something into installed cmake file. >> >> For example see this; >> lib/cmake/ITK-4.8/ITKTargets-release.cmake >> >> set(CMAKE_IMPORT_FILE_VERSION 1) >> set(LIB_INSTALL_PREFIX) >> get_filename_component(CURRENT_FILE_DIR "${CMAKE_CURRENT_LIST_FILE}" PATH) >> get_filename_component(LIB_INSTALL_PREFIX "${CURRENT_FILE_DIR}" PATH) >> get_filename_component(LIB_INSTALL_PREFIX "${LIB_INSTALL_PREFIX}" PATH) >> get_filename_component(LIB_INSTALL_PREFIX "${LIB_INSTALL_PREFIX}" PATH) >> >> and at last: >> >> $(SED) -i 's,$(PREFIX)/$(TARGET),\${LIB_INSTALL_PREFIX},g' >> 'lib/cmake/ITK-$(ITK_VER)/ITKTargets-release.cmake' >> >> I would like to have this patch inside the other .cmake files in the >> installation and avoid the sed commands during post-installation >> >> Here is the list of cmake files that needs this change. >> lib/cmake/ITK-4.8/ITKTargets-release.cmake >> lib/cmake/ITK-4.8/Modules/ITKZLIB.cmake >> lib/cmake/ITK-4.8/Modules/ITKExpat.cmake >> lib/cmake/ITK-4.8/Modules/ITKHDF5.cmake >> lib/cmake/ITK-4.8/Modules/ITKJPEG.cmake >> lib/cmake/ITK-4.8/Modules/ITKTIFF.cmake >> lib/cmake/ITK-4.8/Modules/ITKPNG.cmake >> >> So is it possible to make the change into future version of ITK? >> >> The major issue here is those cmake files are generated by cmake. Is >> there a way cmake could use relative path ? >> >> >> -- >> Regards, >> Rashad >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers >> >> > -- Regards, Rashad -------------- next part -------------- An HTML attachment was scrubbed... URL: From matt.mccormick at kitware.com Thu May 12 14:53:22 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Thu, 12 May 2016 14:53:22 -0400 Subject: [ITK-dev] [ANN] ITK 4.10 Release Candidate 1 is ready for testing! Message-ID: On behalf of the Insight Toolkit community, we are proud to announce that ITK 4.10 release candidate 1 has been tagged and is available for testing! Please take this opportunity to test the new features in the release candidate. To obtain the source code, git clone http://itk.org/ITK.git cd ITK git checkout -q --detach v4.10rc01 For more details, please see the Git documentation [1]. A few selected highlights for this release: - New Remote module: TwoProjectionRegistration performs simultaneous registration of two projection images to a 3D image volume, which is useful for external beam radiotherapy and other applications. It uses Powell?s method for optimization and the Siddon-Jacobs fast ray-tracing algorithm. - First update to internal VNL in five years. Many improvements were made to upstream VNL. We now push patches upstream and stay in sync via a Git subtree workflow. - Windows builds now support processing 4GB+ images by default - GDCM updated for better DICOM support Additionally, in the Python wrapping, type specification is no longer necessary during the creation of most filters. The required type is inferred from a primary input passed on filter creation. For example, instead of the explicit type specification: median = itk.MedianImageFilter[ImageType, ImageType].New() median.SetInput(reader.GetOutput()) It is now possible to call: median = itk.MedianImageFilter.New(Input=reader.GetOutput()) Or, the shortened: median = itk.MedianImageFilter.New(reader.GetOutput()) Or: median = itk.MedianImageFliter.New(reader) An itk.ImageFileReader can be created by specifying the FileName during instantiation: reader = itk.ImageFileReader.New(FileName=?inputFile.mha?) Please test the release candidate and share your experiences on the mailing list, issue tracker, and Gerrit Code Review. An Experimental build, which demonstrates how the test suite performs on your local build system, can be submitted to the dashboard [2] with: mkdir ../ITK-build cd ../ITK-build cmake ../ITK ctest -j 4 -M Experimental -T Configure -T Build -T Test -T Submit Visual Studio builds must also add ?-C Release? to the ctest command. Notify the mailing list if there are any unexpected failures. Testing your own applications against the RC is also appreciated. Congratulations and well done to the 26 contributors to this release. We would especially like to recognize the new contributors: Andrey Fedorov, Sujin Philip, Francois Budin, and b'Alvaro Sanchez. The 4.10.0 final release is scheduled for the end of May. [1] http://www.itk.org/Wiki/ITK/Git [2] http://open.cdash.org/index.php?project=Insight New Features --------------------- * Wrapping improvements - ITK_USE_64BITS_IDS supported on Windows - Faster builds (CastXML calls and build targets reduced by half) - Faster runtime loading and smaller binary size due to hidden symbol visibility - Wrapping with BUILD_SHARED_LIBS disabled is supported - Do not link to libpython when possible - Filter types do not need to be specified when ?Input=inputImage? is specified in the constructor - Improved wrapping class coverage - Visual Studio 2015 Update 2 Supported * New Remote Module - TwoProjectionRegistration - 2D-3D registration designed for radiotherapy - http://hdl.handle.net/10380/3245 * Core Improvements - Data and build tool downloads now over HTTPS - Extended constexpr usage with ITK_CONSTEXPR and ITKCONSTEXPR_FUNC macros - ITK_USE_64BITS_IDS, required to process 4GB+ images on Windows, now enabled by default - VNL updated and modernized - CMake configuration major modernization - vcl has been removed in favor of the standard libraries - vnl_math_ function avoided in favor of std:: and itk::Math - VNL had suppressed integer data conversion warnings on Visual Studio (C4257); this suppression has been removed and all warnings addressed - Various improvements for building a module externally against an ITK build tree - CMAKE_POSITION_INDEPENDENT_CODE is enabled by default - Improved EXERCISE_BASIC_OBJECT_METHODS testing macro * Filtering Improvements - RGB pixel support added to itk::ImageToVTKImageFilter - itk::Box* filters moved out of the Review module - itk::GaussianDerivativeOperator moved out of the Review module - MaskLabel is deprecated in N4BiasFieldCorrectionFilter in favor any non-zero pixel * Registration Improvements - Fixed and moving masks added to the v4 registration methods * Documentation Improvements - Updates to the Software Guide, Doxygen, Wiki and Sphinx Examples * Third Party Library Updates - pygccxml updated to v1.7.3 - GDCM updated to the release branch latest - VNL updated to latest upstream - MINC updated to the latest upstream - SWIG updated to v3.0.8 - PCRE update to v8.38 * Improved code coverage -- we are at 85.0%! * *Lots* of important bug fixes * And much more! See details in the log below. Changes from v4.9.0..v4.10rc01 ------------------------------------------------ Alvaro Sanchez (1): STYLE: moved itkKappaSigmaThresholdImageFilter/Calculator from Nonunit/Review Andrey Fedorov (2): BUG: Add missing itk_expat_mangle.h install target BUG: fix typo in file name Bill Hoffman (2): COMP: fix shared build on Windows when Review is on. COMP: work around for VS 2015 optimizer bug causing test failures. Bill Lorensen (6): ENH: Bump version for style fixups. ENH: Bump wiki examples version, new remote module process ENH: Bump wiki examples version, new remote module process STYLE: SuperClass should be Superclass COMP: Resolve clang linkage issue BUG: Valgrind detected an invalid read Bradley Lowekamp (21): BUG: Compilation problem with GCC 4.1 and explicit instantiation ENH: Update Insight Journal handle links to https ENH: Adding const qualifier to results BUG: Adding missing const qualifier for GetConfusionMatrix method BUG: Use Set/GetMacros, fix const correctness and PrintSelf. ENH: added inlined Zero and one values for integer NumericTraits ENH: Use constexpr for floating point NumericTraits ENH: Make NumericTraits functions constexpr for intrinsic BUG: Add definition of static constexpr NumericTrait members BUG: Declared static constexpr members need to be defined as constexpr ENH: ITK_CONSTEXPR_FUNC implies inline BUG: Addressing VS10 and VS11 NumericTraits linkage issue BUG: Use LargestPossible region for BSpline domain BUG: Remove errant file COMP: Address warning about this usage in initializer list ENH: Prefer ZeroValue function over variable STYLE: Use consistent path for try_compiles binary directory BUG: Don't use "=" in cmake variable name ENH: Test address of NumericTraits One and Zero constexpr ENH: Use ITK_USE_64BITS_IDS for windows 64 by default ENH: Enable run-time dependency on Python library Davis Vigneault (4): ENH: Update itkFileTools to allow std::string arguments. ENH: Add Floored and Truncated Modulus to VNL ENH: Add Ternary Operator Image Filter STYLE: Prefer static cast D?enan Zuki? (1): ENH: CovariantVector's Normalize returns the norm. Francois Budin (6): PERF: Simplify itkTemplate New() input type identification. ENH: Avoid template type specification for image reader in Python wrapping BUG: Missing IOPixelType strings in ImageIOBase BUG: Wrapping intermediate files were not automatically updated ENH: Reduce number of dependencies for XML files generated for wrapping BUG: GCC is limited when calling overloaded base class functions GCC-XML Upstream (1): ENH: pygccxml v1.7.3 (reduced) GDCM Upstream (1): GDCM 2015-09-02 (1efe9e28) Hans Johnson (27): COMP: Static analysis warning COMP: Incorrect delete found by static analysis PERF: Avoid temporary std:vector copying. COMP: Provide VXL backward compatible includes COMP: ITK requires legacy methods ENH: Need propagate ITK_LIBRARY_PROPERTIES ENH: Added UpdateFromUpstream.sh for VNL ENH: Manual copy from vxl/master STYLE: vnl_math_[min|max] -> std::[min|max] STYLE: Text files should end with a newline COMP: Prefer C++11 constexpr when possible COMP: Prefer C++11 constexpr when possible ENH: Simplify std:: math function definitions COMP: Error in constexpr usage COMP: Add const to previous const variables COMP: SizeValueType can has different definition for itkArray ENH: Added utility for modernizing vcl_ to std:: ENH: Reference vnl_math.h constants directly ENH: Avoid using vnl_math_ functions COMP: Missing symbol for itkStaticConstMacro COMP: Function override missing in BioCell ENH: Convert vcl_ to std:: BUG: Windows vcl_snprintf failures addressed COMP: Disabmiguate function calls to SetData ENH: Provided static code API for external applications COMP: Remove possible type conversion warnings ENH: Merge GDCM release branch Hyun Jae Kang (25): COMP: Fixed the compiler error of ITKCommon2TestDriver on OSX 10.6 BUG: Fixed the runtime crash of VideoSourceTest on OSX 10.6 BUG: Fixed the runtime crash of itkTimeProbeTest2 BUG: Fixed the runtime crash of ITKFastMarchingTestDriver's tests on OSX 10.6 BUG: Fixed the runtime crash of ITKReviewTestDriver on OSX 10.6 COMP: Fixed the data conversion warning messages of itkResourceProbe BUG: Fixed the runtime crash of itkLabelOverlapMeasuresImageFilterTest BUG: Fixed the runtime crash of ITKStatisticsTestDriver tests on OSX 10.6 BUG: Fixed the runtime crash of itkMRIBiasFieldCorrectionFilterTest BUG: Fixed the runtime crash of itkBinaryShapeOpeningImageFilterTest1 BUG: Fixed the runtime crash of vnl_test_complex on OSX 10.6 BUG: Fixed the runtime crash of vnl_test_numeric_traits BUG: Fixed the runtime crash of test_pow_log on OSX 10.6 BUG: Exclude a test code of ITKLabelMapTestDriver on OSX 10.6 BUG: Fixed the failed test case of itkSTLThreadTest on OS X 10.8 COMP: Update KWStyle to utilize the latest boost library COMP: Fixed the compiler error of ITK on Mingw-w64 COMP: Temporarily suppress the warning messages of data-conversion on VS14 COMP: Put back the disappeared option of "BUILD EXAMPLES". BUG: Fix segmentation faults on mingw-W64 x86_64. BUG: Fix the failed test of itkCastImageFilterTest on mingw-w64 compiler. COMP: Fixed the cmake configuration for ITK_WRAP_DOC COMP: Fixed the warning messages on VS14. COMP: Add a missing head file at itkNumericTraitsStdVector.h COMP: Fix the wraning message of data-conversion Jean-Christophe Fillion-Robin (4): COMP: ITKExternalModule: Support building module without test directory. STYLE: Facilitate maintenance of CastXML generator refactoring CMakeLists COMP: Allow use of multiple "ITK external modules" in the same project. STYLE: UseITK: Document static registration of ITK IO factories. See #3393 Jon Haitz Legarreta (7): COMP: Delete unused variable compiler warning. ENH: Refactored itkBioCellTest ENH: Exercise non-tested itk::Math methods. ENH: Improve MersenneTwister class and test. ENH: Improve itkFEMLoadPoint coverage. ENH: Improve itkVersion class code coverage. ENH: Perform class name checks in test macro KWSys Robot (1): KWSys 2016-03-09 (36d8666f) Lucas Gandel (9): ENH: Implement GetNumberOfParameter() in ImageToSpatialObjectMetric COMP: Enable wrapping of multiple "ITK external modules" in the same project COMP: Fix CASTXML_EXECUTABLE value for multiple external module COMP: Fix external module testing COMP: Fix git protocol setup ENH: Conditionally add testing for External Modules BUG: Fix call to std::max() with different variable types Manuel Grizonnet (1): COMP: add ITKCommon_EXPORT to fix link issues with external applications Matthew McCormick (73): ENH: Add TwoProjectionRegistration Remote Module. ENH: Allow ITKVideoBridgeOpenCV to be built externally. COMP: Add export specification for itk::ResourceProbe. ENH: Do not force shared libraries when wrapping. BUG: BUILD_TESTING should be not advanced. ENH: Bump ITK version to 4.10.0. DOC: Correct ITKImageNoise description spelling. ENH: Wrap FFTNormalizedCorrelationImageFilter. BUG: Remove Azure ExternalData resource. BUG: ExternalData downloads from midas3.kitware.com only supports https. BUG: Update ExternalData resource. BUG: slicer.kitware.com/midas3/ ExternalData will not support http. ENH: Add ITK_CUSTOM_LIBRARY_SUFFIX variable. ENH: Wrap PipelineMonitorImageFilter. BUG: Update MIDAS url for https in archive testing data script. ENH: Wrap std::vector< itk::ImageRegion >. BUG: Fix wrapping build with DEFAULT_MODULES OFF. ENH: Add RGB pixel support to ImageToVTKImageFilter. ENH: Add RGB and vector pixel type wrapping for ImageToVTKImageFilter. STYLE: Use PixelType and ImageType in Python tests. ENH: Avoid template type specification in Python wrapping. COMP: Do not use has_key in itkTemplate New. DOC: Emphasize that push access is not required to contribute patches. ENH: Download SWIG and PCRE from midas3.kitware.com. COMP: Ignore build warning from KWStyle's boost. BUG: Remove Azure ExternalData resource. BUG: ExternalData downloads from midas3.kitware.com only supports https. BUG: slicer.kitware.com/midas3/ ExternalData will not support http. ENH: Update the VNL README-ITK.txt subtree commit revision. BUG: Mark VXL internal CMake variables as advanced. BUG: Run itk_module_target on itknetlib. DOC: Direct patches for VXL upstream to the GitHub repository. BUG: Run itk_module_target on itknetlib. COMP: Account for removal of vcl_* from upstream VXL. COMP: Remove itkTypeMacro from BioCellHelper. COMP: Convert itkBioCellTest arguments from double to int. COMP: Turn off BUILD_DOCUMENTATION for VNL. BUG: Install VXL config files to backwards-compatible locations. ENH: Remove vcl_complex from the wrapping. BUG: Install vnl_export.h and vnl_algo_export.h to previous locations. BUG: midas3.kitware.com only supports the https protocol. BUG: ImageIOBase SetDimensions should take SizeValueType. ENH: Add wrapping for ImagePCAShapeModelEstimator. COMP: Do not specify COMPONENTS with find_package(VTK. DOC: Fix FFTW warning grammar. COMP: Build against system HDF5 1.8.16. ENH: Set a default CMAKE_BUILD_TYPE when building a module externally COMP: Make initial HDF5 discovery of 1.8.16 quiet. ENH: Use hidden symbol visibility for the CPython extension modules. ENH: Turn on CMAKE_POSITION_INDEPENDENT_CODE by default. BUG: FEMLoadPoint uninitialized value in the constructor. BUG: Fix wrapping of complex types in VNL. ENH: Bump CMakeLists.txt version 4.9.1. COMP: Address ITKCommon Python submodule order. BUG: Extend ExternalData_TIMEOUT_ABSOLUTE to 900 seconds. BUG: Do not run KWStyle Git config on a release tarball. COMP: Ambiguous RGBPixel access in CustomColormapFunction. BUG: Prevent division by zero in PhasedArray3DSpecialCoordinatesImage. BUG: Initialize azimuth and elevation to pi/2 in PhasedArray3D. BUG: Increase MaskLabel backwards compatibility in N4 bias correction. ENH: Deprecate MaskLabel in N4BiasFieldCorrectionImageFilter. COMP: Update CastXML to support Visual Studio 2015 Update 2. COMP: Do not set wrapping library visibility with static builds. COMP: Update CastXML to support Visual Studio 2015 Update 2. COMP: Broaden the KWStyle warning exception. COMP: Update KWStyle version. BUG: Do not use the same output file in N4BiasField Test 2,3. COMP: Expand EXERCISE_BASIC_OBJECT_METHODS for other GCC versions. ENH: Update Cuberille Remote to 2015-05-01. ENH: Enable registration of the IOOpenSlide module through CMake. ENH: Update itk.org URL's for HTTPS support. BUG: Use CastXML built against LLVM with LLVM_ENABLE_TERMINFO OFF. BUG: Fix Python wrapping on Windows when ITK_USE_64BIT_IDS is ON. Michka Popoff (12): ENH: Use importlib for python 3.4 instead of imp ENH: Update to Swig 3.0.8 ENH: Update PCRE to version 8.38 ENH: Wrap RayCastInterpolateImageFunction ENH: Wrap RayCastInterpolateImageFunction COMP: Remove debug output after vcl_complex removal from wrapping ENH: Consolidate .idx file generation with swig .i generation. ENH: Update UpdatepygccxmlFromUpstream.sh script COMP: Set CastXML path and name for pygccxml 1.7.3 COMP: Fix RayCastInterpolateImageFunction wrapping for image dim 2 ENH: Use argparse instead of optparse in igenerator.py ENH: Use https URL for OS X castxml binary (for consistency) Nick Tustison (2): ENH: Add fixed/moving masking in reg. methods. ENH: Making the mask usage consistent with ITK. Pablo Hernandez-Cerdan (1): COMP: Fix warn in FFTW about delete []. Sean McBride (18): COMP: Made script OS X compatible COMP: mark GDCM GetSeriesHelper() method as deprecated BUG: update script to fetch GDCM from its release-2-4 branch instead of master DOC: Updated comment to reflect new GDCM version COMP: Fixed recently introduced build error with deprecated GDCM method BUG: Fixed invalid memory access found by ASan COMP: Fixed clang warning about macro expansion giving defined COMP: Fixed minor dashboards warnings and typos. COMP: Fixed a bunch of clang -Wunreachable-code-break warnings COMP: fixed some dashboard warnings (dead code, false positive) BUG: Fixed off-by-1 error found by ASan COMP: Fixed clang -Wcomma warning COMP: Introduce ITK_FALLTHROUGH, to suppress switch fall through warnings COMP: Fixed -Wwritable-strings warnings COMP: Fixed remaining -Wcomma warnings ENH: switch gdcm to release branch, not release-2-4 COMP: Hack HDF5 to build under ASan & UBSan COMP: fixed clang -Wdeprecated-writable-strings warning Shawn Waldon (1): STYLE: move itkGaussianDerivativeOperator Sujin Philip (1): STYLE: Move itkBox* Filters Sumedha Singla (3): ENH: Issue: ITK#3363 Replaced assignment in SetParameters function. ENH: Remove unnecessary const_cast BUG: Fixed the test itkHDF5ImageIOTest VXL Maintainers (9): VNL 2015-11-22 (ea1d60fb) VNL 2016-03-02 (cb31149e) VNL 2016-03-13 (ae34f0fc) VNL 2016-03-15 (751698ab) VNL 2016-03-19 (df10fefa) VNL 2016-03-25 (f0040231) VNL 2016-03-30 (88f50849) VNL 2016-04-22 (0ed18124) VNL 2016-04-26 (6b168535) Vladimir S. FONOV (3): MINC 2015-12-17 (dcb93a5f) MINC 2016-01-30 (783bca38) MINC 2016-02-24 (8632513e) Ziv Yaniv (1): BUG: Interpretation of the Euler angles ZYX or ZXY was not exported. ----------------------------------------------------- Errors or omissions? Please fix them here: https://docs.google.com/document/d/1n6xDC3phae7bH40OVO-QTECZ6gKRlPr1dwZR3fydzfU/edit From hyunjae.kang at kitware.com Fri May 13 11:51:28 2016 From: hyunjae.kang at kitware.com (Hyun Jae Kang) Date: Fri, 13 May 2016 11:51:28 -0400 Subject: [ITK-dev] About the failing case of itkTestTransformGetInverse. Message-ID: Hi Alexander, Thank you for submit nightly dashboard. We are trying to figure out the test failing case [1] on your machine. Could you check the test code and provide us more information about the failing case? [1] https://open.cdash.org/viewTest.php?onlyfailed&buildid=4363789 Thanks, Hyun Jae -------------- next part -------------- An HTML attachment was scrubbed... URL: From blowekamp at mail.nih.gov Mon May 16 09:59:48 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Mon, 16 May 2016 13:59:48 +0000 Subject: [ITK-dev] SimpleITK update to ITK 4.10rc1 and VNL issues Message-ID: <1CB7DF80-F3A1-41BF-8E3D-6E1B90F3D5B3@mail.nih.gov> Hans, I update SimpleITK next to use ITK 4.10rc1 and I am getting some CMake errors on the dashboard [1]: Target "itkvcl" INTERFACE_INCLUDE_DIRECTORIES property contains relative path: "include/ITK-4.10" Do you know if this is addressed in upstream VXL? Does it look familiar? Or should I take a dive into the issue? Thanks, Brad [1] https://open.cdash.org/viewBuildError.php?buildid=4367313 -------------- next part -------------- An HTML attachment was scrubbed... URL: From matt.mccormick at kitware.com Mon May 16 11:38:54 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Mon, 16 May 2016 11:38:54 -0400 Subject: [ITK-dev] [ITK] SimpleITK update to ITK 4.10rc1 and VNL issues In-Reply-To: <1CB7DF80-F3A1-41BF-8E3D-6E1B90F3D5B3@mail.nih.gov> References: <1CB7DF80-F3A1-41BF-8E3D-6E1B90F3D5B3@mail.nih.gov> Message-ID: Hi Brad, Thanks for testing the RC! It looks like that system is running CMake 2.8.11.2. This issue was addressed in upstream VXL here: https://github.com/vxl/vxl/commit/d7d6314fb9846b923a5e90e8f7f65b3ab28bfc8e for CMake 2.8.11, but it is evidently still present for CMake 2.8.11.2. Here is a patch: https://github.com/vxl/vxl/pull/296 I am looking at addressing some of the VNL warnings on the ITK dashboard -- we will do a VXL Git subtree update soon. Thanks, Matt On Mon, May 16, 2016 at 9:59 AM, Lowekamp, Bradley (NIH/NLM/LHC) [C] wrote: > Hans, > > I update SimpleITK next to use ITK 4.10rc1 and I am getting some CMake > errors on the dashboard [1]: > > Target "itkvcl" INTERFACE_INCLUDE_DIRECTORIES property contains relative > path: > > "include/ITK-4.10" > > > Do you know if this is addressed in upstream VXL? Does it look familiar? Or > should I take a dive into the issue? > > Thanks, > Brad > > [1] https://open.cdash.org/viewBuildError.php?buildid=4367313 > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > > _______________________________________________ > Community mailing list > Community at itk.org > http://public.kitware.com/mailman/listinfo/community > From blowekamp at mail.nih.gov Tue May 17 10:14:38 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Tue, 17 May 2016 14:14:38 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error Message-ID: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> Hello, On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am getting the following compilation error with VS9 2008[1]: 3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------ 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------ 3>2>Compiling... 3>4>Compiling... 3>1>Compiling... 3>2>triangle.c 3>1>vcl_deprecated.cxx 3>4>FStream.cxx 3>3>Compiling... 3>3>v3p_netlib_init.c 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error : "Missing definition for SHARED_PTR" Is this addressed in VNL upstream yet? or should I begin looking into it? Thanks, Brad [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 -------------- next part -------------- An HTML attachment was scrubbed... URL: From blowekamp at mail.nih.gov Tue May 17 10:34:23 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Tue, 17 May 2016 14:34:23 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> Message-ID: <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> Hans, I?ll take a look into it. Thanks for the offer for a hang out, well go there if needed. I haven?t tries this my self, but there is the Free, VS for Python 2.7, that is suppose to be based on VS9 2008[1]. I don?t know how this works with general CMake project, but maybe it will help improve your access. Brad [1] https://www.visualstudio.com/en-us/features/python-vs.aspx On May 17, 2016, at 10:29 AM, Johnson, Hans J > wrote: This is not fixed in VXL upstream. There are currently no windows builds on VXL dashboard: https://open.cdash.org/index.php?project=vxl I don?t see any VS9 builds for ITK either. I?d be happy to help identify a solution, but I don?t have the VS resources. If you would like to have a hang out, I?d be interested in assisting with the fix. Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:14 AM To: "insight-developers at itk.org" > Cc: Hans Johnson > Subject: ITK4.10rc1 SimpleITK VNL error Hello, On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am getting the following compilation error with VS9 2008[1]: 3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------ 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------ 3>2>Compiling... 3>4>Compiling... 3>1>Compiling... 3>2>triangle.c 3>1>vcl_deprecated.cxx 3>4>FStream.cxx 3>3>Compiling... 3>3>v3p_netlib_init.c 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error : "Missing definition for SHARED_PTR" Is this addressed in VNL upstream yet? or should I begin looking into it? Thanks, Brad [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 -------------- next part -------------- An HTML attachment was scrubbed... URL: From hans-johnson at uiowa.edu Tue May 17 10:29:48 2016 From: hans-johnson at uiowa.edu (Johnson, Hans J) Date: Tue, 17 May 2016 14:29:48 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> Message-ID: <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> This is not fixed in VXL upstream. There are currently no windows builds on VXL dashboard: https://open.cdash.org/index.php?project=vxl I don?t see any VS9 builds for ITK either. I?d be happy to help identify a solution, but I don?t have the VS resources. If you would like to have a hang out, I?d be interested in assisting with the fix. Hans -- From: Bradley Lowekamp Date: Tuesday, May 17, 2016 at 9:14 AM To: "insight-developers at itk.org" Cc: Hans Johnson Subject: ITK4.10rc1 SimpleITK VNL error Hello, On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am getting the following compilation error with VS9 2008[1]: 3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------ 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------ 3>2>Compiling... 3>4>Compiling... 3>1>Compiling... 3>2>triangle.c 3>1>vcl_deprecated.cxx 3>4>FStream.cxx 3>3>Compiling... 3>3>v3p_netlib_init.c 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error : "Missing definition for SHARED_PTR" Is this addressed in VNL upstream yet? or should I begin looking into it? Thanks, Brad [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 -------------- next part -------------- An HTML attachment was scrubbed... URL: From hans-johnson at uiowa.edu Tue May 17 11:07:30 2016 From: hans-johnson at uiowa.edu (Johnson, Hans J) Date: Tue, 17 May 2016 15:07:30 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> Message-ID: Thanks Brad. Do you know if this version can be installed along side of VS 2015 without conflicts? Hans -- From: Bradley Lowekamp Date: Tuesday, May 17, 2016 at 9:34 AM To: Hans Johnson Cc: "insight-developers at itk.org" Subject: Re: ITK4.10rc1 SimpleITK VNL error Hans, I?ll take a look into it. Thanks for the offer for a hang out, well go there if needed. I haven?t tries this my self, but there is the Free, VS for Python 2.7, that is suppose to be based on VS9 2008[1]. I don?t know how this works with general CMake project, but maybe it will help improve your access. Brad [1] https://www.visualstudio.com/en-us/features/python-vs.aspx On May 17, 2016, at 10:29 AM, Johnson, Hans J > wrote: This is not fixed in VXL upstream. There are currently no windows builds on VXL dashboard: https://open.cdash.org/index.php?project=vxl I don?t see any VS9 builds for ITK either. I?d be happy to help identify a solution, but I don?t have the VS resources. If you would like to have a hang out, I?d be interested in assisting with the fix. Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:14 AM To: "insight-developers at itk.org" > Cc: Hans Johnson > Subject: ITK4.10rc1 SimpleITK VNL error Hello, On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am getting the following compilation error with VS9 2008[1]: 3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------ 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------ 3>2>Compiling... 3>4>Compiling... 3>1>Compiling... 3>2>triangle.c 3>1>vcl_deprecated.cxx 3>4>FStream.cxx 3>3>Compiling... 3>3>v3p_netlib_init.c 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error : "Missing definition for SHARED_PTR" Is this addressed in VNL upstream yet? or should I begin looking into it? Thanks, Brad [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 -------------- next part -------------- An HTML attachment was scrubbed... URL: From blowekamp at mail.nih.gov Tue May 17 15:44:43 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Tue, 17 May 2016 19:44:43 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> Message-ID: <71FCFB79-1B08-4A59-BE33-A8CEAA45ED37@mail.nih.gov> Hans, This looks like an issue with tr1 includes [1]. This is very tricky business with VS, gcc, clang and libstdc++ and libc++. And it looks like VCL is now requiring shared_ptr support? It that intentional? In my tests for SimpleITK, I have it noted [2], that Visual Studio 2008, 2010, 2012 don?t need the tr1 in the include path for tr1 headers. The checks in VXL seem to require this sub-folder arrangement. So check like the following should be done: CHECK_TYPE_EXISTS_ZERO(std::tr1::shared_ptr memory VCL_MEMORY_HAS_TR1_SHARED_PTR) Note the tr1 namespace but not the tr1 include path. I?m working on testing this now. [1] https://github.com/vxl/vxl/blob/abb93b9cea365318028cf18c9b84020c3c6a1d67/vcl/vcl_compiler.h#L942-L955 [2] https://github.com/SimpleITK/SimpleITK/blob/fc6bbeaf91dd74ebb294db57ccef8f9bb9e5e6b0/CMake/sitkCheckCXX11.cmake#L59-L61 On May 17, 2016, at 11:07 AM, Johnson, Hans J > wrote: Thanks Brad. Do you know if this version can be installed along side of VS 2015 without conflicts? Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:34 AM To: Hans Johnson > Cc: "insight-developers at itk.org" > Subject: Re: ITK4.10rc1 SimpleITK VNL error Hans, I?ll take a look into it. Thanks for the offer for a hang out, well go there if needed. I haven?t tries this my self, but there is the Free, VS for Python 2.7, that is suppose to be based on VS9 2008[1]. I don?t know how this works with general CMake project, but maybe it will help improve your access. Brad [1] https://www.visualstudio.com/en-us/features/python-vs.aspx On May 17, 2016, at 10:29 AM, Johnson, Hans J > wrote: This is not fixed in VXL upstream. There are currently no windows builds on VXL dashboard: https://open.cdash.org/index.php?project=vxl I don?t see any VS9 builds for ITK either. I?d be happy to help identify a solution, but I don?t have the VS resources. If you would like to have a hang out, I?d be interested in assisting with the fix. Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:14 AM To: "insight-developers at itk.org" > Cc: Hans Johnson > Subject: ITK4.10rc1 SimpleITK VNL error Hello, On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am getting the following compilation error with VS9 2008[1]: 3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------ 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------ 3>2>Compiling... 3>4>Compiling... 3>1>Compiling... 3>2>triangle.c 3>1>vcl_deprecated.cxx 3>4>FStream.cxx 3>3>Compiling... 3>3>v3p_netlib_init.c 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error : "Missing definition for SHARED_PTR" Is this addressed in VNL upstream yet? or should I begin looking into it? Thanks, Brad [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 -------------- next part -------------- An HTML attachment was scrubbed... URL: From hans-johnson at uiowa.edu Tue May 17 15:51:41 2016 From: hans-johnson at uiowa.edu (Johnson, Hans J) Date: Tue, 17 May 2016 19:51:41 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: <71FCFB79-1B08-4A59-BE33-A8CEAA45ED37@mail.nih.gov> References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> <71FCFB79-1B08-4A59-BE33-A8CEAA45ED37@mail.nih.gov> Message-ID: <9BAF0F8F-1EB8-4650-AB49-AA927ED4C63F@uiowa.edu> Brad, Thank you for your assistance. I am hopeful that your solution can maintain a relatively simple set of rules implementing cross platform support. I?ll review ASAP when you have a patch set to look at. Your assistance is GREATLY appreciated. Hans -- From: Bradley Lowekamp Date: Tuesday, May 17, 2016 at 2:44 PM To: Hans Johnson Cc: "insight-developers at itk.org" Subject: Re: ITK4.10rc1 SimpleITK VNL error Hans, This looks like an issue with tr1 includes [1]. This is very tricky business with VS, gcc, clang and libstdc++ and libc++. And it looks like VCL is now requiring shared_ptr support? It that intentional? In my tests for SimpleITK, I have it noted [2], that Visual Studio 2008, 2010, 2012 don?t need the tr1 in the include path for tr1 headers. The checks in VXL seem to require this sub-folder arrangement. So check like the following should be done: CHECK_TYPE_EXISTS_ZERO(std::tr1::shared_ptr memory VCL_MEMORY_HAS_TR1_SHARED_PTR) Note the tr1 namespace but not the tr1 include path. I?m working on testing this now. [1] https://github.com/vxl/vxl/blob/abb93b9cea365318028cf18c9b84020c3c6a1d67/vcl/vcl_compiler.h#L942-L955 [2] https://github.com/SimpleITK/SimpleITK/blob/fc6bbeaf91dd74ebb294db57ccef8f9bb9e5e6b0/CMake/sitkCheckCXX11.cmake#L59-L61 On May 17, 2016, at 11:07 AM, Johnson, Hans J > wrote: Thanks Brad. Do you know if this version can be installed along side of VS 2015 without conflicts? Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:34 AM To: Hans Johnson > Cc: "insight-developers at itk.org" > Subject: Re: ITK4.10rc1 SimpleITK VNL error Hans, I?ll take a look into it. Thanks for the offer for a hang out, well go there if needed. I haven?t tries this my self, but there is the Free, VS for Python 2.7, that is suppose to be based on VS9 2008[1]. I don?t know how this works with general CMake project, but maybe it will help improve your access. Brad [1] https://www.visualstudio.com/en-us/features/python-vs.aspx On May 17, 2016, at 10:29 AM, Johnson, Hans J > wrote: This is not fixed in VXL upstream. There are currently no windows builds on VXL dashboard: https://open.cdash.org/index.php?project=vxl I don?t see any VS9 builds for ITK either. I?d be happy to help identify a solution, but I don?t have the VS resources. If you would like to have a hang out, I?d be interested in assisting with the fix. Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:14 AM To: "insight-developers at itk.org" > Cc: Hans Johnson > Subject: ITK4.10rc1 SimpleITK VNL error Hello, On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am getting the following compilation error with VS9 2008[1]: 3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------ 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------ 3>2>Compiling... 3>4>Compiling... 3>1>Compiling... 3>2>triangle.c 3>1>vcl_deprecated.cxx 3>4>FStream.cxx 3>3>Compiling... 3>3>v3p_netlib_init.c 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error : "Missing definition for SHARED_PTR" Is this addressed in VNL upstream yet? or should I begin looking into it? Thanks, Brad [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 -------------- next part -------------- An HTML attachment was scrubbed... URL: From blowekamp at mail.nih.gov Wed May 18 08:35:59 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Wed, 18 May 2016 12:35:59 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: <9BAF0F8F-1EB8-4650-AB49-AA927ED4C63F@uiowa.edu> References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> <71FCFB79-1B08-4A59-BE33-A8CEAA45ED37@mail.nih.gov> <9BAF0F8F-1EB8-4650-AB49-AA927ED4C63F@uiowa.edu> Message-ID: Is VXL in a state to update ITK with the current mater? Brad On May 17, 2016, at 3:51 PM, Johnson, Hans J > wrote: Brad, Thank you for your assistance. I am hopeful that your solution can maintain a relatively simple set of rules implementing cross platform support. I?ll review ASAP when you have a patch set to look at. Your assistance is GREATLY appreciated. Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 2:44 PM To: Hans Johnson > Cc: "insight-developers at itk.org" > Subject: Re: ITK4.10rc1 SimpleITK VNL error Hans, This looks like an issue with tr1 includes [1]. This is very tricky business with VS, gcc, clang and libstdc++ and libc++. And it looks like VCL is now requiring shared_ptr support? It that intentional? In my tests for SimpleITK, I have it noted [2], that Visual Studio 2008, 2010, 2012 don?t need the tr1 in the include path for tr1 headers. The checks in VXL seem to require this sub-folder arrangement. So check like the following should be done: CHECK_TYPE_EXISTS_ZERO(std::tr1::shared_ptr memory VCL_MEMORY_HAS_TR1_SHARED_PTR) Note the tr1 namespace but not the tr1 include path. I?m working on testing this now. [1] https://github.com/vxl/vxl/blob/abb93b9cea365318028cf18c9b84020c3c6a1d67/vcl/vcl_compiler.h#L942-L955 [2] https://github.com/SimpleITK/SimpleITK/blob/fc6bbeaf91dd74ebb294db57ccef8f9bb9e5e6b0/CMake/sitkCheckCXX11.cmake#L59-L61 On May 17, 2016, at 11:07 AM, Johnson, Hans J > wrote: Thanks Brad. Do you know if this version can be installed along side of VS 2015 without conflicts? Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:34 AM To: Hans Johnson > Cc: "insight-developers at itk.org" > Subject: Re: ITK4.10rc1 SimpleITK VNL error Hans, I?ll take a look into it. Thanks for the offer for a hang out, well go there if needed. I haven?t tries this my self, but there is the Free, VS for Python 2.7, that is suppose to be based on VS9 2008[1]. I don?t know how this works with general CMake project, but maybe it will help improve your access. Brad [1] https://www.visualstudio.com/en-us/features/python-vs.aspx On May 17, 2016, at 10:29 AM, Johnson, Hans J > wrote: This is not fixed in VXL upstream. There are currently no windows builds on VXL dashboard: https://open.cdash.org/index.php?project=vxl I don?t see any VS9 builds for ITK either. I?d be happy to help identify a solution, but I don?t have the VS resources. If you would like to have a hang out, I?d be interested in assisting with the fix. Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:14 AM To: "insight-developers at itk.org" > Cc: Hans Johnson > Subject: ITK4.10rc1 SimpleITK VNL error Hello, On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am getting the following compilation error with VS9 2008[1]: 3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------ 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------ 3>2>Compiling... 3>4>Compiling... 3>1>Compiling... 3>2>triangle.c 3>1>vcl_deprecated.cxx 3>4>FStream.cxx 3>3>Compiling... 3>3>v3p_netlib_init.c 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error : "Missing definition for SHARED_PTR" Is this addressed in VNL upstream yet? or should I begin looking into it? Thanks, Brad [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 -------------- next part -------------- An HTML attachment was scrubbed... URL: From blowekamp at mail.nih.gov Wed May 18 09:37:06 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Wed, 18 May 2016 13:37:06 +0000 Subject: [ITK-dev] CDash - Where is the CMake version Message-ID: Hello, I can?t seem to find the cmake version for builds any more. Where is it now? Thanks, Brad From hans-johnson at uiowa.edu Wed May 18 10:11:19 2016 From: hans-johnson at uiowa.edu (Johnson, Hans J) Date: Wed, 18 May 2016 14:11:19 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> <71FCFB79-1B08-4A59-BE33-A8CEAA45ED37@mail.nih.gov> <9BAF0F8F-1EB8-4650-AB49-AA927ED4C63F@uiowa.edu> Message-ID: <03BB5B28-804D-4FAA-8F52-7D1C913A1CB6@uiowa.edu> I believe so. I am pretty sure that it will improve C++11 support in ITK. Hans -- From: Bradley Lowekamp Date: Wednesday, May 18, 2016 at 7:35 AM To: Hans Johnson Cc: "insight-developers at itk.org" Subject: Re: ITK4.10rc1 SimpleITK VNL error Is VXL in a state to update ITK with the current mater? Brad On May 17, 2016, at 3:51 PM, Johnson, Hans J > wrote: Brad, Thank you for your assistance. I am hopeful that your solution can maintain a relatively simple set of rules implementing cross platform support. I?ll review ASAP when you have a patch set to look at. Your assistance is GREATLY appreciated. Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 2:44 PM To: Hans Johnson > Cc: "insight-developers at itk.org" > Subject: Re: ITK4.10rc1 SimpleITK VNL error Hans, This looks like an issue with tr1 includes [1]. This is very tricky business with VS, gcc, clang and libstdc++ and libc++. And it looks like VCL is now requiring shared_ptr support? It that intentional? In my tests for SimpleITK, I have it noted [2], that Visual Studio 2008, 2010, 2012 don?t need the tr1 in the include path for tr1 headers. The checks in VXL seem to require this sub-folder arrangement. So check like the following should be done: CHECK_TYPE_EXISTS_ZERO(std::tr1::shared_ptr memory VCL_MEMORY_HAS_TR1_SHARED_PTR) Note the tr1 namespace but not the tr1 include path. I?m working on testing this now. [1] https://github.com/vxl/vxl/blob/abb93b9cea365318028cf18c9b84020c3c6a1d67/vcl/vcl_compiler.h#L942-L955 [2] https://github.com/SimpleITK/SimpleITK/blob/fc6bbeaf91dd74ebb294db57ccef8f9bb9e5e6b0/CMake/sitkCheckCXX11.cmake#L59-L61 On May 17, 2016, at 11:07 AM, Johnson, Hans J > wrote: Thanks Brad. Do you know if this version can be installed along side of VS 2015 without conflicts? Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:34 AM To: Hans Johnson > Cc: "insight-developers at itk.org" > Subject: Re: ITK4.10rc1 SimpleITK VNL error Hans, I?ll take a look into it. Thanks for the offer for a hang out, well go there if needed. I haven?t tries this my self, but there is the Free, VS for Python 2.7, that is suppose to be based on VS9 2008[1]. I don?t know how this works with general CMake project, but maybe it will help improve your access. Brad [1] https://www.visualstudio.com/en-us/features/python-vs.aspx On May 17, 2016, at 10:29 AM, Johnson, Hans J > wrote: This is not fixed in VXL upstream. There are currently no windows builds on VXL dashboard: https://open.cdash.org/index.php?project=vxl I don?t see any VS9 builds for ITK either. I?d be happy to help identify a solution, but I don?t have the VS resources. If you would like to have a hang out, I?d be interested in assisting with the fix. Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:14 AM To: "insight-developers at itk.org" > Cc: Hans Johnson > Subject: ITK4.10rc1 SimpleITK VNL error Hello, On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am getting the following compilation error with VS9 2008[1]: 3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------ 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------ 3>2>Compiling... 3>4>Compiling... 3>1>Compiling... 3>2>triangle.c 3>1>vcl_deprecated.cxx 3>4>FStream.cxx 3>3>Compiling... 3>3>v3p_netlib_init.c 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error : "Missing definition for SHARED_PTR" Is this addressed in VNL upstream yet? or should I begin looking into it? Thanks, Brad [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 -------------- next part -------------- An HTML attachment was scrubbed... URL: From zack.galbreath at kitware.com Wed May 18 11:11:10 2016 From: zack.galbreath at kitware.com (Zack Galbreath) Date: Wed, 18 May 2016 11:11:10 -0400 Subject: [ITK-dev] CDash - Where is the CMake version In-Reply-To: References: Message-ID: On Wed, May 18, 2016 at 9:37 AM, Lowekamp, Bradley (NIH/NLM/LHC) [C] < blowekamp at mail.nih.gov> wrote: > Hello, > > I can?t seem to find the cmake version for builds any more. Where is it > now? > It's still available on buildSummary.php (click on the build name from index.php). It's shown as CTest version, but this should correspond to the version of CMake used to configure the build. Is there some other spot where you were expecting to see this information? -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: ctest_version.png Type: image/png Size: 132014 bytes Desc: not available URL: From dzenanz at gmail.com Wed May 18 11:16:51 2016 From: dzenanz at gmail.com (=?UTF-8?B?RMW+ZW5hbiBadWtpxIc=?=) Date: Wed, 18 May 2016 11:16:51 -0400 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> Message-ID: Hi Hans, Python support is included with default installation of VS2015. You just need to tick it when installing, or modifying your installation. Or were you asking about something different? Regards On Tue, May 17, 2016 at 11:07 AM, Johnson, Hans J wrote: > Thanks Brad. Do you know if this version can be installed along side of > VS 2015 without conflicts? > > > > Hans > > -- > > > > > > *From: *Bradley Lowekamp > *Date: *Tuesday, May 17, 2016 at 9:34 AM > *To: *Hans Johnson > *Cc: *"insight-developers at itk.org" > *Subject: *Re: ITK4.10rc1 SimpleITK VNL error > > > > Hans, > > > > I?ll take a look into it. Thanks for the offer for a hang out, well go > there if needed. > > > > I haven?t tries this my self, but there is the Free, VS for Python 2.7, > that is suppose to be based on VS9 2008[1]. I don?t know how this works > with general CMake project, but maybe it will help improve your access. > > > > Brad > > > > > > [1] https://www.visualstudio.com/en-us/features/python-vs.aspx > > > > On May 17, 2016, at 10:29 AM, Johnson, Hans J > wrote: > > > > This is not fixed in VXL upstream. > > > > There are currently no windows builds on VXL dashboard: > https://open.cdash.org/index.php?project=vxl > > > > I don?t see any VS9 builds for ITK either. > > > > I?d be happy to help identify a solution, but I don?t have the VS > resources. If you would like to have a hang out, I?d be interested in > assisting with the fix. > > > > Hans > > > > -- > > > > > > *From: *Bradley Lowekamp > *Date: *Tuesday, May 17, 2016 at 9:14 AM > *To: *"insight-developers at itk.org" > *Cc: *Hans Johnson > *Subject: *ITK4.10rc1 SimpleITK VNL error > > > > Hello, > > > > On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am > getting the following compilation error with VS9 2008[1]: > > > > 3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------ > > 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------ > > 3>2>Compiling... > > 3>4>Compiling... > > 3>1>Compiling... > > 3>2>triangle.c > > 3>1>vcl_deprecated.cxx > > 3>4>FStream.cxx > > 3>3>Compiling... > > 3>3>v3p_netlib_init.c > > *3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error : "Missing definition for SHARED_PTR"* > > > > Is this addressed in VNL upstream yet? or should I begin looking into it? > > > > Thanks, > > Brad > > > > > > [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From blowekamp at mail.nih.gov Wed May 18 11:33:32 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Wed, 18 May 2016 15:33:32 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> Message-ID: <4F248E77-5B69-48EF-B547-0E6D17695A23@mail.nih.gov> @Hans, I have 5 versions of VS on the same system without problems. I would not try to mix multiple versions of the same release i.e. VS9 for Python with VS9 or VS14 with VS14 express. I?d expect VS14 and VS9 for Python 2.7 to work fine. @Dzenan The official Python.org 2.7 is compiled and distributed with the VS9 tool chain. This the the compiler recommenced to build Python 2.7 extensions according to PyPA[1]. While you can build an extension and mix the compilers, when something crashes unexpectedly I?d blame this first :) HTH, Brad [1] https://media.readthedocs.org/pdf/python-packaging-user-guide/latest/python-packaging-user-guide.pdf Visual Su On May 18, 2016, at 11:16 AM, D?enan Zuki? > wrote: Hi Hans, Python support is included with default installation of VS2015. You just need to tick it when installing, or modifying your installation. Or were you asking about something different? Regards On Tue, May 17, 2016 at 11:07 AM, Johnson, Hans J > wrote: Thanks Brad. Do you know if this version can be installed along side of VS 2015 without conflicts? Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:34 AM To: Hans Johnson > Cc: "insight-developers at itk.org" > Subject: Re: ITK4.10rc1 SimpleITK VNL error Hans, I?ll take a look into it. Thanks for the offer for a hang out, well go there if needed. I haven?t tries this my self, but there is the Free, VS for Python 2.7, that is suppose to be based on VS9 2008[1]. I don?t know how this works with general CMake project, but maybe it will help improve your access. Brad [1] https://www.visualstudio.com/en-us/features/python-vs.aspx On May 17, 2016, at 10:29 AM, Johnson, Hans J > wrote: This is not fixed in VXL upstream. There are currently no windows builds on VXL dashboard: https://open.cdash.org/index.php?project=vxl I don?t see any VS9 builds for ITK either. I?d be happy to help identify a solution, but I don?t have the VS resources. If you would like to have a hang out, I?d be interested in assisting with the fix. Hans -- From: Bradley Lowekamp > Date: Tuesday, May 17, 2016 at 9:14 AM To: "insight-developers at itk.org" > Cc: Hans Johnson > Subject: ITK4.10rc1 SimpleITK VNL error Hello, On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am getting the following compilation error with VS9 2008[1]: 3>3>------ Build started: Project: itkv3p_netlib, Configuration: MinSizeRel x64 ------ 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 ------ 3>2>Compiling... 3>4>Compiling... 3>1>Compiling... 3>2>triangle.c 3>1>vcl_deprecated.cxx 3>4>FStream.cxx 3>3>Compiling... 3>3>v3p_netlib_init.c 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) : fatal error C1189: #error : "Missing definition for SHARED_PTR" Is this addressed in VNL upstream yet? or should I begin looking into it? Thanks, Brad [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers -------------- next part -------------- An HTML attachment was scrubbed... URL: From matt.mccormick at kitware.com Wed May 18 11:34:08 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Wed, 18 May 2016 11:34:08 -0400 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> Message-ID: There are a many enhancements in VXL master that have not been sufficiently tested to merge for ITK 4.10 at this point in the release cycle. This patch https://github.com/vxl/vxl/commit/ebd2d26bea536a669ce10a88ec21ff28bd659533 is a high risk. If there are individual patches that are bug fixes or provide improved compiler support, please let me know, and I will port them to the ITK subtree for the 4.10 release. Thanks, Matt On Wed, May 18, 2016 at 11:16 AM, D?enan Zuki? wrote: > Hi Hans, > > Python support is included with default installation of VS2015. You just > need to tick it when installing, or modifying your installation. Or were you > asking about something different? > > Regards > > On Tue, May 17, 2016 at 11:07 AM, Johnson, Hans J > wrote: >> >> Thanks Brad. Do you know if this version can be installed along side of >> VS 2015 without conflicts? >> >> >> >> Hans >> >> -- >> >> >> >> >> >> From: Bradley Lowekamp >> Date: Tuesday, May 17, 2016 at 9:34 AM >> To: Hans Johnson >> Cc: "insight-developers at itk.org" >> Subject: Re: ITK4.10rc1 SimpleITK VNL error >> >> >> >> Hans, >> >> >> >> I?ll take a look into it. Thanks for the offer for a hang out, well go >> there if needed. >> >> >> >> I haven?t tries this my self, but there is the Free, VS for Python 2.7, >> that is suppose to be based on VS9 2008[1]. I don?t know how this works with >> general CMake project, but maybe it will help improve your access. >> >> >> >> Brad >> >> >> >> >> >> [1] https://www.visualstudio.com/en-us/features/python-vs.aspx >> >> >> >> On May 17, 2016, at 10:29 AM, Johnson, Hans J >> wrote: >> >> >> >> This is not fixed in VXL upstream. >> >> >> >> There are currently no windows builds on VXL dashboard: >> https://open.cdash.org/index.php?project=vxl >> >> >> >> I don?t see any VS9 builds for ITK either. >> >> >> >> I?d be happy to help identify a solution, but I don?t have the VS >> resources. If you would like to have a hang out, I?d be interested in >> assisting with the fix. >> >> >> >> Hans >> >> >> >> -- >> >> >> >> >> >> From: Bradley Lowekamp >> Date: Tuesday, May 17, 2016 at 9:14 AM >> To: "insight-developers at itk.org" >> Cc: Hans Johnson >> Subject: ITK4.10rc1 SimpleITK VNL error >> >> >> >> Hello, >> >> >> >> On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am >> getting the following compilation error with VS9 2008[1]: >> >> >> >> 3>3>------ Build started: Project: itkv3p_netlib, Configuration: >> MinSizeRel x64 ------ >> >> 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 >> ------ >> >> 3>2>Compiling... >> >> 3>4>Compiling... >> >> 3>1>Compiling... >> >> 3>2>triangle.c >> >> 3>1>vcl_deprecated.cxx >> >> 3>4>FStream.cxx >> >> 3>3>Compiling... >> >> 3>3>v3p_netlib_init.c >> >> >> 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) >> : fatal error C1189: #error : "Missing definition for SHARED_PTR" >> >> >> >> Is this addressed in VNL upstream yet? or should I begin looking into it? >> >> >> >> Thanks, >> >> Brad >> >> >> >> >> >> [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 >> >> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers >> > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > From blowekamp at mail.nih.gov Wed May 18 11:38:29 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Wed, 18 May 2016 15:38:29 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> Message-ID: The is an important one causing problem with SimpleITK and complaints with Slicer users too: https://github.com/vxl/vxl/pull/298 Brad > On May 18, 2016, at 11:34 AM, Matt McCormick wrote: > > There are a many enhancements in VXL master that have not been > sufficiently tested to merge for ITK 4.10 at this point in the release > cycle. > > This patch > > https://github.com/vxl/vxl/commit/ebd2d26bea536a669ce10a88ec21ff28bd659533 > > is a high risk. > > > If there are individual patches that are bug fixes or provide improved > compiler support, please let me know, and I will port them to the ITK > subtree for the 4.10 release. > > Thanks, > Matt > > On Wed, May 18, 2016 at 11:16 AM, D?enan Zuki? wrote: >> Hi Hans, >> >> Python support is included with default installation of VS2015. You just >> need to tick it when installing, or modifying your installation. Or were you >> asking about something different? >> >> Regards >> >> On Tue, May 17, 2016 at 11:07 AM, Johnson, Hans J >> wrote: >>> >>> Thanks Brad. Do you know if this version can be installed along side of >>> VS 2015 without conflicts? >>> >>> >>> >>> Hans >>> >>> -- >>> >>> >>> >>> >>> >>> From: Bradley Lowekamp >>> Date: Tuesday, May 17, 2016 at 9:34 AM >>> To: Hans Johnson >>> Cc: "insight-developers at itk.org" >>> Subject: Re: ITK4.10rc1 SimpleITK VNL error >>> >>> >>> >>> Hans, >>> >>> >>> >>> I?ll take a look into it. Thanks for the offer for a hang out, well go >>> there if needed. >>> >>> >>> >>> I haven?t tries this my self, but there is the Free, VS for Python 2.7, >>> that is suppose to be based on VS9 2008[1]. I don?t know how this works with >>> general CMake project, but maybe it will help improve your access. >>> >>> >>> >>> Brad >>> >>> >>> >>> >>> >>> [1] https://www.visualstudio.com/en-us/features/python-vs.aspx >>> >>> >>> >>> On May 17, 2016, at 10:29 AM, Johnson, Hans J >>> wrote: >>> >>> >>> >>> This is not fixed in VXL upstream. >>> >>> >>> >>> There are currently no windows builds on VXL dashboard: >>> https://open.cdash.org/index.php?project=vxl >>> >>> >>> >>> I don?t see any VS9 builds for ITK either. >>> >>> >>> >>> I?d be happy to help identify a solution, but I don?t have the VS >>> resources. If you would like to have a hang out, I?d be interested in >>> assisting with the fix. >>> >>> >>> >>> Hans >>> >>> >>> >>> -- >>> >>> >>> >>> >>> >>> From: Bradley Lowekamp >>> Date: Tuesday, May 17, 2016 at 9:14 AM >>> To: "insight-developers at itk.org" >>> Cc: Hans Johnson >>> Subject: ITK4.10rc1 SimpleITK VNL error >>> >>> >>> >>> Hello, >>> >>> >>> >>> On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am >>> getting the following compilation error with VS9 2008[1]: >>> >>> >>> >>> 3>3>------ Build started: Project: itkv3p_netlib, Configuration: >>> MinSizeRel x64 ------ >>> >>> 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 >>> ------ >>> >>> 3>2>Compiling... >>> >>> 3>4>Compiling... >>> >>> 3>1>Compiling... >>> >>> 3>2>triangle.c >>> >>> 3>1>vcl_deprecated.cxx >>> >>> 3>4>FStream.cxx >>> >>> 3>3>Compiling... >>> >>> 3>3>v3p_netlib_init.c >>> >>> >>> 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) >>> : fatal error C1189: #error : "Missing definition for SHARED_PTR" >>> >>> >>> >>> Is this addressed in VNL upstream yet? or should I begin looking into it? >>> >>> >>> >>> Thanks, >>> >>> Brad >>> >>> >>> >>> >>> >>> [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 >>> >>> >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/insight-developers >>> >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers >> > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers From matt.mccormick at kitware.com Wed May 18 14:26:36 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Wed, 18 May 2016 14:26:36 -0400 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> Message-ID: Thanks. This patch has been merged to the release branch. M On Wed, May 18, 2016 at 11:38 AM, Lowekamp, Bradley (NIH/NLM/LHC) [C] wrote: > The is an important one causing problem with SimpleITK and complaints with Slicer users too: > > https://github.com/vxl/vxl/pull/298 > > Brad > > >> On May 18, 2016, at 11:34 AM, Matt McCormick wrote: >> >> There are a many enhancements in VXL master that have not been >> sufficiently tested to merge for ITK 4.10 at this point in the release >> cycle. >> >> This patch >> >> https://github.com/vxl/vxl/commit/ebd2d26bea536a669ce10a88ec21ff28bd659533 >> >> is a high risk. >> >> >> If there are individual patches that are bug fixes or provide improved >> compiler support, please let me know, and I will port them to the ITK >> subtree for the 4.10 release. >> >> Thanks, >> Matt >> >> On Wed, May 18, 2016 at 11:16 AM, D?enan Zuki? wrote: >>> Hi Hans, >>> >>> Python support is included with default installation of VS2015. You just >>> need to tick it when installing, or modifying your installation. Or were you >>> asking about something different? >>> >>> Regards >>> >>> On Tue, May 17, 2016 at 11:07 AM, Johnson, Hans J >>> wrote: >>>> >>>> Thanks Brad. Do you know if this version can be installed along side of >>>> VS 2015 without conflicts? >>>> >>>> >>>> >>>> Hans >>>> >>>> -- >>>> >>>> >>>> >>>> >>>> >>>> From: Bradley Lowekamp >>>> Date: Tuesday, May 17, 2016 at 9:34 AM >>>> To: Hans Johnson >>>> Cc: "insight-developers at itk.org" >>>> Subject: Re: ITK4.10rc1 SimpleITK VNL error >>>> >>>> >>>> >>>> Hans, >>>> >>>> >>>> >>>> I?ll take a look into it. Thanks for the offer for a hang out, well go >>>> there if needed. >>>> >>>> >>>> >>>> I haven?t tries this my self, but there is the Free, VS for Python 2.7, >>>> that is suppose to be based on VS9 2008[1]. I don?t know how this works with >>>> general CMake project, but maybe it will help improve your access. >>>> >>>> >>>> >>>> Brad >>>> >>>> >>>> >>>> >>>> >>>> [1] https://www.visualstudio.com/en-us/features/python-vs.aspx >>>> >>>> >>>> >>>> On May 17, 2016, at 10:29 AM, Johnson, Hans J >>>> wrote: >>>> >>>> >>>> >>>> This is not fixed in VXL upstream. >>>> >>>> >>>> >>>> There are currently no windows builds on VXL dashboard: >>>> https://open.cdash.org/index.php?project=vxl >>>> >>>> >>>> >>>> I don?t see any VS9 builds for ITK either. >>>> >>>> >>>> >>>> I?d be happy to help identify a solution, but I don?t have the VS >>>> resources. If you would like to have a hang out, I?d be interested in >>>> assisting with the fix. >>>> >>>> >>>> >>>> Hans >>>> >>>> >>>> >>>> -- >>>> >>>> >>>> >>>> >>>> >>>> From: Bradley Lowekamp >>>> Date: Tuesday, May 17, 2016 at 9:14 AM >>>> To: "insight-developers at itk.org" >>>> Cc: Hans Johnson >>>> Subject: ITK4.10rc1 SimpleITK VNL error >>>> >>>> >>>> >>>> Hello, >>>> >>>> >>>> >>>> On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am >>>> getting the following compilation error with VS9 2008[1]: >>>> >>>> >>>> >>>> 3>3>------ Build started: Project: itkv3p_netlib, Configuration: >>>> MinSizeRel x64 ------ >>>> >>>> 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 >>>> ------ >>>> >>>> 3>2>Compiling... >>>> >>>> 3>4>Compiling... >>>> >>>> 3>1>Compiling... >>>> >>>> 3>2>triangle.c >>>> >>>> 3>1>vcl_deprecated.cxx >>>> >>>> 3>4>FStream.cxx >>>> >>>> 3>3>Compiling... >>>> >>>> 3>3>v3p_netlib_init.c >>>> >>>> >>>> 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) >>>> : fatal error C1189: #error : "Missing definition for SHARED_PTR" >>>> >>>> >>>> >>>> Is this addressed in VNL upstream yet? or should I begin looking into it? >>>> >>>> >>>> >>>> Thanks, >>>> >>>> Brad >>>> >>>> >>>> >>>> >>>> >>>> [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Kitware offers ITK Training Courses, for more information visit: >>>> http://kitware.com/products/protraining.php >>>> >>>> Please keep messages on-topic and check the ITK FAQ at: >>>> http://www.itk.org/Wiki/ITK_FAQ >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://public.kitware.com/mailman/listinfo/insight-developers >>>> >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/insight-developers >>> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers > From blowekamp at mail.nih.gov Wed May 18 14:28:22 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Wed, 18 May 2016 18:28:22 +0000 Subject: [ITK-dev] ITK4.10rc1 SimpleITK VNL error In-Reply-To: References: <3FF9413D-8B06-4A57-A213-3A9E467233B6@mail.nih.gov> <1D0811FD-3C63-4F0E-A7EE-689F54CCA717@uiowa.edu> <77525D9D-3613-4E62-A4E6-C8EE33792676@mail.nih.gov> Message-ID: <856371F5-CAD5-42BB-A1EE-D039CF7DBEFA@mail.nih.gov> Awesome! Thank you! > On May 18, 2016, at 2:26 PM, Matt McCormick wrote: > > Thanks. This patch has been merged to the release branch. > > M > > On Wed, May 18, 2016 at 11:38 AM, Lowekamp, Bradley (NIH/NLM/LHC) [C] > wrote: >> The is an important one causing problem with SimpleITK and complaints with Slicer users too: >> >> https://github.com/vxl/vxl/pull/298 >> >> Brad >> >> >>> On May 18, 2016, at 11:34 AM, Matt McCormick wrote: >>> >>> There are a many enhancements in VXL master that have not been >>> sufficiently tested to merge for ITK 4.10 at this point in the release >>> cycle. >>> >>> This patch >>> >>> https://github.com/vxl/vxl/commit/ebd2d26bea536a669ce10a88ec21ff28bd659533 >>> >>> is a high risk. >>> >>> >>> If there are individual patches that are bug fixes or provide improved >>> compiler support, please let me know, and I will port them to the ITK >>> subtree for the 4.10 release. >>> >>> Thanks, >>> Matt >>> >>> On Wed, May 18, 2016 at 11:16 AM, D?enan Zuki? wrote: >>>> Hi Hans, >>>> >>>> Python support is included with default installation of VS2015. You just >>>> need to tick it when installing, or modifying your installation. Or were you >>>> asking about something different? >>>> >>>> Regards >>>> >>>> On Tue, May 17, 2016 at 11:07 AM, Johnson, Hans J >>>> wrote: >>>>> >>>>> Thanks Brad. Do you know if this version can be installed along side of >>>>> VS 2015 without conflicts? >>>>> >>>>> >>>>> >>>>> Hans >>>>> >>>>> -- >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> From: Bradley Lowekamp >>>>> Date: Tuesday, May 17, 2016 at 9:34 AM >>>>> To: Hans Johnson >>>>> Cc: "insight-developers at itk.org" >>>>> Subject: Re: ITK4.10rc1 SimpleITK VNL error >>>>> >>>>> >>>>> >>>>> Hans, >>>>> >>>>> >>>>> >>>>> I?ll take a look into it. Thanks for the offer for a hang out, well go >>>>> there if needed. >>>>> >>>>> >>>>> >>>>> I haven?t tries this my self, but there is the Free, VS for Python 2.7, >>>>> that is suppose to be based on VS9 2008[1]. I don?t know how this works with >>>>> general CMake project, but maybe it will help improve your access. >>>>> >>>>> >>>>> >>>>> Brad >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> [1] https://www.visualstudio.com/en-us/features/python-vs.aspx >>>>> >>>>> >>>>> >>>>> On May 17, 2016, at 10:29 AM, Johnson, Hans J >>>>> wrote: >>>>> >>>>> >>>>> >>>>> This is not fixed in VXL upstream. >>>>> >>>>> >>>>> >>>>> There are currently no windows builds on VXL dashboard: >>>>> https://open.cdash.org/index.php?project=vxl >>>>> >>>>> >>>>> >>>>> I don?t see any VS9 builds for ITK either. >>>>> >>>>> >>>>> >>>>> I?d be happy to help identify a solution, but I don?t have the VS >>>>> resources. If you would like to have a hang out, I?d be interested in >>>>> assisting with the fix. >>>>> >>>>> >>>>> >>>>> Hans >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> From: Bradley Lowekamp >>>>> Date: Tuesday, May 17, 2016 at 9:14 AM >>>>> To: "insight-developers at itk.org" >>>>> Cc: Hans Johnson >>>>> Subject: ITK4.10rc1 SimpleITK VNL error >>>>> >>>>> >>>>> >>>>> Hello, >>>>> >>>>> >>>>> >>>>> On the SimpleITK dashboard with SimpleITK compiled with ITK 4.10rc1 I am >>>>> getting the following compilation error with VS9 2008[1]: >>>>> >>>>> >>>>> >>>>> 3>3>------ Build started: Project: itkv3p_netlib, Configuration: >>>>> MinSizeRel x64 ------ >>>>> >>>>> 3>4>------ Build started: Project: itksys, Configuration: MinSizeRel x64 >>>>> ------ >>>>> >>>>> 3>2>Compiling... >>>>> >>>>> 3>4>Compiling... >>>>> >>>>> 3>1>Compiling... >>>>> >>>>> 3>2>triangle.c >>>>> >>>>> 3>1>vcl_deprecated.cxx >>>>> >>>>> 3>4>FStream.cxx >>>>> >>>>> 3>3>Compiling... >>>>> >>>>> 3>3>v3p_netlib_init.c >>>>> >>>>> >>>>> 3>1>c:\d\vs9\simpleitk-build\itk\modules\thirdparty\vnl\src\vxl\vcl\vcl_compiler.h(940) >>>>> : fatal error C1189: #error : "Missing definition for SHARED_PTR" >>>>> >>>>> >>>>> >>>>> Is this addressed in VNL upstream yet? or should I begin looking into it? >>>>> >>>>> >>>>> >>>>> Thanks, >>>>> >>>>> Brad >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> [1] https://open.cdash.org/viewBuildError.php?buildid=4368953 >>>>> >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Powered by www.kitware.com >>>>> >>>>> Visit other Kitware open-source projects at >>>>> http://www.kitware.com/opensource/opensource.html >>>>> >>>>> Kitware offers ITK Training Courses, for more information visit: >>>>> http://kitware.com/products/protraining.php >>>>> >>>>> Please keep messages on-topic and check the ITK FAQ at: >>>>> http://www.itk.org/Wiki/ITK_FAQ >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> http://public.kitware.com/mailman/listinfo/insight-developers >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Kitware offers ITK Training Courses, for more information visit: >>>> http://kitware.com/products/protraining.php >>>> >>>> Please keep messages on-topic and check the ITK FAQ at: >>>> http://www.itk.org/Wiki/ITK_FAQ >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://public.kitware.com/mailman/listinfo/insight-developers >>>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/insight-developers >> From matt.mccormick at kitware.com Wed May 18 14:28:38 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Wed, 18 May 2016 14:28:38 -0400 Subject: [ITK-dev] [ITK] SimpleITK update to ITK 4.10rc1 and VNL issues In-Reply-To: References: <1CB7DF80-F3A1-41BF-8E3D-6E1B90F3D5B3@mail.nih.gov> Message-ID: The patch submitted to upstream VXL has been backported to the ITK release branch. Thanks, Matt On Mon, May 16, 2016 at 11:38 AM, Matt McCormick wrote: > Hi Brad, > > Thanks for testing the RC! > > It looks like that system is running CMake 2.8.11.2. This issue was > addressed in upstream VXL here: > > https://github.com/vxl/vxl/commit/d7d6314fb9846b923a5e90e8f7f65b3ab28bfc8e > > for CMake 2.8.11, but it is evidently still present for CMake 2.8.11.2. > > Here is a patch: > > https://github.com/vxl/vxl/pull/296 > > I am looking at addressing some of the VNL warnings on the ITK > dashboard -- we will do a VXL Git subtree update soon. > > Thanks, > Matt > > On Mon, May 16, 2016 at 9:59 AM, Lowekamp, Bradley (NIH/NLM/LHC) [C] > wrote: >> Hans, >> >> I update SimpleITK next to use ITK 4.10rc1 and I am getting some CMake >> errors on the dashboard [1]: >> >> Target "itkvcl" INTERFACE_INCLUDE_DIRECTORIES property contains relative >> path: >> >> "include/ITK-4.10" >> >> >> Do you know if this is addressed in upstream VXL? Does it look familiar? Or >> should I take a dive into the issue? >> >> Thanks, >> Brad >> >> [1] https://open.cdash.org/viewBuildError.php?buildid=4367313 >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers >> >> _______________________________________________ >> Community mailing list >> Community at itk.org >> http://public.kitware.com/mailman/listinfo/community >> From matt.mccormick at kitware.com Thu May 19 14:14:06 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Thu, 19 May 2016 14:14:06 -0400 Subject: [ITK-dev] mug ITK Nightly non-zero return value in ctest Message-ID: Hi Dave, Thanks for submitting the ITK Windows Nightly. Sometime we are getting the opaque build error: *** WARNING non-zero return value in ctest from: C:\Program Files (x86)\CMake\bin\cmake.exe https://open.cdash.org/viewBuildError.php?type=1&buildid=4372761 Do you know what is happening with this build? Thanks, Matt From matt.mccormick at kitware.com Thu May 19 15:20:52 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Thu, 19 May 2016 15:20:52 -0400 Subject: [ITK-dev] [ANN] ITK 4.10 Release Candidate 2 is ready for testing! Message-ID: On behalf of the Insight Toolkit community, we are proud to announce that ITK 4.10 release candidate 2 has been tagged and is available for testing! Please take this opportunity to test the new features in the release candidate. To obtain the source code, git clone https://itk.org/ITK.git cd ITK git checkout -q --detach v4.10rc02 For more details, please see the Git documentation [1]. A few selected highlights for this release: * New Remote module: TwoProjectionRegistration performs simultaneous registration of two projection images to a 3D image volume, which is useful for external beam radiotherapy and other applications. It uses Powell?s method for optimization and the Siddon-Jacobs fast ray-tracing algorithm. * First update to internal VNL in five years. Many improvements were made to upstream VNL. We now push patches upstream and stay in sync via a Git subtree workflow. * Windows builds now support processing 4GB+ images by default * GDCM updated for better DICOM support Additionally, in the Python wrapping, type specification is no longer necessary during the creation of most filters. The required type is inferred from a primary input passed on filter creation. For example, instead of the explicit type specification: median = itk.MedianImageFilter[ImageType, ImageType].New() median.SetInput(reader.GetOutput()) It is now possible to call: median = itk.MedianImageFilter.New(Input=reader.GetOutput()) Or, the shortened: median = itk.MedianImageFilter.New(reader.GetOutput()) Or: median = itk.MedianImageFliter.New(reader) An itk.ImageFileReader can be created by specifying the FileName during instantiation: reader = itk.ImageFileReader.New(FileName=?inputFile.mha?) Please test the release candidate and share your experiences on the mailing list, issue tracker, and Gerrit Code Review. An Experimental build, which demonstrates how the test suite performs on your local build system, can be submitted to the dashboard [2] with: mkdir ../ITK-build cd ../ITK-build cmake ../ITK ctest -j 4 -M Experimental -T Configure -T Build -T Test -T Submit Visual Studio builds must also add ?-C Release? to the ctest command. Notify the mailing list if there are any unexpected failures. Testing your own applications against the RC is also appreciated. Congratulations to the 26 contributors to this release. We would especially like to recognize the new contributors: Andrey Fedorov, Sujin Philip, Francois Budin, and b'Alvaro Sanchez. The 4.10.0 final release is scheduled for the end of May. [1] http://www.itk.org/Wiki/ITK/Git [2] http://open.cdash.org/index.php?project=Insight New Features =========== * Wrapping improvements ---------------------------------------- * ITK_USE_64BITS_IDS supported on Windows * Faster builds (CastXML calls and build targets reduced by half) * Faster runtime loading and smaller binary size due to hidden symbol visibility * Wrapping with BUILD_SHARED_LIBS disabled is supported * Do not link to libpython when possible * Filter types do not need to be specified when ?Input=inputImage? is specified in the constructor * Improved wrapping class coverage * Visual Studio 2015 Update 2 Supported * New Remote Module ----------------------------------- * TwoProjectionRegistration * 2D-3D registration designed for radiotherapy * http://hdl.handle.net/10380/3245 * Core Improvements --------------------------------- * Data and build tool downloads now over HTTPS * Extended constexpr usage with ITK_CONSTEXPR and ITKCONSTEXPR_FUNC macros * ITK_USE_64BITS_IDS, required to process 4GB+ images on Windows, now enabled by default * VNL updated and modernized * CMake configuration major modernization * vcl has been removed in favor of the standard libraries * vnl_math_ function avoided in favor of std:: and itk::Math * VNL had suppressed integer data conversion warnings on Visual Studio (C4257); this suppression has been removed and all warnings addressed * Various improvements for building a module externally against an ITK build tree * CMAKE_POSITION_INDEPENDENT_CODE is enabled by default * Improved EXERCISE_BASIC_OBJECT_METHODS testing macro * Filtering Improvements --------------------------------------- * RGB pixel support added to itk::ImageToVTKImageFilter * itk::Box* filters moved out of the Review module * itk::GaussianDerivativeOperator moved out of the Review module * MaskLabel is deprecated in N4BiasFieldCorrectionFilter in favor any non-zero pixel * Registration Improvements ------------------------------------------- * Fixed and moving masks added to the v4 registration methods * Documentation Improvements -------------------------------------------------- * Updates to the Software Guide, Doxygen, Wiki and Sphinx Examples * Third Party Library Updates --------------------------------------------- * pygccxml updated to v1.7.3 * GDCM updated to the release branch latest * VNL updated to latest upstream * MINC updated to the latest upstream * SWIG updated to v3.0.8 * PCRE update to v8.38 * Improved code coverage -- we are at 85.0%! * *Lots* of important bug fixes * And much more! See details in the log below. Changes from v4.10rc01..v4.10rc02 ------------------------------------------------ Davis Vigneault (1): BUG: Improve error checking and testing for ConnectedRegionsMesh Hyun Jae Kang (2): BUG: Address the issue of "Missing Delete" within SwapZeroCornerToIRP. COMP: Fixed Mac OSX wrapping configuration warning Matthew McCormick (6): BUG: The ImageFileReader internal pipeline methods should be protected. BUG: Use new VNL include directory variables. COMP: Add missing NeighborhoodAccessor methods to PhasedArray3D image. BUG: Adjust itk.org ExternalData URL. COMP: Do not use target_include_directories with CMake 2.8.11.2. BUG: Address missing shared_ptr for VS9 Changes from v4.9.0..v4.10rc01 ------------------------------------------------ Alvaro Sanchez (1): STYLE: moved itkKappaSigmaThresholdImageFilter/Calculator from Nonunit/Review Andrey Fedorov (2): BUG: Add missing itk_expat_mangle.h install target BUG: fix typo in file name Bill Hoffman (2): COMP: fix shared build on Windows when Review is on. COMP: work around for VS 2015 optimizer bug causing test failures. Bill Lorensen (6): ENH: Bump version for style fixups. ENH: Bump wiki examples version, new remote module process ENH: Bump wiki examples version, new remote module process STYLE: SuperClass should be Superclass COMP: Resolve clang linkage issue BUG: Valgrind detected an invalid read Bradley Lowekamp (21): BUG: Compilation problem with GCC 4.1 and explicit instantiation ENH: Update Insight Journal handle links to https ENH: Adding const qualifier to results BUG: Adding missing const qualifier for GetConfusionMatrix method BUG: Use Set/GetMacros, fix const correctness and PrintSelf. ENH: added inlined Zero and one values for integer NumericTraits ENH: Use constexpr for floating point NumericTraits ENH: Make NumericTraits functions constexpr for intrinsic BUG: Add definition of static constexpr NumericTrait members BUG: Declared static constexpr members need to be defined as constexpr ENH: ITK_CONSTEXPR_FUNC implies inline BUG: Addressing VS10 and VS11 NumericTraits linkage issue BUG: Use LargestPossible region for BSpline domain BUG: Remove errant file COMP: Address warning about this usage in initializer list ENH: Prefer ZeroValue function over variable STYLE: Use consistent path for try_compiles binary directory BUG: Don't use "=" in cmake variable name ENH: Test address of NumericTraits One and Zero constexpr ENH: Use ITK_USE_64BITS_IDS for windows 64 by default ENH: Enable run-time dependency on Python library Davis Vigneault (4): ENH: Update itkFileTools to allow std::string arguments. ENH: Add Floored and Truncated Modulus to VNL ENH: Add Ternary Operator Image Filter STYLE: Prefer static cast D?enan Zuki? (1): ENH: CovariantVector's Normalize returns the norm. Francois Budin (6): PERF: Simplify itkTemplate New() input type identification. ENH: Avoid template type specification for image reader in Python wrapping BUG: Missing IOPixelType strings in ImageIOBase BUG: Wrapping intermediate files were not automatically updated ENH: Reduce number of dependencies for XML files generated for wrapping BUG: GCC is limited when calling overloaded base class functions GCC-XML Upstream (1): ENH: pygccxml v1.7.3 (reduced) GDCM Upstream (1): GDCM 2015-09-02 (1efe9e28) Hans Johnson (27): COMP: Static analysis warning COMP: Incorrect delete found by static analysis PERF: Avoid temporary std:vector copying. COMP: Provide VXL backward compatible includes COMP: ITK requires legacy methods ENH: Need propagate ITK_LIBRARY_PROPERTIES ENH: Added UpdateFromUpstream.sh for VNL ENH: Manual copy from vxl/master STYLE: vnl_math_[min|max] -> std::[min|max] STYLE: Text files should end with a newline COMP: Prefer C++11 constexpr when possible COMP: Prefer C++11 constexpr when possible ENH: Simplify std:: math function definitions COMP: Error in constexpr usage COMP: Add const to previous const variables COMP: SizeValueType can has different definition for itkArray ENH: Added utility for modernizing vcl_ to std:: ENH: Reference vnl_math.h constants directly ENH: Avoid using vnl_math_ functions COMP: Missing symbol for itkStaticConstMacro COMP: Function override missing in BioCell ENH: Convert vcl_ to std:: BUG: Windows vcl_snprintf failures addressed COMP: Disabmiguate function calls to SetData ENH: Provided static code API for external applications COMP: Remove possible type conversion warnings ENH: Merge GDCM release branch Hyun Jae Kang (25): COMP: Fixed the compiler error of ITKCommon2TestDriver on OSX 10.6 BUG: Fixed the runtime crash of VideoSourceTest on OSX 10.6 BUG: Fixed the runtime crash of itkTimeProbeTest2 BUG: Fixed the runtime crash of ITKFastMarchingTestDriver's tests on OSX 10.6 BUG: Fixed the runtime crash of ITKReviewTestDriver on OSX 10.6 COMP: Fixed the data conversion warning messages of itkResourceProbe BUG: Fixed the runtime crash of itkLabelOverlapMeasuresImageFilterTest BUG: Fixed the runtime crash of ITKStatisticsTestDriver tests on OSX 10.6 BUG: Fixed the runtime crash of itkMRIBiasFieldCorrectionFilterTest BUG: Fixed the runtime crash of itkBinaryShapeOpeningImageFilterTest1 BUG: Fixed the runtime crash of vnl_test_complex on OSX 10.6 BUG: Fixed the runtime crash of vnl_test_numeric_traits BUG: Fixed the runtime crash of test_pow_log on OSX 10.6 BUG: Exclude a test code of ITKLabelMapTestDriver on OSX 10.6 BUG: Fixed the failed test case of itkSTLThreadTest on OS X 10.8 COMP: Update KWStyle to utilize the latest boost library COMP: Fixed the compiler error of ITK on Mingw-w64 COMP: Temporarily suppress the warning messages of data-conversion on VS14 COMP: Put back the disappeared option of "BUILD EXAMPLES". BUG: Fix segmentation faults on mingw-W64 x86_64. BUG: Fix the failed test of itkCastImageFilterTest on mingw-w64 compiler. COMP: Fixed the cmake configuration for ITK_WRAP_DOC COMP: Fixed the warning messages on VS14. COMP: Add a missing head file at itkNumericTraitsStdVector.h COMP: Fix the wraning message of data-conversion Jean-Christophe Fillion-Robin (4): COMP: ITKExternalModule: Support building module without test directory. STYLE: Facilitate maintenance of CastXML generator refactoring CMakeLists COMP: Allow use of multiple "ITK external modules" in the same project. STYLE: UseITK: Document static registration of ITK IO factories. See #3393 Jon Haitz Legarreta (7): COMP: Delete unused variable compiler warning. ENH: Refactored itkBioCellTest ENH: Exercise non-tested itk::Math methods. ENH: Improve MersenneTwister class and test. ENH: Improve itkFEMLoadPoint coverage. ENH: Improve itkVersion class code coverage. ENH: Perform class name checks in test macro KWSys Robot (1): KWSys 2016-03-09 (36d8666f) Lucas Gandel (9): ENH: Implement GetNumberOfParameter() in ImageToSpatialObjectMetric COMP: Enable wrapping of multiple "ITK external modules" in the same project COMP: Fix CASTXML_EXECUTABLE value for multiple external module COMP: Fix external module testing COMP: Fix git protocol setup ENH: Conditionally add testing for External Modules BUG: Fix call to std::max() with different variable types Manuel Grizonnet (1): COMP: add ITKCommon_EXPORT to fix link issues with external applications Matthew McCormick (73): ENH: Add TwoProjectionRegistration Remote Module. ENH: Allow ITKVideoBridgeOpenCV to be built externally. COMP: Add export specification for itk::ResourceProbe. ENH: Do not force shared libraries when wrapping. BUG: BUILD_TESTING should be not advanced. ENH: Bump ITK version to 4.10.0. DOC: Correct ITKImageNoise description spelling. ENH: Wrap FFTNormalizedCorrelationImageFilter. BUG: Remove Azure ExternalData resource. BUG: ExternalData downloads from midas3.kitware.com only supports https. BUG: Update ExternalData resource. BUG: slicer.kitware.com/midas3/ ExternalData will not support http. ENH: Add ITK_CUSTOM_LIBRARY_SUFFIX variable. ENH: Wrap PipelineMonitorImageFilter. BUG: Update MIDAS url for https in archive testing data script. ENH: Wrap std::vector< itk::ImageRegion >. BUG: Fix wrapping build with DEFAULT_MODULES OFF. ENH: Add RGB pixel support to ImageToVTKImageFilter. ENH: Add RGB and vector pixel type wrapping for ImageToVTKImageFilter. STYLE: Use PixelType and ImageType in Python tests. ENH: Avoid template type specification in Python wrapping. COMP: Do not use has_key in itkTemplate New. DOC: Emphasize that push access is not required to contribute patches. ENH: Download SWIG and PCRE from midas3.kitware.com. COMP: Ignore build warning from KWStyle's boost. BUG: Remove Azure ExternalData resource. BUG: ExternalData downloads from midas3.kitware.com only supports https. BUG: slicer.kitware.com/midas3/ ExternalData will not support http. ENH: Update the VNL README-ITK.txt subtree commit revision. BUG: Mark VXL internal CMake variables as advanced. BUG: Run itk_module_target on itknetlib. DOC: Direct patches for VXL upstream to the GitHub repository. BUG: Run itk_module_target on itknetlib. COMP: Account for removal of vcl_* from upstream VXL. COMP: Remove itkTypeMacro from BioCellHelper. COMP: Convert itkBioCellTest arguments from double to int. COMP: Turn off BUILD_DOCUMENTATION for VNL. BUG: Install VXL config files to backwards-compatible locations. ENH: Remove vcl_complex from the wrapping. BUG: Install vnl_export.h and vnl_algo_export.h to previous locations. BUG: midas3.kitware.com only supports the https protocol. BUG: ImageIOBase SetDimensions should take SizeValueType. ENH: Add wrapping for ImagePCAShapeModelEstimator. COMP: Do not specify COMPONENTS with find_package(VTK. DOC: Fix FFTW warning grammar. COMP: Build against system HDF5 1.8.16. ENH: Set a default CMAKE_BUILD_TYPE when building a module externally COMP: Make initial HDF5 discovery of 1.8.16 quiet. ENH: Use hidden symbol visibility for the CPython extension modules. ENH: Turn on CMAKE_POSITION_INDEPENDENT_CODE by default. BUG: FEMLoadPoint uninitialized value in the constructor. BUG: Fix wrapping of complex types in VNL. ENH: Bump CMakeLists.txt version 4.9.1. COMP: Address ITKCommon Python submodule order. BUG: Extend ExternalData_TIMEOUT_ABSOLUTE to 900 seconds. BUG: Do not run KWStyle Git config on a release tarball. COMP: Ambiguous RGBPixel access in CustomColormapFunction. BUG: Prevent division by zero in PhasedArray3DSpecialCoordinatesImage. BUG: Initialize azimuth and elevation to pi/2 in PhasedArray3D. BUG: Increase MaskLabel backwards compatibility in N4 bias correction. ENH: Deprecate MaskLabel in N4BiasFieldCorrectionImageFilter. COMP: Update CastXML to support Visual Studio 2015 Update 2. COMP: Do not set wrapping library visibility with static builds. COMP: Update CastXML to support Visual Studio 2015 Update 2. COMP: Broaden the KWStyle warning exception. COMP: Update KWStyle version. BUG: Do not use the same output file in N4BiasField Test 2,3. COMP: Expand EXERCISE_BASIC_OBJECT_METHODS for other GCC versions. ENH: Update Cuberille Remote to 2015-05-01. ENH: Enable registration of the IOOpenSlide module through CMake. ENH: Update itk.org URL's for HTTPS support. BUG: Use CastXML built against LLVM with LLVM_ENABLE_TERMINFO OFF. BUG: Fix Python wrapping on Windows when ITK_USE_64BIT_IDS is ON. Michka Popoff (12): ENH: Use importlib for python 3.4 instead of imp ENH: Update to Swig 3.0.8 ENH: Update PCRE to version 8.38 ENH: Wrap RayCastInterpolateImageFunction ENH: Wrap RayCastInterpolateImageFunction COMP: Remove debug output after vcl_complex removal from wrapping ENH: Consolidate .idx file generation with swig .i generation. ENH: Update UpdatepygccxmlFromUpstream.sh script COMP: Set CastXML path and name for pygccxml 1.7.3 COMP: Fix RayCastInterpolateImageFunction wrapping for image dim 2 ENH: Use argparse instead of optparse in igenerator.py ENH: Use https URL for OS X castxml binary (for consistency) Nick Tustison (2): ENH: Add fixed/moving masking in reg. methods. ENH: Making the mask usage consistent with ITK. Pablo Hernandez-Cerdan (1): COMP: Fix warn in FFTW about delete []. Sean McBride (18): COMP: Made script OS X compatible COMP: mark GDCM GetSeriesHelper() method as deprecated BUG: update script to fetch GDCM from its release-2-4 branch instead of master DOC: Updated comment to reflect new GDCM version COMP: Fixed recently introduced build error with deprecated GDCM method BUG: Fixed invalid memory access found by ASan COMP: Fixed clang warning about macro expansion giving defined COMP: Fixed minor dashboards warnings and typos. COMP: Fixed a bunch of clang -Wunreachable-code-break warnings COMP: fixed some dashboard warnings (dead code, false positive) BUG: Fixed off-by-1 error found by ASan COMP: Fixed clang -Wcomma warning COMP: Introduce ITK_FALLTHROUGH, to suppress switch fall through warnings COMP: Fixed -Wwritable-strings warnings COMP: Fixed remaining -Wcomma warnings ENH: switch gdcm to release branch, not release-2-4 COMP: Hack HDF5 to build under ASan & UBSan COMP: fixed clang -Wdeprecated-writable-strings warning Shawn Waldon (1): STYLE: move itkGaussianDerivativeOperator Sujin Philip (1): STYLE: Move itkBox* Filters Sumedha Singla (3): ENH: Issue: ITK#3363 Replaced assignment in SetParameters function. ENH: Remove unnecessary const_cast BUG: Fixed the test itkHDF5ImageIOTest VXL Maintainers (9): VNL 2015-11-22 (ea1d60fb) VNL 2016-03-02 (cb31149e) VNL 2016-03-13 (ae34f0fc) VNL 2016-03-15 (751698ab) VNL 2016-03-19 (df10fefa) VNL 2016-03-25 (f0040231) VNL 2016-03-30 (88f50849) VNL 2016-04-22 (0ed18124) VNL 2016-04-26 (6b168535) Vladimir S. FONOV (3): MINC 2015-12-17 (dcb93a5f) MINC 2016-01-30 (783bca38) MINC 2016-02-24 (8632513e) Ziv Yaniv (1): BUG: Interpretation of the Euler angles ZYX or ZXY was not exported. ----------------------------------------------------- Errors or omissions? Please fix them here: https://docs.google.com/document/d/1n6xDC3phae7bH40OVO-QTECZ6gKRlPr1dwZR3fydzfU/edit From DLRdave at aol.com Fri May 20 10:29:33 2016 From: DLRdave at aol.com (David Cole) Date: Fri, 20 May 2016 10:29:33 -0400 Subject: [ITK-dev] mug ITK Nightly non-zero return value in ctest In-Reply-To: References: Message-ID: I do not know. There must be some sort of build error which ctest is not properly detecting. The log of the stderr shows only "Error(s) when building project": ElapsedTime='0' delta='0' context='EasyDashboardVariables-TopOfScript' ElapsedTime='0' delta='0' context='EasyDashboardVariables-BottomOfScript' ElapsedTime='0' delta='0' context='EasyDashboard-TopOfScript' ElapsedTime='0' delta='0' context='before CTEST_EMPTY_BINARY_DIRECTORY("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' ElapsedTime='49' delta='49' context='after CTEST_EMPTY_BINARY_DIRECTORY("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' ElapsedTime='49' delta='0' context='before CTEST_START("Nightly" )' ElapsedTime='49' delta='0' context='after CTEST_START("Nightly" )' ElapsedTime='49' delta='0' context='before CTEST_UPDATE("C:/n/r/ITK")' ElapsedTime='113' delta='64' context='after CTEST_UPDATE("C:/n/r/ITK")' ElapsedTime='113' delta='0' context='before CTEST_CONFIGURE("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' ElapsedTime='370' delta='257' context='after CTEST_CONFIGURE("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' ElapsedTime='370' delta='0' context='before CTEST_READ_CUSTOM_FILES("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' ElapsedTime='370' delta='0' context='after CTEST_READ_CUSTOM_FILES("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' BullseyeCoverage Build Enable/Disable 8.8.11 Windows License 9529 Copyright (c) Bullseye Testing Technology 1990-2014 ElapsedTime='370' delta='0' context='before CTEST_SUBMIT(PARTS;Notes;Update;Configure)' ElapsedTime='372' delta='2' context='after CTEST_SUBMIT(PARTS;Notes;Update;Configure)' ElapsedTime='372' delta='2' context='before CTEST_BUILD("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' Error(s) when building project ElapsedTime='615' delta='243' context='after CTEST_BUILD("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' ElapsedTime='615' delta='0' context='before CTEST_SUBMIT(PARTS;Build)' ElapsedTime='615' delta='0' context='after CTEST_SUBMIT(PARTS;Build)' ElapsedTime='615' delta='0' context='before CTEST_TEST("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release" PARALLEL_LEVEL;4)' Unable to find executable: C:/n/r/Nightly/ITK Win32-ninja-cl12-Release/bin/ITKImageNoiseTestDriver.exe Unable to find executable: C:/n/r/Nightly/ITK Win32-ninja-cl12-Release/bin/ITKImageNoiseTestDriver.exe ... thousands more lines like this ... I tried rebuilding manually, and got this error: [1894/3315] Linking CXX executable bin\ITKIOPNGTestDriver.exe FAILED: cmd.exe /C "cd . && "C:\Program Files (x86)\CMake\bin\cmake.exe" -E vs_link_exe C: \PROGRA~2\MICROS~2.0\VC\bin\link.exe /nologo Modules\IO\PNG\test\CMakeFiles\ITKIOPNGTestDr iver.dir\ITKIOPNGTestDriver.cxx.obj Modules\IO\PNG\test\CMakeFiles\ITKIOPNGTestDriver.dir\ itkPNGImageIOTest.cxx.obj Modules\IO\PNG\test\CMakeFiles\ITKIOPNGTestDriver.dir\itkPNGImag eIOTest2.cxx.obj /out:bin\ITKIOPNGTestDriver.exe /implib:lib\ITKIOPNGTestDriver.lib /pdb: bin\ITKIOPNGTestDriver.pdb /version:0.0 /machine:X86 /INCREMENTAL:NO /subsystem:console lib\ITKIOPNG-4.10.lib lib\ITKCommon-4.10.lib lib\itkdouble-conversion-4.10.lib lib\ITKIOB MP-4.10.lib lib\ITKIOGDCM-4.10.lib lib\ITKIOGIPL-4.10.lib lib\ITKIOImageBase-4.10.lib lib\ ITKIOJPEG-4.10.lib lib\ITKIOMeta-4.10.lib lib\ITKIONIFTI-4.10.lib lib\ITKIONRRD-4.10.lib l ib\ITKIOPNG-4.10.lib lib\ITKIOTIFF-4.10.lib lib\ITKIOVTK-4.10.lib lib\itksys-4.10.lib lib\ ITKCommon-4.10.lib lib\itkdouble-conversion-4.10.lib lib\ITKIOBMP-4.10.lib lib\ITKIOGDCM-4 .10.lib lib\ITKIOGIPL-4.10.lib lib\ITKIOImageBase-4.10.lib lib\ITKIOJPEG-4.10.lib lib\ITKI OMeta-4.10.lib lib\ITKIONIFTI-4.10.lib lib\ITKIONRRD-4.10.lib lib\ITKIOPNG-4.10.lib lib\IT KIOTIFF-4.10.lib lib\ITKIOVTK-4.10.lib lib\itksys-4.10.lib lib\itkpng-4.10.lib lib\itkgdcm MSFF-4.10.lib lib\itkgdcmDICT-4.10.lib lib\itkgdcmIOD-4.10.lib lib\itkgdcmDSED-4.10.lib li b\itkgdcmCommon-4.10.lib crypt32.lib lib\ITKEXPAT-4.10.lib lib\itkgdcmjpeg8-4.10.lib lib\i tkgdcmjpeg12-4.10.lib lib\itkgdcmjpeg16-4.10.lib lib\itkgdcmopenjpeg-4.10.lib lib\itkgdcmc harls-4.10.lib rpcrt4.lib lib\ITKMetaIO-4.10.lib comctl32.lib wsock32.lib lib\ITKniftiio-4 .10.lib lib\ITKznz-4.10.lib lib\ITKTransform-4.10.lib lib\ITKNrrdIO-4.10.lib lib\itktiff-4 .10.lib lib\itkzlib-4.10.lib lib\itkjpeg-4.10.lib lib\ITKIOImageBase-4.10.lib lib\ITKCommo n-4.10.lib lib\itkdouble-conversion-4.10.lib lib\itksys-4.10.lib ws2_32.lib Psapi.lib lib\ ITKVNLInstantiation-4.10.lib lib\itkvnl_algo-4.10.lib lib\itkvnl-4.10.lib lib\itkv3p_netli b-4.10.lib lib\itknetlib-4.10.lib lib\itkvcl-4.10.lib kernel32.lib user32.lib gdi32.lib wi nspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ." C:/Program Files (x86)/Windows Kits/8.1/bin/x86/mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "bin\ITKIOPNGTestDriver.exe". The syst em cannot open the device or file specified. MT failed. with 31 [1894/3315] Building CXX object Modules\IO\...AWTestDriver.dir\ITKIORAWTestDriver.cxx.obj ninja: build stopped: subcommand failed. HTH, David C. On Thu, May 19, 2016 at 2:14 PM, Matt McCormick wrote: > Hi Dave, > > Thanks for submitting the ITK Windows Nightly. Sometime we are > getting the opaque build error: > > *** WARNING non-zero return value in ctest from: C:\Program Files > (x86)\CMake\bin\cmake.exe > > https://open.cdash.org/viewBuildError.php?type=1&buildid=4372761 > > Do you know what is happening with this build? > > Thanks, > Matt From matt.mccormick at kitware.com Fri May 20 10:45:40 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Fri, 20 May 2016 10:45:40 -0400 Subject: [ITK-dev] mug ITK Nightly non-zero return value in ctest In-Reply-To: References: Message-ID: Thanks for the note. Anecdotally, I have also encountered this error: > C:/Program Files (x86)/Windows Kits/8.1/bin/x86/mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "bin\ITKIOPNGTestDriver.exe". The syst em cannot open the device or file specified. MT failed. when using ninja. I did not find the underlying cause, but I did find that using a different shell (Git Bash vs a shell within ConEmu) helped. A Google search identifies this behavior with anti-virus checker interference. Thanks, Matt On Fri, May 20, 2016 at 10:29 AM, David Cole wrote: > I do not know. There must be some sort of build error which ctest is > not properly detecting. > > The log of the stderr shows only "Error(s) when building project": > > ElapsedTime='0' delta='0' context='EasyDashboardVariables-TopOfScript' > ElapsedTime='0' delta='0' context='EasyDashboardVariables-BottomOfScript' > ElapsedTime='0' delta='0' context='EasyDashboard-TopOfScript' > ElapsedTime='0' delta='0' context='before > CTEST_EMPTY_BINARY_DIRECTORY("C:/n/r/Nightly/ITK > Win32-ninja-cl12-Release")' > ElapsedTime='49' delta='49' context='after > CTEST_EMPTY_BINARY_DIRECTORY("C:/n/r/Nightly/ITK > Win32-ninja-cl12-Release")' > ElapsedTime='49' delta='0' context='before CTEST_START("Nightly" )' > ElapsedTime='49' delta='0' context='after CTEST_START("Nightly" )' > ElapsedTime='49' delta='0' context='before CTEST_UPDATE("C:/n/r/ITK")' > ElapsedTime='113' delta='64' context='after CTEST_UPDATE("C:/n/r/ITK")' > ElapsedTime='113' delta='0' context='before > CTEST_CONFIGURE("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' > ElapsedTime='370' delta='257' context='after > CTEST_CONFIGURE("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' > ElapsedTime='370' delta='0' context='before > CTEST_READ_CUSTOM_FILES("C:/n/r/Nightly/ITK > Win32-ninja-cl12-Release")' > ElapsedTime='370' delta='0' context='after > CTEST_READ_CUSTOM_FILES("C:/n/r/Nightly/ITK > Win32-ninja-cl12-Release")' > BullseyeCoverage Build Enable/Disable 8.8.11 Windows License 9529 > > Copyright (c) Bullseye Testing Technology 1990-2014 > > ElapsedTime='370' delta='0' context='before > CTEST_SUBMIT(PARTS;Notes;Update;Configure)' > ElapsedTime='372' delta='2' context='after > CTEST_SUBMIT(PARTS;Notes;Update;Configure)' > ElapsedTime='372' delta='2' context='before > CTEST_BUILD("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' > Error(s) when building project > ElapsedTime='615' delta='243' context='after > CTEST_BUILD("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release")' > ElapsedTime='615' delta='0' context='before CTEST_SUBMIT(PARTS;Build)' > ElapsedTime='615' delta='0' context='after CTEST_SUBMIT(PARTS;Build)' > ElapsedTime='615' delta='0' context='before > CTEST_TEST("C:/n/r/Nightly/ITK Win32-ninja-cl12-Release" > PARALLEL_LEVEL;4)' > Unable to find executable: C:/n/r/Nightly/ITK > Win32-ninja-cl12-Release/bin/ITKImageNoiseTestDriver.exe > Unable to find executable: C:/n/r/Nightly/ITK > Win32-ninja-cl12-Release/bin/ITKImageNoiseTestDriver.exe > ... > thousands more lines like this > ... > > > I tried rebuilding manually, and got this error: > > [1894/3315] Linking CXX executable bin\ITKIOPNGTestDriver.exe > FAILED: cmd.exe /C "cd . && "C:\Program Files > (x86)\CMake\bin\cmake.exe" -E vs_link_exe C: > \PROGRA~2\MICROS~2.0\VC\bin\link.exe /nologo > Modules\IO\PNG\test\CMakeFiles\ITKIOPNGTestDr > iver.dir\ITKIOPNGTestDriver.cxx.obj > Modules\IO\PNG\test\CMakeFiles\ITKIOPNGTestDriver.dir\ > itkPNGImageIOTest.cxx.obj > Modules\IO\PNG\test\CMakeFiles\ITKIOPNGTestDriver.dir\itkPNGImag > eIOTest2.cxx.obj /out:bin\ITKIOPNGTestDriver.exe > /implib:lib\ITKIOPNGTestDriver.lib /pdb: > bin\ITKIOPNGTestDriver.pdb /version:0.0 /machine:X86 /INCREMENTAL:NO > /subsystem:console > lib\ITKIOPNG-4.10.lib lib\ITKCommon-4.10.lib > lib\itkdouble-conversion-4.10.lib lib\ITKIOB > MP-4.10.lib lib\ITKIOGDCM-4.10.lib lib\ITKIOGIPL-4.10.lib > lib\ITKIOImageBase-4.10.lib lib\ > ITKIOJPEG-4.10.lib lib\ITKIOMeta-4.10.lib lib\ITKIONIFTI-4.10.lib > lib\ITKIONRRD-4.10.lib l > ib\ITKIOPNG-4.10.lib lib\ITKIOTIFF-4.10.lib lib\ITKIOVTK-4.10.lib > lib\itksys-4.10.lib lib\ > ITKCommon-4.10.lib lib\itkdouble-conversion-4.10.lib > lib\ITKIOBMP-4.10.lib lib\ITKIOGDCM-4 > .10.lib lib\ITKIOGIPL-4.10.lib lib\ITKIOImageBase-4.10.lib > lib\ITKIOJPEG-4.10.lib lib\ITKI > OMeta-4.10.lib lib\ITKIONIFTI-4.10.lib lib\ITKIONRRD-4.10.lib > lib\ITKIOPNG-4.10.lib lib\IT > KIOTIFF-4.10.lib lib\ITKIOVTK-4.10.lib lib\itksys-4.10.lib > lib\itkpng-4.10.lib lib\itkgdcm > MSFF-4.10.lib lib\itkgdcmDICT-4.10.lib lib\itkgdcmIOD-4.10.lib > lib\itkgdcmDSED-4.10.lib li > b\itkgdcmCommon-4.10.lib crypt32.lib lib\ITKEXPAT-4.10.lib > lib\itkgdcmjpeg8-4.10.lib lib\i > tkgdcmjpeg12-4.10.lib lib\itkgdcmjpeg16-4.10.lib > lib\itkgdcmopenjpeg-4.10.lib lib\itkgdcmc > harls-4.10.lib rpcrt4.lib lib\ITKMetaIO-4.10.lib comctl32.lib > wsock32.lib lib\ITKniftiio-4 > .10.lib lib\ITKznz-4.10.lib lib\ITKTransform-4.10.lib > lib\ITKNrrdIO-4.10.lib lib\itktiff-4 > .10.lib lib\itkzlib-4.10.lib lib\itkjpeg-4.10.lib > lib\ITKIOImageBase-4.10.lib lib\ITKCommo > n-4.10.lib lib\itkdouble-conversion-4.10.lib lib\itksys-4.10.lib > ws2_32.lib Psapi.lib lib\ > ITKVNLInstantiation-4.10.lib lib\itkvnl_algo-4.10.lib > lib\itkvnl-4.10.lib lib\itkv3p_netli > b-4.10.lib lib\itknetlib-4.10.lib lib\itkvcl-4.10.lib kernel32.lib > user32.lib gdi32.lib wi > nspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib > advapi32.lib && cd ." > > C:/Program Files (x86)/Windows Kits/8.1/bin/x86/mt.exe : general error > c101008d: Failed to > write the updated manifest to the resource of file > "bin\ITKIOPNGTestDriver.exe". The syst > em cannot open the device or file specified. > MT failed. with 31 > [1894/3315] Building CXX object > Modules\IO\...AWTestDriver.dir\ITKIORAWTestDriver.cxx.obj > ninja: build stopped: subcommand failed. > > > HTH, > David C. > > > On Thu, May 19, 2016 at 2:14 PM, Matt McCormick > wrote: >> Hi Dave, >> >> Thanks for submitting the ITK Windows Nightly. Sometime we are >> getting the opaque build error: >> >> *** WARNING non-zero return value in ctest from: C:\Program Files >> (x86)\CMake\bin\cmake.exe >> >> https://open.cdash.org/viewBuildError.php?type=1&buildid=4372761 >> >> Do you know what is happening with this build? >> >> Thanks, >> Matt From blowekamp at mail.nih.gov Fri May 20 14:13:12 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Fri, 20 May 2016 18:13:12 +0000 Subject: [ITK-dev] ITKv4.10rc2 - Why are there so many new CMake variable? Message-ID: I am now getting a whole bunch of X11 related CMake variables in the advanced configuration of CMake. These are very annoying and not useful. There also seems to be a bunch of other VXL related variables, that didn?t use to be there. Brad From matt.mccormick at kitware.com Mon May 23 13:43:23 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Mon, 23 May 2016 13:43:23 -0400 Subject: [ITK-dev] ITKv4.10rc2 - Why are there so many new CMake variable? In-Reply-To: References: Message-ID: Hi, I looked into this and I found two places that find_package(X11) are called. The first one is in a netlib example, which could easily be disabled: https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/examples/CMakeLists.txt#L7 The second, though, is in GDCM's OpenJPEG: https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/GDCM/src/gdcm/Utilities/gdcmopenjpeg-v2/CMakeLists.txt#L76 https://github.com/Kitware/CMake/blob/c75d91a05c9f442582726e3e80fec41d016da76f/Modules/CMakeBackwardCompatibilityC.cmake#L52 This would have to be changed to only perform the checks it needs. The reduced try_compile checks could also reduce initial configuration time. Thanks, Matt On Fri, May 20, 2016 at 2:13 PM, Lowekamp, Bradley (NIH/NLM/LHC) [C] wrote: > I am now getting a whole bunch of X11 related CMake variables in the advanced configuration of CMake. These are very annoying and not useful. There also seems to be a bunch of other VXL related variables, that didn?t use to be there. > > Brad > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers From blowekamp at mail.nih.gov Mon May 23 13:55:33 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Mon, 23 May 2016 17:55:33 +0000 Subject: [ITK-dev] ITKv4.10rc2 - Why are there so many new CMake variable? In-Reply-To: References: Message-ID: <6259C2E3-6972-4367-A020-84845549BE6A@mail.nih.gov> Matt, Great thanks for digging into this! Based on some other CMake variables popping up, are we enabling VNL testing and examples [1]? Perhaps examples for VNL should be turned off [2]? I think we have always run VNL testings though. Brad [1] https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeLists.txt#L441-L447 [2] https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/CMakeLists.txt#L19 > On May 23, 2016, at 1:43 PM, Matt McCormick wrote: > > Hi, > > I looked into this and I found two places that find_package(X11) are called. > > The first one is in a netlib example, which could easily be disabled: > > https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/examples/CMakeLists.txt#L7 > > The second, though, is in GDCM's OpenJPEG: > > https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/GDCM/src/gdcm/Utilities/gdcmopenjpeg-v2/CMakeLists.txt#L76 > https://github.com/Kitware/CMake/blob/c75d91a05c9f442582726e3e80fec41d016da76f/Modules/CMakeBackwardCompatibilityC.cmake#L52 > > This would have to be changed to only perform the checks it needs. > The reduced try_compile checks could also reduce initial configuration > time. > > Thanks, > Matt > > On Fri, May 20, 2016 at 2:13 PM, Lowekamp, Bradley (NIH/NLM/LHC) [C] > wrote: >> I am now getting a whole bunch of X11 related CMake variables in the advanced configuration of CMake. These are very annoying and not useful. There also seems to be a bunch of other VXL related variables, that didn?t use to be there. >> >> Brad >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers From matt.mccormick at kitware.com Mon May 23 13:55:15 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Mon, 23 May 2016 13:55:15 -0400 Subject: [ITK-dev] ITKv4.10rc2 - Why are there so many new CMake variable? In-Reply-To: References: Message-ID: I created an issue to track this: https://issues.itk.org/jira/browse/ITK-3433 On Mon, May 23, 2016 at 1:43 PM, Matt McCormick wrote: > Hi, > > I looked into this and I found two places that find_package(X11) are called. > > The first one is in a netlib example, which could easily be disabled: > > https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/examples/CMakeLists.txt#L7 > > The second, though, is in GDCM's OpenJPEG: > > https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/GDCM/src/gdcm/Utilities/gdcmopenjpeg-v2/CMakeLists.txt#L76 > https://github.com/Kitware/CMake/blob/c75d91a05c9f442582726e3e80fec41d016da76f/Modules/CMakeBackwardCompatibilityC.cmake#L52 > > This would have to be changed to only perform the checks it needs. > The reduced try_compile checks could also reduce initial configuration > time. > > Thanks, > Matt > > On Fri, May 20, 2016 at 2:13 PM, Lowekamp, Bradley (NIH/NLM/LHC) [C] > wrote: >> I am now getting a whole bunch of X11 related CMake variables in the advanced configuration of CMake. These are very annoying and not useful. There also seems to be a bunch of other VXL related variables, that didn?t use to be there. >> >> Brad >> >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers From matt.mccormick at kitware.com Mon May 23 14:03:17 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Mon, 23 May 2016 14:03:17 -0400 Subject: [ITK-dev] ITKv4.10rc2 - Why are there so many new CMake variable? In-Reply-To: <6259C2E3-6972-4367-A020-84845549BE6A@mail.nih.gov> References: <6259C2E3-6972-4367-A020-84845549BE6A@mail.nih.gov> Message-ID: Good idea. Added here: http://review.source.kitware.com/#/c/21155/ On Mon, May 23, 2016 at 1:55 PM, Lowekamp, Bradley (NIH/NLM/LHC) [C] wrote: > Matt, > > Great thanks for digging into this! > > Based on some other CMake variables popping up, are we enabling VNL testing and examples [1]? > > Perhaps examples for VNL should be turned off [2]? I think we have always run VNL testings though. > > Brad > > [1] https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/CMakeLists.txt#L441-L447 > [2] https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/CMakeLists.txt#L19 > >> On May 23, 2016, at 1:43 PM, Matt McCormick wrote: >> >> Hi, >> >> I looked into this and I found two places that find_package(X11) are called. >> >> The first one is in a netlib example, which could easily be disabled: >> >> https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/examples/CMakeLists.txt#L7 >> >> The second, though, is in GDCM's OpenJPEG: >> >> https://github.com/InsightSoftwareConsortium/ITK/blob/2e04f1da5984be79ef1eb6c3ac6f3a905a0f709a/Modules/ThirdParty/GDCM/src/gdcm/Utilities/gdcmopenjpeg-v2/CMakeLists.txt#L76 >> https://github.com/Kitware/CMake/blob/c75d91a05c9f442582726e3e80fec41d016da76f/Modules/CMakeBackwardCompatibilityC.cmake#L52 >> >> This would have to be changed to only perform the checks it needs. >> The reduced try_compile checks could also reduce initial configuration >> time. >> >> Thanks, >> Matt >> >> On Fri, May 20, 2016 at 2:13 PM, Lowekamp, Bradley (NIH/NLM/LHC) [C] >> wrote: >>> I am now getting a whole bunch of X11 related CMake variables in the advanced configuration of CMake. These are very annoying and not useful. There also seems to be a bunch of other VXL related variables, that didn?t use to be there. >>> >>> Brad >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/insight-developers > From matt.mccormick at kitware.com Mon May 23 19:21:39 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Mon, 23 May 2016 19:21:39 -0400 Subject: [ITK-dev] installed ITK cannot be moved due to absolute path In-Reply-To: References: Message-ID: Hi Rashad, It looks like MXE is configured to use system versions of EXPAT, HDF5, JPEG, PNG, TIFF, and ZLIB: https://github.com/mxe/mxe/blob/4135f9b1227ba56b92ceb8a982016370ad5c8894/src/itk.mk#L28-L33 USE_SYSTEM could be disabled for these libraries. Or, it may be possible for the module system to learn relative locations of these libraries with ITK_USE_SYSTEM*. But, it would work best if these projects were configured with CMake, create a Config.cmake or -config.cmake file, and use relative paths internally. HTH, Matt On Tue, May 10, 2016 at 5:25 PM, Rashad Kanavath wrote: > > > On Tue, May 10, 2016 at 10:50 PM, D?enan Zuki? wrote: >> >> Hi Rashad, >> >> a few months ago relative paths were completely removed from CMake, >> because they were never fully implemented. Have you followed recommendations >> from here for cross-compiling? > > > Yes. indeed. I had updated the mxe/src/itk.mk for several versions of ITK! > > Regarding relative path in cmake, I don't understand. I didn't use cmake > specific REL_PATH. >> >> >> As for integrating your changes into ITK, you should submit a patch >> following the instructions here. If your changes don't break anything, they >> are likely to be integrated. > > > issue here is a bit different. For all libitk* stuff the story ends well. > For thirdparties, zlib, expat etc.. it is good idea to put the full path > because we don't know if they are in same install directory as ITK or not. > But this make the installed cmake modules non-portable even to a different > location on the same disk. > > Now if anyone want to provide a distributable setup of ITK. patch the > generated cmake files with sed and then copy it. This is what I am doing > right now! > A simple not perfect solution is to have all thirdparties make > _PREFIX variable inside the ITKConfig.cmake > > and for each library we use _PREFIX/include and > _PREFIX/lib > > > Another option is to avoid full path directly inside cmake module files and > put find_package() calls in the install tree. > > As these files are autogenerated by cmake, don't know what is possible. > > > > > >> >> Regards, >> D?enan >> >> On Mon, May 9, 2016 at 4:27 PM, Rashad Kanavath >> wrote: >>> >>> Hello all, >>> >>> I have some issue when copying ITK install directory to a different >>> system. I agree this is not usual and may not appear on a linux distro or >>> windows. >>> >>> My requirement is bit different. I cross-compile ITK and then use the >>> binaries on Windows. Using dll and headers are fine. But the installed cmake >>> files are a problem. They have absolute path in ITK-4.8/Modules/*.cmake >>> files. It is not in all .cmake files even though I put a wildcard there.. >>> >>> For a easy and quick workaround. I rely on mighty sed command to insert >>> something into installed cmake file. >>> >>> For example see this; >>> lib/cmake/ITK-4.8/ITKTargets-release.cmake >>> >>> set(CMAKE_IMPORT_FILE_VERSION 1) >>> set(LIB_INSTALL_PREFIX) >>> get_filename_component(CURRENT_FILE_DIR "${CMAKE_CURRENT_LIST_FILE}" >>> PATH) >>> get_filename_component(LIB_INSTALL_PREFIX "${CURRENT_FILE_DIR}" PATH) >>> get_filename_component(LIB_INSTALL_PREFIX "${LIB_INSTALL_PREFIX}" PATH) >>> get_filename_component(LIB_INSTALL_PREFIX "${LIB_INSTALL_PREFIX}" PATH) >>> >>> and at last: >>> >>> $(SED) -i 's,$(PREFIX)/$(TARGET),\${LIB_INSTALL_PREFIX},g' >>> 'lib/cmake/ITK-$(ITK_VER)/ITKTargets-release.cmake' >>> >>> I would like to have this patch inside the other .cmake files in the >>> installation and avoid the sed commands during post-installation >>> >>> Here is the list of cmake files that needs this change. >>> lib/cmake/ITK-4.8/ITKTargets-release.cmake >>> lib/cmake/ITK-4.8/Modules/ITKZLIB.cmake >>> lib/cmake/ITK-4.8/Modules/ITKExpat.cmake >>> lib/cmake/ITK-4.8/Modules/ITKHDF5.cmake >>> lib/cmake/ITK-4.8/Modules/ITKJPEG.cmake >>> lib/cmake/ITK-4.8/Modules/ITKTIFF.cmake >>> lib/cmake/ITK-4.8/Modules/ITKPNG.cmake >>> >>> So is it possible to make the change into future version of ITK? >>> >>> The major issue here is those cmake files are generated by cmake. Is >>> there a way cmake could use relative path ? >>> >>> >>> -- >>> Regards, >>> Rashad >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/insight-developers >>> >> > > > > -- > Regards, > Rashad > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > From M.Staring at lumc.nl Tue May 24 10:55:39 2016 From: M.Staring at lumc.nl (M.Staring at lumc.nl) Date: Tue, 24 May 2016 14:55:39 +0000 Subject: [ITK-dev] imagefilereader Message-ID: <24D8AA23EC0DCB4498C35EC60401E76144000AD9@MAIL-MB02.lumcnet.prod.intern> Hi Matt, This change: https://itk.org/gitweb?p=ITK.git;a=commitdiff;h=3e1d822985b9eb3548e4fb9891f6773452467a81 is breaking our code where we rely on the availability of the GenerateOutputInformation() function to read image info while avoiding to read the actual data. We use that information to select the correct reader from a list of instantiated readers. I had a look, and indeed in the base class (ProcessObject) this function is protected, so I guess it qualifies as a bug that GenerateOutputInformation() was public previously. This change does break backward compatibility however. Do you have a suggestion on how to fix this? I really would like to have functionality in the image readers that read the meta data only, and not the data itself. Thanks for your advice, Marius Marius Staring, PhD Division of Image Processing (LKEB) Department of Radiology Leiden University Medical Center PO Box 9600, 2300 RC Leiden, The Netherlands phone: +31 (0)71 52 62137, fax: +31 (0)71 524 8256 m.staring at lumc.nl -------------- next part -------------- An HTML attachment was scrubbed... URL: From blowekamp at mail.nih.gov Tue May 24 11:29:27 2016 From: blowekamp at mail.nih.gov (Lowekamp, Bradley (NIH/NLM/LHC) [C]) Date: Tue, 24 May 2016 15:29:27 +0000 Subject: [ITK-dev] [ITK] imagefilereader In-Reply-To: <24D8AA23EC0DCB4498C35EC60401E76144000AD9@MAIL-MB02.lumcnet.prod.intern> References: <24D8AA23EC0DCB4498C35EC60401E76144000AD9@MAIL-MB02.lumcnet.prod.intern> Message-ID: Hello Marius, The commit you linked to has the simple change needed: - reader->GenerateOutputInformation(); + reader->UpdateOutputInformation(); HTH, Brad On May 24, 2016, at 10:55 AM, M.Staring at lumc.nl wrote: Hi Matt, This change: https://itk.org/gitweb?p=ITK.git;a=commitdiff;h=3e1d822985b9eb3548e4fb9891f6773452467a81 is breaking our code where we rely on the availability of the GenerateOutputInformation() function to read image info while avoiding to read the actual data. We use that information to select the correct reader from a list of instantiated readers. I had a look, and indeed in the base class (ProcessObject) this function is protected, so I guess it qualifies as a bug that GenerateOutputInformation() was public previously. This change does break backward compatibility however. Do you have a suggestion on how to fix this? I really would like to have functionality in the image readers that read the meta data only, and not the data itself. Thanks for your advice, Marius Marius Staring, PhD Division of Image Processing (LKEB) Department of Radiology Leiden University Medical Center PO Box 9600, 2300 RC Leiden, The Netherlands phone: +31 (0)71 52 62137, fax: +31 (0)71 524 8256 m.staring at lumc.nl _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers _______________________________________________ Community mailing list Community at itk.org http://public.kitware.com/mailman/listinfo/community -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Tue May 24 12:18:15 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 24 May 2016 12:18:15 -0400 Subject: [ITK-dev] [ITK] imagefilereader In-Reply-To: References: <24D8AA23EC0DCB4498C35EC60401E76144000AD9@MAIL-MB02.lumcnet.prod.intern> Message-ID: Without looking at the code, are you saying that a customer has to change their application from: reader->GenerateOutputInformation(); to reader->UpdateOutputInformation(); Why? On Tue, May 24, 2016 at 11:29 AM, Lowekamp, Bradley (NIH/NLM/LHC) [C] wrote: > Hello Marius, > > The commit you linked to has the simple change needed: > > - reader->GenerateOutputInformation(); > + reader->UpdateOutputInformation(); > > > HTH, > Brad > > On May 24, 2016, at 10:55 AM, M.Staring at lumc.nl wrote: > > Hi Matt, > > This change: > https://itk.org/gitweb?p=ITK.git;a=commitdiff;h=3e1d822985b9eb3548e4fb9891f6773452467a81 > is breaking our code where we rely on the availability of the > GenerateOutputInformation() function to read image info while avoiding to > read the actual data. We use that information to select the correct reader > from a list of instantiated readers. > > I had a look, and indeed in the base class (ProcessObject) this function is > protected, so I guess it qualifies as a bug that GenerateOutputInformation() > was public previously. This change does break backward compatibility > however. > > Do you have a suggestion on how to fix this? I really would like to have > functionality in the image readers that read the meta data only, and not the > data itself. > > Thanks for your advice, > Marius > > Marius Staring, PhD > Division of Image Processing (LKEB) > Department of Radiology > Leiden University Medical Center > PO Box 9600, 2300 RC Leiden, The Netherlands > phone: +31 (0)71 52 62137, fax: +31 (0)71 524 8256 m.staring at lumc.nl > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > _______________________________________________ > Community mailing list > Community at itk.org > http://public.kitware.com/mailman/listinfo/community > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > -- Unpaid intern in BillsBasement at noware dot com From matt.mccormick at kitware.com Tue May 24 14:06:49 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Tue, 24 May 2016 14:06:49 -0400 Subject: [ITK-dev] [ITK] imagefilereader In-Reply-To: References: <24D8AA23EC0DCB4498C35EC60401E76144000AD9@MAIL-MB02.lumcnet.prod.intern> Message-ID: On Tue, May 24, 2016 at 12:18 PM, Bill Lorensen wrote: > Without looking at the code, are you saying that a customer has to > change their application from: > > reader->GenerateOutputInformation(); > > to > > reader->UpdateOutputInformation(); Yes. UpdateOutputInformation() is the public method that a user wants to call. GenerateOutputInformation() is a protected member that the algorithm implemented defines. > Why? GeneratedOutputInformation() gets called when UpdateOutputInformation() gets called. It is possible that GenerateOutputInformation() will not generate the correct output information; unlike UpdateOutputInformation(), it does not ensure that the inputs that it is generating its output information from have been updated. Thanks, Matt From bill.lorensen at gmail.com Tue May 24 14:19:26 2016 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 24 May 2016 14:19:26 -0400 Subject: [ITK-dev] [ITK] imagefilereader In-Reply-To: References: <24D8AA23EC0DCB4498C35EC60401E76144000AD9@MAIL-MB02.lumcnet.prod.intern> Message-ID: How would a customer know about this? Maybe we should warn with a deprecated message first? Something like: GenerateOutputInformation will be protected in release x.x. Change GenerateOutputInformation to UpdateOutputInformation. On Tue, May 24, 2016 at 2:06 PM, Matt McCormick wrote: > On Tue, May 24, 2016 at 12:18 PM, Bill Lorensen wrote: >> Without looking at the code, are you saying that a customer has to >> change their application from: >> >> reader->GenerateOutputInformation(); >> >> to >> >> reader->UpdateOutputInformation(); > > Yes. UpdateOutputInformation() is the public method that a user wants > to call. GenerateOutputInformation() is a protected member that the > algorithm implemented defines. > > >> Why? > > GeneratedOutputInformation() gets called when > UpdateOutputInformation() gets called. It is possible that > GenerateOutputInformation() will not generate the correct output > information; unlike UpdateOutputInformation(), it does not ensure that > the inputs that it is generating its output information from have been > updated. > > > Thanks, > Matt -- Unpaid intern in BillsBasement at noware dot com From matt.mccormick at kitware.com Tue May 24 14:48:34 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Tue, 24 May 2016 14:48:34 -0400 Subject: [ITK-dev] [ITK] imagefilereader In-Reply-To: References: <24D8AA23EC0DCB4498C35EC60401E76144000AD9@MAIL-MB02.lumcnet.prod.intern> Message-ID: On Tue, May 24, 2016 at 2:19 PM, Bill Lorensen wrote: > How would a customer know about this? Maybe we should warn with a > deprecated message first? Something like: > GenerateOutputInformation will be protected in release x.x. Change > GenerateOutputInformation to UpdateOutputInformation. This is a good idea, but I do not know a way it can be implemented. From M.Staring at lumc.nl Wed May 25 05:51:43 2016 From: M.Staring at lumc.nl (M.Staring at lumc.nl) Date: Wed, 25 May 2016 09:51:43 +0000 Subject: [ITK-dev] [ITK] imagefilereader In-Reply-To: References: <24D8AA23EC0DCB4498C35EC60401E76144000AD9@MAIL-MB02.lumcnet.prod.intern> Message-ID: <24D8AA23EC0DCB4498C35EC60401E76144000BBE@MAIL-MB02.lumcnet.prod.intern> Thanks for the feedback, we will change our code to use UpdateOutputInformation() Best, Marius > -----Original Message----- > From: Insight-developers [mailto:insight-developers-bounces at itk.org] On > Behalf Of Matt McCormick > Sent: dinsdag 24 mei 2016 20:49 > To: Bill Lorensen > Cc: insight-developers at itk.org; Shamonin, D.P. (LKEB) > Subject: Re: [ITK-dev] [ITK] imagefilereader > > On Tue, May 24, 2016 at 2:19 PM, Bill Lorensen > wrote: > > How would a customer know about this? Maybe we should warn with a > > deprecated message first? Something like: > > GenerateOutputInformation will be protected in release x.x. Change > > GenerateOutputInformation to UpdateOutputInformation. > > This is a good idea, but I do not know a way it can be implemented. > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers From matt.mccormick at kitware.com Wed May 25 15:47:56 2016 From: matt.mccormick at kitware.com (Matt McCormick) Date: Wed, 25 May 2016 15:47:56 -0400 Subject: [ITK-dev] Merging for ITK 4.10.1 and ITK 4.11.0 Message-ID: Hi folks, After cleaning up the dashboard and addressing remaining issues for the release, the v4.10.0 tag has been added to the Git repository! Following an amazing surge in community contributions over the last week, we have quite the queue in Gerrit ready to be merged to master. Let's merge them in stages so it is easier to catch the source of any issues that may arise on the Nightly builds. I merged ten for today. Thanks, Matt