[ITK-dev] New Defects reported by Coverity Scan for InsightSoftwareConsortium

[Bradley Lowekamp]

Matt,

This defect looks legitimate. I added the noexept specifier here[1].

My guess is that  Coverity has just added this feature for C++11.

I'll dig into this and help to ensure out destructors have better exception safety...

Brad

[1] https://github.com/InsightSoftwareConsortium/ITK/commit/06f8ef0175d901ec5d23197efb4f9044c1b62ab3

On Sep 14, 2015, at 12:30 PM, Matt McCormick <matt.mccormick at kitware.com> wrote:

> Hello,
> 
> Does the new Coverity defect below ring a bell with anyone?
> 
> Thanks,
> Matt
> 
> 
> ---------- Forwarded message ----------
> From:  <scan-admin at coverity.com>
> Date: Sat, Sep 12, 2015 at 3:05 AM
> Subject: New Defects reported by Coverity Scan for InsightSoftwareConsortium
> To: matt.mccormick at kitware.com
> 
> 
> 
> Hi,
> 
> Please find the latest report on new defect(s) introduced to
> InsightSoftwareConsortium found with Coverity Scan.
> 
> 1 new defect(s) introduced to InsightSoftwareConsortium found with
> Coverity Scan.
> 395 defect(s), reported by Coverity Scan earlier, were marked fixed in
> the recent build analyzed by Coverity Scan.
> 
> New defect(s) Reported-by: Coverity Scan
> Showing 1 of 1 defect(s)
> 
> 
> ** CID 1323843:  Error handling issues  (UNCAUGHT_EXCEPT)
> /home/kitware/Dashboards/Coverity/ITK/Modules/Core/Common/src/itkObject.cxx:
> 412 in itk::Object::UnRegister() const()
> 
> 
> ________________________________________________________________________________________________________
> *** CID 1323843:  Error handling issues  (UNCAUGHT_EXCEPT)
> /home/kitware/Dashboards/Coverity/ITK/Modules/Core/Common/src/itkObject.cxx:
> 412 in itk::Object::UnRegister() const()
> 406
> 407     /**
> 408      * Decrease the reference count (release by another object).
> 409      */
> 410     void
> 411     Object
>>>>    CID 1323843:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>>    An exception of type "itk::ExceptionObject" is thrown but the throw list "throw ()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
> 412     ::UnRegister() const ITK_NOEXCEPT
> 413     {
> 414       // call the parent
> 415       itkDebugMacro( << "UnRegistered, "
> 416                      << "ReferenceCount = " << ( m_ReferenceCount - 1 ) );
> 417
> 
> 
> ________________________________________________________________________________________________________
> To view the defects in Coverity Scan visit,
> https://scan.coverity.com/projects/insightsoftwareconsortium?tab=overview
> 
> To manage Coverity Scan email notifications for
> "matt.mccormick at kitware.com", click
> https://scan.coverity.com/subscriptions/edit?email=matt.mccormick%40kitware.com&token=d32d0bd32d3dfdd9bc75f2cd636b6067
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers