From matt.mccormick at kitware.com Mon May 4 09:50:09 2015 From: matt.mccormick at kitware.com (Matt McCormick) Date: Mon, 4 May 2015 09:50:09 -0400 Subject: [ITK-dev] [ANNOUNCE] ITK 4.7.2 has been released! Message-ID: On behalf of the Insight Toolkit Community, we are happy to announce the release of ITK 4.7.2! Release files can be downloaded from: http://itk.org/ITK/resources/software.html This is a patch release that fixes critical issues, regressions, important documentation, and compiler support. The 4.7.2 release addresses use of the LevelSetsv4 framework with libc++, which is now the default C++ standard library when building with MacOSX Xcode. A long standing convergence bug in the LBFGSB optimizer has been resolved. Improved support for building with VTK 6.2.0 and VTK Git master was also added. A number of other issues were addressed -- see the changelog below for details. Congratulations and thanks to everyone who contributed to this release. Questions and comments are welcome on the ITK mailing lists. The next feature release of 4.8.0 is scheduled for the end of June, and it will feature many exciting enhancements! Enjoy ITK! Changes from v4.7.1 to v4.7.2: Arnaud Gelas (2): COMP: fix warning with non default template parameter for OutputImage BUG: fix BinaryImageToLabelMapFilter with negative OutputBackgroundValue Bill Lorensen (1): COMP: Only require the minimal VTK modules Bradley Lowekamp (4): BUG: Move LBFGSB callback helper to parent BUG: Update AmoebaOptimizer NumberOfIterations BUG: Use base's NumberOfIterations for stopping condition BUG: Correct convergence string check Ga?tan Lehmann (1): BUG: fix runtime information for cross correlation filters Hans Johnson (1): COMP: VTK and ITK H5 build program collision Jon Haitz Legarreta (1): ENH: Increase code coverage for itkCustomColormapFunction Matthew McCormick (9): BUG: Export ITK_FFTW_INCLUDE_PATH as CMake path. COMP: Fix LevelSetsv4 tests with libc++. BUG: Set ITK_BUILD_SHARED in ITKConfig.cmake on Windows. COMP: Address quoted MSVC variable in GDCM. COMP: Remove duplicate InternalLabelType typedef. BUG: Link to VTK 6 rendering backend modules. BUG: Add VTK modules for annotation rendering. BUG: Link vtkRenderingFreeType in the VTK modules. From blowekamp at mail.nih.gov Wed May 6 10:50:08 2015 From: blowekamp at mail.nih.gov (Bradley Lowekamp) Date: Wed, 6 May 2015 10:50:08 -0400 Subject: [ITK-dev] SimpleITK 0.9 Registration Release Candidate 1 Message-ID: <9AC672A9-E68F-4401-AFE1-166C716E1CDD@mail.nih.gov> We are pleased to announce the SimpleITK 0.9 Release Candidate 1! NOW WITH REGISTRATION We encourage the community to download and test these binary packages. Thank you to those who tested the Beta release and provided feedback. We expect to be releasing 0.9 next week! This release features the ImageRegistrationMethod which brings a SimpleITK style interface to the modular ITKv4 registration framework. This adds support for a variety of transforms including rigid, affine, b-spline, and deformation fields. The metrics supported include correlation, means squares, ANTS neighborhood correlation, and mutual information. A variety of optimizers are available along with scales estimators for the optimized transformation parameters and built in multi-scale registration support. Additionally, a number of registration filters have been added: DemonsRegistrationFilter, DiffeomorphicDemonsRegistrationFilter, FastSymmetricForcesDemonsRegistrationFilter, LevelSetMotionRegistrationFilter and SymmetricForcesDemonsRegistrationFilter. Several examples can be found in the examples directory to help you get started. These examples include Affine registration, BSpline, Demons and Displacement fields. http://www.itk.org/SimpleITKDoxygen/html/examples.html There are several IPython/Jupyter Notebooks to illustrate using the registration framework: http://www.itk.org/Wiki/SimpleITK/ReleaseNotes#Release_Candidate_Announcement We have also added the following filters: AdditiveGaussianNoiseImageFilter, AggregateLabelMapFilter, BinaryImageToLabelMapFilter, ChangeLabelLabelMapFilter, CollidingFrontsImageFilter, DisplacementFieldJacobianDeterminantFilter, FastMarchingBaseImageFilter, FastMarchingUpwindGradientImageFilter, InverseDisplacementFieldImageFilter, InvertDisplacementFieldImageFilter, LabelImageToLabelMapFilter, LabelShapeStatisticsImageFilter, LabelStatisticsImageFilter, LabelUniqueLabelMapFilter, MergeLabelMapFilter, RelabelLabelMapFilter, SaltAndPepperNoiseImageFilter, ShotNoiseImageFilter, SpeckleNoiseImageFilter and TransformToDisplacementFieldFilter Before the final release we will work on improving documentation, and fixing critical bugs. You will need to manually download the beta binaries, then explicitly install the downloaded beta file. Information on how to get started and download the binaries: http://www.itk.org/Wiki/SimpleITK/GettingStarted#Binaries Binary distributions for many platforms and languages are available for downloading: https://sourceforge.net/projects/simpleitk/files/SimpleITK/0.9rc1/ Nightly Doxygen Documentation: http://www.itk.org/SimpleITKDoxygen/html/index.html Additional Release Notes: http://www.itk.org/Wiki/SimpleITK/ReleaseNotes#Release_Candidate_Announcement Enjoy! From matt.mccormick at kitware.com Tue May 12 13:18:57 2015 From: matt.mccormick at kitware.com (Matt McCormick) Date: Tue, 12 May 2015 13:18:57 -0400 Subject: [ITK-dev] Opportunities to share, discuss, design, and learn with other ITK community members Message-ID: There are a couple of upcoming opportunities to share, discuss, design, and learn with your fellow ITK community members. On Thursday (tomorrow), 1:00 PM Eastern USA time, there will be a Google+ Hangout where we will be doing code reviews: https://plus.google.com/events/c6g0t2lmomori9ccnptep9hssog On Friday, 11:00 AM Eastern USA time, an ITK development conference, https://plus.google.com/events/cth20a2augvkbauq1cadrkbqnrg For those that cannot join via Hangout, telephone call-in is also possible. Dial: 585-632-6296 Enter pin: 31423 To get regular invites to these events, join the ITK Bar Camp G+ Community: https://plus.google.com/u/0/communities/111375098792764998322 All are welcome. Hope to talk to you then! From blowekamp at mail.nih.gov Fri May 15 15:57:06 2015 From: blowekamp at mail.nih.gov (Bradley Lowekamp) Date: Fri, 15 May 2015 15:57:06 -0400 Subject: [ITK-dev] [ANNOUNCE] SimpleITK 0.9.0 Release Message-ID: We are pleased to announce the release of SimpleITK 0.9.0! NOW WITH REGISTRATION Here is a quick overview of the ITKv4's registration in SimpleITK via IPython/Jupiter notebook: http://insightsoftwareconsortium.github.io/SimpleITK-Notebooks/60_RegistrationIntroduction.html This release features the ImageRegistrationMethod which brings a SimpleITK style interface to the modular ITKv4 registration framework. This adds support for a variety of transforms including rigid, affine, b-spline, and deformation fields. The metrics supported include correlation, means squares, ANTS neighborhood correlation, and mutual information. A variety of optimizers are available along with scales estimators for the optimized transformation parameters and built in multi-scale registration support. Additionally, a number of registration filters have been added: DemonsRegistrationFilter, DiffeomorphicDemonsRegistrationFilter, FastSymmetricForcesDemonsRegistrationFilter, LevelSetMotionRegistrationFilter and SymmetricForcesDemonsRegistrationFilter. Several examples can be found in the examples directory to help you get started. These examples include Affine registration, BSpline, Demons and Displacement fields. http://www.itk.org/SimpleITKDoxygen/html/examples.html We have also added the following filters: AdditiveGaussianNoiseImageFilter, AggregateLabelMapFilter, BinaryImageToLabelMapFilter, ChangeLabelLabelMapFilter, CollidingFrontsImageFilter, DisplacementFieldJacobianDeterminantFilter, FastMarchingBaseImageFilter, FastMarchingUpwindGradientImageFilter, InverseDisplacementFieldImageFilter, InvertDisplacementFieldImageFilter, LabelImageToLabelMapFilter, LabelShapeStatisticsImageFilter, LabelStatisticsImageFilter, LabelUniqueLabelMapFilter, MergeLabelMapFilter, RelabelLabelMapFilter, SaltAndPepperNoiseImageFilter, ShotNoiseImageFilter, SpeckleNoiseImageFilter and TransformToDisplacementFieldFilter Information on how to get started and download the binaries: http://www.itk.org/Wiki/SimpleITK/GettingStarted#Binaries Binary distributions for many platforms and languages are available for downloading: https://sourceforge.net/projects/simpleitk/files/SimpleITK/0.9rc1/ Release Doxygen Documentation: http://www.itk.org/SimpleITKDoxygen09/html/index.html Additional Release Notes: http://www.itk.org/Wiki/SimpleITK/ReleaseNotes#SimpleITK_-_Version_0.9.0_Release Enjoy! From bill.lorensen at gmail.com Fri May 22 10:11:11 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 22 May 2015 10:11:11 -0400 Subject: [ITK-dev] Failing link on Mac after May 7 changes Message-ID: My Mac build i686-apple-darwin11-llvm-g++-4.2 (GCC) 4.2.1 has link errors after this commit: commit c11b4ebd3d5f63f2ec281d31eef14f3af6dbf1d4 Author: Hans Johnson Date: Thu May 7 06:56:36 2015 -0500 COMP: Prefer modern CMake visibility settings When available, prefer to use the modern cmake set_target_property() mechanism for setting export visibility of libaries. The add_compiler_export_flags function is obsolete. Use the CXX_VISIBILITY_PRESET and VISIBILITY_INLINES_HIDDEN target properties instead. Change-Id: Ibcf8b493bd8cba021e12e14bf18a7b46ae7e6e0a The linker errors are many like the following: Undefined symbols for architecture x86_64: "itk::Object::~Object()", referenced from: itk::Statistics::RandomVariateGeneratorBase::~RandomVariateGeneratorBase()in ITKCommonHeaderTest5.cxx.o itk::Statistics::RandomVariateGeneratorBase::~RandomVariateGeneratorBase()in ITKCommonHeaderTest5.cxx.o itk::Statistics::MersenneTwisterRandomVariateGenerator::~MersenneTwisterRandomVariateGenerator()in ITKCommonHeaderTest5.cxx.o itk::Statistics::MersenneTwisterRandomVariateGenerator::~MersenneTwisterRandomVariateGenerator()in ITKCommonHeaderTest5.cxx.o "itk::Object::CreateAnother() const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::LightObject::Delete()", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::Object::Register() const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::Object::UnRegister() const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::Object::SetReferenceCount(int)", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::Object::PrintSelf(std::basic_ostream >&, itk::Indent) const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o "itk::LightObject::PrintHeader(std::basic_ostream >&, itk::Indent) const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::LightObject::PrintTrailer(std::basic_ostream >&, itk::Indent) const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::LightObject::InternalClone() const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::Object::DebugOn() const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::Object::DebugOff() const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::Object::GetMTime() const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::Object::GetTimeStamp() const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::Object::Modified() const", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "itk::Object::SetTimeStamp(itk::TimeStamp const&)", referenced from: vtable for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o "typeinfo for itk::Object", referenced from: typeinfo for itk::Statistics::RandomVariateGeneratorBasein ITKCommonHeaderTest5.cxx.o "itk::Statistics::MersenneTwisterRandomVariateGenerator::PrintSelf(std::basic_ostream >&, itk::Indent) const", referenced from: vtable for itk::Statistics::MersenneTwisterRandomVariateGeneratorin ITKCommonHeaderTest5.cxx.o ld: symbol(s) not found for architecture x86_64 From blowekamp at mail.nih.gov Fri May 22 10:20:44 2015 From: blowekamp at mail.nih.gov (Bradley Lowekamp) Date: Fri, 22 May 2015 10:20:44 -0400 Subject: [ITK-dev] Failing link on Mac after May 7 changes In-Reply-To: References: Message-ID: <4802737A-C3FA-4563-B7EF-2A299D59EBCA@mail.nih.gov> Bill, This compiler has known problems with visibility. These are the lines that should disable it for your compiler: https://github.com/InsightSoftwareConsortium/ITK/blob/master/CMake/ITKModuleMacros.cmake#L12-L15 What is the value of USE_COMPILER_HIDDEN_VISIBILITY in you CMakeCache.txt files? Does manually setting it to off resolve your issue? Brad On May 22, 2015, at 10:11 AM, Bill Lorensen wrote: > My Mac build > i686-apple-darwin11-llvm-g++-4.2 (GCC) 4.2.1 > has link errors after this commit: > commit c11b4ebd3d5f63f2ec281d31eef14f3af6dbf1d4 > Author: Hans Johnson > Date: Thu May 7 06:56:36 2015 -0500 > > COMP: Prefer modern CMake visibility settings > > When available, prefer to use the modern cmake > set_target_property() mechanism for setting > export visibility of libaries. > > The add_compiler_export_flags function is obsolete. Use the > CXX_VISIBILITY_PRESET and VISIBILITY_INLINES_HIDDEN target properties > instead. > > Change-Id: Ibcf8b493bd8cba021e12e14bf18a7b46ae7e6e0a > > The linker errors are many like the following: > Undefined symbols for architecture x86_64: > "itk::Object::~Object()", referenced from: > itk::Statistics::RandomVariateGeneratorBase::~RandomVariateGeneratorBase()in > ITKCommonHeaderTest5.cxx.o > itk::Statistics::RandomVariateGeneratorBase::~RandomVariateGeneratorBase()in > ITKCommonHeaderTest5.cxx.o > itk::Statistics::MersenneTwisterRandomVariateGenerator::~MersenneTwisterRandomVariateGenerator()in > ITKCommonHeaderTest5.cxx.o > itk::Statistics::MersenneTwisterRandomVariateGenerator::~MersenneTwisterRandomVariateGenerator()in > ITKCommonHeaderTest5.cxx.o > "itk::Object::CreateAnother() const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::LightObject::Delete()", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::Object::Register() const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::Object::UnRegister() const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::Object::SetReferenceCount(int)", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::Object::PrintSelf(std::basic_ostream std::char_traits >&, itk::Indent) const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > "itk::LightObject::PrintHeader(std::basic_ostream std::char_traits >&, itk::Indent) const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::LightObject::PrintTrailer(std::basic_ostream std::char_traits >&, itk::Indent) const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::LightObject::InternalClone() const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::Object::DebugOn() const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::Object::DebugOff() const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::Object::GetMTime() const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::Object::GetTimeStamp() const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::Object::Modified() const", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "itk::Object::SetTimeStamp(itk::TimeStamp const&)", referenced from: > vtable for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > "typeinfo for itk::Object", referenced from: > typeinfo for itk::Statistics::RandomVariateGeneratorBasein > ITKCommonHeaderTest5.cxx.o > "itk::Statistics::MersenneTwisterRandomVariateGenerator::PrintSelf(std::basic_ostream std::char_traits >&, itk::Indent) const", referenced from: > vtable for > itk::Statistics::MersenneTwisterRandomVariateGeneratorin > ITKCommonHeaderTest5.cxx.o > ld: symbol(s) not found for architecture x86_64 > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers From bill.lorensen at gmail.com Fri May 22 10:28:45 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Fri, 22 May 2015 10:28:45 -0400 Subject: [ITK-dev] Failing link on Mac after May 7 changes In-Reply-To: <4802737A-C3FA-4563-B7EF-2A299D59EBCA@mail.nih.gov> References: <4802737A-C3FA-4563-B7EF-2A299D59EBCA@mail.nih.gov> Message-ID: Brad, I just pushed a patch. Bill On Fri, May 22, 2015 at 10:20 AM, Bradley Lowekamp wrote: > Bill, > > This compiler has known problems with visibility. These are the lines that should disable it for your compiler: > https://github.com/InsightSoftwareConsortium/ITK/blob/master/CMake/ITKModuleMacros.cmake#L12-L15 > > What is the value of USE_COMPILER_HIDDEN_VISIBILITY in you CMakeCache.txt files? Does manually setting it to off resolve your issue? > > Brad > > On May 22, 2015, at 10:11 AM, Bill Lorensen wrote: > >> My Mac build >> i686-apple-darwin11-llvm-g++-4.2 (GCC) 4.2.1 >> has link errors after this commit: >> commit c11b4ebd3d5f63f2ec281d31eef14f3af6dbf1d4 >> Author: Hans Johnson >> Date: Thu May 7 06:56:36 2015 -0500 >> >> COMP: Prefer modern CMake visibility settings >> >> When available, prefer to use the modern cmake >> set_target_property() mechanism for setting >> export visibility of libaries. >> >> The add_compiler_export_flags function is obsolete. Use the >> CXX_VISIBILITY_PRESET and VISIBILITY_INLINES_HIDDEN target properties >> instead. >> >> Change-Id: Ibcf8b493bd8cba021e12e14bf18a7b46ae7e6e0a >> >> The linker errors are many like the following: >> Undefined symbols for architecture x86_64: >> "itk::Object::~Object()", referenced from: >> itk::Statistics::RandomVariateGeneratorBase::~RandomVariateGeneratorBase()in >> ITKCommonHeaderTest5.cxx.o >> itk::Statistics::RandomVariateGeneratorBase::~RandomVariateGeneratorBase()in >> ITKCommonHeaderTest5.cxx.o >> itk::Statistics::MersenneTwisterRandomVariateGenerator::~MersenneTwisterRandomVariateGenerator()in >> ITKCommonHeaderTest5.cxx.o >> itk::Statistics::MersenneTwisterRandomVariateGenerator::~MersenneTwisterRandomVariateGenerator()in >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::CreateAnother() const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::LightObject::Delete()", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::Register() const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::UnRegister() const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::SetReferenceCount(int)", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::PrintSelf(std::basic_ostream> std::char_traits >&, itk::Indent) const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> "itk::LightObject::PrintHeader(std::basic_ostream> std::char_traits >&, itk::Indent) const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::LightObject::PrintTrailer(std::basic_ostream> std::char_traits >&, itk::Indent) const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::LightObject::InternalClone() const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::DebugOn() const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::DebugOff() const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::GetMTime() const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::GetTimeStamp() const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::Modified() const", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "itk::Object::SetTimeStamp(itk::TimeStamp const&)", referenced from: >> vtable for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> "typeinfo for itk::Object", referenced from: >> typeinfo for itk::Statistics::RandomVariateGeneratorBasein >> ITKCommonHeaderTest5.cxx.o >> "itk::Statistics::MersenneTwisterRandomVariateGenerator::PrintSelf(std::basic_ostream> std::char_traits >&, itk::Indent) const", referenced from: >> vtable for >> itk::Statistics::MersenneTwisterRandomVariateGeneratorin >> ITKCommonHeaderTest5.cxx.o >> ld: symbol(s) not found for architecture x86_64 >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers > -- Unpaid intern in BillsBasement at noware dot com From p.zaffino at yahoo.it Fri May 22 11:03:30 2015 From: p.zaffino at yahoo.it (Paolo Zaffino) Date: Fri, 22 May 2015 17:03:30 +0200 Subject: [ITK-dev] ITK and GCC 5.1 Message-ID: <555F4542.1070509@yahoo.it> Hi, on my Arch Linux box I got GCC 5.1 update and I'm not able to compile ITK 4.7.2 so far. Any idea? Thanks a lot. Paolo From blowekamp at mail.nih.gov Fri May 22 11:59:46 2015 From: blowekamp at mail.nih.gov (Bradley Lowekamp) Date: Fri, 22 May 2015 11:59:46 -0400 Subject: [ITK-dev] ITK and GCC 5.1 In-Reply-To: <555F4542.1070509@yahoo.it> References: <555F4542.1070509@yahoo.it> Message-ID: <5C922F16-7BF1-4538-A21C-44EA39267121@mail.nih.gov> Hello, I thought a couple patches were placed in ITK 4.7.2 to enable support for gcc 5.1, I am surprised it didn't work for you. There are a couple builds on the dashboard using that compiler [1, 2], so perhaps the master branch will work better? An error message would help diagnose the problem. Brad [1] https://open.cdash.org/buildSummary.php?buildid=3824845 [2] https://open.cdash.org/buildSummary.php?buildid=3825176 On May 22, 2015, at 11:03 AM, Paolo Zaffino wrote: > Hi, > on my Arch Linux box I got GCC 5.1 update and I'm not able to compile ITK 4.7.2 so far. > > Any idea? > Thanks a lot. > > Paolo > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers From matt.mccormick at kitware.com Fri May 22 12:01:24 2015 From: matt.mccormick at kitware.com (Matt McCormick) Date: Fri, 22 May 2015 12:01:24 -0400 Subject: [ITK-dev] ITK and GCC 5.1 In-Reply-To: <5C922F16-7BF1-4538-A21C-44EA39267121@mail.nih.gov> References: <555F4542.1070509@yahoo.it> <5C922F16-7BF1-4538-A21C-44EA39267121@mail.nih.gov> Message-ID: Yes, the fixes did not make it into 4.7.2. Please use Git master [1]. There are a couple of outstanding warnings and test failures. Thanks, Matt [1] http://www.itk.org/Wiki/ITK/Git On Fri, May 22, 2015 at 11:59 AM, Bradley Lowekamp wrote: > Hello, > > I thought a couple patches were placed in ITK 4.7.2 to enable support for > gcc 5.1, I am surprised it didn't work for you. > > There are a couple builds on the dashboard using that compiler [1, 2], so > perhaps the master branch will work better? > > An error message would help diagnose the problem. > > Brad > > > [1] https://open.cdash.org/buildSummary.php?buildid=3824845 > [2] https://open.cdash.org/buildSummary.php?buildid=3825176 > > On May 22, 2015, at 11:03 AM, Paolo Zaffino wrote: > > > Hi, > > on my Arch Linux box I got GCC 5.1 update and I'm not able to compile > ITK 4.7.2 so far. > > > > Any idea? > > Thanks a lot. > > > > Paolo > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Kitware offers ITK Training Courses, for more information visit: > > http://kitware.com/products/protraining.php > > > > Please keep messages on-topic and check the ITK FAQ at: > > http://www.itk.org/Wiki/ITK_FAQ > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/insight-developers > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > -------------- next part -------------- An HTML attachment was scrubbed... URL: From p.zaffino at yahoo.it Fri May 22 13:46:54 2015 From: p.zaffino at yahoo.it (Paolo Zaffino) Date: Fri, 22 May 2015 19:46:54 +0200 Subject: [ITK-dev] ITK and GCC 5.1 In-Reply-To: References: <555F4542.1070509@yahoo.it> <5C922F16-7BF1-4538-A21C-44EA39267121@mail.nih.gov> Message-ID: <555F6B8E.1080503@yahoo.it> Dear all, using the git version it works. Thank you! Paolo On 22/05/2015 18:01, Matt McCormick wrote: > Yes, the fixes did not make it into 4.7.2. Please use Git master [1]. > There are a couple of outstanding warnings and test failures. > > Thanks, > Matt > > [1] http://www.itk.org/Wiki/ITK/Git > > > > On Fri, May 22, 2015 at 11:59 AM, Bradley Lowekamp > > wrote: > > Hello, > > I thought a couple patches were placed in ITK 4.7.2 to enable > support for gcc 5.1, I am surprised it didn't work for you. > > There are a couple builds on the dashboard using that compiler [1, > 2], so perhaps the master branch will work better? > > An error message would help diagnose the problem. > > Brad > > > [1] https://open.cdash.org/buildSummary.php?buildid=3824845 > [2] https://open.cdash.org/buildSummary.php?buildid=3825176 > > On May 22, 2015, at 11:03 AM, Paolo Zaffino > wrote: > > > Hi, > > on my Arch Linux box I got GCC 5.1 update and I'm not able to > compile ITK 4.7.2 so far. > > > > Any idea? > > Thanks a lot. > > > > Paolo > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Kitware offers ITK Training Courses, for more information visit: > > http://kitware.com/products/protraining.php > > > > Please keep messages on-topic and check the ITK FAQ at: > > http://www.itk.org/Wiki/ITK_FAQ > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/insight-developers > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bill.lorensen at gmail.com Mon May 25 11:59:58 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 25 May 2015 11:59:58 -0400 Subject: [ITK-dev] ITKApps failing after recent commit Message-ID: Since this topic was merged, ITKApps failk to build. I narrowed it down using git commit. http://review.source.kitware.com/#/c/19729/ Here is the failing dashboard entry: https://open.cdash.org/viewBuildError.php?buildid=3828894 I'll take a lot to see if I can fix it. Bill From bill.lorensen at gmail.com Mon May 25 12:08:37 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 25 May 2015 12:08:37 -0400 Subject: [ITK-dev] ITKApps failing after recent commit In-Reply-To: References: Message-ID: Looks to me that the API for itkEventMacro has changed. This is bad. In ITKApps there are several definitions like this. How must these be changed? namespace fltk { /** * List of the events expected in this domain */ itkEventMacro( RedrawEvent, itk::UserEvent ); itkEventMacro( GlDrawEvent, itk::UserEvent ); itkEventMacro( VolumeReslicedEvent, itk::UserEvent ); itkEventMacro( ClippingPlaneEvent, itk::UserEvent ); } // end namespace fltk On Mon, May 25, 2015 at 11:59 AM, Bill Lorensen wrote: > Since this topic was merged, ITKApps failk to build. I narrowed it > down using git commit. > > http://review.source.kitware.com/#/c/19729/ > > Here is the failing dashboard entry: > https://open.cdash.org/viewBuildError.php?buildid=3828894 > > I'll take a lot to see if I can fix it. > > Bill -- Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Mon May 25 15:10:50 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Mon, 25 May 2015 15:10:50 -0400 Subject: [ITK-dev] ITKApps failing after recent commit In-Reply-To: References: Message-ID: itksnap also has issues with the API change. I'll try to make a small example that illustrates the problem. On Mon, May 25, 2015 at 12:08 PM, Bill Lorensen wrote: > Looks to me that the API for itkEventMacro has changed. This is bad. > In ITKApps there are several definitions like this. How must these be > changed? > > namespace fltk { > > /** > * List of the events expected in this domain > */ > itkEventMacro( RedrawEvent, itk::UserEvent ); > itkEventMacro( GlDrawEvent, itk::UserEvent ); > itkEventMacro( VolumeReslicedEvent, itk::UserEvent ); > itkEventMacro( ClippingPlaneEvent, itk::UserEvent ); > > > > } // end namespace fltk > > > On Mon, May 25, 2015 at 11:59 AM, Bill Lorensen wrote: >> Since this topic was merged, ITKApps failk to build. I narrowed it >> down using git commit. >> >> http://review.source.kitware.com/#/c/19729/ >> >> Here is the failing dashboard entry: >> https://open.cdash.org/viewBuildError.php?buildid=3828894 >> >> I'll take a lot to see if I can fix it. >> >> Bill > > > > -- > Unpaid intern in BillsBasement at noware dot com -- Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Tue May 26 11:26:10 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 26 May 2015 11:26:10 -0400 Subject: [ITK-dev] ITK API Change (was ITKApps failing after recent commit) Message-ID: itkEventMacro no longer works the way it used to. Applications that used itkEventMacro(myEvent, itk::UserEvent); must break up the statement into two statements and two files: in the .h file itkEventMacroDeclaration(myEvent,itk::UserEvent); in the .cxx file itkEventMacroDefinition(myEvent,itk::UserEvent); The problems occurs when an application has multiple source files that include the file with itkEventMacro. Duplicate symbols are created now. Prior to the API-break this was fine. Application code that uses itkEventMacro that wants to support ITK pre-the-API-break and post-the-API-break will need further statements. I am working on getting the ITKApps to work with both pre and post API-break versions. The unintended consequences of this API break are troublesome. On Mon, May 25, 2015 at 3:10 PM, Bill Lorensen wrote: > itksnap also has issues with the API change. I'll try to make a small > example that illustrates the problem. > > > > On Mon, May 25, 2015 at 12:08 PM, Bill Lorensen wrote: >> Looks to me that the API for itkEventMacro has changed. This is bad. >> In ITKApps there are several definitions like this. How must these be >> changed? >> >> namespace fltk { >> >> /** >> * List of the events expected in this domain >> */ >> itkEventMacro( RedrawEvent, itk::UserEvent ); >> itkEventMacro( GlDrawEvent, itk::UserEvent ); >> itkEventMacro( VolumeReslicedEvent, itk::UserEvent ); >> itkEventMacro( ClippingPlaneEvent, itk::UserEvent ); >> >> >> >> } // end namespace fltk >> >> >> On Mon, May 25, 2015 at 11:59 AM, Bill Lorensen wrote: >>> Since this topic was merged, ITKApps failk to build. I narrowed it >>> down using git commit. >>> >>> http://review.source.kitware.com/#/c/19729/ >>> >>> Here is the failing dashboard entry: >>> https://open.cdash.org/viewBuildError.php?buildid=3828894 >>> >>> I'll take a lot to see if I can fix it. >>> >>> Bill >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com > > > > -- > Unpaid intern in BillsBasement at noware dot com -- Unpaid intern in BillsBasement at noware dot com From matt.mccormick at kitware.com Tue May 26 11:31:54 2015 From: matt.mccormick at kitware.com (Matt McCormick) Date: Tue, 26 May 2015 11:31:54 -0400 Subject: [ITK-dev] ITK API Change (was ITKApps failing after recent commit) In-Reply-To: References: Message-ID: Hi Bill, Thanks for bringing attention to this. If we cannot find a way for external Event code to work without modification, I thing we should revert the change before we release 4.8. 2 cents, Matt On Tue, May 26, 2015 at 11:26 AM, Bill Lorensen wrote: > itkEventMacro no longer works the way it used to. Applications that used > itkEventMacro(myEvent, itk::UserEvent); > must break up the statement into two statements and two files: > in the .h file > itkEventMacroDeclaration(myEvent,itk::UserEvent); > in the .cxx file > itkEventMacroDefinition(myEvent,itk::UserEvent); > > The problems occurs when an application has multiple source files that > include the file with itkEventMacro. Duplicate symbols are created > now. Prior to the API-break this was fine. > > Application code that uses itkEventMacro that wants to support ITK > pre-the-API-break and post-the-API-break will need further statements. > > I am working on getting the ITKApps to work with both pre and post > API-break versions. > > The unintended consequences of this API break are troublesome. > > On Mon, May 25, 2015 at 3:10 PM, Bill Lorensen wrote: >> itksnap also has issues with the API change. I'll try to make a small >> example that illustrates the problem. >> >> >> >> On Mon, May 25, 2015 at 12:08 PM, Bill Lorensen wrote: >>> Looks to me that the API for itkEventMacro has changed. This is bad. >>> In ITKApps there are several definitions like this. How must these be >>> changed? >>> >>> namespace fltk { >>> >>> /** >>> * List of the events expected in this domain >>> */ >>> itkEventMacro( RedrawEvent, itk::UserEvent ); >>> itkEventMacro( GlDrawEvent, itk::UserEvent ); >>> itkEventMacro( VolumeReslicedEvent, itk::UserEvent ); >>> itkEventMacro( ClippingPlaneEvent, itk::UserEvent ); >>> >>> >>> >>> } // end namespace fltk >>> >>> >>> On Mon, May 25, 2015 at 11:59 AM, Bill Lorensen wrote: >>>> Since this topic was merged, ITKApps failk to build. I narrowed it >>>> down using git commit. >>>> >>>> http://review.source.kitware.com/#/c/19729/ >>>> >>>> Here is the failing dashboard entry: >>>> https://open.cdash.org/viewBuildError.php?buildid=3828894 >>>> >>>> I'll take a lot to see if I can fix it. >>>> >>>> Bill >>> >>> >>> >>> -- >>> Unpaid intern in BillsBasement at noware dot com >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com > > > > -- > Unpaid intern in BillsBasement at noware dot com > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers From bill.lorensen at gmail.com Tue May 26 11:37:49 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 26 May 2015 11:37:49 -0400 Subject: [ITK-dev] ITK API Change (was ITKApps failing after recent commit) In-Reply-To: References: Message-ID: I agree. I will soon have a patch to the ITKApps that works for both versions of ITK. This will illustrate how much work is required to support both API's. The current ITK makes itkEventMacro dangerous and worthless. On Tue, May 26, 2015 at 11:31 AM, Matt McCormick wrote: > Hi Bill, > > Thanks for bringing attention to this. If we cannot find a way for > external Event code to work without modification, I thing we should > revert the change before we release 4.8. > > 2 cents, > Matt > > On Tue, May 26, 2015 at 11:26 AM, Bill Lorensen wrote: >> itkEventMacro no longer works the way it used to. Applications that used >> itkEventMacro(myEvent, itk::UserEvent); >> must break up the statement into two statements and two files: >> in the .h file >> itkEventMacroDeclaration(myEvent,itk::UserEvent); >> in the .cxx file >> itkEventMacroDefinition(myEvent,itk::UserEvent); >> >> The problems occurs when an application has multiple source files that >> include the file with itkEventMacro. Duplicate symbols are created >> now. Prior to the API-break this was fine. >> >> Application code that uses itkEventMacro that wants to support ITK >> pre-the-API-break and post-the-API-break will need further statements. >> >> I am working on getting the ITKApps to work with both pre and post >> API-break versions. >> >> The unintended consequences of this API break are troublesome. >> >> On Mon, May 25, 2015 at 3:10 PM, Bill Lorensen wrote: >>> itksnap also has issues with the API change. I'll try to make a small >>> example that illustrates the problem. >>> >>> >>> >>> On Mon, May 25, 2015 at 12:08 PM, Bill Lorensen wrote: >>>> Looks to me that the API for itkEventMacro has changed. This is bad. >>>> In ITKApps there are several definitions like this. How must these be >>>> changed? >>>> >>>> namespace fltk { >>>> >>>> /** >>>> * List of the events expected in this domain >>>> */ >>>> itkEventMacro( RedrawEvent, itk::UserEvent ); >>>> itkEventMacro( GlDrawEvent, itk::UserEvent ); >>>> itkEventMacro( VolumeReslicedEvent, itk::UserEvent ); >>>> itkEventMacro( ClippingPlaneEvent, itk::UserEvent ); >>>> >>>> >>>> >>>> } // end namespace fltk >>>> >>>> >>>> On Mon, May 25, 2015 at 11:59 AM, Bill Lorensen wrote: >>>>> Since this topic was merged, ITKApps failk to build. I narrowed it >>>>> down using git commit. >>>>> >>>>> http://review.source.kitware.com/#/c/19729/ >>>>> >>>>> Here is the failing dashboard entry: >>>>> https://open.cdash.org/viewBuildError.php?buildid=3828894 >>>>> >>>>> I'll take a lot to see if I can fix it. >>>>> >>>>> Bill >>>> >>>> >>>> >>>> -- >>>> Unpaid intern in BillsBasement at noware dot com >>> >>> >>> >>> -- >>> Unpaid intern in BillsBasement at noware dot com >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers -- Unpaid intern in BillsBasement at noware dot com From blowekamp at mail.nih.gov Tue May 26 11:44:15 2015 From: blowekamp at mail.nih.gov (Bradley Lowekamp) Date: Tue, 26 May 2015 11:44:15 -0400 Subject: [ITK-dev] [ITK] ITK API Change (was ITKApps failing after recent commit) In-Reply-To: References: Message-ID: Lets try to keep moving forward. The itkEventMacro is not really used in ITK. It should not be hard to revert it to the old behavior. All that is likely needed is to improve the usage of the ITKEvent_EXPORT define [1]. It looks like the re-write of these macros was only intended for internal ITK usage as it's defined an ITKCommom_EXPORT. Brad [1] https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/Common/include/itkEventObject.h#L108 On May 26, 2015, at 11:37 AM, Bill Lorensen wrote: > I agree. I will soon have a patch to the ITKApps that works for both > versions of ITK. This will illustrate how much work is required to > support both API's. The current ITK makes itkEventMacro dangerous and > worthless. > > On Tue, May 26, 2015 at 11:31 AM, Matt McCormick > wrote: >> Hi Bill, >> >> Thanks for bringing attention to this. If we cannot find a way for >> external Event code to work without modification, I thing we should >> revert the change before we release 4.8. >> >> 2 cents, >> Matt >> >> On Tue, May 26, 2015 at 11:26 AM, Bill Lorensen wrote: >>> itkEventMacro no longer works the way it used to. Applications that used >>> itkEventMacro(myEvent, itk::UserEvent); >>> must break up the statement into two statements and two files: >>> in the .h file >>> itkEventMacroDeclaration(myEvent,itk::UserEvent); >>> in the .cxx file >>> itkEventMacroDefinition(myEvent,itk::UserEvent); >>> >>> The problems occurs when an application has multiple source files that >>> include the file with itkEventMacro. Duplicate symbols are created >>> now. Prior to the API-break this was fine. >>> >>> Application code that uses itkEventMacro that wants to support ITK >>> pre-the-API-break and post-the-API-break will need further statements. >>> >>> I am working on getting the ITKApps to work with both pre and post >>> API-break versions. >>> >>> The unintended consequences of this API break are troublesome. >>> >>> On Mon, May 25, 2015 at 3:10 PM, Bill Lorensen wrote: >>>> itksnap also has issues with the API change. I'll try to make a small >>>> example that illustrates the problem. >>>> >>>> >>>> >>>> On Mon, May 25, 2015 at 12:08 PM, Bill Lorensen wrote: >>>>> Looks to me that the API for itkEventMacro has changed. This is bad. >>>>> In ITKApps there are several definitions like this. How must these be >>>>> changed? >>>>> >>>>> namespace fltk { >>>>> >>>>> /** >>>>> * List of the events expected in this domain >>>>> */ >>>>> itkEventMacro( RedrawEvent, itk::UserEvent ); >>>>> itkEventMacro( GlDrawEvent, itk::UserEvent ); >>>>> itkEventMacro( VolumeReslicedEvent, itk::UserEvent ); >>>>> itkEventMacro( ClippingPlaneEvent, itk::UserEvent ); >>>>> >>>>> >>>>> >>>>> } // end namespace fltk >>>>> >>>>> >>>>> On Mon, May 25, 2015 at 11:59 AM, Bill Lorensen wrote: >>>>>> Since this topic was merged, ITKApps failk to build. I narrowed it >>>>>> down using git commit. >>>>>> >>>>>> http://review.source.kitware.com/#/c/19729/ >>>>>> >>>>>> Here is the failing dashboard entry: >>>>>> https://open.cdash.org/viewBuildError.php?buildid=3828894 >>>>>> >>>>>> I'll take a lot to see if I can fix it. >>>>>> >>>>>> Bill >>>>> >>>>> >>>>> >>>>> -- >>>>> Unpaid intern in BillsBasement at noware dot com >>>> >>>> >>>> >>>> -- >>>> Unpaid intern in BillsBasement at noware dot com >>> >>> >>> >>> -- >>> Unpaid intern in BillsBasement at noware dot com >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/insight-developers > > > > -- > Unpaid intern in BillsBasement at noware dot com > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > _______________________________________________ > Community mailing list > Community at itk.org > http://public.kitware.com/mailman/listinfo/community From matt.mccormick at kitware.com Tue May 26 11:47:46 2015 From: matt.mccormick at kitware.com (Matt McCormick) Date: Tue, 26 May 2015 11:47:46 -0400 Subject: [ITK-dev] Enhancements for 4.8 Message-ID: Hi, Per our release schedule [1], the first 4.8 release candidate is scheduled to be tagged on Monday, June 8th. Please have all enhancements that have been reviewed and are passing tests merged by next Friday, June 5th. Thanks, Matt [1] http://www.itk.org/Wiki/ITK/Release_Schedule From bill.lorensen at gmail.com Tue May 26 11:58:13 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 26 May 2015 11:58:13 -0400 Subject: [ITK-dev] [ITK] ITK API Change (was ITKApps failing after recent commit) In-Reply-To: References: Message-ID: Brad, That is not the problem. The old macro duplicated implementations in each file that included a common .h file. The new api changes that. But, is it important. I think not. The old, less elegant form, worked. On Tue, May 26, 2015 at 11:44 AM, Bradley Lowekamp wrote: > > Lets try to keep moving forward. > > The itkEventMacro is not really used in ITK. It should not be hard to revert it to the old behavior. > > All that is likely needed is to improve the usage of the ITKEvent_EXPORT define [1]. It looks like the re-write of these macros was only intended for internal ITK usage as it's defined an ITKCommom_EXPORT. > > Brad > > > > [1] https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/Common/include/itkEventObject.h#L108 > > On May 26, 2015, at 11:37 AM, Bill Lorensen wrote: > >> I agree. I will soon have a patch to the ITKApps that works for both >> versions of ITK. This will illustrate how much work is required to >> support both API's. The current ITK makes itkEventMacro dangerous and >> worthless. >> >> On Tue, May 26, 2015 at 11:31 AM, Matt McCormick >> wrote: >>> Hi Bill, >>> >>> Thanks for bringing attention to this. If we cannot find a way for >>> external Event code to work without modification, I thing we should >>> revert the change before we release 4.8. >>> >>> 2 cents, >>> Matt >>> >>> On Tue, May 26, 2015 at 11:26 AM, Bill Lorensen wrote: >>>> itkEventMacro no longer works the way it used to. Applications that used >>>> itkEventMacro(myEvent, itk::UserEvent); >>>> must break up the statement into two statements and two files: >>>> in the .h file >>>> itkEventMacroDeclaration(myEvent,itk::UserEvent); >>>> in the .cxx file >>>> itkEventMacroDefinition(myEvent,itk::UserEvent); >>>> >>>> The problems occurs when an application has multiple source files that >>>> include the file with itkEventMacro. Duplicate symbols are created >>>> now. Prior to the API-break this was fine. >>>> >>>> Application code that uses itkEventMacro that wants to support ITK >>>> pre-the-API-break and post-the-API-break will need further statements. >>>> >>>> I am working on getting the ITKApps to work with both pre and post >>>> API-break versions. >>>> >>>> The unintended consequences of this API break are troublesome. >>>> >>>> On Mon, May 25, 2015 at 3:10 PM, Bill Lorensen wrote: >>>>> itksnap also has issues with the API change. I'll try to make a small >>>>> example that illustrates the problem. >>>>> >>>>> >>>>> >>>>> On Mon, May 25, 2015 at 12:08 PM, Bill Lorensen wrote: >>>>>> Looks to me that the API for itkEventMacro has changed. This is bad. >>>>>> In ITKApps there are several definitions like this. How must these be >>>>>> changed? >>>>>> >>>>>> namespace fltk { >>>>>> >>>>>> /** >>>>>> * List of the events expected in this domain >>>>>> */ >>>>>> itkEventMacro( RedrawEvent, itk::UserEvent ); >>>>>> itkEventMacro( GlDrawEvent, itk::UserEvent ); >>>>>> itkEventMacro( VolumeReslicedEvent, itk::UserEvent ); >>>>>> itkEventMacro( ClippingPlaneEvent, itk::UserEvent ); >>>>>> >>>>>> >>>>>> >>>>>> } // end namespace fltk >>>>>> >>>>>> >>>>>> On Mon, May 25, 2015 at 11:59 AM, Bill Lorensen wrote: >>>>>>> Since this topic was merged, ITKApps failk to build. I narrowed it >>>>>>> down using git commit. >>>>>>> >>>>>>> http://review.source.kitware.com/#/c/19729/ >>>>>>> >>>>>>> Here is the failing dashboard entry: >>>>>>> https://open.cdash.org/viewBuildError.php?buildid=3828894 >>>>>>> >>>>>>> I'll take a lot to see if I can fix it. >>>>>>> >>>>>>> Bill >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Unpaid intern in BillsBasement at noware dot com >>>>> >>>>> >>>>> >>>>> -- >>>>> Unpaid intern in BillsBasement at noware dot com >>>> >>>> >>>> >>>> -- >>>> Unpaid intern in BillsBasement at noware dot com >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Kitware offers ITK Training Courses, for more information visit: >>>> http://kitware.com/products/protraining.php >>>> >>>> Please keep messages on-topic and check the ITK FAQ at: >>>> http://www.itk.org/Wiki/ITK_FAQ >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://public.kitware.com/mailman/listinfo/insight-developers >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers >> _______________________________________________ >> Community mailing list >> Community at itk.org >> http://public.kitware.com/mailman/listinfo/community > -- Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Tue May 26 12:01:39 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 26 May 2015 12:01:39 -0400 Subject: [ITK-dev] [ITK] ITK API Change (was ITKApps failing after recent commit) In-Reply-To: References: Message-ID: Brad, In an application, by separating the declaration (in a .h file) from the definition (in a .cxx file) solves the problem. But this is a PITA for an application that currently uses itkEventMacro. Upsetting customers is not moving forward. On Tue, May 26, 2015 at 11:58 AM, Bill Lorensen wrote: > Brad, > > That is not the problem. The old macro duplicated implementations in > each file that included a common .h file. The new api changes that. > But, is it important. I think not. The old, less elegant form, worked. > > > On Tue, May 26, 2015 at 11:44 AM, Bradley Lowekamp > wrote: >> >> Lets try to keep moving forward. >> >> The itkEventMacro is not really used in ITK. It should not be hard to revert it to the old behavior. >> >> All that is likely needed is to improve the usage of the ITKEvent_EXPORT define [1]. It looks like the re-write of these macros was only intended for internal ITK usage as it's defined an ITKCommom_EXPORT. >> >> Brad >> >> >> >> [1] https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/Common/include/itkEventObject.h#L108 >> >> On May 26, 2015, at 11:37 AM, Bill Lorensen wrote: >> >>> I agree. I will soon have a patch to the ITKApps that works for both >>> versions of ITK. This will illustrate how much work is required to >>> support both API's. The current ITK makes itkEventMacro dangerous and >>> worthless. >>> >>> On Tue, May 26, 2015 at 11:31 AM, Matt McCormick >>> wrote: >>>> Hi Bill, >>>> >>>> Thanks for bringing attention to this. If we cannot find a way for >>>> external Event code to work without modification, I thing we should >>>> revert the change before we release 4.8. >>>> >>>> 2 cents, >>>> Matt >>>> >>>> On Tue, May 26, 2015 at 11:26 AM, Bill Lorensen wrote: >>>>> itkEventMacro no longer works the way it used to. Applications that used >>>>> itkEventMacro(myEvent, itk::UserEvent); >>>>> must break up the statement into two statements and two files: >>>>> in the .h file >>>>> itkEventMacroDeclaration(myEvent,itk::UserEvent); >>>>> in the .cxx file >>>>> itkEventMacroDefinition(myEvent,itk::UserEvent); >>>>> >>>>> The problems occurs when an application has multiple source files that >>>>> include the file with itkEventMacro. Duplicate symbols are created >>>>> now. Prior to the API-break this was fine. >>>>> >>>>> Application code that uses itkEventMacro that wants to support ITK >>>>> pre-the-API-break and post-the-API-break will need further statements. >>>>> >>>>> I am working on getting the ITKApps to work with both pre and post >>>>> API-break versions. >>>>> >>>>> The unintended consequences of this API break are troublesome. >>>>> >>>>> On Mon, May 25, 2015 at 3:10 PM, Bill Lorensen wrote: >>>>>> itksnap also has issues with the API change. I'll try to make a small >>>>>> example that illustrates the problem. >>>>>> >>>>>> >>>>>> >>>>>> On Mon, May 25, 2015 at 12:08 PM, Bill Lorensen wrote: >>>>>>> Looks to me that the API for itkEventMacro has changed. This is bad. >>>>>>> In ITKApps there are several definitions like this. How must these be >>>>>>> changed? >>>>>>> >>>>>>> namespace fltk { >>>>>>> >>>>>>> /** >>>>>>> * List of the events expected in this domain >>>>>>> */ >>>>>>> itkEventMacro( RedrawEvent, itk::UserEvent ); >>>>>>> itkEventMacro( GlDrawEvent, itk::UserEvent ); >>>>>>> itkEventMacro( VolumeReslicedEvent, itk::UserEvent ); >>>>>>> itkEventMacro( ClippingPlaneEvent, itk::UserEvent ); >>>>>>> >>>>>>> >>>>>>> >>>>>>> } // end namespace fltk >>>>>>> >>>>>>> >>>>>>> On Mon, May 25, 2015 at 11:59 AM, Bill Lorensen wrote: >>>>>>>> Since this topic was merged, ITKApps failk to build. I narrowed it >>>>>>>> down using git commit. >>>>>>>> >>>>>>>> http://review.source.kitware.com/#/c/19729/ >>>>>>>> >>>>>>>> Here is the failing dashboard entry: >>>>>>>> https://open.cdash.org/viewBuildError.php?buildid=3828894 >>>>>>>> >>>>>>>> I'll take a lot to see if I can fix it. >>>>>>>> >>>>>>>> Bill >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Unpaid intern in BillsBasement at noware dot com >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Unpaid intern in BillsBasement at noware dot com >>>>> >>>>> >>>>> >>>>> -- >>>>> Unpaid intern in BillsBasement at noware dot com >>>>> _______________________________________________ >>>>> Powered by www.kitware.com >>>>> >>>>> Visit other Kitware open-source projects at >>>>> http://www.kitware.com/opensource/opensource.html >>>>> >>>>> Kitware offers ITK Training Courses, for more information visit: >>>>> http://kitware.com/products/protraining.php >>>>> >>>>> Please keep messages on-topic and check the ITK FAQ at: >>>>> http://www.itk.org/Wiki/ITK_FAQ >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> http://public.kitware.com/mailman/listinfo/insight-developers >>> >>> >>> >>> -- >>> Unpaid intern in BillsBasement at noware dot com >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/insight-developers >>> _______________________________________________ >>> Community mailing list >>> Community at itk.org >>> http://public.kitware.com/mailman/listinfo/community >> > > > > -- > Unpaid intern in BillsBasement at noware dot com -- Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Tue May 26 12:02:31 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 26 May 2015 12:02:31 -0400 Subject: [ITK-dev] [ITK] Enhancements for 4.8 In-Reply-To: References: Message-ID: I think we should revert the event macro code until we find a backward compatible solution. On Tue, May 26, 2015 at 11:47 AM, Matt McCormick wrote: > Hi, > > Per our release schedule [1], the first 4.8 release candidate is > scheduled to be tagged on Monday, June 8th. Please have all > enhancements that have been reviewed and are passing tests merged by > next Friday, June 5th. > > Thanks, > Matt > > [1] http://www.itk.org/Wiki/ITK/Release_Schedule > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers > _______________________________________________ > Community mailing list > Community at itk.org > http://public.kitware.com/mailman/listinfo/community -- Unpaid intern in BillsBasement at noware dot com From blowekamp at mail.nih.gov Tue May 26 13:26:48 2015 From: blowekamp at mail.nih.gov (Bradley Lowekamp) Date: Tue, 26 May 2015 13:26:48 -0400 Subject: [ITK-dev] [ITK] ITK API Change (was ITKApps failing after recent commit) In-Reply-To: References: Message-ID: <36F5E631-2B07-4CB8-A7FC-EFDE3F4199FE@mail.nih.gov> Bill, I am OK reverting the implementation of the itkEvenMacro. But I think we can keep the separated definition of the ITK classes and the current implementation of itkEventMacroDeclaration, and itkEventMacroDefinition. Brad On May 26, 2015, at 12:01 PM, Bill Lorensen wrote: > Brad, > > In an application, by separating the declaration (in a .h file) from > the definition (in a .cxx file) solves the problem. But this is a PITA > for an application that currently uses itkEventMacro. Upsetting > customers is not moving forward. > > > On Tue, May 26, 2015 at 11:58 AM, Bill Lorensen wrote: >> Brad, >> >> That is not the problem. The old macro duplicated implementations in >> each file that included a common .h file. The new api changes that. >> But, is it important. I think not. The old, less elegant form, worked. >> >> >> On Tue, May 26, 2015 at 11:44 AM, Bradley Lowekamp >> wrote: >>> >>> Lets try to keep moving forward. >>> >>> The itkEventMacro is not really used in ITK. It should not be hard to revert it to the old behavior. >>> >>> All that is likely needed is to improve the usage of the ITKEvent_EXPORT define [1]. It looks like the re-write of these macros was only intended for internal ITK usage as it's defined an ITKCommom_EXPORT. >>> >>> Brad >>> >>> >>> >>> [1] https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/Common/include/itkEventObject.h#L108 >>> >>> On May 26, 2015, at 11:37 AM, Bill Lorensen wrote: >>> >>>> I agree. I will soon have a patch to the ITKApps that works for both >>>> versions of ITK. This will illustrate how much work is required to >>>> support both API's. The current ITK makes itkEventMacro dangerous and >>>> worthless. >>>> >>>> On Tue, May 26, 2015 at 11:31 AM, Matt McCormick >>>> wrote: >>>>> Hi Bill, >>>>> >>>>> Thanks for bringing attention to this. If we cannot find a way for >>>>> external Event code to work without modification, I thing we should >>>>> revert the change before we release 4.8. >>>>> >>>>> 2 cents, >>>>> Matt >>>>> >>>>> On Tue, May 26, 2015 at 11:26 AM, Bill Lorensen wrote: >>>>>> itkEventMacro no longer works the way it used to. Applications that used >>>>>> itkEventMacro(myEvent, itk::UserEvent); >>>>>> must break up the statement into two statements and two files: >>>>>> in the .h file >>>>>> itkEventMacroDeclaration(myEvent,itk::UserEvent); >>>>>> in the .cxx file >>>>>> itkEventMacroDefinition(myEvent,itk::UserEvent); >>>>>> >>>>>> The problems occurs when an application has multiple source files that >>>>>> include the file with itkEventMacro. Duplicate symbols are created >>>>>> now. Prior to the API-break this was fine. >>>>>> >>>>>> Application code that uses itkEventMacro that wants to support ITK >>>>>> pre-the-API-break and post-the-API-break will need further statements. >>>>>> >>>>>> I am working on getting the ITKApps to work with both pre and post >>>>>> API-break versions. >>>>>> >>>>>> The unintended consequences of this API break are troublesome. >>>>>> >>>>>> On Mon, May 25, 2015 at 3:10 PM, Bill Lorensen wrote: >>>>>>> itksnap also has issues with the API change. I'll try to make a small >>>>>>> example that illustrates the problem. >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Mon, May 25, 2015 at 12:08 PM, Bill Lorensen wrote: >>>>>>>> Looks to me that the API for itkEventMacro has changed. This is bad. >>>>>>>> In ITKApps there are several definitions like this. How must these be >>>>>>>> changed? >>>>>>>> >>>>>>>> namespace fltk { >>>>>>>> >>>>>>>> /** >>>>>>>> * List of the events expected in this domain >>>>>>>> */ >>>>>>>> itkEventMacro( RedrawEvent, itk::UserEvent ); >>>>>>>> itkEventMacro( GlDrawEvent, itk::UserEvent ); >>>>>>>> itkEventMacro( VolumeReslicedEvent, itk::UserEvent ); >>>>>>>> itkEventMacro( ClippingPlaneEvent, itk::UserEvent ); >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> } // end namespace fltk >>>>>>>> >>>>>>>> >>>>>>>> On Mon, May 25, 2015 at 11:59 AM, Bill Lorensen wrote: >>>>>>>>> Since this topic was merged, ITKApps failk to build. I narrowed it >>>>>>>>> down using git commit. >>>>>>>>> >>>>>>>>> http://review.source.kitware.com/#/c/19729/ >>>>>>>>> >>>>>>>>> Here is the failing dashboard entry: >>>>>>>>> https://open.cdash.org/viewBuildError.php?buildid=3828894 >>>>>>>>> >>>>>>>>> I'll take a lot to see if I can fix it. >>>>>>>>> >>>>>>>>> Bill >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Unpaid intern in BillsBasement at noware dot com >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Unpaid intern in BillsBasement at noware dot com >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Unpaid intern in BillsBasement at noware dot com >>>>>> _______________________________________________ >>>>>> Powered by www.kitware.com >>>>>> >>>>>> Visit other Kitware open-source projects at >>>>>> http://www.kitware.com/opensource/opensource.html >>>>>> >>>>>> Kitware offers ITK Training Courses, for more information visit: >>>>>> http://kitware.com/products/protraining.php >>>>>> >>>>>> Please keep messages on-topic and check the ITK FAQ at: >>>>>> http://www.itk.org/Wiki/ITK_FAQ >>>>>> >>>>>> Follow this link to subscribe/unsubscribe: >>>>>> http://public.kitware.com/mailman/listinfo/insight-developers >>>> >>>> >>>> >>>> -- >>>> Unpaid intern in BillsBasement at noware dot com >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Kitware offers ITK Training Courses, for more information visit: >>>> http://kitware.com/products/protraining.php >>>> >>>> Please keep messages on-topic and check the ITK FAQ at: >>>> http://www.itk.org/Wiki/ITK_FAQ >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://public.kitware.com/mailman/listinfo/insight-developers >>>> _______________________________________________ >>>> Community mailing list >>>> Community at itk.org >>>> http://public.kitware.com/mailman/listinfo/community >>> >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com > > > > -- > Unpaid intern in BillsBasement at noware dot com From bill.lorensen at gmail.com Tue May 26 14:57:13 2015 From: bill.lorensen at gmail.com (Bill Lorensen) Date: Tue, 26 May 2015 14:57:13 -0400 Subject: [ITK-dev] [ITK] ITK API Change (was ITKApps failing after recent commit) In-Reply-To: <36F5E631-2B07-4CB8-A7FC-EFDE3F4199FE@mail.nih.gov> References: <36F5E631-2B07-4CB8-A7FC-EFDE3F4199FE@mail.nih.gov> Message-ID: I'll take a stab at a patch. On Tue, May 26, 2015 at 1:26 PM, Bradley Lowekamp wrote: > Bill, > > I am OK reverting the implementation of the itkEvenMacro. > > But I think we can keep the separated definition of the ITK classes and the current implementation of itkEventMacroDeclaration, and itkEventMacroDefinition. > > Brad > > On May 26, 2015, at 12:01 PM, Bill Lorensen wrote: > >> Brad, >> >> In an application, by separating the declaration (in a .h file) from >> the definition (in a .cxx file) solves the problem. But this is a PITA >> for an application that currently uses itkEventMacro. Upsetting >> customers is not moving forward. >> >> >> On Tue, May 26, 2015 at 11:58 AM, Bill Lorensen wrote: >>> Brad, >>> >>> That is not the problem. The old macro duplicated implementations in >>> each file that included a common .h file. The new api changes that. >>> But, is it important. I think not. The old, less elegant form, worked. >>> >>> >>> On Tue, May 26, 2015 at 11:44 AM, Bradley Lowekamp >>> wrote: >>>> >>>> Lets try to keep moving forward. >>>> >>>> The itkEventMacro is not really used in ITK. It should not be hard to revert it to the old behavior. >>>> >>>> All that is likely needed is to improve the usage of the ITKEvent_EXPORT define [1]. It looks like the re-write of these macros was only intended for internal ITK usage as it's defined an ITKCommom_EXPORT. >>>> >>>> Brad >>>> >>>> >>>> >>>> [1] https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/Common/include/itkEventObject.h#L108 >>>> >>>> On May 26, 2015, at 11:37 AM, Bill Lorensen wrote: >>>> >>>>> I agree. I will soon have a patch to the ITKApps that works for both >>>>> versions of ITK. This will illustrate how much work is required to >>>>> support both API's. The current ITK makes itkEventMacro dangerous and >>>>> worthless. >>>>> >>>>> On Tue, May 26, 2015 at 11:31 AM, Matt McCormick >>>>> wrote: >>>>>> Hi Bill, >>>>>> >>>>>> Thanks for bringing attention to this. If we cannot find a way for >>>>>> external Event code to work without modification, I thing we should >>>>>> revert the change before we release 4.8. >>>>>> >>>>>> 2 cents, >>>>>> Matt >>>>>> >>>>>> On Tue, May 26, 2015 at 11:26 AM, Bill Lorensen wrote: >>>>>>> itkEventMacro no longer works the way it used to. Applications that used >>>>>>> itkEventMacro(myEvent, itk::UserEvent); >>>>>>> must break up the statement into two statements and two files: >>>>>>> in the .h file >>>>>>> itkEventMacroDeclaration(myEvent,itk::UserEvent); >>>>>>> in the .cxx file >>>>>>> itkEventMacroDefinition(myEvent,itk::UserEvent); >>>>>>> >>>>>>> The problems occurs when an application has multiple source files that >>>>>>> include the file with itkEventMacro. Duplicate symbols are created >>>>>>> now. Prior to the API-break this was fine. >>>>>>> >>>>>>> Application code that uses itkEventMacro that wants to support ITK >>>>>>> pre-the-API-break and post-the-API-break will need further statements. >>>>>>> >>>>>>> I am working on getting the ITKApps to work with both pre and post >>>>>>> API-break versions. >>>>>>> >>>>>>> The unintended consequences of this API break are troublesome. >>>>>>> >>>>>>> On Mon, May 25, 2015 at 3:10 PM, Bill Lorensen wrote: >>>>>>>> itksnap also has issues with the API change. I'll try to make a small >>>>>>>> example that illustrates the problem. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Mon, May 25, 2015 at 12:08 PM, Bill Lorensen wrote: >>>>>>>>> Looks to me that the API for itkEventMacro has changed. This is bad. >>>>>>>>> In ITKApps there are several definitions like this. How must these be >>>>>>>>> changed? >>>>>>>>> >>>>>>>>> namespace fltk { >>>>>>>>> >>>>>>>>> /** >>>>>>>>> * List of the events expected in this domain >>>>>>>>> */ >>>>>>>>> itkEventMacro( RedrawEvent, itk::UserEvent ); >>>>>>>>> itkEventMacro( GlDrawEvent, itk::UserEvent ); >>>>>>>>> itkEventMacro( VolumeReslicedEvent, itk::UserEvent ); >>>>>>>>> itkEventMacro( ClippingPlaneEvent, itk::UserEvent ); >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> } // end namespace fltk >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, May 25, 2015 at 11:59 AM, Bill Lorensen wrote: >>>>>>>>>> Since this topic was merged, ITKApps failk to build. I narrowed it >>>>>>>>>> down using git commit. >>>>>>>>>> >>>>>>>>>> http://review.source.kitware.com/#/c/19729/ >>>>>>>>>> >>>>>>>>>> Here is the failing dashboard entry: >>>>>>>>>> https://open.cdash.org/viewBuildError.php?buildid=3828894 >>>>>>>>>> >>>>>>>>>> I'll take a lot to see if I can fix it. >>>>>>>>>> >>>>>>>>>> Bill >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Unpaid intern in BillsBasement at noware dot com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Unpaid intern in BillsBasement at noware dot com >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Unpaid intern in BillsBasement at noware dot com >>>>>>> _______________________________________________ >>>>>>> Powered by www.kitware.com >>>>>>> >>>>>>> Visit other Kitware open-source projects at >>>>>>> http://www.kitware.com/opensource/opensource.html >>>>>>> >>>>>>> Kitware offers ITK Training Courses, for more information visit: >>>>>>> http://kitware.com/products/protraining.php >>>>>>> >>>>>>> Please keep messages on-topic and check the ITK FAQ at: >>>>>>> http://www.itk.org/Wiki/ITK_FAQ >>>>>>> >>>>>>> Follow this link to subscribe/unsubscribe: >>>>>>> http://public.kitware.com/mailman/listinfo/insight-developers >>>>> >>>>> >>>>> >>>>> -- >>>>> Unpaid intern in BillsBasement at noware dot com >>>>> _______________________________________________ >>>>> Powered by www.kitware.com >>>>> >>>>> Visit other Kitware open-source projects at >>>>> http://www.kitware.com/opensource/opensource.html >>>>> >>>>> Kitware offers ITK Training Courses, for more information visit: >>>>> http://kitware.com/products/protraining.php >>>>> >>>>> Please keep messages on-topic and check the ITK FAQ at: >>>>> http://www.itk.org/Wiki/ITK_FAQ >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> http://public.kitware.com/mailman/listinfo/insight-developers >>>>> _______________________________________________ >>>>> Community mailing list >>>>> Community at itk.org >>>>> http://public.kitware.com/mailman/listinfo/community >>>> >>> >>> >>> >>> -- >>> Unpaid intern in BillsBasement at noware dot com >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com > -- Unpaid intern in BillsBasement at noware dot com From jgonzabal at gmail.com Wed May 27 03:57:43 2015 From: jgonzabal at gmail.com (=?UTF-8?Q?Javier_Gonz=C3=A1lez_Gonz=C3=A1lez=2DZabaleta?=) Date: Wed, 27 May 2015 09:57:43 +0200 Subject: [ITK-dev] Fwd: Scale and share your ITK software using Medimsight In-Reply-To: References: Message-ID: Hello colleagues, Medimsight is a new cloud platform that wants to help medical image analysis developers to share and enhance their analysis algorithms. We put at the same place, R&D and an easy UI for Clinicians worldwide. Develop in Medimsight is very easy, we use Linux machines and all the standard libraries. Just encapsulate your code in python. Even if you have code in C++, Java, etc, your code will work in our cloud in a few minutes. To put a new method on Medimsight is absolutely free for developers and if you decide to win money with it you will decide the final price with a fee of just the 33% of sales. Easy and fast distributions that will help your team to get access to more clients and also get faster certifications. We want to promote the use of ITK (Or SimpleITK) and we will do a competition for new methods in the near future. Here is an example of code that uses an ITK executable and SimpleITK: *myinput = mdsutil.get_input("vol_t1")* *import subprocess* *dicom2nrrd = "./DicomSeriesReadImageWrite2 " + myinput + ' ' + 'head.nrrd'* *out, err = subprocess.Popen(dicom2nrrd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate()* *import SimpleITK as sitk* *img = sitk.ReadImage('head.nrrd')* *t = sitk.ThresholdImageFilter()* *t.SetLower(500)* *t.SetUpper(1000)* *t.SetOutsideValue(0)* *timg = t.Execute(img)* *sitk.WriteImage(timg, 'volume.nii.gz')* *mdsutil.set_output("vol_out", 'volume.nii.gz')* Users will receive the new volume as another image, but also, we can get back .PDF, .VTK, video, .TRK, etc. I invite you to join Medimsight community. Best regards! -- Javier Gonz?lez Glez.-Zabaleta Tel. M?vil: (+34) 687918369 -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Thu May 28 15:21:14 2015 From: sean at rogue-research.com (Sean McBride) Date: Thu, 28 May 2015 15:21:14 -0400 Subject: [ITK-dev] clang -Wdocumentation-unknown-command warnings Message-ID: <20150528192114.1043256461@mail.rogue-research.com> Hi all, On one of my dashboards here: We see the following warnings: ITK/Modules/Core/Common/include/itkNumericTraits.h:65:4: warning: unknown command tag name [-Wdocumentation-unknown-command] * \wiki ^ ITK/Modules/Core/Common/include/itkNumericTraits.h:66:4: warning: unknown command tag name [-Wdocumentation-unknown-command] * \wikiexample{SimpleOperations/NumericTraits,Get some basic information about a type} ^ ITK/Modules/Core/Common/include/itkNumericTraits.h:67:4: warning: unknown command tag name [-Wdocumentation-unknown-command] * \endwiki ^ Indeed I don't see \wiki etc in the list of doxygen commands: What's the story with these tags? Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From matt.mccormick at kitware.com Thu May 28 15:26:24 2015 From: matt.mccormick at kitware.com (Matt McCormick) Date: Thu, 28 May 2015 15:26:24 -0400 Subject: [ITK-dev] clang -Wdocumentation-unknown-command warnings In-Reply-To: <20150528192114.1043256461@mail.rogue-research.com> References: <20150528192114.1043256461@mail.rogue-research.com> Message-ID: Hi Sean, These are aliases defined to help link to the Wiki examples. They are defined in the doxygen.config [1]. Matt [1] http://itk.org/gitweb?p=ITK.git;a=blob;f=Utilities/Doxygen/doxygen.config.in;h=452ebc425317d06657fa2f0d54f5febf77490c4d;hb=HEAD#l231 On Thu, May 28, 2015 at 3:21 PM, Sean McBride wrote: > Hi all, > > On one of my dashboards here: > > > We see the following warnings: > > ITK/Modules/Core/Common/include/itkNumericTraits.h:65:4: warning: unknown command tag name [-Wdocumentation-unknown-command] > * \wiki > ^ > ITK/Modules/Core/Common/include/itkNumericTraits.h:66:4: warning: unknown command tag name [-Wdocumentation-unknown-command] > * \wikiexample{SimpleOperations/NumericTraits,Get some basic information about a type} > ^ > ITK/Modules/Core/Common/include/itkNumericTraits.h:67:4: warning: unknown command tag name [-Wdocumentation-unknown-command] > * \endwiki > ^ > > Indeed I don't see \wiki etc in the list of doxygen commands: > > > What's the story with these tags? > > Cheers, > > -- > ____________________________________________________________ > Sean McBride, B. Eng sean at rogue-research.com > Rogue Research www.rogue-research.com > Mac Software Developer Montr?al, Qu?bec, Canada > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers From sean at rogue-research.com Thu May 28 15:28:10 2015 From: sean at rogue-research.com (Sean McBride) Date: Thu, 28 May 2015 15:28:10 -0400 Subject: [ITK-dev] clang -Wdocumentation-unknown-command warnings In-Reply-To: References: <20150528192114.1043256461@mail.rogue-research.com> Message-ID: <20150528192810.1462641532@mail.rogue-research.com> On Thu, 28 May 2015 15:26:24 -0400, Matt McCormick said: >These are aliases defined to help link to the Wiki examples. They are >defined in the doxygen.config [1]. > >Matt > >[1] http://itk.org/gitweb?p=ITK.git;a=blob;f=Utilities/Doxygen/ >doxygen.config.in;h=452ebc425317d06657fa2f0d54f5febf77490c4d;hb=HEAD#l231 Ah, interesting. So I guess I should suppress that warning flag? Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada From matt.mccormick at kitware.com Thu May 28 15:41:45 2015 From: matt.mccormick at kitware.com (Matt McCormick) Date: Thu, 28 May 2015 15:41:45 -0400 Subject: [ITK-dev] clang -Wdocumentation-unknown-command warnings In-Reply-To: <20150528192810.1462641532@mail.rogue-research.com> References: <20150528192114.1043256461@mail.rogue-research.com> <20150528192810.1462641532@mail.rogue-research.com> Message-ID: On Thu, May 28, 2015 at 3:28 PM, Sean McBride wrote: > On Thu, 28 May 2015 15:26:24 -0400, Matt McCormick said: > >>These are aliases defined to help link to the Wiki examples. They are >>defined in the doxygen.config [1]. >> >>Matt >> >>[1] http://itk.org/gitweb?p=ITK.git;a=blob;f=Utilities/Doxygen/ >>doxygen.config.in;h=452ebc425317d06657fa2f0d54f5febf77490c4d;hb=HEAD#l231 > > Ah, interesting. So I guess I should suppress that warning flag? Yes, thanks for looking into it! From arnaudgelas at gmail.com Fri May 29 02:20:08 2015 From: arnaudgelas at gmail.com (Arnaud Gelas) Date: Fri, 29 May 2015 08:20:08 +0200 Subject: [ITK-dev] clang -Wdocumentation-unknown-command warnings In-Reply-To: <20150528192810.1462641532@mail.rogue-research.com> References: <20150528192114.1043256461@mail.rogue-research.com> <20150528192810.1462641532@mail.rogue-research.com> Message-ID: <14CD0D91-7CC8-46C8-9DC2-DF6766B14F6E@gmail.com> Hi Sean, If I am not mistaken, following clang?s documentation [1], you could add -fcomment-block-commands=wiki ?? Arnaud [1] http://clang.llvm.org/docs/UsersManual.html#cmdoption-fcomment-block-commands > On 28 May 2015, at 21:28, Sean McBride wrote: > > On Thu, 28 May 2015 15:26:24 -0400, Matt McCormick said: > >> These are aliases defined to help link to the Wiki examples. They are >> defined in the doxygen.config [1]. >> >> Matt >> >> [1] http://itk.org/gitweb?p=ITK.git;a=blob;f=Utilities/Doxygen/ >> doxygen.config.in;h=452ebc425317d06657fa2f0d54f5febf77490c4d;hb=HEAD#l231 > > Ah, interesting. So I guess I should suppress that warning flag? > > Cheers, > > -- > ____________________________________________________________ > Sean McBride, B. Eng sean at rogue-research.com > Rogue Research www.rogue-research.com > Mac Software Developer Montr?al, Qu?bec, Canada > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/insight-developers -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean at rogue-research.com Fri May 29 15:43:38 2015 From: sean at rogue-research.com (Sean McBride) Date: Fri, 29 May 2015 15:43:38 -0400 Subject: [ITK-dev] clang -Wdocumentation-unknown-command warnings In-Reply-To: <14CD0D91-7CC8-46C8-9DC2-DF6766B14F6E@gmail.com> References: <20150528192114.1043256461@mail.rogue-research.com> <20150528192810.1462641532@mail.rogue-research.com> <14CD0D91-7CC8-46C8-9DC2-DF6766B14F6E@gmail.com> Message-ID: <20150529194338.1475298576@mail.rogue-research.com> On Fri, 29 May 2015 08:20:08 +0200, Arnaud Gelas said: >If I am not mistaken, following clang?s documentation [1], you could add >-fcomment-block-commands=wiki ?? Thanks! I've made this change, we'll see on tonight's build... Cheers, -- ____________________________________________________________ Sean McBride, B. Eng sean at rogue-research.com Rogue Research www.rogue-research.com Mac Software Developer Montr?al, Qu?bec, Canada