[ITK-dev] Function-style preprocessor definitions

[Matt McCormick]

On Fri, Jan 30, 2015 at 4:06 PM, Brad King <brad.king at kitware.com> wrote:
> On 1/30/2015 2:53 PM, Johnson, Hans J wrote:
>> CXX_DEFINES = -D) -DITK_IOFACTORY_REGISTERMANGER ….< other stuff>
>>
>> This happens when building agains VTK and ITK, but with ITK I have
>> VTKGlue turned off.
>
> I cannot reproduce this with a basic setup of the case described.
>
> What versions (Git commit sha1s) of ITK and VTK did you build?
> What version of CMake are you using?
> What configuration options were given to each of ITK and VTK?
> Can you reproduce it with a simple CMakeLists.txt for the app code?

I have been able to reproduce it.  It seems to be related to this change:

  http://review.source.kitware.com/#/c/18944/1

I have ITKVtkGlue ON, ITK_WRAP_PYTHON ON (although I do not know if
they are both required).

It happens with both CMake master and CMake 3.1.0 (although I get two
WARNINGS with CMake master and a single warning with CMake 3.1.0).

Without the above change, errors occur on Windows, when
${ITKVtkGlue_VTK_DEFINITIONS} has content.  On Unix, when it does not
have content, it appears to cause issues with the above change.

What is the best approach here?

Thanks,
Matt