[ITK-dev] New math comparison methods

Bill Lorensen bill.lorensen at gmail.com
Tue Aug 18 12:07:21 EDT 2015


If there are no objections, I'll take a pass on changing new math
comparison operators back to vanilla comparisons for cases where

two integral types of the same type are compared
for example in
Modules/Segmentation/Classifiers/include/itkImageGaussianModelEstimator.hxx:
  if ( Math::NotAlmostEquals( ( m_NumberOfSamples[classIndex][0] - 1 ), 0.0 ) )

I think there may be other cases that can be reverted but I won't know
until I do a line by line inspection./




On Tue, Aug 18, 2015 at 11:42 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> Folks,
>
> It is hard for me see see why the new math comparison operators are
> used for statements like this one in Core/Common/test/
> itkDerivativeOperatorTest
>
>     if( itk::Math::NotAlmostEquals( expected.size(), coefficients.size() ) )
> instead of the original:
>     if( expected.size() != coefficients.size() )
>
> Can we revisit this topic?
>
> Bill



-- 
Unpaid intern in BillsBasement at noware dot com


More information about the Insight-developers mailing list