[ITK-dev] [ITK] ITK bugs with recent patch

Tue Apr 21 17:46:10 EDT 2015

After conversations, here is a new patch:

  http://review.source.kitware.com/#/c/19667/

I tested locally on Linux.  Please test on the Mac.

Thanks,
Matt

On Tue, Apr 21, 2015 at 1:54 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> JC,
>
> Patches from experts are also welcome on gerrit.
>
> Bill
>
>
> On Tue, Apr 21, 2015 at 1:23 PM, Jean-Christophe Fillion-Robin
> <jchris.fillionr at kitware.com> wrote:
>> Hi Bill, Hans, Matt,
>>
>> To account for the different VTK backends, you could introduce an option
>> named ITK_VTK_BACKEND that would default to "OpenGL", that way you would
>> specific VTK components using "vtkRendering${ITK_VTK_BACKEND}".
>>
>> To account for the fact recent version of VTK do not provide
>> vtkRenderingFreeType${ITK_VTK_BACKEND} [1], you could add a compile test
>> internally calling "find_package(VTK)" and checking if the target
>> "vtkRenderingFreeType${ITK_VTK_BACKEND}" exists using "if(TARGET
>> vtkRenderingFreeType${ITK_VTK_BACKEND})".
>>
>> Hth
>> Jc
>>
>> [1] https://github.com/Kitware/VTK/commit/4f7460a57
>>
>>
>> On Tue, Apr 21, 2015 at 11:40 AM, Bill Lorensen <bill.lorensen at gmail.com>
>> wrote:
>>>
>>> I think we need to revert the patch. Since vtkRenderingFreeTypeOpenGL
>>> is now gone from VTK, the warnings go away (I'm verifying that now).
>>> It does mean that using a VTK prior to the removal of that module,
>>> users will get the warning.
>>>
>>> Bill
>>>
>>> On Tue, Apr 21, 2015 at 11:37 AM, Johnson, Hans J
>>> <hans-johnson at uiowa.edu> wrote:
>>> > Mac build, but with fairly up-to-date version of VTK.
>>> >
>>> > Hans
>>> >
>>> >> On Apr 21, 2015, at 10:15 AM, Bill Lorensen <bill.lorensen at gmail.com>
>>> >> wrote:
>>> >>
>>> >> I see it also on my Mac. I'll investigate.
>>> >>
>>> >> On Tue, Apr 21, 2015 at 11:11 AM, Johnson, Hans J
>>> >> <hans-johnson at uiowa.edu> wrote:
>>> >>> Matt and Bill,
>>> >>>
>>> >>> I think a new bug has been introduced for ITK.
>>> >>>
>>> >>>
>>> >>>
>>> >>> CMake Error at
>>> >>> /scratch/johnsonhj/src/BT-bld/VTK/CMake/vtkModuleAPI.cmake:120
>>> >>> (message):
>>> >>>  Requested modules not available:
>>> >>>
>>> >>>    vtkRenderingFreeTypeOpenGL
>>> >>> Call Stack (most recent call first):
>>> >>>  Modules/Bridge/VtkGlue/CMakeLists.txt:31 (vtk_module_config)
>>> >>>
>>> >>>
>>> >>> -- Configuring incomplete, errors occurred!
>>> >>> See also
>>> >>>
>>> >>> "/scratch/johnsonhj/src/BT-bld/ITKv4-build/CMakeFiles/CMakeOutput.log".
>>> >>> See also
>>> >>> "/scratch/johnsonhj/src/BT-bld/ITKv4-build/CMakeFiles/CMakeError.log".
>>> >>> make[2]: *** [ITKv4-prefix/src/ITKv4-stamp/ITKv4-configure] Error 1
>>> >>> make[1]: *** [CMakeFiles/ITKv4.dir/all] Error 2
>>> >>> make: *** [all] Error 2
>>> >>>
>>> >>> Hans
>>> >>>
>>> >>>
>>> >>>
>>> >>> ========================================================================
>>> >>> Hans J. Johnson, Ph.D.,  Associate Professor
>>> >>> Electrical and Computer Engineering (Primary), Biomedical Engineering,
>>> >>> Psychiatry
>>> >>> hans-johnson at uiowa.edu
>>> >>> (319) 621 7185 (cell)
>>> >>> (319) 384 3538  ECE Phone (Primary)
>>> >>> (319) 353 8587 Psychiatry Phone (Secondary)
>>> >>>
>>> >>> 4316 Seamans Center
>>> >>> Iowa City, IA 52242
>>> >>>
>>> >>>
>>> >>>
>>> >>> ________________________________
>>> >>> Notice: This UI Health Care e-mail (including attachments) is covered
>>> >>> by the
>>> >>> Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>> >>> confidential
>>> >>> and may be legally privileged.  If you are not the intended recipient,
>>> >>> you
>>> >>> are hereby notified that any retention, dissemination, distribution,
>>> >>> or
>>> >>> copying of this communication is strictly prohibited.  Please reply to
>>> >>> the
>>> >>> sender that you have received the message in error, then delete it.
>>> >>> Thank
>>> >>> you.
>>> >>> ________________________________
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Unpaid intern in BillsBasement at noware dot com
>>> >
>>> >
>>> >
>>> > ________________________________
>>> > Notice: This UI Health Care e-mail (including attachments) is covered by
>>> > the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>> > confidential and may be legally privileged.  If you are not the intended
>>> > recipient, you are hereby notified that any retention, dissemination,
>>> > distribution, or copying of this communication is strictly prohibited.
>>> > Please reply to the sender that you have received the message in error, then
>>> > delete it.  Thank you.
>>> > ________________________________
>>>
>>>
>>>
>>> --
>>> Unpaid intern in BillsBasement at noware dot com
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.php
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://public.kitware.com/mailman/listinfo/insight-developers
>>
>>
>>
>>
>> --
>> +1 919 869 8849
>
>
>
> --
> Unpaid intern in BillsBasement at noware dot com
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers
> _______________________________________________
> Community mailing list
> Community at itk.org
> http://public.kitware.com/mailman/listinfo/community