[Insight-developers] [ITK Community] A Contrib group?

[Brad King]

On 01/15/2014 05:40 PM, Matt McCormick wrote:
> An Contrib Group is a neat idea.  What is the difference between this
> and Nonunit/Review though?

FWIW, one of the goals of modularization, conversion to Git, and
introduction of code review tools was to get rid of the "Review"
kit (which was just another name for "Contrib").  In practice code
rarely graduates from contrib directories.  Code should either be
supported or not included in the first place.

A proposed module should simply be locally added to the correct
group and located in the source tree where it would belong as a
first-class module.  Then it should go through the Insight Journal
or just Gerrit review.  If accepted then it should be merged
immediately as a first-class supported module.  If not then it
should be revised prior to inclusion in upstream.

What is the purpose of IJ + Gerrit if not to review code to ensure
sufficient quality before acceptance?  The bar should not be made
lower just by labeling something "Contrib".  Such a lower bar is
one reason code rarely graduates out of that label.

-Brad K