[ITK-dev] New clang warnings: reserved-id-macro

[Matt McCormick]

Personally, I don't have any strong preference.

How about

  itkFooBar_h

, since it seems to be the most compatible.

Thanks,
Matt


On Fri, Dec 12, 2014 at 9:22 AM, Bradley Lowekamp
<blowekamp at mail.nih.gov> wrote:
> And all the remote modules should be updated as well...
>
>
> On Dec 11, 2014, at 3:30 PM, Sean McBride <sean at rogue-research.com> wrote:
>
>> On Thu, 11 Dec 2014 15:20:31 -0500, Bradley Lowekamp said:
>>
>>> Having the header guarder not begin with an '_' seems wrong to me.
>>>
>>> What about _<project>_<filename>?
>>
>> That works too as long as <project> starts lowercase, as starting with underscore+uppercase is also reserved.  So "_itkFooBar_h" would be ok, but not "_ITKFOOBAR_H" for example.
>>
>> Adding another underscore between seems gratuitous though.
>>
>> This change will touch hundreds and hundreds of files, so you guys decide on the scheme, then I'll do it. :)
>>
>> Cheers,
>>
>> --
>> ____________________________________________________________
>> Sean McBride, B. Eng                 sean at rogue-research.com
>> Rogue Research                        www.rogue-research.com
>> Mac Software Developer              Montréal, Québec, Canada
>>
>>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-developers