[ITK-dev] New clang warnings: reserved-id-macro

[Bradley Lowekamp]

I Think so:

https://github.com/InsightSoftwareConsortium/ITK/blob/master/Utilities/KWStyle/ITK.kws.xml#L14

Having the header guarder not begin with an '_' seems wrong to me. 

What about _<project>_<filename>?

Brad


On Dec 11, 2014, at 3:15 PM, Sean McBride <sean at rogue-research.com> wrote:

> On Thu, 11 Dec 2014 12:32:49 -0500, Bradley Lowekamp said:
> 
>> warning: reserved identifier is used as macro name [-Wreserved-id-macro]
>> #define __itkMacro_h
> 
> So I did some find/replace, but when I try to commit, I get:
> 
> ---------------------------
> Examples/IO/XML/itkParticleSwarmOptimizerDOMReader.h:29: error: itkParticleSwarmOptimizerDOMReader_h v.s. __itkParticleSwarmOptimizerDOMReader_h
> pre-commit hook failure
> -----------------------
> 
> KWStyle check failed.
> 
> Line numbers in the errors shown refer to the file:
> Examples/IO/XML/itkParticleSwarmOptimizerDOMReader.h.kws
> ---------------------------
> 
> Is there a style check that's checking for a header guard format?!
> 
> Cheers,
> 
> -- 
> ____________________________________________________________
> Sean McBride, B. Eng                 sean at rogue-research.com
> Rogue Research                        www.rogue-research.com 
> Mac Software Developer              Montréal, Québec, Canada
> 
>