[Insight-developers] JPEG2000 bool issue on OSX ppc

[Matt McCormick]

Excellent work, Brad and Sean!

Please go ahead and merge the second patch if the CDash at Home builds
come back OK.  I am currently at the ITK-UNC workshop, and I will not
likely get a chance.

Thanks,
Matt

On Tue, May 28, 2013 at 12:16 PM, Bradley Lowekamp
<blowekamp at mail.nih.gov> wrote:
> Matt,
>
> I have submitted two patch either of which should address the problem:
>
> BUG: Use stdbool for C bool type in openjpeg2000
> BUG: C++ bool is 4 bytes on osx ppc
>
> So we should have a choose of what is the best solution and is most likely
> to work.
>
> Brad
>
> On May 28, 2013, at 9:37 AM, Matt McCormick <matt.mccormick at kitware.com>
> wrote:
>
> Hi Brad,
>
> Is there time to get this issue merged today?  If so, we could still
> create the tarballs tomorrow, then wait for another clean dashboard
> before the announcement.
>
> Thanks,
> Matt
>
>
>
> On Tue, May 28, 2013 at 8:53 AM, Bradley Lowekamp
> <blowekamp at mail.nih.gov> wrote:
>
> Hello,
>
> My hack for JPEG2000's 1.2 bool issue:
>
> https://github.com/Kitware/ITK/commit/a7eee65
>
> is not working for OSX ppc:
>
> http://open.cdash.org/viewTest.php?onlyfailed&buildid=2920031
>
> because sizeof(bool) there is 4. So it looks like I'll need to do a try
> compile thing to get the right size... it'll still be a hack until we can
> upgrade to JPEG2000 2.0.
>
> This is particularly erk-some since I just put in a good bit of effort to
> fix the other failing tests:
>
> http://open.cdash.org/viewTest.php?onlyfailed&buildid=2907078
>
> Brad
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>