[Insight-developers] OpenJPEG 2000

[Bradley Lowekamp]

On May 23, 2013, at 11:32 AM, Brad King <brad.king at kitware.com> wrote:
> The content of the new commit looks good.  I usually use the date
> printed out by the extraction script as the --date value on the
> "git commit" line so that the authorship recorded for the commit
> not only reflects the upstream developers but the upstream time
> of the version as well.

OK, that makes sense. 

> 
>> The only thing missing is that to initially copy the upstream branch ( when you are starting something new or a like my case ) into ITK I have used the following command (after a commit to delete the old): 
>> 
>> git read-tree --prefix=Modules/ThirdParty/OpenJPEG/src/openjpeg -u openjpeg-upstream
> 
> That's correct.  The VNL instructions leave that out because they
> are for updating the already-initialized tree.

That comment was mainly to document my process here in the mailing list.

> 
> You'll also have trouble pushing/merging it the first time to
> master but just put the full topic somewhere I can fetch and
> I'll push it for you.  The reason is that there is a server-side
> hook that blocks new root commits from entering history.  It is
> there to prevent someone from accidentally merging an unrelated
> project's history into ITK.

That commit hooks seems like a very good idea.

Let me get everything working and compiling inside ITK before we do anything like that.

Lastly is there any concern about adding these additional branches to ITK is terms of ITKs size? I would guess that it's mostly adding the same code, just in a different place. Git is likely doing something very smart, so that we are adding very little to the size of the repo.

Thanks for all you help!

Brad