[Insight-developers] Release branch broken with regards to Review module

[Matt McCormick]

Patch:

http://review.source.kitware.com/#/c/12147/

On Tue, Jul 30, 2013 at 11:15 PM, Matt McCormick
<matt.mccormick at kitware.com> wrote:
> Hi Brad,
>
> Great observations!
>
> With a second configure:
>
>   http://open.cdash.org/buildSummary.php?buildid=2982896
>
> With an initial configure, and ctest -M Experimental -T Build -T Test -T Submit,
>
>   http://open.cdash.org/buildSummary.php?buildid=2983035
>
> +1 for teamwork.
>
> Thanks,
> Matt
>
> On Tue, Jul 30, 2013 at 4:22 PM, Bradley Lowekamp
> <blowekamp at mail.nih.gov> wrote:
>> Matt,
>>
>> Regarding tracking down this bug.
>>
>> The continuous builds are very interesting!
>>
>> The first time run the review tests are missing while the second time the review tests are there!
>>
>> Perhaps the issue goes away if cmake configures the builds twice?
>>
>> Have you tried a clean build tree and just running "cmake -DITK_USE_REVIEW:BOOL=ONE ~/src/ITK & make -j ${NP}", so that cmake configure only happens once?
>>
>> Brad
>>
>> On Jul 30, 2013, at 3:02 PM, Matt McCormick <matt.mccormick at kitware.com> wrote:
>>
>>> Hi Brad,
>>>
>>> I am looking into the issue.  My initial fresh build with default
>>> settings is all clean:
>>>
>>>  http://open.cdash.org/buildSummary.php?buildid=2982863
>>>
>>> but I still need to do further work.
>>>
>>> It is a good idea to let patches hit the Nightly dashboard on master
>>> before merging into release.
>>>
>>> Thanks,
>>> Matt
>>>
>>> On Tue, Jul 30, 2013 at 3:16 PM, Bradley Lowekamp
>>> <blowekamp at mail.nih.gov> wrote:
>>>> Hello,
>>>>
>>>> The release branch is still broken with regards to the modular option to the Review module.
>>>>
>>>> With no sign of a patch, I think the offending patches should be reverted in the release branch. The release branch is suppose to be the most stable! And it's currently not working.
>>>>
>>>> It should be best practices, that any patch merged into the release branch be first merged into the master branch and tested on the dashboard for a night before merging into the stable release branch.
>>>>
>>>> Brad
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://kitware.com/products/protraining.php
>>>>
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>