[Insight-developers] VS warning suppression in itk

[Matt McCormick]

Hi Rupert,

I created an issue in the issue tracker:

  https://issues.itk.org/jira/browse/ITK-3184

I will take a look at it myself if it gets high enough in the priority
list, but the best way to ensure it gets into 4.5.0 is to submit a
patch.

Thanks,
Matt

On Mon, Aug 5, 2013 at 2:41 PM, Rupert Brooks <rupert.brooks at gmail.com> wrote:
> Im glad to hear that you all think its a bug too.  Do we need to do
> something additional to put it on the fix list for 4.5?
>
> The bad news is that VTK also seems to have the problem (caveat, im looking
> at a fairly old version, could be fixed now), and DCMTK has a few instances
> (same caveat).
>
> Rupert
>
>
>
>
> --------------------------------------------------------------
> Rupert Brooks
> rupert.brooks at gmail.com
>
>
> On Wed, Jul 31, 2013 at 6:48 AM, David Cole <dlrdave at aol.com> wrote:
>>
>> Definitely a bug. Thanks for reporting this, Rupert. Until it’s fixed in
>> ITK, I’m glad I’ve isolated my use of ITK into a single header file we
>> include in our app...
>>
>>
>> > +1
>>
>> >> I would say a bug.
>>
>> >>> This has apparently been happening for a long time, but i only noticed
>> >>> it
>> >>> recently.  ITK suppresses a number of Visual Studio warnings in its
>> >>> header
>> >>> files, without pushing or popping the warning state.  As a result,
>> >>> including
>> >>> an ITK header quietly suppresses a number of warnings in my own code.
>>
>>
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.php
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>