[Insight-developers] CMake minimum version number

[Cory Quammen]

Using GET_FILENAME_COMPONENT() seems like the least burden on users.
I'll submit a patch when time allows unless someone beats me to it.

Thanks,
Cory

On Fri, Apr 19, 2013 at 10:33 AM, Xiaoxiao Liu <xiaoxiao.liu at kitware.com> wrote:
> We could use GET_FILENAME_COMPONENT()  if we want to avoid
> updating minimum CMake version requirement for now.
> But I don't see why we should not update the CMake version.
> Do you want to submit a patch to gerrit ?
>
>
>
> On Thu, Apr 18, 2013 at 4:00 PM, Cory Quammen <cquammen at cs.unc.edu> wrote:
>>
>> I just tried to configure ITK master with CMake 2.8.2 because that was
>> the CMake that happened to be on the system. I get the following
>> error:
>>
>>  CMake Error at Modules/ThirdParty/DCMTK/CMakeLists.txt:182 (include):
>>    include could not find load file:
>>
>>      /DCMTKGitTag.cmake
>>
>> This line is
>>
>>   include(${CMAKE_CURRENT_LIST_DIR}/DCMTKGitTag.cmake)
>>
>> Problem is, CMAKE_CURRENT_LIST_DIR isn't defined until CMake 2.8.3.
>>
>> Seems to me that the minimum version of ITK should be bumped up to at
>> least 2.8.3. It is currently 2.8.
>>
>> Thanks,
>> Cory
>>
>> --
>> Cory Quammen
>> Research Associate
>> Department of Computer Science
>> The University of North Carolina at Chapel Hill
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.php
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>
>
>
>
> --
>
>
> ---------------------------------------------
> Xiaoxiao Liu, Ph.D.
> R & D Engineer
> Kitware Inc.
> Clifton Park, NY
> Phone: (518) 881-4924  or  (518) 371-3971 x124
>



-- 
Cory Quammen
Research Associate
Department of Computer Science
The University of North Carolina at Chapel Hill