[Insight-developers] ENH patches for the A2D2 PBNRR

[Bradley Lowekamp]

Matt,

You have a wide variety of patches on the topic "PrimaryName". I am having difficulty reviewing this topic with as many commits as it is, and many of them don't appear to be depended on each other.

If it's a new A2D2, it would be best to get it in while there is still time to work on refining it. And you have an outstanding record of rapidly addressing issue that come up on the dashboard.

As for changing the ProcessObject, to support a custom PrimaryName, I am not enthused by this change. It seems like it's adding more complication to the base class without a huge benefit. With the interwoven commits on this topic it's hard to figure out  where it's needed. It appears that this was the approached used to address some bugs in the BlockMatchingImageFilter. However, I don't see why the standard numbered inputs were not used. It appears that all 3 inputs are required, which matches the conventional usage of numbered inputs.

Sorry for the delayed response,
Brad


========================================================
Bradley Lowekamp  
Medical Science and Computing for
Office of High Performance Computing and Communications
National Library of Medicine 
blowekamp at mail.nih.gov

On Jun 18, 2012, at 7:16 PM, Matt McCormick wrote:

> Hi,
> 
> Please consider the following A2D2 patches for consideration in this
> release cycle.  While it is late in the release process, if they are
> merged within the next few days we will still have funding to address
> any issues that come up on the dashboard during the remainder of the
> week.
> 
> This patch:
> 
>  http://review.source.kitware.com/#/c/6155/
> 
> Is a class to perform the BlockMatching/FEM registration based on the
> already merged feature selection class.
> 
> This patch:
> 
>  http://review.source.kitware.com/#/c/6234/
> 
> Is needed to have the inputs named in the former filter as desired and
> let the pipeline update properly.
> 
> There are also related bug fixes that were discovered in the process
> of preparing the patch:
> 
>  http://review.source.kitware.com/#/c/6238/
>  http://review.source.kitware.com/#/c/6239/
>  http://review.source.kitware.com/#/c/6245/
> 
> Thanks,
> Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/pipermail/insight-developers/attachments/20120621/a97865b6/attachment.htm>