[Insight-developers] ITKApps Superbuild

[Bill Lorensen]

I'm almost ready with a new patch. Hopefully this morning.

On Mon, Jan 30, 2012 at 8:51 AM, Rupert Brooks <rupert.brooks at gmail.com> wrote:
> Hi Bill,
>
> Not sure where your at in this process.  I noticed this mornign that
> the errors in building Morphogenesis could be avoided by changing the
> order of the includes in Cell.h to this
>
> #include "itkRGBPixel.h"
> #include "itkVector.h"
> #include "itkPoint.h"
> #include "Genome.h"
> #include <FL/fl_draw.H>
> #include "fltkSphere3D.h"
>
> Somwhere along the line - i suspect fl_draw - somebody is including
> windows.h which defines macros max and min.... leading to much
> trouble.  Morphogenesis built properly after this change - but it
> strikes me as ugly - that theres a better way to fix the problem.
>
> Hope it helps a bit.
> Rupert
> --------------------------------------------------------------
> Rupert Brooks
> rupert.brooks at gmail.com
>
>
>
> On Sat, Jan 28, 2012 at 09:13, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> Rupert,
>>
>> I'm building now on VS 2010. I fixed the FLTK_DIR issue for windows
>> and will look at the others once my (very slow) old Dell finishes
>> building. I post a gerrit patch when done.
>>
>> Bill
>>
>> On Thu, Jan 26, 2012 at 9:53 AM, Rupert Brooks <rupert.brooks at gmail.com> wrote:
>>> Works on Ubuntu.
>>>
>>> On windows I have two problems
>>> 1 - the superbuild does not fill in the FLTK_DIR in the ITKApps.  And
>>> if i go fill it in myself in CMakeGui, running the superbuild
>>> afterwards will remove it.
>>> 2. if i go into ITKApps, run cmake, fix the FLTK_DIR and try to
>>> compile from the solution generated there, i get build errors.
>>>
>>> As a starting point - i notice that at line 31, of SliceView.h, theres
>>> a "using namespace itk;"  This causes a name conflict with uintptr_t
>>> Removing it leads to problems in fltkImageViewer.h... where itk
>>> namespace is assumed.   (This also gives me wierd deja vu... i thought
>>> this problem appeart in the past and was fixed.)
>>>
>>> I'd be interested to understand the process of making and submitting a
>>> fix.  However, i probably cant spend any time on this till the weekend
>>> or early next week.  If you guys get to it before then, great - if
>>> not, point me to some instructions on how to submit a patch for review
>>> and i'll see what i can do.
>>>
>>> Best
>>>
>>> Rupert
>>>
>>> --------------------------------------------------------------
>>> Rupert Brooks
>>> rupert.brooks at gmail.com
>>>
>>>
>>>
>>> On Wed, Jan 25, 2012 at 17:02, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>>>> I have a patch on gerrit to properly patch FLTK:
>>>> http://review.source.kitware.com/#/c/3741/
>>>>
>>>> Rupert, Can you try this on your Ubuntu system?
>>>>
>>>> Next, I'll look at Windows issues, and I just got a MacAir, so then
>>>> I'll look at Apple issues.
>>>>
>>>> Bill
>>>>
>>>>
>>>> On Wed, Jan 25, 2012 at 11:48 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>>>>> Bill is correct. I tried to take the easy way out. I'll use the patch facility.
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Jan 25, 2012 at 11:39 AM, Bill Hoffman <bill.hoffman at kitware.com> wrote:
>>>>>> On 1/24/2012 10:01 PM, Rupert Brooks wrote:
>>>>>>>
>>>>>>> Yes, and the compile line does have -ldl, but its the first thing on
>>>>>>> the line i.e.
>>>>>>>
>>>>>>> /usr/bin/c++     -ldl CMakeFiles/fluid.dir/CodeEditor.cxx.o
>>>>>>> CMakeFiles/fluid.dir/Fl_Function_Type.cxx.o
>>>>>>> CMakeFiles/fluid.dir/Fl_Group_Type.cxx.o CMakeFiles/flu....
>>>>>>>
>>>>>>> if i manually run the command, and add -ldl at the end, it links ok.
>>>>>>>
>>>>>>> I guess it needs to be added to CMake such that it shows up at the
>>>>>>> end.  Any CMake gurus want to comment?
>>>>>>> --------------------------------------------------------------
>>>>>>> Rupert Brooks
>>>>>>> rupert.brooks at gmail.com
>>>>>>>
>>>>>> This is something that really needs to be in the fltk CMakeLists.txt files.
>>>>>> There is not a clean way to just add libraries to the link line.  You could
>>>>>> use the patch process of exteranl_project_add to add a fix.
>>>>>>
>>>>>> -Bill
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Bill Hoffman
>>>>>> Kitware, Inc.
>>>>>> 28 Corporate Drive
>>>>>> Clifton Park, NY 12065
>>>>>> bill.hoffman at kitware.com
>>>>>> http://www.kitware.com
>>>>>> 518 881-4905 (Direct)
>>>>>> 518 371-3971 x105
>>>>>> Fax (518) 371-4573
>>>>>>
>>>>>> _______________________________________________
>>>>>> Powered by www.kitware.com
>>>>>>
>>>>>> Visit other Kitware open-source projects at
>>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>>
>>>>>> Kitware offers ITK Training Courses, for more information visit:
>>>>>> http://kitware.com/products/protraining.html
>>>>>>
>>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>>
>>>>>> Follow this link to subscribe/unsubscribe:
>>>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Unpaid intern in BillsBasement at noware dot com
>>>>
>>>>
>>>>
>>>> --
>>>> Unpaid intern in BillsBasement at noware dot com
>>
>>
>>
>> --
>> Unpaid intern in BillsBasement at noware dot com



-- 
Unpaid intern in BillsBasement at noware dot com