[Insight-developers] many new test failures, divide by 0 of m_NumberOfPixelsWithDifferences

[Sean McBride]

Hi all,

My dashboards with clang's 'catch undefined behaviour' flags have about 684 new test failures today.

I tried a random one in gdb and it seems to be doing an integer divide by 0.  I'm assuming they are all failing for the same reasons, but maybe not.  I haven't investigated what change caused this, hoping it'll be obvious to someone reading this post. :)

Cheers,

Sean


Program received signal EXC_BAD_INSTRUCTION, Illegal instruction/operand.

itk::Testing::ComparisonImageFilter<itk::Image<double, 6u>, itk::Image<double, 6u> >::AfterThreadedGenerateData (this=0x101dc0920) at itkTestingComparisonImageFilter.hxx:283
283	  m_MeanDifference = m_TotalDifference / m_NumberOfPixelsWithDifferences;

(gdb) p m_NumberOfPixelsWithDifferences
$1 = 0

(gdb) bt
#0  itk::Testing::ComparisonImageFilter<itk::Image<double, 6u>, itk::Image<double, 6u> >::AfterThreadedGenerateData (this=0x101dc0920) at itkTestingComparisonImageFilter.hxx:283
#1  0x00000001001e999e in itk::ImageSource<itk::Image<double, 6u> >::GenerateData (this=0x101dc0920) at itkImageSource.hxx:279
#2  0x0000000100e79e06 in itk::ProcessObject::UpdateOutputData (this=0x101dc0920) at /Users/builder/external/ITK/Modules/Core/Common/src/itkProcessObject.cxx:1500
#3  0x0000000100e9adb9 in itk::DataObject::UpdateOutputData (this=0x102031e00) at /Users/builder/external/ITK/Modules/Core/Common/src/itkDataObject.cxx:434
#4  0x000000010004703a in itk::ImageBase<6u>::UpdateOutputData (this=0x102031e00) at itkImageBase.hxx:285
#5  0x0000000100e9a7e6 in itk::DataObject::Update (this=0x102031e00) at /Users/builder/external/ITK/Modules/Core/Common/src/itkDataObject.cxx:359
#6  0x0000000100e7a675 in itk::ProcessObject::UpdateLargestPossibleRegion (this=0x101dc0920) at /Users/builder/external/ITK/Modules/Core/Common/src/itkProcessObject.cxx:1625
#7  0x0000000100006908 in RegressionTestImage (testImageFilename=0x7fff5fbffb7d "/Users/builder/external/ITK-clang-dbg-x86_64-static/Testing/Temporary/RGBTestImageJPEG.tif", baselineImageFilename=0x101dbf428 "/Users/builder/external/ITK-clang-dbg-x86_64-static/ExternalData/Testing/Data/Baseline/IO/RGBTestImageJPEG.tif", reportErrors=0, intensityTolerance=2, numberOfPixelsTolerance=0, radiusTolerance=0) at itkTestDriverInclude.h:500
#8  0x000000010000bc3f in main (ac=3, av=0x7fff5fbff980) at itkTestDriverAfterTest.inc:60

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada