[Insight-developers] PhilipsRecImageIO

[Bradley Lowekamp]

Kent,

I'd also like to point out that we have had two release candidates since this patch was merged. So the community also was not able to detect this bug since then either.

Brad



On Dec 18, 2012, at 10:48 AM, "Williams, Norman K" <norman-k-williams at uiowa.edu> wrote:

> Mea Maxima Culpa. This was meant to fix a problem where re-use of ImageIO
> objects was putting metadata from one file read into the next file read.
> 
> 
> I should have caught this but like you I didn't have PHilipsRecImageIO
> turned on.
> 
> Is there a good reason not to have this ON by default?  And I'm all for
> making all the factory builds turn on everything that's practical to turn
> on.
> 
> On 12/18/12 4:08 AM, "M.Staring at lumc.nl" <M.Staring at lumc.nl> wrote:
> 
>> Hi Kent,
>> 
>> I noticed that the change 966fcb62c859229f9b421403c4faf3e6ef5e2b81
>> included the line:
>> 
>> metaDict->Clear();
>> to the function ReadImageInformation from itkPhilipsRECImageIO.cxx.
>> 
>> This gives a compile error:
>> 
>> /usr/local/toolkits/ITK/latest_release/src/Modules/IO/PhilipsREC/src/itkPh
>> ilipsRECImageIO.cxx: In member function âvirtual void
>> itk::PhilipsRECImageIO::ReadImageInformation()â:
>> /usr/local/toolkits/ITK/latest_release/src/Modules/IO/PhilipsREC/src/itkPh
>> ilipsRECImageIO.cxx:744:3: error: âmetaDictâ was not declared in this
>> scope
>> 
>> Did you not mean:
>> thisDic->Clear();
>> ?
>> 
>> If this was not discovered at the dashboard, then probably the option
>> Module_ITKIOPhilipsREC was not enabled. By default it is OFF.
>> 
>> Regards, Marius
>> 
>> 
>> Marius Staring, PhD
>> Division of Image Processing (LKEB)
>> Department of Radiology
>> Leiden University Medical Center
>> PO Box 9600, 2300 RC Leiden, The Netherlands
>> phone: +31 (0)71 526 2137, fax: +31 (0)71 524 8256
>> m.staring at lumc.nl
>> 
>> 
> 
> 
> 
> ________________________________
> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
> ________________________________
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers