[Insight-developers] Patches for the riemann.sumost.ca

Steve M. Robbins steve at sumost.ca
Sat Dec 8 21:54:26 EST 2012


Hello Matt,

Did not compile with patches, but review comments follow.

On December 7, 2012 10:28:01 AM Matt McCormick wrote:
> Hi Steve,
> 
> Thanks again for you riemann.sumost.ca dashboard submissions.
> 
> I created patches to address warnings on that box:
> 
>   http://review.source.kitware.com/#/c/8846/

Looks fine.

>   http://review.source.kitware.com/#/c/8847/

While I believe the change is correct, I would have used 
IndexType::IndexValueType (for x, y) rather than itk::IndexValueType, to make 
the subsequent line

    const IndexType index = { { x, y } };

more clearly correct.

Cheers,
-Steve



More information about the Insight-developers mailing list