[Insight-developers] Patch submission to SimpleITK?

[Johnson, Hans J]

Kent,

Please use "git format-patch" and attach that to the JIRA ticket.  Then
ping Brad Lowekamp requesting integration.

Hans

--
Hans J. Johnson, Ph.D.
hans-johnson at uiowa.edu
Assistant Professor of Psychiatry
University of Iowa Carver College of Medicine
W278 GH, 200 Hawkins Drive

Iowa City, Iowa 52242
Phone:  319-353-8587







-----Original Message-----
From: <Williams>, Kent Williams <norman-k-williams at uiowa.edu>
Date: Tuesday, August 14, 2012 12:35 PM
To: ITK <insight-developers at itk.org>
Subject: [Insight-developers] Patch submission to SimpleITK?

There was this bug report from Hans:
https://issues.itk.org/jira/browse/SIMPLEITK-296

CLang was pickier than our other supported compilers, and unfortunately,
the fix broke Visual Studio builds.

I have a patch that fixes this problem with a preprocessor symbol that is
set to 'template' only for clang, by adding a preprocessor conditional to
sitConfigure.h.in

This is in my github fork of SITK:
https://github.com/BRAINSia/SimpleITK/commits/CLangCompileFix

So how and to whom should I send this patch?  I don't really follow
SimpleITK development so I don't know if there's an established SimpleITK
equivalent of the Gerrit workflow for ITK.

--
Kent Williams norman-k-williams at uiowa.edu






________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by
the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
confidential and may be legally privileged.  If you are not the intended
recipient, you are hereby notified that any retention, dissemination,
distribution, or copying of this communication is strictly prohibited.
Please reply to the sender that you have received the message in error,
then delete it.  Thank you.
________________________________
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://www.itk.org/mailman/listinfo/insight-developers



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________