[Insight-developers] CTestCustom.cmake warning suppression

[David Cole]

Gerrit patch here:
http://review.source.kitware.com/3015

Please review if you are interested...


Thanks,
David


On Fri, Sep 30, 2011 at 11:26 AM, David Cole <david.cole at kitware.com> wrote:
> I committed this to CMake's own CTestCustom yesterday, and it finally
> suppressed warnings from clang properly:
>
>  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ad6fa0cbca85febca573e18bbbd7bafa2ea00f81
>
> Apparently, we were also detecting clang's summary line "3 warnings
> generated." as a warning, and need to exclude that match as well...
>
> I will submit a gerrit patch proposing a similar change for ITK.
>
>
> Cheers,
> David C.
>
>
> On Thu, Sep 22, 2011 at 1:01 PM, David Cole <david.cole at kitware.com> wrote:
>> I do not have time in the next two weeks to investigate what is
>> happening here. If somebody else figures out why this is happening,
>> please post details.
>>
>>
>> On Thu, Sep 22, 2011 at 10:48 AM, Sean McBride <sean at rogue-research.com> wrote:
>>> David,
>>>
>>> Just wanted to ping you that there ThirdParty warnings are still showing up:
>>> <http://www.cdash.org/CDash/viewBuildError.php?type=1&buildid=1554621>
>>>
>>> Sean
>>>
>>>
>>> On Thu, 15 Sep 2011 15:21:11 -0400, David Cole said:
>>>
>>>>We need the regular dashboard for now.
>>>>
>>>>Simply remove the one line:
>>>>
>>>>  include(${CTEST_SCRIPT_DIRECTORY}/../itkmodular_common.cmake)
>>>>
>>>>And then remind me again tomorrow to look at it if there are still
>>>>MetaIO warnings showing up.
>>>>
>>>>
>>>>Thanks,
>>>>David
>>>>
>>>>
>>>>On Thu, Sep 15, 2011 at 3:06 PM, Bill Lorensen <bill.lorensen at gmail.com>
>>>>wrote:
>>>>> please do not do a modular dashboard. very few people look at it. a regular
>>>>> dashboard is what we need.
>>>>>
>>>>>
>>>>> On Thu, Sep 15, 2011 at 3:04 PM, Sean McBride <sean at rogue-research.com>
>>>>> wrote:
>>>>>>
>>>>>> On Thu, 15 Sep 2011 14:58:23 -0400, David Cole said:
>>>>>>
>>>>>> >I think this line should match:
>>>>>> >
>>>>>> >  ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Mm]eta[Ii][Oo][/\\\
>>>>>> >\].*[Ww]arning.*"
>>>>>> >
>>>>>> >Sean, your script is a little on the weird side
>>>>>>
>>>>>> No doubt due to my only barely understanding the cmake/ctest/whatever
>>>>>> language. :)
>>>>>>
>>>>>> >in that it appears to
>>>>>> >run an ITKModular dashboard first, and then the regular one. Is that
>>>>>> >intentional?
>>>>>>
>>>>>> I dunno. :)   I seem to recall that all dashboard maintainers were
>>>>>> supposed to enable this new module way of doing things..., no?
>>>>>>
>>>>>> Would you rather I do ITKModular dashboard or a regular one?  Which is
>>>>>> more useful to the community?
>>>>>>
>>>>>> >The intent with including "itkmodular_common" should be to make it the
>>>>>> >last line of a script that does *only* an ITKModular dashboard
>>>>>> >submission.
>>>>>>
>>>>>> OK, what do I need to remove to start the extra regular submission?  The
>>>>>> CTEST_SUBMIT at the end?
>>>
>>>
>>>
>>
>