[Insight-developers] Errors after V3Compatibility move

[Williams, Norman K]

Vince Magnotta is funnelling some FEM code fixes through me since he's not
yet a Gerrit-Jockey.


I have a gerrit patch up incorporating his changes, which are
straightforward. But I'm hampered by the broken-ness of the current
itk.org master:

CMake Error at CMake/ExternalData.cmake:369 (message):
  Data file referenced by argument

    DATA{Baseline/itkBSplineDeformableTransformTest2PixelCentered.png}

  corresponds to source tree path


Modules/Compatibility/V3Compatibility/test/Baseline/itkBSplineDeformableTra
nsformTest2PixelCentered.png

  that does not exist (with or without an extension)!
Call Stack (most recent call first):
  CMake/ExternalData.cmake:236 (_ExternalData_arg)
  CMake/ExternalData.cmake:154 (ExternalData_expand_arguments)
  CMakeLists.txt:115 (ExternalData_add_test)
  Modules/Compatibility/V3Compatibility/test/CMakeLists.txt:49
(itk_add_test)





On 9/29/11 11:14 AM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:

>No problem.
>
>On Thu, Sep 29, 2011 at 12:11 PM, Johnson, Hans J
><hans-johnson at uiowa.edu> wrote:
>> Bill,
>>
>> This exposed other shortcomings in the refactoring that were also
>>causing
>> problems for the pure ITKv4 SimpleITK project.  While we have a few more
>> hours of Xiaoxiao, we are going to work on a universally correct
>>solution.
>>  That does mean, however, that we can not move the
>> BSplineDeformableTransforms back again (we need it as a test case).
>>
>> If you don't mind, please just leave it broken so that we can fix this
>> from a single stable broken version that will not cause merge issues
>> latter.
>>
>> Thanks,
>> Hans
>>
>>
>> On 9/29/11 11:44 AM, "Johnson, Hans J" <hans-johnson at uiowa.edu> wrote:
>>
>>>I'm working on the solution right now because I'm sitting across from
>>>the
>>>modularization expert (Xiaoxiao).
>>>
>>>Hans
>>>
>>>
>>>On 9/29/11 11:35 AM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:
>>>
>>>>Hans,
>>>>
>>>>I looked at this a bit further. Moving the old bspline transform into
>>>>v3compatibility is going to cause problems with the transform factory.
>>>>the Transform module will need a conditional dependency on
>>>>V3Compatibility which then causes a circular dependency. (I have tried
>>>>it).
>>>>
>>>>I suggest, reverting this change for now until we can come up with a
>>>>better solution.
>>>>
>>>>Bill
>>>>
>>>>On Thu, Sep 29, 2011 at 9:35 AM, Johnson, Hans J
>>>><hans-johnson at uiowa.edu>
>>>>wrote:
>>>>> My mistake,  I'll fix in a patch set very soon.  Sorry.
>>>>>
>>>>> Hans
>>>>>
>>>>>
>>>>> On 9/29/11 9:22 AM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:
>>>>>
>>>>>>Hans,
>>>>>>
>>>>>>ITK no longer  builds with v3 compatibility on. I noticed that your
>>>>>>patch renamed itkBSplineDeformableTransform to
>>>>>>itkBSplineDeformableV3Compatibility. Likewise with some others. Why
>>>>>>did you rename the files? They should have just been mover I think.
>>>>>>Also, the Baseline data for the tests was not moved. I started a
>>>>>>patch
>>>>>>to move the data but then I realized the file names for code had been
>>>>>>changed. I am abandoning that patch.
>>>>>>
>>>>>>Bill
>>>>>
>>>>>
>>>>>
>>>>> ________________________________
>>>>> Notice: This UI Health Care e-mail (including attachments) is covered
>>>>>by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>>>>confidential and may be legally privileged.  If you are not the
>>>>>intended
>>>>>recipient, you are hereby notified that any retention, dissemination,
>>>>>distribution, or copying of this communication is strictly prohibited.
>>>>>Please reply to the sender that you have received the message in
>>>>>error,
>>>>>then delete it.  Thank you.
>>>>> ________________________________
>>>>>
>>>
>>>
>>>
>>>________________________________
>>>Notice: This UI Health Care e-mail (including attachments) is covered by
>>>the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>>confidential and may be legally privileged.  If you are not the intended
>>>recipient, you are hereby notified that any retention, dissemination,
>>>distribution, or copying of this communication is strictly prohibited.
>>>Please reply to the sender that you have received the message in error,
>>>then delete it.  Thank you.
>>>________________________________
>>>_______________________________________________
>>>Powered by www.kitware.com
>>>
>>>Visit other Kitware open-source projects at
>>>http://www.kitware.com/opensource/opensource.html
>>>
>>>Kitware offers ITK Training Courses, for more information visit:
>>>http://kitware.com/products/protraining.html
>>>
>>>Please keep messages on-topic and check the ITK FAQ at:
>>>http://www.itk.org/Wiki/ITK_FAQ
>>>
>>>Follow this link to subscribe/unsubscribe:
>>>http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>>
>> ________________________________
>> Notice: This UI Health Care e-mail (including attachments) is covered
>>by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>confidential and may be legally privileged.  If you are not the intended
>>recipient, you are hereby notified that any retention, dissemination,
>>distribution, or copying of this communication is strictly prohibited.
>>Please reply to the sender that you have received the message in error,
>>then delete it.  Thank you.
>> ________________________________
>>
>_______________________________________________
>Powered by www.kitware.com
>
>Visit other Kitware open-source projects at
>http://www.kitware.com/opensource/opensource.html
>
>Kitware offers ITK Training Courses, for more information visit:
>http://kitware.com/products/protraining.html
>
>Please keep messages on-topic and check the ITK FAQ at:
>http://www.itk.org/Wiki/ITK_FAQ
>
>Follow this link to subscribe/unsubscribe:
>http://www.itk.org/mailman/listinfo/insight-developers



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________