[Insight-developers] clang warning in itk::Mesh

[Sean McBride]

On Thu, 15 Sep 2011 07:38:27 -0400, Arnaud Gelas said:

>I am looking at the following clang warning:
>
>/Users/builder/kitware/ITK/Modules/Core/Mesh/include/itkMesh.hxx: 
>509:37: warning: unused parameter 'cellId' [-Wunused-parameter]
>::GetCellBoundingBox(CellIdentifier cellId, BoundingBoxPointer bbox)

This warning appears on my dashboard.

>Here is the corresponding code:
>
>503 /**
>  504  * Get the bounding box of the cell with the given identifier.
>  505  */
>  506 template< typename TPixelType, unsigned int VDimension, typename  
>TMeshTrait     s >
>  507 typename Mesh< TPixelType, VDimension, TMeshTraits  
> >::BoundingBoxPointer
>  508 Mesh< TPixelType, VDimension, TMeshTraits >
>  509 ::GetCellBoundingBox(CellIdentifier cellId, BoundingBoxPointer  
>bbox)
>  510 {
>  511   bbox->SetPoints( this->GetPoints() );
>  512   return bbox;
>  513 }
>
>The documentation and the method name does not match at all the  
>implementation...
>I can fix the warning or fix the implementation for this warning, but  
>it'd definitively affect code which make use of this method...

It is indeed very suspicious.

>Is it used ?

It seems not!

>Recommendations ?

Remove it. :)

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada