[Insight-developers] ImageSpacing or not ImageSpacing

[Bill Lorensen]

Hans,

I agree. The migration guide is the correct approach.

Bill


On Fri, Sep 16, 2011 at 5:03 PM, Johnson, Hans J <hans-johnson at uiowa.edu>wrote:

>   Bill,
>
>  I disagree with the use of ITKV3_COMPATIBILITY that introduces a compile
> time algorithmic change.  I think that using ITKV3_COMPATIBILITY for
> providing deprecated API compatibility is OK, but maintaining mutilple
> algorithmic results based on CMake compile time options is something that
> ITKv4 should take the opportunity to avoid.  This is a case where the
> migration guide is the necessary place to help end-users.
>
>  Please let me know what you think.
>
>  Hans
> --
>   Hans J. Johnson, Ph.D.
> hans-johnson at uiowa.edu
> Assistant Professor of Psychiatry
> University of Iowa Carver College of Medicine
>  W278 GH, 200 Hawkins Drive
>  Iowa City, Iowa 52242
> Phone:  319-353-8587
>
>   From: Bill Lorensen <bill.lorensen at gmail.com>
> Date: Fri, 16 Sep 2011 16:32:06 -0400
>
> To: ITK <insight-developers at itk.org>
> Subject: Re: [Insight-developers] ImageSpacing or not ImageSpacing
>
>  I failed to mention that I recommend we use the ITKV3_COMPATIBILITY flag
> to maintain the old behaviour for legacy apps.
>
>
> On Fri, Sep 16, 2011 at 4:28 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:
>
>> Folks,
>>
>> Our recent discussions regarding consistency of the distance map filters
>> hightlights the inconsistent use of ImageSpacingOn/Off in the toolkit. There
>> are about 33 classes that have the option. I have not checked them all, but
>> they are not all consistent.
>>
>> Should we make sure we are consistent, UseImageSpacingOn?
>>
>> I am willing to investigate this?
>>
>> Bill
>>
>>
> _______________________________________________ Powered by www.kitware.comVisit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html Kitware offers ITK
> Training Courses, for more information visit:
> http://kitware.com/products/protraining.html Please keep messages on-topic
> and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link
> to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>
> ------------------------------
> Notice: This UI Health Care e-mail (including attachments) is covered by
> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
> confidential and may be legally privileged.  If you are not the intended
> recipient, you are hereby notified that any retention, dissemination,
> distribution, or copying of this communication is strictly prohibited.
> Please reply to the sender that you have received the message in error, then
> delete it.  Thank you.
> ------------------------------
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110916/fef90f37/attachment.htm>