[Insight-developers] Conflicting itkPointSetToPointSetMetric headers

[Nicholas Tustison]

Thanks Hans.  

That sounds good to me but, just to make sure, it's okay to also get rid of 
the PointSetToPointSetRegistrationMethod with the intent that it will
be soon replaced, correct?

Nick


On Oct 7, 2011, at 11:37 AM, Johnson, Hans J wrote:

> If the new classes replace the old, then a migration guide and a delete of
> the old files is the best path.
> 
> Hans
> 
> --
> Hans J. Johnson, Ph.D.
> hans-johnson at uiowa.edu
> Assistant Professor of Psychiatry
> University of Iowa Carver College of Medicine
> W278 GH, 200 Hawkins Drive
> 
> Iowa City, Iowa 52242
> Phone:  319-353-8587
> 
> 
> 
> 
> 
> 
> 
> -----Original Message-----
> From: Nicholas Tustison <ntustison at gmail.com>
> Date: Fri, 7 Oct 2011 11:09:48 -0400
> To: Brad King <brad.king at kitware.com>
> Cc: ITK <insight-developers at itk.org>
> Subject: Re: [Insight-developers] Conflicting itkPointSetToPointSetMetric
> headers
> 
> Sorry about that.
> 
> So the idea would be to ultimately remove the old PointSetToPointSetMetric
> and derived classes.  There's only one derived class, the ICP metric, and
> we reimplemented that in a more efficient manner.  However, we don't have
> a PointSetToPointSetRegistrationMethod class, yet, to replace the current
> one.
> 
> I don't know that I have a preference but do we want to delete the old
> classes or
> should we simply rename the new classes?
> 
> Nick
> 
> On Oct 7, 2011, at 11:03 AM, Brad King wrote:
> 
>> Hi Folks,
>> 
>> This commit:
>> 
>> http://itk.org/gitweb?p=ITK.git;a=commitdiff;h=3076fe37
>> 
>> added
>> 
>> 
>> Modules/Registration/HighDimensionalMetrics/include/itkPointSetToPointSetM
>> etric.h
>> 
>> Modules/Registration/HighDimensionalMetrics/include/itkPointSetToPointSetM
>> etric.hxx
>> 
>> but that header name already existed at
>> 
>> Modules/Registration/Common/include/itkPointSetToPointSetMetric.h
>> Modules/Registration/Common/include/itkPointSetToPointSetMetric.hxx
>> 
>> The headers clobber each other in an install tree where they are not
>> divided by module.  This was exposed by my "TestExternal" build that
>> builds the module tests against an installed ITK:
>> 
>> http://www.cdash.org/CDash/viewBuildError.php?buildid=1602106
>> 
>> -Brad
> 
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
> 
> 
> 
> ________________________________
> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
> ________________________________