[Insight-developers] Add a Convolution module under filtering?

[Luis Ibanez]

Hi Cory,

Before moving the itkConvolutionImageFilter out of Review...

Did you do a Code Review of this filter using the Check List ?
http://www.itk.org/Wiki/ITK_Release_4/Modularization/Code_Reviews/Checklist


Code from the Review directory can't simply be moved to
final directories without first verifying that it fits ITK coding
standards.

In particular :  Code Coverage.

In many cases this can be code that was copied directly
from Insight Journal contributions and may or may not
have passes through a maturation process in the Review
directory.   (git log could verify how many changes the
code have experienced while in Review).



Please note also that a bug was reported in this filter
during the weekend:

http://public.kitware.com/Bug/view.php?id=12236

http://www.itk.org/pipermail/insight-users/2011-May/041307.html


    Luis


---------------------------------------------------
On Tue, May 31, 2011 at 12:58 PM, Cory Quammen <cquammen at cs.unc.edu> wrote:
> A patch for this move has been posted:
> http://review.source.kitware.com/#change,1756
>
> A later patch will include the submission of the FFT based convolution
> image filter.
>
> Thanks,
> Cory
>
> On Sun, May 29, 2011 at 8:55 AM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>> Hi Cory,
>>
>> The "Filtering" group seems to be the right place
>> for this new Convolution module.
>>
>> Moving the classes that you mentioned to this
>> new modules looks very reasonable.
>>
>>
>>     Luis
>>
>>
>> -------------------------------------------------------------
>> On Fri, May 27, 2011 at 4:19 PM, Cory Quammen <cquammen at cs.unc.edu> wrote:
>>> Dear modularization team,
>>>
>>> In preparation for our A2D2 work on deconvolution, I'd like to create
>>> a new module under Filtering named Convolution.
>>>
>>> Here's my tentative plan:
>>> - Move itk::ConvolutionImageFilter and associated tests currently in
>>> Review to the Convolution module.
>>> - Add Gaetan Lehmann's FFT based convolution image filter from his
>>> Insight Journal article into this module.
>>>
>>> If there is a better place to put these classes, please let me know.
>>>
>>> Thanks,
>>> Cory
>>>
>>> --
>>> Cory Quammen
>>> Computer Integrated Systems for Microscopy and Manipulation (CISMM)
>>> Department of Computer Science
>>> University of North Carolina at Chapel Hill
>>> http://www.cs.unc.edu/~cquammen
>>>
>>
>
>
>
> --
> Cory Quammen
> Computer Integrated Systems for Microscopy and Manipulation (CISMM)
> Department of Computer Science
> University of North Carolina at Chapel Hill
> http://www.cs.unc.edu/~cquammen
>