[Insight-developers] Making changes to ITK3.20

Thu May 26 12:49:59 EDT 2011

I redefined gerrit-push to be
	gerrit-push = !sh -c \"git push gerrit HEAD:refs/for/master/$(git
symbolic-ref HEAD | sed -e 's|^refs/heads/||')\"

and I was able to push to gerrit. Not a long-term solution.

On Thu, May 26, 2011 at 12:33 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> Hans,
>
> I did that.
>
> I see what has happened. The alias for gerrit-push used to be:
> gerrit-push = !sh -c \"git push gerrit HEAD:refs/for/master/$(git
> symbolic-ref HEAD | sed -e 's|^refs/heads/||')\"
> but now is:
> gerrit-push = !Utilities/Git/git-gerrit-push
>
> Of course, Utilities/Git/git-gerrit-push does not exist in ITK3.20.
>
>
> On Thu, May 26, 2011 at 11:57 AM, Johnson, Hans J
> <hans-johnson at uiowa.edu> wrote:
>> Bill,
>>
>> I think the following will work.
>>
>> 1) create your topic,
>> 2) then checkout master
>> 3) run the "Utilities/SetupForDevelopment.sh"
>> 4) then checkout your topic
>>
>> The "Utilities/SetupForDevelopment.sh" does not exists in the ITKv3
>> branch, but the aliases that are set up persist  after the other topic is
>> checked out.
>>
>> Hans
>>
>>
>> --
>> Hans J. Johnson, Ph.D.
>> hans-johnson at uiowa.edu
>> Assistant Professor of Psychiatry
>> University of Iowa Carver College of Medicine
>> W278 GH, 200 Hawkins Drive
>>
>> Iowa City, Iowa 52242
>> Phone:  319-353-8587
>>
>>
>>
>>
>>
>>
>>
>> -----Original Message-----
>> From: Bill Lorensen <bill.lorensen at gmail.com>
>> Date: Thu, 26 May 2011 11:41:47 -0400
>> To: Hans Johnson <hans-johnson at uiowa.edu>
>> Cc: Estanislao Oubel <stan.oubel at gmail.com>, ITK
>> <insight-developers at itk.org>
>> Subject: Re: [Insight-users] VNL 1.14 and ITK 3.20
>>
>> Hans,
>>
>> However, gerrit-push does not exist for me when I checkout
>> origin/release. Without it, I'm brainless.
>>
>>
>> On Thu, May 26, 2011 at 10:40 AM, Johnson, Hans J
>> <hans-johnson at uiowa.edu> wrote:
>>> Bill,
>>>
>>> Just make a topic branched off of the latest ITKv3 tag, and push to
>>>gerrit
>>> as normal.
>>>
>>>
>>>http://www.itk.org/mailman/private/insight-developers/2011-January/017023.
>>>h
>>> tml
>>>
>>> The only strange thing is that Brad King is required to do the merge
>>> because we do not have permission to change that tag.
>>>
>>> Hans
>>>
>>> --
>>> Hans J. Johnson, Ph.D.
>>> hans-johnson at uiowa.edu
>>> Assistant Professor of Psychiatry
>>> University of Iowa Carver College of Medicine
>>> W278 GH, 200 Hawkins Drive
>>>
>>> Iowa City, Iowa 52242
>>> Phone:  319-353-8587
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> -----Original Message-----
>>> From: Bill Lorensen <bill.lorensen at gmail.com>
>>> Date: Thu, 26 May 2011 10:23:08 -0400
>>> To: Hans Johnson <hans-johnson at uiowa.edu>
>>> Cc: Estanislao Oubel <stan.oubel at gmail.com>, "insight-users at itk.org"
>>> <insight-users at itk.org>
>>> Subject: Re: [Insight-users] VNL 1.14 and ITK 3.20
>>>
>>> Sure, but I don't know how to do that...
>>>
>>> On Thu, May 26, 2011 at 10:18 AM, Johnson, Hans J
>>> <hans-johnson at uiowa.edu> wrote:
>>>> Bill,
>>>>
>>>> Can we get your patch incorporated into ITKv3?
>>>>
>>>> Thanks,
>>>> Hans
>>>>
>>>> --
>>>> Hans J. Johnson, Ph.D.
>>>> hans-johnson at uiowa.edu
>>>> Assistant Professor of Psychiatry
>>>> University of Iowa Carver College of Medicine
>>>> W278 GH, 200 Hawkins Drive
>>>>
>>>> Iowa City, Iowa 52242
>>>> Phone:  319-353-8587
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: Estanislao Oubel <stan.oubel at gmail.com>
>>>> Date: Thu, 26 May 2011 16:12:31 +0200
>>>> To: Bill Lorensen <bill.lorensen at gmail.com>
>>>> Cc: <insight-users at itk.org>
>>>> Subject: Re: [Insight-users] VNL 1.14 and ITK 3.20
>>>>
>>>> yes it works ! thanks !
>>>>
>>>>
>>>> Le 26/05/2011 14:22, Bill Lorensen a écrit :
>>>>> Not in ITK3.20.
>>>>>
>>>>> Did my fix work?
>>>>>
>>>>> On Thu, May 26, 2011 at 4:03 AM, francois rousseau<rousseau at unistra.fr>
>>>>>wrote:
>>>>>
>>>>>> Would it be possible to avoid the compilation of the FEM module ?
>>>>>>
>>>>>> françois
>>>>>>
>>>>>>
>>>>>> On May 24, 2011, at 4:25 PM, Bill Lorensen wrote:
>>>>>>
>>>>>>
>>>>>>> The VXL folks made a non backward-compatible change to their API. The
>>>>>>> following change has been made in ITKv4, but not ITK3.20.
>>>>>>>
>>>>>>>
>>>>>>> In itkFEMLinearSystemWrapperVNL.cxx
>>>>>>> go to the error line and replace it with the following:
>>>>>>>
>>>>>>> #if VXL_VERSION_MAJOR == 1&&  VXL_VERSION_MINOR == 9
>>>>>>> ((*m_Matrices)[LeftMatrixIndex])->mult(
>>>>>>> *((*m_Matrices)[RightMatrixIndex]),
>>>>>>> *((*m_Matrices)[ResultMatrixIndex]) );
>>>>>>> #else
>>>>>>> *((*m_Matrices)[ResultMatrixIndex]) =
>>>>>>> *((*m_Matrices)[LeftMatrixIndex]) * (
>>>>>>>*((*m_Matrices)[RightMatrixIndex]));
>>>>>>> #endif
>>>>>>>
>>>>>>> On Tue, May 24, 2011 at 8:46 AM, Estanislao
>>>>>>>Oubel<stan.oubel at gmail.com>  wrote:
>>>>>>>
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> I'd like to use VNL 1.14 with ITK 3.20 because the vnl_sparse_matrix
>>>>>>>> includes several
>>>>>>>> useful methods absent in the VNL version included in ITK 3.20
>>>>>>>> (sparse matrix multiplication for example)
>>>>>>>>
>>>>>>>> I've set ITK_USE_SYSTEM_VXL to ON but I get some compilation errors:
>>>>>>>>
>>>>>>>> [100%] [100%] [100%] Building CXX object
>>>>>>>> Code/Numerics/FEM/CMakeFiles/ITKFEM.dir/itkFEMUtility.o
>>>>>>>> Building CXX object
>>>>>>>> Code/Numerics/FEM/CMakeFiles/ITKFEM.dir/itkFEMInitialization.o
>>>>>>>> Building C object Code/Numerics/FEM/CMakeFiles/ITKFEM.dir/dsrc2c.o
>>>>>>>> /home/miv/oubel/lib/vxl-1.14.0/core/vnl/vnl_sparse_matrix.h: In
>>>>>>>>member
>>>>>>>> function Œvirtual void
>>>>>>>> itk::fem::LinearSystemWrapperVNL::MultiplyMatrixMatrix(unsigned int,
>>>>>>>> unsigned int, unsigned int)¹:
>>>>>>>> /home/miv/oubel/lib/vxl-1.14.0/core/vnl/vnl_sparse_matrix.h:268:
>>>>>>>>error:
>>>>>>>> Œvoid vnl_sparse_matrix<T>::mult(const vnl_sparse_matrix<T>&,
>>>>>>>> vnl_sparse_matrix<T>&) const [with T = double]¹ is protected
>>>>>>>>
>>>>>>>>/home/miv/oubel/lib/InsightToolkit-3.20.0/Code/Numerics/FEM/itkFEMLin
>>>>>>>>e
>>>>>>>>a
>>>>>>>>rSystemWrapperVNL.cxx:265:
>>>>>>>> error: within this context
>>>>>>>> make[2]: ***
>>>>>>>>
>>>>>>>>[Code/Numerics/FEM/CMakeFiles/ITKFEM.dir/itkFEMLinearSystemWrapperVNL
>>>>>>>>.
>>>>>>>>o
>>>>>>>>]
>>>>>>>> Erreur 1
>>>>>>>> make[2]: *** Attente des tâches non terminées....
>>>>>>>> make[1]: *** [Code/Numerics/FEM/CMakeFiles/ITKFEM.dir/all] Erreur 2
>>>>>>>> make[1]: *** Attente des tâches non terminées....
>>>>>>>> Linking CXX shared library ../../bin/libITKIOReview.so
>>>>>>>> [100%] Built target ITKIOReview
>>>>>>>> Linking CXX executable ../../bin/itkTestDriver
>>>>>>>> [100%] Built target itkTestDriver
>>>>>>>> make: *** [all] Erreur 2
>>>>>>>>
>>>>>>>> Am I doing anything wrong? Have you found similar problems?
>>>>>>>>
>>>>>>>> Best
>>>>>>>>
>>>>>>>> stan
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> _____________________________________
>>>>>>>> Powered by www.kitware.com
>>>>>>>>
>>>>>>>> Visit other Kitware open-source projects at
>>>>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>>>>
>>>>>>>> Kitware offers ITK Training Courses, for more information visit:
>>>>>>>> http://www.kitware.com/products/protraining.html
>>>>>>>>
>>>>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>>>>
>>>>>>>> Follow this link to subscribe/unsubscribe:
>>>>>>>> http://www.itk.org/mailman/listinfo/insight-users
>>>>>>>>
>>>>>>>>
>>>>>>> _____________________________________
>>>>>>> Powered by www.kitware.com
>>>>>>>
>>>>>>> Visit other Kitware open-source projects at
>>>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>>>
>>>>>>> Kitware offers ITK Training Courses, for more information visit:
>>>>>>> http://www.kitware.com/products/protraining.html
>>>>>>>
>>>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>>>
>>>>>>> Follow this link to subscribe/unsubscribe:
>>>>>>> http://www.itk.org/mailman/listinfo/insight-users
>>>>>>>
>>>>>>>
>>>>>> --
>>>>>> ---------------------------
>>>>>> Francois Rousseau
>>>>>> LSIIT
>>>>>> Pôle API
>>>>>> Boulevard Sébastien Brant
>>>>>> F-67400 ILLKIRCH
>>>>>> tel : +33 3 68 85 44 89
>>>>>> email : rousseau at unistra.fr
>>>>>> http://lsiit-miv.u-strasbg.fr/miv/19-ROUSSEAU-Francois.html
>>>>>>
>>>>>>
>>>>>>
>>>>
>>>> _____________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://www.kitware.com/products/protraining.html
>>>>
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.itk.org/mailman/listinfo/insight-users
>>>>
>>>>
>>>>
>>>> ________________________________
>>>> Notice: This UI Health Care e-mail (including attachments) is covered by
>>>>the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>>>confidential and may be legally privileged.  If you are not the intended
>>>>recipient, you are hereby notified that any retention, dissemination,
>>>>distribution, or copying of this communication is strictly prohibited.
>>>>Please reply to the sender that you have received the message in error,
>>>>then delete it.  Thank you.
>>>> ________________________________
>>>>
>>>
>>>
>>>
>>> ________________________________
>>> Notice: This UI Health Care e-mail (including attachments) is covered by
>>>the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>>confidential and may be legally privileged.  If you are not the intended
>>>recipient, you are hereby notified that any retention, dissemination,
>>>distribution, or copying of this communication is strictly prohibited.
>>>Please reply to the sender that you have received the message in error,
>>>then delete it.  Thank you.
>>> ________________________________
>>>
>>
>>
>>
>> ________________________________
>> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
>> ________________________________
>>
>