[Insight-developers] Broken Continuous

[Williams, Norman K]

I meant 'patch' as in 'local change on my machine not checked in anywhere
yet' as opposed to 'git patch that's up on review.source.kitware.com as a
gerrit topic.' In the future I shall endeavor to be more succinct.

http://review.source.kitware.com/#change,1688



On 5/19/11 3:49 PM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:

>I don't see it on gerrit. If it's there, I can test.
>
>On Thu, May 19, 2011 at 4:42 PM, Williams, Norman K
><norman-k-williams at uiowa.edu> wrote:
>
>Not to name names or anything (*cough*xiaoxiao*cough*) but the problem I
>think is a missing dependency in
>Modules/Numerics/Statistics/itk-module.cmake.
>
>
>I'm testing this patch:
>
>diff --git a/Modules/Numerics/Statistics/itk-module.cmake
>b/Modules/Numerics/Statistics/itk-module.cmake
>index 1f37389..59065d3 100644 <tel:3%20100644>
>--- a/Modules/Numerics/Statistics/itk-module.cmake
>+++ b/Modules/Numerics/Statistics/itk-module.cmake
>@@ -1,2 +1,2 @@
>-itk_module(ITK-Statistics DEPENDS ITK-Common ITK-Netlib TEST_DEPENDS
>ITK-TestKernel  ITK-ImageIntensity)
>+itk_module(ITK-Statistics DEPENDS ITK-Common ITK-Netlib TEST_DEPENDS
>ITK-TestKernel  ITK-ImageIntensity ITK-ImageCompose)
> #extra test dependecy of ImageIntensity is introduced by
>itkImageToListSampleAdaptorTest.cxx)
>
>
>If that works, then I can merge it.
>
>I get a little concerned about adding dependencies like this.  On the one
>hand, strictly limiting inter-module dependencies is a Good Thing.  It
>allows proper subsets of monolithic ITK to be built -- providing of course
>that users will do the legwork to only build the modules they actually
>need.
>
>On the other hand, it means that one can no longer write code inside the
>library proper without considering whether or not to introduce a new
>dependency. It makes it feel as though one no longer has the whole library
>at your disposal.
>
>On 5/19/11 3:28 PM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:
>
>>After a huge checkin, the continuous is broken.
>>http://www.cdash.org/CDash/viewBuildError.php?buildid=1145398
>>
>>Hopefully the culprit will fix it before tonight's build. Otherwise lots
>>of red for tomottow's t-con...
>>
>>Bill
>>
>
>
>>_______________________________________________
>>Powered by www.kitware.com <http://www.kitware.com>
>>
>>Visit other Kitware open-source projects at
>>http://www.kitware.com/opensource/opensource.html
>>
>>Kitware offers ITK Training Courses, for more information visit:
>>http://kitware.com/products/protraining.html
>>
>>Please keep messages on-topic and check the ITK FAQ at:
>>http://www.itk.org/Wiki/ITK_FAQ
>>
>>Follow this link to subscribe/unsubscribe:
>>http://www.itk.org/mailman/listinfo/insight-developers
>
>
>
>________________________________
>Notice: This UI Health Care e-mail (including attachments) is covered by
>the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>confidential and may be legally privileged.  If you are not the intended
>recipient, you are hereby notified that any retention, dissemination,
>distribution, or copying of this communication is strictly prohibited.
>Please reply to the sender that you have received the message in error,
>then delete it.  Thank you.
>
>________________________________
>
>
>
>



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________