[Insight-developers] Code Review of BinaryMorphologicalOpening/Closing

[Luis Ibanez]

Hi Gatean,

Also,
The Opening filter uses "Foreground" and "Background"
member variables, while the Closening filter only uses
"Foreground".

Why are not they symmetric implementations ?


     Thanks


          Luis


---------------------------------------------------
On Tue, May 10, 2011 at 6:10 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
> Hi Gaetan,
>
> I'm reviewing the classes:
>
>    itkBinaryMorphologicalClosingImageFilter
>    itkBinaryMorphologicalOpeningImageFilter
>
> to move them out of the Review directory
> according to Xiaoxiao's patch:
>
>    http://review.source.kitware.com/#change,1623
>
> --
>
> Could you comment on why is that the Closening filter
> is not simply a dual implementation of the Opening filter ?
>
> In particular, the Closening filter has a "m_SafeBorder"
> boolean variable, and an associated block of code that
> introduces  two more filters in the pipeline in order todo
> Padding and Cropping.
>
> What are the border effects that motivate this logic ?
>
> and why are not an issue in the Opening filter, where
> on would expect to find a dual implementation of the
> Closening filter ?
>
>
> The two extra Padding and Cropping filters are an onerous
> addition to the pipeline, and don't seem to be justified...
>
>
>     Thanks for any hints
>
>
>           Luis
>