[Insight-developers] GradientToMagnitudeImageFilter name

[Cory Quammen]

David,

I think a name change makes sense. VectorMagnitudeImageFilter seems
like a good name to me.

To preserve backwards compatibility, I suggest re-implementing
GradientToMagnitudeImageFilter as a subclass of
VectorMagnitudeImageFilter and moving GradientToMagnitudeImageFilter
to the Nonunit/Deprecated module.

Do you want to submit a patch to gerrit with the changes?

Cory

On Mon, May 2, 2011 at 7:56 PM, David Doria <daviddoria at gmail.com> wrote:
> The filter GradientToMagnitudeImageFilter:
> http://www.itk.org/Doxygen/html/classitk_1_1GradientToMagnitudeImageFilter.html
>
> seems to have nothing at all to do with Gradients. A more appropriate
> name seems to be something like VectorImageToMagnitudeImageFilter or
> simply ImageMagnitudeFilter. I realize changing a class name is not
> backwards compatible, but in a big version step (ITKv4) would
> clarifying this make sense?
>
> David
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>



-- 
Cory Quammen
Computer Integrated Systems for Microscopy and Manipulation (CISMM)
Department of Computer Science
University of North Carolina at Chapel Hill
http://www.cs.unc.edu/~cquammen