[Insight-developers] why can't a file in Modules/Filtering/DiffusionTensorImage/include find itkSpatialObject.h?

[Luis Ibanez]

Cory,


Good point,
The same warning doesn't hold for Examples nor Wrapping.


The word of caution applies to the Modules directory.



The concern is that it is very tempting to solve problems by
just adding one dependency between modules, and that
operation is very costly to undo (should it turn out to be wrong).


So, we should think twice before adding new dependencies
between modules, and we should have a discussion about
the valid need for such new dependencies.



       Luis



-------------------------------------------------------------
On Sat, Mar 26, 2011 at 12:58 PM, Cory Quammen <cquammen at cs.unc.edu> wrote:
> Hi Luis,
>
> Does the same warning hold for Examples? I hope not, otherwise it will
> make it very difficult to include real-world examples in the toolkit.
>
> Thanks,
> Cory
>
> On Sat, Mar 26, 2011 at 12:01 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>> A word of caution:
>>
>>
>> Please don't take lightly the act of adding new dependencies
>> between modules.
>>
>>
>> It took a lot of effort to untangle the matrix of dependencies
>> between ITK classes, and by adding dependencies we take
>> steps back to a monolithic ITK configuration.
>>
>>
>> Needs for new dependencies, may be indications of
>>
>> 1)  Misclassified classes
>> 2)  Design flaws
>>
>>
>> I'm not saying that this particular new dependency is a problem,
>>
>>
>> Just want to make us aware that adding a dependency link
>> between two modules has large consequences and therefore
>> is something that must be done only after some discussion
>> among developers.
>>
>>
>>      Luis
>>
>>
>> -------------------------------------------------------------------------------------
>> On Fri, Mar 25, 2011 at 4:21 PM, Williams, Norman K
>> <norman-k-williams at uiowa.edu> wrote:
>>> Answer my own question: I have to add ITK-SpatialObjects to the itk_module
>>> macro in Modules/Filtering/DiffusionTensorImage/itk-module.cmake
>>>
>>> Bonus fun fact: If you misspell any of the module names in the DEPENDS
>>> clause of itk_module, CMake throws a bogus warning about your
>>> build-directory already being in use for ITK.
>>>
>>>
>>>
>>>
>>> On 3/25/11 2:47 PM, "Williams, Norman K" <norman-k-williams at uiowa.edu>
>>> wrote:
>>>
>>>>Is there some special mojo involved in getting the
>>>>Modules/Core/SpatialObjects/include into the include path?
>>>>I'm modifying itk::DiffusionTensor3DReconstructionImageFilter to take
>>>>SpatialObjects as masks and the compilation is failing for
>>>>itkDiffusionTensor3DReconstructionImageFilterTest, saying
>>>>
>>>>[ 63%] Building CXX object
>>>>Modules/Filtering/DiffusionTensorImage/test/CMakeFiles/ITK-DiffusionTensor
>>>>I
>>>>mageTestDriver.dir/itkDiffusionTensor3DReconstructionImageFilterTest.cxx.o
>>>>In file included from
>>>>ITK/Modules/Filtering/DiffusionTensorImage/test/itkDiffusionTensor3DRecons
>>>>t
>>>>ructionImageFilterTest.cxx:18:
>>>>ITK/Modules/Filtering/DiffusionTensorImage/include/itkDiffusionTensor3DRec
>>>>o
>>>>nstructionImageFilter.h:22:30: error: itkSpatialObject.h: No such file or
>>>>directory
>>>>In file included from
>>>>ITK/Modules/Filtering/DiffusionTensorImage/include/itkDiffusionTensor3DRec
>>>>o
>>>>nstructionImageFilter.h:324,
>>>>                 from
>>>>ITK/Modules/Filtering/DiffusionTensorImage/test/itkDiffusionTensor3DRecons
>>>>t
>>>>ructionImageFilterTest.cxx:18:
>>>>ITK/Modules/Filtering/DiffusionTensorImage/include/itkDiffusionTensor3DRec
>>>>o
>>>>nstructionImageFilter.txx:25:39: error: itkImageMaskSpatialObject.h: No
>>>>such file or directory
>>>>
>>>>
>>>>--
>>>>Kent Williams norman-k-williams at uiowa.edu
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>________________________________
>>>>Notice: This UI Health Care e-mail (including attachments) is covered by
>>>>the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>>>confidential and may be legally privileged.  If you are not the intended
>>>>recipient, you are hereby notified that any retention, dissemination,
>>>>distribution, or copying of this communication is strictly prohibited.
>>>>Please reply to the sender that you have received the message in error,
>>>>then delete it.  Thank you.
>>>>________________________________
>>>>_______________________________________________
>>>>Powered by www.kitware.com
>>>>
>>>>Visit other Kitware open-source projects at
>>>>http://www.kitware.com/opensource/opensource.html
>>>>
>>>>Kitware offers ITK Training Courses, for more information visit:
>>>>http://kitware.com/products/protraining.html
>>>>
>>>>Please keep messages on-topic and check the ITK FAQ at:
>>>>http://www.itk.org/Wiki/ITK_FAQ
>>>>
>>>>Follow this link to subscribe/unsubscribe:
>>>>http://www.itk.org/mailman/listinfo/insight-developers
>>>
>>>
>>>
>>> ________________________________
>>> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
>>> ________________________________
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>
>
>
> --
> Cory Quammen
> Computer Integrated Systems for Microscopy and Manipulation (CISMM)
> Department of Computer Science
> University of North Carolina at Chapel Hill
> http://www.cs.unc.edu/~cquammen
>