[Insight-developers] SimpleITK - now using next branch

[Gabe Hart]

Shoot... one more thing I forgot that has probably already been 
discussed, but is really important.  All topic branches MUST be based on 
master and not next.  I got into a lot of trouble by basing things on 
dev (our version of next) when I first started using this workflow.

-Gabe

On 03/17/2011 10:58 AM, Bradley Lowekamp wrote:
> Gabe,
>
> Please share that check. I only had the following:
>
> if( NOT ITK_USE_REVIEW )
> # TODO need to check ITK configuration to verify that it has the 
> needed modules
> # message(FATAL_ERROR "Please reconfigure ITK by turning 
> ITK_USE_REVIEW ON")
> endif()
>
> Brad
>
>
> On Mar 17, 2011, at 10:50 AM, Gabe Hart wrote:
>
>> Good catch.  I remember some discussion about using next, but then 
>> was out of the loop for a while, so I haven't been good about 
>> checking what is already in next.  I'll try to be better about 
>> checking there before I push ahead with new ideas.
>>
>> As far as this topic goes, I did manage to get things compiled and 
>> linked against the modularized version by just adding a check to see 
>> if "ITK-Review" is in the ITK_MODULES_ENABLED list after finding ITK, 
>> but all of the tests fail when compiled this way.  I'll abandon this 
>> issue since it seems like it's already being taken care of.
>>
>> -Gabe
>>
>> On 03/17/2011 10:45 AM, Bradley Lowekamp wrote:
>>> Gabe,
>>>
>>> I see you added a new issue into JIRA that is basically a duplicate:
>>>
>>> https://itk.icts.uiowa.edu/jira/browse/SIMPLEITK-23
>>>
>>> I make the link and commented about the issue.
>>>
>>> As this has been already addressed and merged in the next branch, I 
>>> must ask if you are aware that we are trying to use the next branch 
>>> for integration of topics?
>>>
>>> Brad
>>>
>>> BTW: I am CC ing the developers list as Luis has suggested that our 
>>> off-list SimpleITK discussions should really be going to the 
>>> developers list. I would still like to maintain the convention of 
>>> including SimpleITK in the subject, so that mail filtering is easy.
>>>
>>>
>>> ========================================================
>>> Bradley Lowekamp
>>> Lockheed Martin Contractor for
>>> Office of High Performance Computing and Communications
>>> National Library of Medicine
>>> blowekamp at mail.nih.gov <mailto:blowekamp at mail.nih.gov>
>>>
>>>
>>
>>
>> -- 
>> Gabe Hart
>> R&D Engineer
>> Kitware, Inc. - North Carolina Office
>> http://www.kitware.com
>> (919) 969-6990 x317
>
> ========================================================
>
> Bradley Lowekamp
>
> Lockheed Martin Contractor for
>
> Office of High Performance Computing and Communications
>
> National Library of Medicine
>
> blowekamp at mail.nih.gov <mailto:blowekamp at mail.nih.gov>
>
>
>


-- 
Gabe Hart
R&D Engineer
Kitware, Inc. - North Carolina Office
http://www.kitware.com
(919) 969-6990 x317

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110317/79652019/attachment.htm>