[Insight-developers] Change in ITK[master]: COMP: attempts to fix gdcm function hiding warnings

[Mark Roden]

Hi Luis,

OK, now I've spent quite a bit of time trying to fix this patch and
this failing test with no luck. There has to be a better way.

How can I find just this test to run it from the command line?  I've
cmade everything using unix makefiles on my mac using Bradley
Lowecamp's switches to expose warnings:

Cxx : -Wall -Wextra -Wunused -Wpointer-arith -Winvalid-pch
-Wcast-align -Woverloaded-virtual -Wshadow -Wwrite-strings
-Wstrict-null-sentinel
C: -Wall -Wextra -Wunused -Wpointer-arith -Winvalid-pch -Wcast-align
-Wno-deprecated-declarations -Wno-uninitialized

I then run make with default options on, as well as testing and
examples.  Everything builds, no tests are produced (or are they in
some directory that I don't know about).

In what may not be a related error, if I turn on anything in gdcm (ie,
gdcm testing), I'll get these cmake errors:

CMake Error at Utilities/gdcm/CMakeLists.txt:510 (SUBDIRS):
  subdirs Incorrect SUBDIRS command.  Directory: Testing does not exists.


If you want to build the test suite, you must set GDCM_DATA_ROOT
(advanced option) to the full path name of the gdcmData directory; if
you don't want, disable GDCM_BUILD_TESTING.
What is gdcmData? Please read:
http://sourceforge.net/apps/mediawiki/gdcm/index.php?title=General_questions#What_is_gdcmData_.3F
CMake Error at Utilities/gdcm/Utilities/CMakeLists.txt:54 (SUBDIRS):
  subdirs Incorrect SUBDIRS command.  Directory: gdcmmd5 does not exists.


Configuring incomplete, errors occurred!

The second error makes sense, since I haven't put the gdcm testing
data in their yet (do I need that for the failing test for this
patch?).  But what's the deal with that first error?  The 'Testing'
directory does 'exists' (sic) in the cmake target directory.

If I set the testing directory to be the directory from the gdcm root,
CMake now reports:
CMake Error at Utilities/gdcm/CMakeLists.txt:510 (SUBDIRS):
  subdirs Incorrect SUBDIRS command.  Directory: Testing does not exists.


CMake Error at Utilities/gdcm/Utilities/CMakeLists.txt:54 (SUBDIRS):
  subdirs Incorrect SUBDIRS command.  Directory: gdcmmd5 does not exists.


Configuring incomplete, errors occurred!

If this is related to the failing test, then I'll need to fix it in
order to fix the test, right?

I'd like to just run  directly so that I can fix that particular test
(and perhaps develop further tests that check codecs other than jpeg).

Thanks,
Mark


On Fri, Mar 4, 2011 at 9:58 AM, Code Review <review at kitware.com> wrote:
> From Mathieu Malaterre <mathieu.malaterre at gmail.com>:
>
> Mathieu Malaterre has posted comments on this change.
>
> Change subject: COMP: attempts to fix gdcm function hiding warnings
> ......................................................................
>
>
> Patch Set 1: Fails; I would prefer that you didn't submit this
>
> --
> To view, visit http://review.source.kitware.com/1120
> To unsubscribe, visit http://review.source.kitware.com/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I413102b25d1c9eee60eace2585c2f857ad564a67
> Gerrit-PatchSet: 1
> Gerrit-Project: ITK
> Gerrit-Branch: master
> Gerrit-Owner: Mark Roden <mmroden at gmail.com>
> Gerrit-Reviewer: Hans J. Johnson <hans-johnson at uiowa.edu>
> Gerrit-Reviewer: Luis Ibanez <luis.ibanez at kitware.com>
> Gerrit-Reviewer: Mathieu Malaterre <mathieu.malaterre at gmail.com>
>