[Insight-developers] Algorithm validation in ITK tests

[Cory Quammen]

Gaëtan,

Here's the random sampling from which I made my observation:

itkGradientDifferenceImageToImageMetricTest.cxx - *no validation of metric*
itkImageAdaptorNthElementTest.cxx - *no validation*
itkMaskImageFilterTest.cxx - *no validation*
itkBSplineResampleImageFilterTest.cxx - lots of validation
itkGaussianImageSourceTest.cxx - *no validation*

It seems I got unlucky with this sampling. Going through the classes
in BasicFilters whose class names start with A, it looks like the
validation situation is not as grim as I thought:

Tests that perform validation
-itkAbsImageFilterAndAdaptorTest.cxx
-itkAbsoluteValueDifferenceImageFilterTest.cxx
-itkAccumulateImageFilterTest.cxx
-itkAcosImageFilterAndAdaptorTest.cxx
-itkAdaptImageFilterTest.cxx
-itkAdaptiveHistogramEqualizationImageFilterTest.cxx
-itkApproximateSignedDistanceMapImageFilterTest.cxx
-itkAsinImageFilterAndAdaptorTest.cxx
-itkAtan2ImageFilterTest.cxx
-itkAtanImageFilterAndAdaptorTest.cxx

Tests that don't perform validation
-itkAddImageFilterTest.cxx
-itkAndImageFilterTest.cxx

Thanks,
Cory

2011/1/28 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>
> Cory,
>
> Most of the tests, especially for the filters producing image, are testing
> the output of the class.
> The image validation is performed by the test driver.
>
> Can you point to a specific test doing some which seems wrong?
>
> For quite complete test example, I would suggest to look at the tests added
> by Sophie Chen and Luis for the label map contribution – for example:
>
>  Testing/Code/Review/itkShapeOpeningLabelMapFilterTest1.cxx
>
> and the related part in
>
>  Testing/Code/Review/CMakeLists.txt
>
>
> Regards,
>
> Gaëtan
>
>
> Le 28 janv. 11 à 19:28, Cory Quammen a écrit :
>
>> Dear ITK developers,
>>
>> I'm writing some tests for some ITK classes to be submitted to gerrit
>> soon. Looking around at existing tests, I find it striking that many
>> (most?) of them merely exercise the public interface of a class and do
>> not perform validation of results produced by the class. Is this by
>> intent or by omission?
>>
>> Obviously, it would be much faster for me to simply exercise the
>> interface of these classes, but that just doesn't seem right.
>>
>> Thanks,
>> Cory
>>
>> --
>> Cory Quammen
>> Computer Integrated Systems for Microscopy and Manipulation (CISMM)
>> Department of Computer Science
>> University of North Carolina at Chapel Hill
>> http://www.cs.unc.edu/~cquammen
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>
> --
> Gaëtan Lehmann
> Biologie du Développement et de la Reproduction
> INRA de Jouy-en-Josas (France)
> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
> http://voxel.jouy.inra.fr  http://www.itk.org
> http://www.mandriva.org  http://www.bepo.fr
>
>



-- 
Cory Quammen
Computer Integrated Systems for Microscopy and Manipulation (CISMM)
Department of Computer Science
University of North Carolina at Chapel Hill
http://www.cs.unc.edu/~cquammen