[Insight-developers] ITKV3_COMPATIBILITY

[Luis Ibanez]

Hi Bill,


Great Idea,


Such patch is already here:

      http://review.source.kitware.com/#change,683

It is only missing to use the ITKV3_COMPATIBILITY flag,
(I was waiting for your merge to go in).

and to rename the symbol:

ITK_SUPPORTS_IMAGES_LARGER_THAN_4GB_IN_WINDOWS_64_BITS

http://review.source.kitware.com/#patch,sidebyside,683,2,CMakeLists.txt

With the more precise:

                  ITK_USE_64BITS_IDS

That Dave proposed in his review.


Since the type adopted in replacement for "unsigned long int"
is "uint64_t" this also addresses the concerns raised by Hans
about uncertainty of the type size, and the concerns raised by
Brad Lowekamp regarding the possibility of addressing large
images in 32-bits systems.

I'm preparing now a third patch for this change.
It should be in Gerrit in a couple of hours.


     Luis



-------------------------------------------------------------------------------
On Sat, Jan 8, 2011 at 11:42 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> Luis,
>
> I just merged the refactored Rigid3DTransform. As part of this we
> introduced the cmake variable ITKV3_COMPATIBILITY. As we agreed, the
> default value of this is OFF.
>
> Recall that the topic add-abstract-integer-types -
> http://review.source.kitware.com/#change,578 originally modified about
> 24 examples and tests. These changes raised a backward compatibility
> (BC!) flag and you and Dave eventually came up with a BC! solution.
>
> Now, with this flag available, I propose the following:
>
> 1) Submit a gerrit patch that includes the changed examples and tests.
> These changes will show users the proper way to use ITK4.
> 2) ifdef the types in itkIntTypes.h so that if ITKV3_COMPATIBILITY is
> ON, the types resolve to ITK3 compatible types.
>
> Bill
>