[Insight-developers] Wrong type in ConnectedRegionsMeshFilter.h

[Bill Lorensen]

Makes we wonder if there are other cases like this. When I get a
chance, I'll walk through all of the changes.

Bill

On Thu, Jan 6, 2011 at 3:44 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
> Hi Bill,
>
> Yeap, the type should be signed.
>
> Here is the patch with the fix in Gerrit:
> http://review.source.kitware.com/#change,675
>
> and a Experimental build for it:
> http://www.cdash.org/CDash/buildSummary.php?buildid=818927
>
>
>     Luis
>
>
> ------------------------------
> On Thu, Jan 6, 2011 at 8:46 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> Guys,
>>
>> In Algorithms/ConnectedRegionsMeshFilter.h
>>
>> std::vector< long >           m_Visited;
>> was changed to
>> std::vector< IdentifierType >  m_Visited;
>>
>> This causes the warnings like these:
>> itkConnectedRegionsMeshFilter.txx:200: warning: comparison of unsigned
>> expression < 0 is always false
>> itkConnectedRegionsMeshFilter.txx:320: warning: comparison of unsigned
>> expression >= 0 is always true
>>
>> Bill
>>
>