[Insight-developers] Failing tests and compile errors after your check in

[Daniel Blezek]

Hi Gaetan,  Thanks for looking into this.

Best,
-dan


On 2/18/11 3:11 AM, "Gaëtan Lehmann" <gaetan.lehmann at jouy.inra.fr> wrote:

> 
> Dan,
> 
> The proposed changed was generating a lot of warnings like this one:
> 
>    gcc: -lrt: linker input file unused because linking not done
> 
> I've modified it to add -lrt only at link time:
> 
>    http://review.source.kitware.com/#change,984
> 
> Gaëtan
> 
> 
> Le 18 févr. 11 à 00:01, Bill Lorensen a écrit :
> 
>> Dan,
>> 
>> Why are you not using gerrit?
>> 
>> Bill
>> 
>> On Thu, Feb 17, 2011 at 4:57 PM, Daniel Blezek
>> <Blezek.Daniel at mayo.edu> wrote:
>>> Hi Gaetan,
>>> 
>>>  Can you pull a fix from my Github?
>>> 
>>> git pull git://github.com/dblezek/ITK.git
>>> Platform_specific_thread_objects
>>> 
>>> On linux, the -lrt flag is not needed (do not know why).  This is a
>>> CMake
>>> change, hopefully it will work.
>>> 
>>> -dan
>>> 
>>> On 2/17/11 11:52 AM, "Gaëtan Lehmann" <gaetan.lehmann at jouy.inra.fr>
>>> wrote:
>>> 
>>>> 
>>>> Le 17 févr. 11 à 18:36, Daniel Blezek a écrit :
>>>> 
>>>>> Hi Gaetan,
>>>>> 
>>>>>  The link errors are (for some reason I thought this was your
>>>>> machine, I
>>>>> could be wrong):
>>>>> 
>>>>> sem_destroy                         ../../../bin/libITKCommon.so.
>>>>> 4.0.0
>>>>> sem_open                            ../../../bin/libITKCommon.so.
>>>>> 4.0.0
>>>>> sem_post                            ../../../bin/libITKCommon.so.
>>>>> 4.0.0
>>>>> sem_wait                            ../../../bin/libITKCommon.so.
>>>>> 4.0.0
>>>>> 
>>>>> http://www.cdash.org/CDash/viewBuildError.php?buildid=865055
>>>>> 
>>>>> On Linux these symbols are in librt.  I don't know what the library
>>>>> would be
>>>>> on the Sun.  This should be a relatively straightforward fix.
>>>>> 
>>>>> NB: I removed the sun specific threading code (mainly semaphores)
>>>>> because
>>>>> Oracle's docs claimed the Sun had POSIX compliance.  It is likely
>>>>> that our
>>>>> CMake code doesn't find the right library on the Sun.
>>>> 
>>>> adding rt in the linker command seems to work.
>>>> 
>>>> [glehmann at itk2 IO]$ /local/bin/g++ -lrt    -ftemplate-depth-50 -
>>>> Wall -
>>>> Wno-deprecated -D_PTHREADS  -L/lib  CMakeFiles/itkTestDriver.dir/
>>>> itkTestDriver.cxx.o  -o ../../bin
>>>> /itkTestDriver  -L/home/papha/glehmann/src/ITK/build/bin ../../bin/
>>>> libITKIO.so.4.0.0 ../../bin/libITKNrrdIO.so.4.0.0 ../../bin/
>>>> libgdcmMSFF.so.2.0.17 ../../bin/libgdcmDI
>>>> CT.so.2.0.17 ../../bin/libgdcmIOD.so.2.0.17 ../../bin/
>>>> libgdcmDSED.so.
>>>> 2.0.17 ../../bin/libgdcmCommon.so.2.0.17 ../../bin/libitkpng.so.
>>>> 4.0.0 ../../bin/libitktiff.so.4.0.0
>>>>   ../../bin/libitkjpeg.so.4.0.0 ../../bin/libITKSpatialObject.so.
>>>> 4.0.0 ../../bin/libITKCommon.so.4.0.0 ../../bin/libitkvnl_inst.so.
>>>> 4.0.0 ../../bin/libitkvnl_algo.so.4.0.
>>>> 0 ../../bin/libitkv3p_netlib.so.4.0.0 ../../bin/libitkvnl.so.
>>>> 4.0.0 ../../bin/libitkvcl.so.4.0.0 ../../bin/libitkv3p_lsqr.so.
>>>> 4.0.0 -
>>>> lm -lthread -lmalloc ../../bin/libITK
>>>> MetaIO.so.4.0.0 -lsocket -lnsl ../../bin/libitksys.so.4.0.0 -
>>>> ldl ../../
>>>> bin/libITKDICOMParser.so.4.0.0 ../../bin/libITKEXPAT.so.4.0.0 ../../
>>>> bin/libITKniftiio.so.4.0.0 -l
>>>> m ../../bin/libITKznz.so.4.0.0 ../../bin/libitkzlib.so.4.0.0 -Wl,-R/
>>>> home/papha/glehmann/src/ITK/build/bin:
>>>> 
>>>> I have no idea where this is configured in ITK, and "rt" is not
>>>> exactly something rare enough to let me search with a grep.
>>>> Can tell me where I should look?
>>>> 
>>>> Thanks,
>>>> 
>>>> Gaëtan
>>>> 
>>>> 
>>>>> 
>>>>> Best,
>>>>> -dan
>>>>> 
>>>>> 
>>>>> On 2/17/11 11:30 AM, "Gaëtan Lehmann" <gaetan.lehmann at jouy.inra.fr>
>>>>> wrote:
>>>>> 
>>>>>> 
>>>>>> Le 17 févr. 11 à 18:25, Daniel Blezek a écrit :
>>>>>> 
>>>>>>> Are you referring to the 2 sun builds?  I'll need some help from
>>>>>>> Gaetan to
>>>>>>> make sure the Sun links to the right Semaphore library.
>>>>>> 
>>>>>> I'd be pleased to help - just let me know what you need.
>>>>>> 
>>>>>>> 
>>>>>>> All the other errors seem to be WrapITK or GDCM errors.
>>>>>> 
>>>>>> I'm working on the WrapITK errors.
>>>>>> 
>>>>>> Gaëtan
>>>>>> 
>>>>>>> 
>>>>>>> -dan
>>>>>>> 
>>>>>>> 
>>>>>>> On 2/17/11 11:07 AM, "Bill Lorensen" <bill.lorensen at gmail.com>
>>>>>>> wrote:
>>>>>>> 
>>>>>>>> Dan,
>>>>>>>> 
>>>>>>>> I assume you noticed the failing tests and build errors after
>>>>>>>> your
>>>>>>>> check in yesterday?
>>>>>>>> 
>>>>>>>> Bill
>>>>>>> 
>>>>>>> --
>>>>>>> Daniel Blezek, PhD
>>>>>>> Medical Imaging Informatics Innovation Center
>>>>>>> 
>>>>>>> P 127 or (77) 8 8886
>>>>>>> T 507 538 8886
>>>>>>> E blezek.daniel at mayo.edu
>>>>>>> 
>>>>>>> Mayo Clinic
>>>>>>> 200 First St. S.W.
>>>>>>> Harwick SL-44
>>>>>>> Rochester, MN 55905
>>>>>>> mayoclinic.org
>>>>>>> "It is more complicated than you think." -- RFC 1925
>>>>>>> 
>>>>> 
>>>>> --
>>>>> Daniel Blezek, PhD
>>>>> Medical Imaging Informatics Innovation Center
>>>>> 
>>>>> P 127 or (77) 8 8886
>>>>> T 507 538 8886
>>>>> E blezek.daniel at mayo.edu
>>>>> 
>>>>> Mayo Clinic
>>>>> 200 First St. S.W.
>>>>> Harwick SL-44
>>>>> Rochester, MN 55905
>>>>> mayoclinic.org
>>>>> "It is more complicated than you think." -- RFC 1925
>>>>> 
>>> 
>>> --
>>> Daniel Blezek, PhD
>>> Medical Imaging Informatics Innovation Center
>>> 
>>> P 127 or (77) 8 8886
>>> T 507 538 8886
>>> E blezek.daniel at mayo.edu
>>> 
>>> Mayo Clinic
>>> 200 First St. S.W.
>>> Harwick SL-44
>>> Rochester, MN 55905
>>> mayoclinic.org
>>> "It is more complicated than you think." -- RFC 1925
>>> 
>>> 

-- 
Daniel Blezek, PhD
Medical Imaging Informatics Innovation Center

P 127 or (77) 8 8886
T 507 538 8886
E blezek.daniel at mayo.edu

Mayo Clinic
200 First St. S.W.
Harwick SL-44
Rochester, MN 55905
mayoclinic.org
"It is more complicated than you think." -- RFC 1925