[Insight-developers] ITKv4: Windows 64 bits : type "long" fixes: for ITKv4-Alpha-03

[Luis Ibanez]

Hi maquette,

Many thanks for patching ITK 3.20 and for making it available.

Please note that for fixing this in ITKv4 we patched many files
(about 400 files), and some of the changes were not trivial.

Full details are here:
http://review.source.kitware.com/#change,578


     Luis


---------------------------------------------------------------------------------
On Mon, Jan 31, 2011 at 7:54 PM, maquette <maquette at lavabit.com> wrote:
> Thanks to all for the fix of this!
> As from a user perspective we can not wait for ITK 4 to be ready, so I
> startet to fix this issue for our vendor branch of ITK to the Composight
> project. It is available by subversion if anyone wants to have a look on it:
>
> https://composight.svn.sourceforge.net/svnroot/composight/3rd/ITK/modified/InsightToolkit-3.20.0-1.0
>
> Use revision 50, it fixes -as mentioned by Luis- the core classes Index,
> Size, Offset, and so far all tests pass :)))
> Also I added a new Test to test iterators on a large (4GB) Image portion
> (partially). The test passes really fast, perhaps you would like to add it?
> But 4GB of virtual memory are allocated for around 1s. I tried to use the
> "highest level" type encapsulation available to a template by either
> Superclass or a Template Parameter, and not size_t / ptrdiff_t directly. BTW
> its also tested on Ubuntu x64.
>
> By now I continue to fix occurences of "long" elsewhere e.g. in
> BSplineInterpolator, only to make our internal tests work with larger
> images...
>
> I think ptrdiff_t and size_t should perhaps not be used directly, because
> they are already encapsulated by ITK in itkIntTypes.h and named
> intptr_t
> uintptr_t
> perhaps they were meant to be used for memory sizes.
>
> Should any occurence of long be replaced by ptrdiff_t? E.g. for the Mesh
> identifiers? or for a statistical sample size? This would shurely help to
> make things work the same way on GCC and Visual Studio platform. Even if
> that means storing more than needed in some case.
>
>
> Am 11.11.2010 22:20, schrieb Luis Ibanez:
>
> As we discussed during the meeting in Iowa,
> we will be cutting the ITKv4-Alpha-03 release
> on November 22nd. (just before Thanksgiving).
>
>
> The main goal for this release is to fix the bug(s)
> that prevents us from using images > 2Gb in
> Windows 64bits.
>
>
> David Cole has bravely volunteered to fix this problem
> in our Windows 64 bit builds. We anticipate that the
> changes will be merged into master by November 19th.
>
> Which means that you will start seeing related patches
> appearing in Gerrit in the following days.
>
>
> Fixing this issue will involve modifications in hundreds
> of files in ITK. That's the reason for doing this before
> we create topic branches for the major refactoring fronts.
>
>
> The top level changes will start at
>
> itkIndex.h
> itkSize.h
> itkOffset.h
>
>
> where we will replace the types
>
>      unsigned long      and      long
>
> with
>
>      size_t     and    ptrdiff_t
>
>
>
> Please let us know if you have any questions
> or concerns with this modifications.
>
>
>      Thanks
>
>
>           Luis
>
>
> Your personal email. Anytime, anywhere.
> Ridiculously affordable at $19.95. No contracts.
> http://www.getpeek.com/lavabit.html
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>