[Insight-developers] gerrit approval

[Nicholas Tustison]

Ah, thank you very much.  I will go ahead and do that.



On Feb 2, 2011, at 1:29 PM, Williams, Norman K wrote:

> Thanks for the esteeming.
> 
> 1. The builds are kicked off when you do the initial push.
> 2. Once a patch is approved, you can push it to the master with
>    git gerrit-merge
> 
> It's usually up to the patch author to do the merge, and it's better to do it ASAP to reduce the potential for merge conflicts.  If you happen to hit any merge conflicts, git will tell you and suggest how to fix it.  These used to be rather misleading, I think they've fixed them now.
> 
> ________________________________________
> From: insight-developers-bounces at itk.org [insight-developers-bounces at itk.org] on behalf of Nicholas Tustison [ntustison at gmail.com]
> Sent: Wednesday, February 02, 2011 11:20 AM
> To: Insight Developers
> Subject: [Insight-developers] gerrit approval
> 
> Dear esteemed developers,
> 
> A couple quick questions:
> 
> 1.  I see that some people's gerrit commits undergo builds.  How can I make that magic happen for my commits?  Is there some special git incantation of which I am unaware?
> 
> 2.  What are the approval parameters for something getting from the gerrit stage to actual merging with the toolkit?  Specifically I'm wondering about a recent submission for which there are two approvals.  Is there a minimum that is needed?
> 
> http://review.source.kitware.com/#change,787
> 
> Thanks
> Nick
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers