[Insight-developers] /usr/lib/ccache does not detect warning flags

[Bill Lorensen]

I just submitted a gerrit patch:
http://review.source.kitware.com/#change,2607,patchset=1

Time for golf...

Bill

On Wed, Aug 31, 2011 at 1:39 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:

> I don't think ITKSetStandardCompilerFlags.cmake ever worked correctly.
>
> It calls:
> CHECK_CXX_SOURCE_COMPILES(${flag} CXX_HAS_WARNING${flag})
>
> The first argument is the source file, which in this case is the flag.
>
> I think Hans wanted to call another function like:
> CHECK_CXX_COMPILER_FLAG(${flag} CXX_HAS_WARNING${flag})
>
>
>
> On Wed, Aug 31, 2011 at 1:31 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:
>
>> I don't have a window.
>>
>> Clear one of your cache entries for a wraning that worked before and
>> you'll see that it does not work now.
>>
>>
>>
>> On Wed, Aug 31, 2011 at 1:24 PM, David Cole <david.cole at kitware.com>wrote:
>>
>>> "Something has changed recently." --
>>>
>>> so wait, this used to work, and now it doesn't ... ?
>>>
>>> What day was it that it stopped working?
>>>
>>> (Or give me a window that I can look at...)
>>>
>>> Was it the merge of the "automatic warning detection" topic that
>>> happened on Friday?
>>>
>>> I thought the problem showed up before last Friday....
>>>
>>>
>>> On Wed, Aug 31, 2011 at 1:23 PM, Bill Lorensen <bill.lorensen at gmail.com>
>>> wrote:
>>> > Dave,
>>> >
>>> > I just cleared my c++ cache and the warnings fail there also. I think
>>> the
>>> > logic in ITKSetStandardCompilerFlags.cmake  is flawed.
>>> >
>>> > For example, when it tests -Wall the error says:
>>> > Source file was:
>>> > -Wall
>>> >
>>> > Something has changed recently.
>>> >
>>> >
>>> > On Wed, Aug 31, 2011 at 12:53 PM, Bill Lorensen <
>>> bill.lorensen at gmail.com>
>>> > wrote:
>>> >>
>>> >> Double maybe.
>>> >>
>>> >> If I create a src.cxx file on my tmp directory, ccache runs just fine.
>>> >>
>>> >>
>>> >> On Wed, Aug 31, 2011 at 12:33 PM, David Cole <david.cole at kitware.com>
>>> >> wrote:
>>> >>>
>>> >>> On Wed, Aug 31, 2011 at 12:29 PM, Bill Lorensen <
>>> bill.lorensen at gmail.com>
>>> >>> wrote:
>>> >>> > Dave,
>>> >>> >
>>> >>> > /usr/lib/ccache/c++ does not detect the warnings flags that c++
>>> does.
>>> >>> >
>>> >>> > I looked at the CMakeError.log file and here is a typical entry:
>>> >>> > Building CXX object CMakeFiles/cmTryCompileExec.dir/src.cxx.o
>>> >>> > /usr/lib/ccache/c++    -g -O0  -fprofile-arcs -ftest-coverage
>>> >>> > -DCXX_HAS_WARNING-Wcast-align   -o
>>> >>> > CMakeFiles/cmTryCompileExec.dir/src.cxx.o
>>> >>> > -c
>>> >>> >
>>> >>> >
>>> /home/lorensen/ProjectsGIT/ITKGerritCoverage-linux/CMakeFiles/CMakeTmp/src.cxx
>>> >>> > <command-line>: warning: missing whitespace after the macro name
>>> >>> >
>>> >>> >
>>> /home/lorensen/ProjectsGIT/ITKGerritCoverage-linux/CMakeFiles/CMakeTmp/src.cxx:1:
>>> >>> > error: expected unqualified-id before ‘-’ token
>>> >>> >
>>> >>> > NOTE: warning: missing whitespace after the macro name appears for
>>> both
>>> >>> > c==
>>> >>> > and cccahce so it is not an issue.
>>> >>> >
>>> >>> > Bill
>>> >>> >
>>> >>> >
>>> >>>
>>> >>>
>>> >>> Is this in reference to why the warnings are not showing up on some
>>> >>> SimpleITK dashboards?
>>> >>>
>>> >>> Perhaps ccache is not even compiling the files that we think it
>>> should
>>> >>> be... Maybe it's got results cached somewhere, and doesn't need to
>>> run
>>> >>> the compile, and therefore.... doesn't have any warnings.
>>> >>
>>> >
>>> >
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110831/1a51b6cb/attachment.htm>