[Insight-developers] Conditional inclusion of headers in HeaderTests

[Bill Lorensen]

Once we merge this topic, I think we should consider placing the v3 files in
another module, maybe V3Compatibility. This would be turned off by default
and turned on if ITKV3_COMPATIBILITY is in ON. We might even consider making
a group called Compatibility and move Deprecated and V3Compatibility into
it. The group NonUnit does not seem the right place for these classes.

On Wed, Aug 31, 2011 at 11:07 AM, Johnson, Hans J <hans-johnson at uiowa.edu>wrote:

> It is for fixing the header tests.  Your solution is MUCH better.
>
> I will implement it.
>
> Hans
>
>
> On 8/31/11 10:05 AM, "Matt McCormick" <matt.mccormick at kitware.com> wrote:
>
> >On Wed, Aug 31, 2011 at 11:02 AM, Johnson, Hans J
> ><hans-johnson at uiowa.edu> wrote:
> >> Bill,
> >> I need a variant of my approach to avoid defining that variable 2 times.
> >>  I am going to add a compile time switch
> >> set_target_properties( ${_test_name} PROPERTIES COMPILE_FLAGS
> >> -DITK_SILENT_HEADER_ERRORS=1 )
> >> And then protect the issuing of the compiler error with that additional
> >> flag.
> >
> >
> >Is that for fixing the HeaderTests?  They can be fixed this way:
> >
> >diff --git a/Utilities/Maintenance/BuildHeaderTest.py
> >b/Utilities/Maintenance/BuildHeaderTest.py
> >index f8d781d..d558053 100755
> >--- a/Utilities/Maintenance/BuildHeaderTest.py
> >+++ b/Utilities/Maintenance/BuildHeaderTest.py
> >@@ -31,10 +31,13 @@ for syntax and missing #include's.
> > # Headers to not test because of dependecy issues, etc.
> > BANNED_HEADERS = set(('itkExceptionObject.h', # There is a
> >pre-processor check so people use itkMacro.h instead.
> >     'itkMINC2ImageIO.h', # In case minc2.h is not available.
> >+    'itkExponentialDeformationFieldImageFilter.h', # deprecated
> >     'itkFFTWForwardFFTImageFilter.h',
> >     'itkFFTWInverseFFTImageFilter.h',
> >     'itkFFTWComplexToComplexImageFilter.h',
> >     'itkFFTWCommon.h',
> >+    'itkInverseDeformationFieldImageFilter.h',     # deprecated
> >+    'itkIterativeInverseDeformationFieldImageFilter.h',  # deprecated
> >     'itkLevelSetEquationChanAndVeseInternalTerm.h',   # JIRA 2645 FIXME
> >     'itkLevelSetEquationCurvatureTerm.h',             # JIRA 2645 FIXME
> >     'itkLevelSetEquationLaplacianTerm.h',             # JIRA 2645 FIXME
>
>
>
> ________________________________
> Notice: This UI Health Care e-mail (including attachments) is covered by
> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
> confidential and may be legally privileged.  If you are not the intended
> recipient, you are hereby notified that any retention, dissemination,
> distribution, or copying of this communication is strictly prohibited.
>  Please reply to the sender that you have received the message in error,
> then delete it.  Thank you.
> ________________________________
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110831/44f62c4a/attachment.htm>