[Insight-developers] Change in ITK[master]: WIP: Accumulated changes to Transform and effected classes.

[Matt McCormick]

Hi Bill,

The API is still changing.  In particular, the TransformParameters
class will likely be renamed to OptimizerParameters.

There are a number of important remaining issues to address, for which
I will file JIRA tickets.  These are noted my myself and Michael in
the ending Gerrit comments.  If anything was missed, please file
another ticket.

This was merged to keep the code flowing into the alpha (while it is
still alpha).  This patch was originally submitted July 15th, there
were few reviews, and the improvements to the code did not progress in
an efficient manner.  Big patch sets that accomplish many things do
not progress very quickly.

Best,
Matt

On Fri, Aug 12, 2011 at 8:33 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> I wish a few more reviewers had looked at this large change before it was
> merged. I had not planned on reviewing it until it changed from WIP to ENH.
> That is my bad however.
>
> Let's clean up the warnings on this one quickly. We'll have a better feel
> for the extent of the warnings tomorrow. Also we can see if there are any
> valgrind issues.
>
> I did not see a migration document. Does this mean that the API has not
> changed? If so, that is fantastic.
>
> Bill
>
> On Fri, Aug 12, 2011 at 8:31 AM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
>>
>> I wish a few more reviewers had looked at this large change before it was
>> merged. I had not planned on reviewing it until it changed from WIP to ENH.
>> That is my bad however.
>>
>> Let's clean up the warnings on this one quickly. We'll have a better feel
>> for the extent of the warnings tomorrow. Also we can see if there are any
>> valgrind issues.
>>
>> I did not see a migration document. Does this mean that the API has not
>> changed? If so, that is fantastic.
>>
>> Bill
>>
>> On Fri, Aug 12, 2011 at 7:44 AM, Matt McCormick
>> <matt.mccormick at kitware.com> wrote:
>>>
>>> Sorry, Bill, I missed your comment.
>>>
>>> Matt
>>>
>>> On Thu, Aug 11, 2011 at 7:21 PM, Bill Lorensen <bill.lorensen at gmail.com>
>>> wrote:
>>> > I'd like to try this patch against ITKApps and Slicer4 before it is
>>> > merged.
>>> >
>>> > I hope to try it this weekend.
>>> >
>>> > Bill
>>> >
>>> > On Thu, Aug 11, 2011 at 6:36 PM, Code Review <review at kitware.com>
>>> > wrote:
>>> >>
>>> >> From Matt McCormick <matt.mccormick at kitware.com>:
>>> >>
>>> >> Matt McCormick has posted comments on this change.
>>> >>
>>> >> Change subject: WIP: Accumulated changes to Transform and effected
>>> >> classes.
>>> >> ......................................................................
>>> >>
>>> >>
>>> >> Patch Set 4:
>>> >>
>>> >> Great work, Michael.  I will merge after the builds go through.
>>> >>
>>> >> Have a good weekend.
>>> >>
>>> >> --
>>> >> To view, visit http://review.source.kitware.com/2087
>>> >> To unsubscribe, visit http://review.source.kitware.com/settings
>>> >>
>>> >> Gerrit-MessageType: comment
>>> >> Gerrit-Change-Id: Ie806bb1897549403c11281e4921ea8025edba2b4
>>> >> Gerrit-PatchSet: 4
>>> >> Gerrit-Project: ITK
>>> >> Gerrit-Branch: master
>>> >> Gerrit-Owner: Michael Stauffer <mstauff at verizon.net>
>>> >> Gerrit-Reviewer: Andinet Enquobahrie <andinet.enqu at kitware.com>
>>> >> Gerrit-Reviewer: Bill Lorensen <bill.lorensen at gmail.com>
>>> >> Gerrit-Reviewer: Jeffrey Duda <jeff.duda at gmail.com>
>>> >> Gerrit-Reviewer: Jim Miller <millerjv at ge.com>
>>> >> Gerrit-Reviewer: Luis Ibanez <luis.ibanez at kitware.com>
>>> >> Gerrit-Reviewer: Marius Staring <m.staring at lumc.nl>
>>> >> Gerrit-Reviewer: Matt McCormick <matt.mccormick at kitware.com>
>>> >> Gerrit-Reviewer: Michael Stauffer <mstauff at verizon.net>
>>> >> Gerrit-Reviewer: Nick Tustison <ntustison at gmail.com>
>>> >> Gerrit-Reviewer: Rupert Brooks <rupert.brooks at gmail.com>
>>> >> Gerrit-Reviewer: brian avants <stnava at gmail.com>
>>> >
>>> >
>>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>