[Insight-developers] un-expected windows problem on the "master" branch of ITK

[Johnson, Hans J]

A patchset from earlier today had conditional code references that changed
the compilation behavior for gcc2.95 and for MSVS6.  Since these two
compilers are no longer supported, those compilation options were removed.

http://review.source.kitware.com/#change,2390  (MSVS6)
http://review.source.kitware.com/#change,2387  (gcc 2.95)


I believe that this patchset will resolve a compliation error on windows
computers that showed up today.

Once I have confirmation that this fixes the windows builds, I'll commit
the patches.

Hans
--
Hans J. Johnson, Ph.D.
hans-johnson at uiowa.edu
Assistant Professor of Psychiatry
University of Iowa Carver College of Medicine
W278 GH, 200 Hawkins Drive

Iowa City, Iowa 52242
Phone:  319-353-8587







-----Original Message-----
From: Hans Johnson <hans-johnson at uiowa.edu>
Date: Fri, 5 Aug 2011 15:45:08 -0500
To: Bill Hoffman <bill.hoffman at kitware.com>, ITK
<insight-developers at itk.org>
Subject: Re: [Insight-developers] un-expected windows problem on the
"master" branch of ITK

Bill,

THANK YOU for confirming this.  I'll make a gerrit patch set.

I was coming close to the same guess, but I had no way to test it.

Hans

--
Hans J. Johnson, Ph.D.
hans-johnson at uiowa.edu
Assistant Professor of Psychiatry
University of Iowa Carver College of Medicine
W278 GH, 200 Hawkins Drive

Iowa City, Iowa 52242
Phone:  319-353-8587







-----Original Message-----
From: Bill Hoffman <bill.hoffman at kitware.com>
Date: Fri, 5 Aug 2011 16:42:36 -0400
To: ITK <insight-developers at itk.org>
Subject: Re: [Insight-developers] un-expected windows problem on the
"master" branch of ITK

OK, forget my last message.  I have a fix.

If you just remove the the ifdef _MSC_VER stuff it compiles.


It will compile with this patch:

--- a/Modules/Core/Common/test/itkLoggerThreadWrapperTest.cxx
+++ b/Modules/Core/Common/test/itkLoggerThreadWrapperTest.cxx
@@ -19,7 +19,6 @@
     //Warning about: identifier was truncated to '255' characters in
the debug i
  #pragma warning( disable : 4786 )
  #endif
-#if ! defined(_MSC_VER) //NOTE: This class does not work under MSVS6

  #include "itkLoggerThreadWrapper.h"
  #include <iostream>
@@ -92,7 +91,6 @@ public:
  private:
    itk::LoggerBase* m_Logger;
  };
-#endif// ! defined(_MSC_VER) //NOTE: This class does not work under MSVS6

  ITK_THREAD_RETURN_TYPE ThreadedGenerateLogMessages2(void* arg)
  {
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.html

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://www.itk.org/mailman/listinfo/insight-developers




________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________