[Insight-developers] Proposal to change file naming conventions

[Bill Lorensen]

I prefer -impl.h over -inl.h

On Wed, Apr 20, 2011 at 10:52 AM, Johnson, Hans J
<hans-johnson at uiowa.edu> wrote:
> Brad,
>
> I respectfully disagree with your claim that we are getting along just
> fine.  In the class that I teach ITK in, students routinely have trouble
> with the fact that .txx files are not recognized as C++ files in their
> editors of choice.  Even after many months of requesting that they put the
> implementations in .txx files they are routinely #include
> "myITKfilter.cxx" in their "myITKfilter.h" file because by naming the file
> with .cxx they get highlighting.  Another bad behavior that they often
> will make copies of the .txx files with .cxx file extensions.
>
> This has been a continuous source of frustration for new users.
>
> Hans
>
>
> On 4/20/11 8:43 AM, "Brad King" <brad.king at kitware.com> wrote:
>
>>On 04/20/2011 08:47 AM, Cory Quammen wrote:
>>>> 1)  Personally I like the google c++ style approach a lot (ie. -inl.h)
>>>> because it more clearly describes the intent of what should be in the
>>>>file
>>>>
>>>>(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#The_-inl
>>>>.h_
>>>> Files).  I proposed the ".hpp" option mainly as a starting point for
>>>> discussion purposes.
>>>
>>> My two cents: I think the "-impl.h" suffix offers the clearest
>>> description of what the file contains.
>>
>>We've been using .txx for 11 years and gotten along okay so far.  Changing
>>it now will be yet another massive rename commit combined with lots of
>>updates to other files to fix the inclusions.  It is a huge effort for an
>>"it would be nice" justification.  There is plenty of other work to do on
>>this project.
>>
>>IMO it would make more sense to contribute patches to the editors in
>>question to support .txx by default.
>>
>>-Brad
>
>
>
> ________________________________
> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
> ________________________________
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>