[Insight-developers] Plans for Insight Journal in ITKv4 (was Mesh IO : IJ)

Dan Mueller dan.muel at gmail.com
Sat Sep 25 03:44:33 EDT 2010


Hi Stephen,

I am interested in your comment regarding changes to the Insight
Journal as part of ITKv4, specifically "Moving items from the IJ to
ITK will (purposefully) be a very rare event". Can you provide further
details? Will the community be able to branch/change code residing in
an IJ article?

Let's take a random example from Code/Review:
itkLabelOverlayImageFilter.h. This filter was added to the IJ in 2006
(http://www.insight-journal.org/browse/publication/79). It was added
to the review folder in 2007. Here is the commit history:

$ git log --pretty=format:"%h - %aN, %aD : %s" itkLabelOverlayImageFilter.h
7445be1 - Luis Ibanez, Tue, 7 Jul 2009 08:27:34 -0400 : ENH: Fixing
API. Get method must be const. GetNumberOfColors() is now const.
AddColor() now takes advantage of a typedef in order to clarify
notation.
21ba533 - Gaëtan Lehmann, Mon, 6 Jul 2009 18:00:57 -0400 : ENH: Let
the user set its own colors. Patch provided by Martin Kavec.
ec6e96b - Bill Lorensen, Thu, 7 Feb 2008 10:58:06 -0500 : COMP:
changed insight journal handle to new location.
eb9fcd0 - Gaëtan Lehmann, Sun, 21 Oct 2007 07:20:35 -0400 : ENH: Move
OverlayFunctor in its own header so it can be used much easily in
another class
576f5b5 - Gaëtan Lehmann, Sun, 21 Oct 2007 05:54:20 -0400 : ENH: Drop
the nearly useless UseBackground option ENH: Add a test for the
LabelToRGBImageFilter class
f7ddfc2 - Bill Lorensen, Fri, 30 Mar 2007 12:50:05 -0400 : STYLE:
various style issues.
fc0b7a2 - Bill Lorensen, Mon, 26 Feb 2007 10:46:56 -0500 : STYLE:
numerous stlye issues.
4e28fca - Luis Ibanez, Mon, 22 Jan 2007 10:20:28 -0500 : STYLE: Fixing
problems indicated by KWStyle.
013b71c - Luis Ibanez, Mon, 22 Jan 2007 10:06:02 -0500 : ENH: Adding
concept checking for HasPixelTraits, HasValueType and
HasBracketOperator.
13546fb - Andinet Enquobahrie, Sat, 20 Jan 2007 14:43:17 -0500 :
STYLE: indicate in the documentation that the filters were contributed
to the Insight Journal and add the Dspace handle of the entry
b7ef3e4 - Luis Ibanez, Tue, 16 Jan 2007 09:00:44 -0500 : ENH: Moving
the itkLabelToRGBFunctor out of the itkLabelToRGBImageFilter so  that
it can be shared with the itkLabelOverlayImageFilter.
bcb2466 - Luis Ibanez, Tue, 16 Jan 2007 08:25:50 -0500 : STYLE: moving
implementations to the txx STYLE: fixing indentations.
9e7da0d - Andinet Enquobahrie, Mon, 15 Jan 2007 15:58:41 -0500 :
STYLE: code style fix
5c77348 - Andinet Enquobahrie, Mon, 15 Jan 2007 15:44:05 -0500 :
STYLE: code style fix
4f358e9 - Andinet Enquobahrie, Wed, 10 Jan 2007 10:46:55 -0500 : ENH:
Uses itkLabelToRGBImageFilter to generate colormap to be applied for
the label image. This modification was done as part of a second
revision to the LabelOverlay filters submitted to the Insight Journal
69b897b - Andinet Enquobahrie, Tue, 9 Jan 2007 10:18:40 -0500 : ENH:
first checkin of the LabelLayout filter to the review subdirectory.
This filter was submitted to the insight journal

If this filter was simply left in the IJ, how would these improvements
have been made?

Don't get me wrong: I think the idea of being able to use IJ articles
from CMake is great! I am simply concerned that code residing in the
IJ do not get the benefits that Open Source offers.

Cheers, Dan

On 22 September 2010 16:03, Stephen Aylward <stephen.aylward at kitware.com> wrote:
>> <IJ mechanism broken>
>>
>> I'm saying that the whole mechanism of insight Journal , and
>> specifically the migration of code from IJ to review and then from
>> review to itk fully depends on the feedback of the community. If that
>> feedback is invisible, there is first no improvement of the code, and
>> then the code stays forever in review or in IJ.
>>
>
> Also, for ITKv4 every IJ article will be equally available as an
> optional module to ITK.  Moving items from the IJ to ITK will
> (purposefully) be a very rare event.  Instead, as part of the CMake
> build process you'll be able to search on keywords and by title to
> find modules (aka IJ articles) that you would like to download and
> include with your ITK build.
>
> s
>
> ==============================
> Stephen R. Aylward, Ph.D.
> Director of Medical Imaging Research
> Kitware, Inc. - North Carolina Office
> http://www.kitware.com
> stephen.aylward (Skype)
> (919) 969-6990 x300


More information about the Insight-developers mailing list