[Insight-developers] [master] Change I823fe9e4: (ITK) Moved QuadEdge Mesh datastrcture, filters and helpers out of...

[Alexandre GOUAILLARD]

just took a look at the dashboard. It's red indeed.

now, just a couple of question to clarify the process:
- is it the responsibility of the person that pushed to stage to later merge?
- if yes, is there a trigger (like the good review in gerrit triggers
the push to stage)?
- if no, who should do the merge?
also, it is my understanding that merge to master directly should be
forbidden, and left to the robot which will merge from stage to
master, is that correct?

regards,

alex.

On Wed, Sep 22, 2010 at 7:08 PM, Bradley Lowekamp
<blowekamp at mail.nih.gov> wrote:
> Alex,
>
> Given that most systems failed to build last night, I would hold off on merging.
>
> Brad
>
> On Sep 21, 2010, at 11:08 PM, Alexandre GOUAILLARD wrote:
>
>> hi,
>>
>> thanks.
>>
>> it's working now.
>>
>> I am supposed to go ahead with:
>> ssh git at itk.org stage ITK merge <topic-name>
>> ?
>>
>> Or is it someone else responsibility?
>>
>> alex.
>>
>>
>> On Wed, Sep 22, 2010 at 10:27 AM, Bradley Lowekamp
>> <blowekamp at mail.nih.gov> wrote:
>>> Hello Alex,
>>>
>>> Is this a typeo: "not allowed: git-receive-pack 'stage/ITK.gi'"  Notice the missing t at the end!
>>>
>>> If you type "git config --list" you should see the following lines:
>>>
>>> remote.stage.url=git://itk.org/stage/ITK.git
>>> remote.stage.pushurl=git at itk.org:stage/ITK.git
>>>
>>> If this is not the case perform git remote rm, then try to add it correctly again.
>>>
>>> You also should be able to execute "git fetch stage" with out issue. This will verify that you have the correct URL.
>>>
>>> Brad
>>>
>>> On Sep 21, 2010, at 10:10 PM, Alexandre GOUAILLARD wrote:
>>>
>>>> I tried to push code accepted in gerrit to itk stage, but it failed
>>>> with the following error message.
>>>>
>>>> anybody has any idea?
>>>>
>>>> not allowed: git-receive-pack 'stage/ITK.gi'
>>>> fatal: The remote end hung up unexpectedly
>>>>
>>>> alex.
>>>>
>>>>
>>>> On Wed, Sep 22, 2010 at 4:38 AM, Luis Ibanez (Code Review)
>>>> <gerrit2 at public.kitware.com> wrote:
>>>>> Comments on Patch Set 1:
>>>>>
>>>>> Patch Set 1: Verified; Looks good to me, approved
>>>>>
>>>>> (2 inline comments)
>>>>>
>>>>> Ran Experimental build, it came out clean (except for tests that were failing previously).
>>>>>
>>>>> http://www.cdash.org/CDash/buildSummary.php?buildid=727926
>>>>>
>>>>> There are just a couple of minor issues with code that is
>>>>> commented out in two files.
>>>>>
>>>>> Please push the changes to the Topic Stage at your convenience.
>>>>>
>>>>> ....................................................
>>>>> File Testing/Code/Review/itkReviewTests.cxx
>>>>> Line 44: //  REGISTER_TEST(itkVTKPolyDataIOQuadEdgeMeshTest);
>>>>> Remove commented out lines.
>>>>>
>>>>> ....................................................
>>>>> File Testing/Code/Review/itkReviewTests2.cxx
>>>>> Line 47:  // REGISTER_TEST(itkQuadEdgeMeshScalarDataVTKPolyDataWriterTest1);
>>>>> Remove commented out code.
>>>>>
>>>>> To respond, visit http://review.source.kitware.com/88
>>>>>
>>>>> --
>>>>> To view visit http://review.source.kitware.com/88
>>>>> To unsubscribe, visit http://review.source.kitware.com/settings
>>>>>
>>>>> Gerrit-MessageType: comment
>>>>> Gerrit-Project: ITK
>>>>> Gerrit-Branch: master
>>>>> Gerrit-Owner: Alex. Gouaillard <agouaillard at gmail.com>
>>>>> Gerrit-Reviewer: Bill Lorensen <bill.lorensen at gmail.com>
>>>>> Gerrit-Reviewer: Bradley Lowekamp <blowekamp at mail.nih.gov>
>>>>> Gerrit-Reviewer: Luis Ibanez <luis.ibanez at kitware.com>
>>>>>
>>>
>>>
>
>