[Insight-developers] Bug in itkSampleToHistogramFilterTest

[Luis Ibanez]

Hi Matt,

Thanks for posting the patch to Gerrit:
http://review.source.kitware.com/#change,40

I just pushed a modified version in which, new
specialized Exception classes are used to
differentiate each one of the specific Exception
cases. In this way, there is no need to parse the
error message that is returned by the ExceptionObject.


If you have a chance, please take a look at the new
set of changes and let us know what you think
(e.g. or review in Gerrit).


      Thanks


           Luis

------------------------------------------------------------------------------
On Fri, Sep 3, 2010 at 6:49 PM, Matthew McCormick (thewtex) <
matt at mmmccormick.com> wrote:

> Thanks again, Luis.  I was able to resolve my problem, and run the test
> suite.
> http://www.cmake.org/Bug/view.php?id=11205
>
> Have a good weekend,
> Matt
>
> On Fri, Sep 3, 2010 at 4:32 PM, Matthew McCormick (thewtex) <
> matt at mmmccormick.com> wrote:
>
>> Hi Luis, Hans, and Bill,
>>
>> Thanks for taking a look at this so quickly.  I worked in ITK 3.18 with
>> the review statistics turned on, and I think I found the problem.  I will
>> try your fix, then work on a patch against master.
>>
>> More to come :-)
>>
>> Matt
>>
>>
>> On Fri, Sep 3, 2010 at 3:40 PM, Luis Ibanez <luis.ibanez at kitware.com>wrote:
>>
>>>
>>> Hi Matt,
>>>
>>> The good news:
>>> Enabling the tests didn't bring up significant problems
>>>
>>>
>>> The only modification needed was to move the
>>>  itkTestingMacros.h file from the directory
>>>
>>>                ITK/Testing/Code/Review
>>>
>>> into the directory
>>>
>>>                 ITK/Code/Common
>>>
>>> The commit with the correction is now in Gerrit:
>>>
>>>   http://review.source.kitware.com/#change,39
>>>
>>>
>>> Hans and Bill have been "volunteered"
>>> as reviewers for it.       :-)
>>>
>>>
>>>
>>>      Luis
>>>
>>>
>>> ------------------------------------------------------
>>>
>>> On Fri, Sep 3, 2010 at 4:02 PM, Luis Ibanez <luis.ibanez at kitware.com>wrote:
>>>
>>>> Hi Matt,
>>>>
>>>> Thanks for pointing this out.
>>>>
>>>> It looks like a bug in the file:
>>>>
>>>> ITK/Testing/Code/Numerics/CMakeLists.txt
>>>>
>>>>
>>>> http://itk.org/gitweb?p=ITK.git;a=blobdiff;f=Testing/Code/Numerics/CMakeLists.txt;h=f31a3cd9dba69acd2486cf2236dec83bd011de93;hp=ba1d930feeb3b89f5dad4841b6c1e5836c82716e;hb=HEAD;hpb=f080996aa052a9d7a0611c8e927a97ff092049d8
>>>>
>>>> I'm now restoring the line
>>>>
>>>>       SUBDIR(Statistics)
>>>>
>>>> and fixing some compilation errors that show up...    :-/
>>>>
>>>> ---
>>>>
>>>> Code Review are Good...
>>>> Code Review are Good...
>>>> Code Review are Good...
>>>> Code Review are Good...
>>>> Code Review are Good...     :-)
>>>>
>>>>
>>>>            Luis
>>>>
>>>>
>>>> ------------------------------------------------------------------
>>>>
>>>> On Fri, Sep 3, 2010 at 3:38 PM, Matthew McCormick (thewtex) <
>>>> matt at mmmccormick.com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I'm trying update my code to ITKv4 and use the new statistics
>>>>> framework.  I see the release notes mention the change to the refactored
>>>>> statistics framework, but all the tests are not being run in
>>>>> Testing/Code/Numerics/CMakeLists.txt.  What is the situation here?  Are all
>>>>> the tests using the old framework?  Can I use the tests as hints for my
>>>>> refactoring?
>>>>>
>>>>> Thanks for any pointers,
>>>>> Matt
>>>>>
>>>>>
>>>>>
>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100904/39251306/attachment.htm>